Re: [Qemu-devel] [PATCH v10] Support vhd type VHD_DIFFERENCING

2015-03-12 Thread Xiaodong Gong
2015年3月11日 16:55于 "Philipp Hahn" 写道: > > Hello, > > On 11.03.2015 07:22, Xiaodong Gong wrote: > >> Hope that clarified things. > ... > > first,your patch is very clear,a good sample. > > > > store ascii code in kernel that I said before is a mist

Re: [Qemu-devel] [PATCH v10] Support vhd type VHD_DIFFERENCING

2015-03-10 Thread Xiaodong Gong
2015年3月8日 18:53于 "Philipp Hahn" 写道: > > Hello, > > On 08.03.2015 02:53, Xiaodong Gong wrote: > > the encoding type of parent location is must be utf 8,utf16e,according > > to the draft > > Yes, the SPEC for VPC/VHD specifies the character encoding to

Re: [Qemu-devel] [PATCH v10] Support vhd type VHD_DIFFERENCING

2015-03-07 Thread Xiaodong Gong
2015年3月5日 06:15于 "Philipp Hahn" 写道: > > Hi, > > On 04.03.2015 15:18, Xiaodong Gong wrote: > > @@ -157,6 +178,224 @@ static int vpc_probe(const uint8_t *buf, int buf_size, const char *filename) > .. > > +static int vpc_decode_maxc_loc(BlockDriverState *bs, ui

[Qemu-devel] [PATCH v10] Support vhd type VHD_DIFFERENCING

2015-03-04 Thread Xiaodong Gong
in "vpc_write". Signed-off-by: Xiaodong Gong Reviewed-by: Ding xiao --- Changes since v9 - use the g_iconv* to change iconv* (Stefan Hajnoczi) - change the value of PLATFORM_* to the value in MicroSoft's draft - change the parent_locator_offset from int to uint64_t (Stefan Hajnoc

Re: [Qemu-devel] [PATCH v9] Support vhd type VHD_DIFFERENCING

2015-02-26 Thread Xiaodong Gong
2015年2月25日 22:58于 "Stefan Hajnoczi" 写道: > > On Sun, Feb 15, 2015 at 09:35:49PM +0800, Xiaodong Gong wrote: > > Now qemu only supports vhd type VHD_FIXED and VHD_DYNAMIC, so qemu > > can't read snapshot volume of vhd, and can't support other storage > >

Re: [Qemu-devel] [PATCH] block:Fix FIXED base vpc be probed to raw format

2015-02-15 Thread Xiaodong Gong
Sent the v2 version of this patch integrated in v9 verison of VHD_DEFFERING patch. Fixed this problem with backing_format. On Sat, Feb 14, 2015 at 10:13 AM, Xiaodong Gong wrote: > > > On Wed, Feb 11, 2015 at 9:39 PM, Stefan Hajnoczi > wrote: > >> On Tue, Feb 10, 201

[Qemu-devel] [PATCH v9] Support vhd type VHD_DIFFERENCING

2015-02-15 Thread Xiaodong Gong
in "vpc_write". Signed-off-by: Xiaodong Gong Reviewed-by: Ding xiao --- Changes since v8 - use backing_format to avoid being probed to format of raw Changes since v7: - use iconv to decode UTF-16LE(w2u) and UTF-8(macx) to ASCII (Stefan Hajnoczi) - change the return value of vpc_write ba

Re: [Qemu-devel] [PATCH] block:Fix FIXED base vpc be probed to raw format

2015-02-13 Thread Xiaodong Gong
On Wed, Feb 11, 2015 at 9:39 PM, Stefan Hajnoczi wrote: > On Tue, Feb 10, 2015 at 11:04:31PM +0800, Xiaodong Gong wrote: > > On Mon, Feb 9, 2015 at 10:54 PM, Stefan Hajnoczi > wrote: > > > > > On Sun, Feb 08, 2015 at 08:39:52PM +0800, Xiaodong Gong wrote: > &g

Re: [Qemu-devel] [PATCH] block:Fix FIXED base vpc be probed to raw format

2015-02-10 Thread Xiaodong Gong
On Mon, Feb 9, 2015 at 10:54 PM, Stefan Hajnoczi wrote: > On Sun, Feb 08, 2015 at 08:39:52PM +0800, Xiaodong Gong wrote: > > When open the vpc snapshot based FIXED format, its backing file, > > this FIXED vpc image, could be probed as a raw image, because that > > the f

Re: [Qemu-devel] [PATCH RESEND] Support vhd type VHD_DIFFERENCING

2015-02-08 Thread Xiaodong Gong
On Wed, Nov 26, 2014 at 11:57 PM, Stefan Hajnoczi wrote: > On Thu, Nov 06, 2014 at 10:43:50PM +0800, Xiaodong Gong wrote: > > Now qemu only supports vhd type VHD_FIXED and VHD_DYNAMIC, so qemu > > can't read snapshot volume of vhd, and can't support other storage

[Qemu-devel] [PATCH v8] Support vhd type VHD_DIFFERENCING

2015-02-08 Thread Xiaodong Gong
in "vpc_write". Signed-off-by: Xiaodong Gong Reviewed-by: Ding xiao --- Changes since v7: - use iconv to decode UTF-16LE(w2u) and UTF-8(macx) to ASCII (Stefan Hajnoczi) - change the return value of vpc_write back to 0 (Stefan Hajnoczi) Changes since v6: - remove include of iconv.h (

[Qemu-devel] [PATCH] block:Fix FIXED base vpc be probed to raw format

2015-02-08 Thread Xiaodong Gong
. Signed-off-by: Xiaodong Gong --- block.c | 55 --- 1 file changed, 48 insertions(+), 7 deletions(-) diff --git a/block.c b/block.c index d45e4dd..e183515 100644 --- a/block.c +++ b/block.c @@ -702,20 +702,24 @@ BlockDriver *bdrv_probe_all

Re: [Qemu-devel] [PATCH RESEND] Support vhd type VHD_DIFFERENCING

2015-02-08 Thread Xiaodong Gong
On Wed, Nov 26, 2014 at 11:32 PM, Stefan Hajnoczi wrote: > On Thu, Nov 06, 2014 at 10:43:50PM +0800, Xiaodong Gong wrote: > > +} else if (platform == PLATFORM_W2RU) { > > +/* Must be UTF16-LE to ASCII */ > > +char *out, *optr; &

[Qemu-devel] [PATCH RESEND] Support vhd type VHD_DIFFERENCING

2014-11-06 Thread Xiaodong Gong
in "vpc_write". Signed-off-by: Xiaodong Gong Reviewed-by: Ding xiao --- Changes since v6: - remove include of iconv.h (Stefan Hajnoczi) - make sure data_length < length of backing_file (Stefan Hajnoczi) - change big-ending of platform to cpu order (Stefan Hajnoczi) Changes since v5: -

[Qemu-devel] [PATCH v7] Support vhd type VHD_DIFFERENCING

2014-11-06 Thread Xiaodong Gong
in "vpc_write". Signed-off-by: Xiaodong Gong Reviewed-by: Ding xiao --- Changes since v6: - remove include of iconv.h (Stefan Hajnoczi) - make sure data_length < length of backing_file (Stefan Hajnoczi) - change big-ending of platform to cpu order (Stefan Hajnoczi) Changes since v5: -

Re: [Qemu-devel] [PATCH v5] Support vhd type VHD_DIFFERENCING

2014-10-31 Thread Xiaodong Gong
On 10/30/14, Stefan Hajnoczi wrote: > On Wed, Oct 29, 2014 at 09:30:31PM +0800, Xiaodong Gong wrote: >> On 10/28/14, Stefan Hajnoczi wrote: >> > On Wed, Oct 08, 2014 at 08:42:32PM +0800, Xiaodong Gong wrote: >> >> +#define PLATFORM_MACX 0x5863614d /* big endian *

Re: [Qemu-devel] [PATCH v5] Support vhd type VHD_DIFFERENCING

2014-10-29 Thread Xiaodong Gong
On 10/28/14, Stefan Hajnoczi wrote: > On Wed, Oct 08, 2014 at 08:42:32PM +0800, Xiaodong Gong wrote: >> Now qemu only supports vhd type VHD_FIXED and VHD_DYNAMIC, so qemu >> can't read snapshot volume of vhd, and can't support other storage >> features of vhd

Re: [Qemu-devel] [PATCH v6] Support vhd type VHD_DIFFERENCING

2014-10-23 Thread Xiaodong Gong
have it now and upgrade in same days. So, could I attach the result from fio to instead of a reviewed-by ? Today is really a tough day. best regards. On Fri, Oct 17, 2014 at 11:45 PM, Xiaodong Gong wrote: > Now qemu only supports vhd type VHD_FIXED and VHD_DYNAMIC, so qemu > can'

[Qemu-devel] [PATCH v6] Support vhd type VHD_DIFFERENCING

2014-10-17 Thread Xiaodong Gong
in "vpc_write". Signed-off-by: Xiaodong Gong --- Changes since v5: - Change malloc to g_malloc. (Gonglei) - Fix the bug of free(null). (Gonglei) Changes since v4: - Parse the batmap only when the version of VHD > 1.2. (Lucian Petrut) - Add support to parent location of W2RU. (Luci

Re: [Qemu-devel] [PATCH RESEND] Support vhd type VHD_DIFFERENCING

2014-10-14 Thread Xiaodong Gong
thx a lot. >in your patch, if error happened, not only -1 is returned, you have to describe >the reason clearer IMO. -1 is error, -2 is sector not allocated, -3 is allocated in backing file.described before get_sector_offset. and what's the meaning of IMO ? :) On 10/11/14, Gonglei

[Qemu-devel] [PATCH RESEND] Support vhd type VHD_DIFFERENCING

2014-10-10 Thread Xiaodong Gong
in "vpc_write". Signed-off-by: Xiaodong Gong --- Changes since v4: - Parse the batmap only when the version of VHD > 1.2. - Add support to parent location of W2RU. Changes since v3: - Remove the PARENT_MAX_LOC. Changes since v2: - Change MACX to PLATFAORM_MACX. - Return with EINVAL to

Re: [Qemu-devel] [PATCH v5] Support vhd type VHD_DIFFERENCING

2014-10-08 Thread Xiaodong Gong
A little bit late for the 7 days of Nation's day, Ding xiao will review my patch. It looks like qcow2 is too popular. :) On Thu, Oct 2, 2014 at 11:36 PM, Stefan Hajnoczi wrote: > On Fri, Sep 26, 2014 at 09:43:18PM +0800, Xiaodong Gong wrote: > > Now qemu only supports vhd type

[Qemu-devel] [PATCH v5] Support vhd type VHD_DIFFERENCING

2014-10-08 Thread Xiaodong Gong
in "vpc_write". Signed-off-by: Xiaodong Gong Reviewed-by: Ding xiao --- block/vpc.c | 428 ++-- 1 file changed, 357 insertions(+), 71 deletions(-) diff --git a/block/vpc.c b/block/vpc.c index 4947369..1210542 100644 --- a/block/

[Qemu-devel] [PATCH v5] Support vhd type VHD_DIFFERENCING

2014-09-26 Thread Xiaodong Gong
in "vpc_write". Signed-off-by: Xiaodong Gong --- block/vpc.c | 428 ++-- 1 file changed, 357 insertions(+), 71 deletions(-) diff --git a/block/vpc.c b/block/vpc.c index 4947369..1210542 100644 --- a/block/vpc.c +++ b/block/vpc.c @@ -

Re: [Qemu-devel] [v4] Support vhd type VHD_DIFFERENCING

2014-09-26 Thread Xiaodong Gong
On Tue, Sep 23, 2014 at 10:25 PM, Xiaodong Gong wrote: > This structure is not documented in the official VHD specs, nor is the > 'tdbatmap' > cookie used in differencing VHDs created by Windows Server 2012. Isn't > Hyper-V > compatibility desired? > > Yepp, t

Re: [Qemu-devel] [PATCH] vpc: fix beX_to_cpu() and cpu_to_beX() confusion

2014-09-24 Thread Xiaodong Gong
no problem, it is look good for me. On Tue, Sep 23, 2014 at 5:40 PM, Stefan Hajnoczi wrote: > The beX_to_cpu() and cpu_to_beX() functions perform the same operation - > they do a byteswap if the host CPU endianness is little-endian or a > nothing otherwise. > > The point of two names for the sam

Re: [Qemu-devel] [v4] Support vhd type VHD_DIFFERENCING

2014-09-23 Thread Xiaodong Gong
tion in function "vpc_open", > read bitmap in "vpc_read", and change bitmap in "vpc_write". > > Signed-off-by: Xiaodong Gong > --- > > Now qemu only supports vhd type VHD_FIXED and VHD_DYNAMIC, > > so qemu can't read snapshot volume of v

[Qemu-devel] [PATCH v4] Support vhd type VHD_DIFFERENCING

2014-09-21 Thread Xiaodong Gong
in "vpc_write". Signed-off-by: Xiaodong Gong --- block/vpc.c | 355 -- include/block/block_int.h | 6 +- 2 files changed, 288 insertions(+), 73 deletions(-) diff --git a/block/vpc.c b/block/vpc.c index c024b4c..2ff2bba 10

[Qemu-devel] [RFC PATCH v3] Support vhd type VHD_DIFFERENCING

2014-09-10 Thread Xiaodong Gong
in "vpc_write". Signed-off-by: Xiaodong Gong --- block/vpc.c | 355 -- include/block/block_int.h | 6 +- 2 files changed, 288 insertions(+), 73 deletions(-) diff --git a/block/vpc.c b/block/vpc.c index c024b4c..2ff2bba 10

[Qemu-devel] [RFC PATCH v3] Support vhd type VHD_DIFFERENCING

2014-09-10 Thread Xiaodong Gong
in "vpc_write". Signed-off-by: Xiaodong Gong --- block/vpc.c | 355 -- include/block/block_int.h | 6 +- 2 files changed, 288 insertions(+), 73 deletions(-) diff --git a/block/vpc.c b/block/vpc.c index c024b4c..2ff2bba 10

[Qemu-devel] [PATCH v2] Support vhd type VHD_DIFFERENCING

2014-09-08 Thread Xiaodong Gong
From: Xiaodong Gong Now qemu only supports vhd type VHD_FIXED and VHD_DYNAMIC, so qemu can't read snapshot volume of vhd, and can't support other storage features of vhd file. This patch add read parent information in function "vpc_open", read bitmap in "vpc_re

[Qemu-devel] [PATCH] Fix improper usage of cpu_to_be32 in vpc

2014-09-08 Thread Xiaodong Gong
From: Xiaodong Gong cpu_to_be32() is wrong since vhd_type is an enum constant (just a regular CPU-endian integer). Signed-off-by: Xiaodong Gong --- block/vpc.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/block/vpc.c b/block/vpc.c index 055efc4..c024b4c 100644