Re: [Qemu-devel] [PATCH 6/8] target-arm: A64: Add integer ops from SIMD 3-same group

2014-01-21 Thread Xbing Wang
My fault. Forgot const static. :-) On 01/22/2014 02:13 PM, Richard Henderson wrote: On 01/21/2014 08:59 PM, Xbing Wang wrote: Making them static makes this function NOT thread-safe Huh? Why in the world would you say that? They're read-only. r~

Re: [Qemu-devel] [PATCH 6/8] target-arm: A64: Add integer ops from SIMD 3-same group

2014-01-21 Thread Xbing Wang
Making them static makes this function NOT thread-safe (and they're hidden in thousands of lines of codes), there will be boys who want the whole file translate-a64.c to be thread-safe. What do you think? Thanks. - xbing On 01/22/2014 03:53 AM, Peter Maydell wrote: On 21 January 2014 19:37, R