Re: [External] Re: [PATCH] hw/pci/pcie.c: Fix invalid PCI_EXP_LNKCAP setting

2022-05-19 Thread Wenliang Wang
As PCI_EXP_LNKCAP is never masked when loading, this patch does affect cross version migration. It seems we need machine type compat to deal with that. What do you suggest, Michael? On 5/20/22 12:49 AM, Michael S. Tsirkin wrote: On Thu, May 19, 2022 at 10:45:59PM +0800, Wenliang Wang wrote

[PATCH] hw/pci/pcie.c: Fix invalid PCI_EXP_LNKCAP setting

2022-05-19 Thread Wenliang Wang
[3.547143] pcieport :02:00.0: pciehp: Failed to check link status We do not touch PCI_EXP_LNKCAP when speed=0 or width=0, as pcie_cap_v1_fill() already do the default setting for us. Signed-off-by: Wenliang Wang --- hw/pci/pcie.c | 5 + 1 file changed, 5 insertions(+) diff --git a/hw/pci