Re: [Qemu-devel] [PATCH] add text about how to use qemu-nbd with qemu

2012-07-09 Thread Wayne Xia
think this is a bug, the nbd-block still works but just need some document to avoid making user debug it. Maybe a document is the easiest way. Instead, it is more productive and rigth (IMHO anyway) to fix the qemu side to stop connecting two times for one device. That too. Paolo -- Best Reg

Re: [Qemu-devel] [PATCH] add text about how to use qemu-nbd with qemu

2012-07-06 Thread Wayne Xia
bug it. Maybe a document is the easiest way. Instead, it is more productive and rigth (IMHO anyway) to fix the qemu side to stop connecting two times for one device. That too. Paolo -- Best Regards Wayne Xia mail:xiaw...@linux.vnet.ibm.com tel:86-010-82450803

Re: [Qemu-devel] [PATCH] add text about how to use qemu-nbd with qemu

2012-07-04 Thread Wayne Xia
t the default for qemu-nbd? -- Best Regards Wayne Xia mail:xiaw...@linux.vnet.ibm.com tel:86-010-82450803

Re: [Qemu-devel] [PATCH] add text about how to use qemu-nbd with qemu

2012-07-03 Thread Wayne Xia
english speaker, but I never see such usage before. Should be "For example"? Sorry it should be "i.e." or "for example", my bad spell custom. Regards, chenwj -- Best Regards Wayne Xia mail:xiaw...@linux.vnet.ibm.com tel:86-010-82450803

Re: [Qemu-devel] [PATCH] add text about how to use qemu-nbd with qemu

2012-07-03 Thread Wayne Xia
mark this change in document in case of breaking potential user case.(maybe someone have used qemu and expect qemu-nbd exit in script). Paolo -- Best Regards Wayne Xia mail:xiaw...@linux.vnet.ibm.com tel:86-010-82450803

Re: [Qemu-devel] [PATCH] add text about how to use qemu-nbd with qemu

2012-07-03 Thread Wayne Xia
elped me. A bit more question: is there a way to let nbd client know the image format used by server? qemu-nbd exports simple_qcow2.img, and qemu saw it as raw block device, is it possible to get the information in qemu that server is using qcow2 image? /mjt -- Best Regards Wayn

Re: [Qemu-devel] [PATCH v2] Sort the help info shown in monitor at runtime

2011-10-11 Thread Wayne Xia
于 2011-10-11 17:09, Markus Armbruster 写道: Wayne Xia writes: Introduced two queues to save sorted command list in it. As a result, command help and help info would show a more friendly sorted command list. For eg: (qemu)help acl_add acl_policy acl_remove acl_reset acl_show balloon block_passwd

[Qemu-devel] [PATCH v3] Sort the help info shown in monitor at runtime

2011-10-11 Thread Wayne Xia
function to sort the command list. Signed-off-by: Wayne Xia --- monitor.c | 30 ++ 1 files changed, 26 insertions(+), 4 deletions(-) diff --git a/monitor.c b/monitor.c index 31b212a..a172167 100644 --- a/monitor.c +++ b/monitor.c @@ -195,8 +195,8 @@ static inline int

Re: [Qemu-devel] [PATCH 0/1] Make the help info more friendly in monitor

2011-10-11 Thread Wayne Xia
于 2011-10-4 21:55, Luiz Capitulino 写道: On Wed, 28 Sep 2011 10:16:19 +0100 Stefan Hajnoczi wrote: On Wed, Sep 28, 2011 at 10:00 AM, Wayne Xia wrote: During my test, I found it inconvenient when I type "help" or "help info", because the information was shown without ord

[Qemu-devel] [PATCH v2] Sort the help info shown in monitor at runtime

2011-10-11 Thread Wayne Xia
back to original array. Signed-off-by: Wayne Xia --- monitor.c | 113 ++-- 1 files changed, 109 insertions(+), 4 deletions(-) diff --git a/monitor.c b/monitor.c index 31b212a..122f950 100644 --- a/monitor.c +++ b/monitor.c @@ -66,6 +66,7

Re: [Qemu-devel] [RFC] potential risk for macro QTAILQ_INSERT_BEFORE

2011-09-28 Thread Wayne Xia
于 2011-9-28 16:43, Jan Kiszka 写道: > On 2011-09-28 05:38, Wayne Xia wrote: >> Hi, during my coding, I found macro a bit different from other >> QTAIL macros. >> >> QTAILQ_INSERT_AFTER was defined as: >> -

[Qemu-devel] [PATCH 1/1] Sort the help info shown in monitor

2011-09-28 Thread Wayne Xia
Introduced two queues to save sorted command list in it, and dump commands from them. As a result, command help and help info would show a more friendly sorted command list. Signed-off-by: Wayne Xia --- monitor.c | 97 ++-- 1 files

[Qemu-devel] [PATCH 0/1] Make the help info more friendly in monitor

2011-09-28 Thread Wayne Xia
block_passwd ... the command list is sorted. Wayne Xia (1): Sort the help info shown in monitor monitor.c | 97 ++-- 1 files changed, 93 insertions(+), 4 deletions(-) -- 1.7.6

[Qemu-devel] [RFC] potential risk for macro QTAILQ_INSERT_BEFORE

2011-09-27 Thread Wayne Xia
ould happen if I use QTAILQ_INSERT_BEFORE to insert one element to a queue that have only one element in it, would it happen that the queue head pointer is not updated and the real first element is lost? Currently some codes in qemu have used this macro. -- Best Regards Wayne Xia mail:xiaw...@linux.vnet.ibm.com tel:86-010-82450803

Re: [Qemu-devel] [PATCH v2] memory: simple memory tree printer

2011-09-26 Thread Wayne Xia
8ec2c5e..f86fff6 100644 --- a/monitor.c +++ b/monitor.c @@ -2978,6 +2978,13 @@ static const mon_cmd_t info_cmds[] = { }, #endif { +.name = "mtree", +.args_type = "", +.params = "", +.help = "show memory tree", +.mhandler.info = mtree_info, +}, +{ .name = "jit", .args_type = "", .params = "", -- Best Regards Wayne Xia mail:xiaw...@linux.vnet.ibm.com tel:86-010-82450803

Re: [Qemu-devel] [PATCH 7/7] migration: qemu_savevm_iterate has three return values

2011-09-22 Thread Wayne Xia
on, s->file) == 1) { > +ret = qemu_savevm_state_iterate(s->mon, s->file); > +if (ret == -1) { > +migrate_fd_error(s); > +} else if (ret == 1) { > int old_vm_running = vm_running; > > DPRINTF("done iterating\n"); Maybe macro could be used in t

Re: [Qemu-devel] [PATCH v6] showing a splash picture when start

2011-07-27 Thread Wayne Xia
Thanks, following is my comments. On 07/10/2011 05:09 AM, Wayne Xia wrote: Added options to let qemu transfer two configuration files to bios: "bootsplash.bmp" and "etc/boot-menu-wait", which could be specified by command -boot splash=P,splash-time=T P is jpg/bmp file name

[Qemu-devel] [PATCH v7] showing a splash picture when start

2011-07-27 Thread Wayne Xia
ed the new seabios's support, which could be got from git. Signed-off-by: Wayne Xia --- hw/fw_cfg.c | 140 ++- qemu-config.c | 27 +++ qemu-options.hx | 16 ++- sysemu.h|3 + vl.c| 17

[Qemu-devel] [PATCH v7] showing a splash picture when start

2011-07-26 Thread Wayne Xia
ed the new seabios's support, which could be got from git. Signed-off-by: Wayne Xia --- hw/fw_cfg.c | 140 ++- qemu-config.c | 27 +++ qemu-options.hx | 16 ++- sysemu.h|3 + vl.c| 17

[Qemu-devel] [PATCH v6] showing a splash picture when start

2011-07-10 Thread Wayne Xia
ios's support, which could be got from git. Signed-off-by: Wayne Xia --- hw/fw_cfg.c | 140 - qemu-config.c | 27 +++ sysemu.h |3 + vl.c | 17 +++- 4 files changed, 185 insertions(+), 2 deletions(-)

[Qemu-devel] [Discuss] is it good to add codes providing information to libvirt about the qemu's capabilities

2011-07-08 Thread Wayne Xia
irt thought it is on. I wonder if it is a good idea to modify the help function in vl.c, to let it adjust -help output according to the configuration, but this would hide some option of "-help" invocation. -- Best Regards Wayne Xia mail:xiaw...@linux.vnet.ibm.com tel:86-010-82450803

Re: [Qemu-devel] [PATCH v5] showing a splash picture when start, seabios image for test

2011-07-04 Thread Wayne Xia
as an option. -- Best Regards Wayne Xia mail:xiaw...@linux.vnet.ibm.com tel:86-010-82450803

Re: [Qemu-devel] [PATCH v5] showing a splash picture when start, seabios image for test

2011-07-04 Thread Wayne Xia
ption. Paul -- Best Regards Wayne Xia mail:xiaw...@linux.vnet.ibm.com tel:86-010-82450803

[Qemu-devel] [PATCH v4] showing a splash picture when start

2011-06-28 Thread Wayne Xia
nd its predefined value is 2500ms. Signed-off-by: Wayne Xia --- hw/fw_cfg.c | 141 - qemu-config.c | 27 +++ sysemu.h |3 + vl.c | 17 +++- 4 files changed, 186 insertions(+), 2 deletions(-) diff --git a/hw/fw_c

Re: [Qemu-devel] [PATCH v3] showing a splash picture when start

2011-06-27 Thread Wayne Xia
On 2011-06-27 08:53, Wayne Xia wrote: Made an option to let qemu pass a picture to bios, let the bios show it as a logo. By default it is off, enable it as following That's better. :) -boot splash_time=N,splash_filename=P N have a max value of 0x, unit is ms. P is the a file na

[Qemu-devel] [PATCH v3] showing a splash picture when start

2011-06-26 Thread Wayne Xia
be used to test it. Signed-off-by: Wayne Xia --- hw/fw_cfg.c | 141 - qemu-config.c | 27 +++ sysemu.h |3 + vl.c | 17 +++- 4 files changed, 186 insertions(+), 2 deletions(-) diff --git a/hw/fw_cfg.c b

Re: [Qemu-devel] [PATCH 12/12] Remove temp_buf, rename CPU_TEMP_BUF_NLONGS

2011-06-26 Thread Wayne Xia
er for temporaries */ +#define TCG_TEMP_BUF_NLONGS 128 + /* when the size of the arguments of a called function is smaller than this value, they are statically allocated in the TB stack frame */ #define TCG_STATIC_CALL_ARGS_SIZE 128 -- Best Regards Wayne Xia mail:xiaw...@linux.vnet.ibm.com tel:86-010-82450803

Re: [Qemu-devel] [PATCH v2 0/3] kvm:showing a splash picture when start

2011-06-23 Thread Wayne Xia
2011-6-23 20:29, Jan Kiszka : On 2011-06-23 14:05, Daniel P. Berrange wrote: On Thu, Jun 23, 2011 at 01:24:01PM +0200, Jan Kiszka wrote: On 2011-06-23 13:20, Wayne Xia wrote: 2011-6-23 18:03, Jan Kiszka On 2011-06-23 11:18, Wayne Xia wrote: Hi, these 3 patch simply enable qemu-kvm to

Re: [Qemu-devel] [PATCH v2 0/3] kvm:showing a splash picture when start

2011-06-23 Thread Wayne Xia
2011-6-23 18:03, Jan Kiszka > On 2011-06-23 11:18, Wayne Xia wrote: >> Hi, >> these 3 patch simply enable qemu-kvm to show a logo picture when it > > You are posting on qemu-devel (which is correct for this topic), so your > patches must target that tree. Patch

[Qemu-devel] [PATCH v2 3/3] kvm:showing a splash picture when start, bios change

2011-06-23 Thread Wayne Xia
Signed-off-by: Wayne Xia --- pc-bios/bios.bin | Bin 131072 -> 131072 bytes 1 files changed, 0 insertions(+), 0 deletions(-) diff --git a/pc-bios/bios.bin b/pc-bios/bios.bin index bdb48314dfb79c6db84846278a696da3cb68d4ff..7691173dc18d41272c60cf0bc7fc7016d5843b26 100644 GIT binary pa

[Qemu-devel] [PATCH v2 1/3] kvm:showing a splash picture when start, code change

2011-06-23 Thread Wayne Xia
Signed-off-by: Wayne Xia --- Makefile |3 +- hw/fw_cfg.c | 131 - qemu-config.c | 27 sysemu.h |3 + vl.c | 17 +++- 5 files changed, 178 insertions(+), 3 deletions(-) diff --git a

[Qemu-devel] [PATCH v2 0/3] kvm:showing a splash picture when start

2011-06-23 Thread Wayne Xia
version of seabios that provide the support officially. Any comments would be very nice. -- Best Regards Wayne Xia mail:xiaw...@linux.vnet.ibm.com tel:86-010-82450803