> -Original Message-
> From: Eugenio Perez Martin
> Sent: 2024年12月12日 15:33
> To: Wafer
> Cc: m...@redhat.com; jasow...@redhat.com; qemu-devel@nongnu.org;
> Angus Chen
> Subject: Re: [PATCH v2] hw/virtio: Fix check available index on virtio loading
>
>
> -Original Message-
> From: Eugenio Perez Martin
> Sent: 2024年12月11日 20:45
> To: Wafer
> Cc: m...@redhat.com; jasow...@redhat.com; qemu-devel@nongnu.org;
> Angus Chen
> Subject: Re: [PATCH v2] hw/virtio: Fix check available index on virtio loading
>
>
From: Wafer Xie
The virtio-1.2 specification writes:
2.7.6 The Virtqueue Available Ring:
"idx field indicates where the driver would put the next descriptor entry
in the ring (modulo the queue size). This starts at 0, and increases"
The idx will increase from 0 to 0x and repeat,
> -Original Message-
> From: Philippe Mathieu-Daudé
> Sent: 2024年11月22日 15:02
> To: Wafer ; m...@redhat.com;
> jasow...@redhat.com; gr...@kaod.org
> Cc: epere...@redhat.com; qemu-devel@nongnu.org; Angus Chen
>
> Subject: Re: [PATCH] hw/virtio: Fix getting th
From: Wafer Xie
The virtio-1.2 specification writes:
2.7.6 The Virtqueue Available Ring:
"idx field indicates where the driver would put the next descriptor entry
in the ring (modulo the queue size). This starts at 0, and increases"
The idx will increase from 0 to 0x and repeat,
Ping :)
> -Original Message-
> From: Wafer
> Sent: 2024/05/10 15:29
> To: epere...@redhat.com; m...@redhat.com; jasow...@redhat.com
> Cc: qemu-devel@nongnu.org; Angus Chen ;
> Wafer
> Subject: [PATCH v3] hw/virtio: Fix obtain the buffer id from the last
> descri
in the virtqueue.
Therefor the buffer id should be obtained from the first descriptor.
In descriptor chaining scenarios, the buffer id should be obtained
from the last descriptor.
Fixes: 86044b24e8 ("virtio: basic packed virtqueue support")
Signed-off-by: Wafer
Reviewed-by: Jason W
in the virtqueue.
Therefor the buffer id should be obtained from the first descriptor.
In descriptor chaining scenarios, the buffer id should be obtained
from the last descriptor.
Fixes: 86044b24e8 ("virtio: basic packed virtqueue support")
Signed-off-by: Wafer
Reviewed-by: Jason W
On Wed, May 08, 2024 at 12:01 PM Jason Wang wrote:
>
> On Mon, Apr 22, 2024 at 9:41 AM Wafer wrote:
> >
> > The virtio-1.3 specification
> > <https://docs.oasis-open.org/virtio/virtio/v1.3/virtio-v1.3.html> writes:
> > 2.8.6 Next Flag: Descriptor Chainin
On Thu, May, 2024 at 2:21 AM Michael S. Tsirkin wrote:
>
> On Wed, May 08, 2024 at 02:56:11PM +0200, Eugenio Perez Martin wrote:
> > On Mon, Apr 22, 2024 at 3:41 AM Wafer wrote:
> > >
> > > The virtio-1.3 specification
> > > <https://docs.oasis-op
in the virtqueue.
Therefor the buffer id should be obtained from the first descriptor.
In descriptor chaining scenarios, the buffer id should be obtained
from the last descriptor.
Fixes: 86044b24e8 ("virtio: basic packed virtqueue support")
Signed-off-by: Wafer
---
hw/virtio/virtio.c |
On 4/9/24 1:32 Eugenio Perez Martin wrote:
>
> External Mail: This email originated from OUTSIDE of the organization!
> Do not click links, open attachments or provide ANY information unless you
> recognize the sender and know the content is safe.
>
>
> On Sun, Apr 7,
ments are merged.
If the value of 'num_buffers' is greater than 1,
all the merged elements will be filled into the descriptor ring.
The 'idx' of the elements should be the value of 'vq->used_idx' plus 'ndescs'.
Fixes: 86044b24e8 ("virtio: basic packed virt
ments are merged.
If the value of 'num_buffers' is greater than 1,
all the merged elements will be filled into the descriptor ring.
The 'idx' of the elements should be the value of 'vq->used_idx' plus 'ndescs'.
Fixes: 86044b24e8 ("virtio: basic packed virtq
ments are merged.
If the value of 'num_buffers' is greater than 1,
all the merged elements will be filled into the descriptor ring.
The 'idx' of the elements should be the value of 'vq->used_idx' plus 'ndescs'.
Signed-off-by: Wafer
---
Changes in v2:
- Clari
c entry value.
Signed-off-by: Wafer
---
hw/virtio/virtio.c | 9 +++--
1 file changed, 7 insertions(+), 2 deletions(-)
diff --git a/hw/virtio/virtio.c b/hw/virtio/virtio.c
index d229755eae..44f1d2fcfc 100644
--- a/hw/virtio/virtio.c
+++ b/hw/virtio/virtio.c
@@ -957,12 +957,17 @@ static void virtqueue
vcpu_dirty_stat_collect() has an unused parameter so remove it.
Signed-off-by: Wafer
---
migration/dirtyrate.c | 7 +++
1 file changed, 3 insertions(+), 4 deletions(-)
diff --git a/migration/dirtyrate.c b/migration/dirtyrate.c
index 036ac017fc..62d86b8be2 100644
--- a/migration/dirtyrate.c
17 matches
Mail list logo
