[PATCH] ui/spice: Destroy the temporary egl fb after the blit is submitted

2025-07-18 Thread Vivek Kasireddy
/spice: Blit the scanout texture if its memory layout is not linear") Reported-by: Peter Maydell Cc: Marc-André Lureau Signed-off-by: Vivek Kasireddy --- v2: - Make scanout_tex_fb local to spice_gl_blit_scanout_texture() since it is not used outside of it (Peter) --- ui/spice-display.c | 14 +

[PATCH] ui/spice: Destroy the temporary egl fb after the blit is submitted

2025-07-17 Thread Vivek Kasireddy
/spice: Blit the scanout texture if its memory layout is not linear") Reported-by: Peter Maydell Cc: Marc-André Lureau Signed-off-by: Vivek Kasireddy --- ui/spice-display.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/ui/spice-display.c b/ui/spice-display.c index 9

[PATCH v6 5/7] ui/console-gl: Add a helper to create a texture with linear memory layout

2025-06-16 Thread Vivek Kasireddy
situations. Cc: Gerd Hoffmann Cc: Marc-André Lureau Cc: Dmitry Osipenko Cc: Frediano Ziglio Cc: Dongwon Kim Reviewed-by: Marc-André Lureau Co-developed-by: Michael Scherle Signed-off-by: Vivek Kasireddy --- include/ui/console.h | 3 +++ ui/console-gl.c | 48

[PATCH v6 7/7] ui/spice: Blit the scanout texture if its memory layout is not linear

2025-06-16 Thread Vivek Kasireddy
nsure that there is no corruption seen regardless of which encoder or decoder is used. Cc: Gerd Hoffmann Cc: Marc-André Lureau Cc: Dmitry Osipenko Cc: Frediano Ziglio Cc: Dongwon Kim Cc: Michael Scherle Reviewed-by: Marc-André Lureau Signed-off-by: Vivek Kasireddy --- include/ui/spice-disp

[PATCH v6 2/7] ui/spice: Enable gl=on option for non-local or remote clients

2025-06-16 Thread Vivek Kasireddy
located on a different machine. Cc: Gerd Hoffmann Cc: Marc-André Lureau Cc: Dmitry Osipenko Cc: Frediano Ziglio Cc: Dongwon Kim Cc: Michael Scherle Reviewed-by: Marc-André Lureau Signed-off-by: Vivek Kasireddy --- include/ui/spice-display.h | 1 + ui/spice-core.c| 4 ui

[PATCH v6 1/7] ui/egl-helpers: Error check the fds in egl_dmabuf_export_texture()

2025-06-16 Thread Vivek Kasireddy
Cc: Dmitry Osipenko Cc: Frediano Ziglio Cc: Dongwon Kim Cc: Michael Scherle Reviewed-by: Marc-André Lureau Signed-off-by: Vivek Kasireddy --- ui/egl-helpers.c | 6 ++ 1 file changed, 6 insertions(+) diff --git a/ui/egl-helpers.c b/ui/egl-helpers.c index 5503a795e4..e3f2872cc1 100644

[PATCH v6 0/7] ui/spice: Enable gl=on option for non-local or remote clients

2025-06-16 Thread Vivek Kasireddy
ssociated Spice server MR (merged): https://gitlab.freedesktop.org/spice/spice/-/merge_requests/229 --- Cc: Gerd Hoffmann Cc: Marc-André Lureau Cc: Dmitry Osipenko Cc: Frediano Ziglio Cc: Michael Scherle Cc: Dongwon Kim Cc: Alex Bennée Cc: Daniel P. Berrangé Vivek Kasireddy (7): ui/egl

[PATCH v6 3/7] ui/spice: Add an option for users to provide a preferred video codec

2025-06-16 Thread Vivek Kasireddy
Lureau Signed-off-by: Vivek Kasireddy --- qemu-options.hx | 8 ui/spice-core.c | 15 +++ 2 files changed, 23 insertions(+) diff --git a/qemu-options.hx b/qemu-options.hx index 7eb8e02b4b..124c87311c 100644 --- a/qemu-options.hx +++ b/qemu-options.hx @@ -2281,6 +2281,7 @@ DEF

[PATCH v6 6/7] ui/spice: Create a new texture with linear layout when gl=on is specified

2025-06-16 Thread Vivek Kasireddy
o Cc: Frediano Ziglio Cc: Dongwon Kim Reviewed-by: Marc-André Lureau Co-developed-by: Michael Scherle Signed-off-by: Vivek Kasireddy --- include/ui/surface.h | 1 + ui/console-gl.c | 6 ui/spice-display.c | 82 3 files changed, 89 inser

[PATCH v6 4/7] ui/spice: Add an option to submit gl_draw requests at fixed rate

2025-06-16 Thread Vivek Kasireddy
-by: Marc-André Lureau Signed-off-by: Vivek Kasireddy --- include/ui/spice-display.h | 1 + qemu-options.hx| 5 +++ ui/spice-core.c| 12 ui/spice-display.c | 62 -- 4 files changed, 70 insertions(+), 10 deletions

[PATCH v5 1/7] ui/egl-helpers: Error check the fds in egl_dmabuf_export_texture()

2025-05-28 Thread Vivek Kasireddy
Cc: Dmitry Osipenko Cc: Frediano Ziglio Cc: Dongwon Kim Cc: Michael Scherle Signed-off-by: Vivek Kasireddy --- ui/egl-helpers.c | 6 ++ 1 file changed, 6 insertions(+) diff --git a/ui/egl-helpers.c b/ui/egl-helpers.c index 5503a795e4..e3f2872cc1 100644 --- a/ui/egl-helpers.c +++ b/ui

[PATCH v5 4/7] ui/spice: Add an option to submit gl_draw requests at fixed rate

2025-05-28 Thread Vivek Kasireddy
-off-by: Vivek Kasireddy --- include/ui/spice-display.h | 1 + qemu-options.hx| 5 +++ ui/spice-core.c| 12 ui/spice-display.c | 62 -- 4 files changed, 70 insertions(+), 10 deletions(-) diff --git a/include/ui/spice

[PATCH v5 7/7] ui/spice: Blit the scanout texture if its memory layout is not linear

2025-05-28 Thread Vivek Kasireddy
nsure that there is no corruption seen regardless of which encoder or decoder is used. Cc: Gerd Hoffmann Cc: Marc-André Lureau Cc: Dmitry Osipenko Cc: Frediano Ziglio Cc: Dongwon Kim Cc: Michael Scherle Signed-off-by: Vivek Kasireddy --- include/ui/spice-display.h | 3 ++ ui/spice-disp

[PATCH v5 3/7] ui/spice: Enable gl=on option for non-local or remote clients

2025-05-28 Thread Vivek Kasireddy
located on a different machine. Cc: Gerd Hoffmann Cc: Marc-André Lureau Cc: Dmitry Osipenko Cc: Frediano Ziglio Cc: Dongwon Kim Cc: Michael Scherle Signed-off-by: Vivek Kasireddy --- include/ui/spice-display.h | 1 + ui/spice-core.c| 4 ui/spice-display.c | 1 + 3

[PATCH v5 5/7] ui/console-gl: Add a helper to create a texture with linear memory layout

2025-05-28 Thread Vivek Kasireddy
situations. Cc: Gerd Hoffmann Cc: Marc-André Lureau Cc: Dmitry Osipenko Cc: Frediano Ziglio Cc: Dongwon Kim Co-developed-by: Michael Scherle Signed-off-by: Vivek Kasireddy --- include/ui/console.h | 3 +++ ui/console-gl.c | 48 2 files changed

[PATCH v5 6/7] ui/spice: Create a new texture with linear layout when gl=on is enabled

2025-05-28 Thread Vivek Kasireddy
o Cc: Frediano Ziglio Cc: Dongwon Kim Co-developed-by: Michael Scherle Signed-off-by: Vivek Kasireddy --- include/ui/surface.h | 1 + ui/console-gl.c | 6 ui/spice-display.c | 82 3 files changed, 89 insertions(+) diff --git a/inclu

[PATCH v5 2/7] ui/spice: Add an option for users to provide a preferred codec

2025-05-28 Thread Vivek Kasireddy
Giving users an option to choose a particular codec will enable them to make an appropriate decision based on their hardware and use-case. Cc: Gerd Hoffmann Cc: Marc-André Lureau Cc: Dmitry Osipenko Cc: Frediano Ziglio Cc: Dongwon Kim Cc: Michael Scherle Signed-off-by: Vivek Kasireddy

[PATCH v5 0/7] ui/spice: Enable gl=on option for non-local or remote clients

2025-05-28 Thread Vivek Kasireddy
R (merged): https://gitlab.freedesktop.org/spice/spice/-/merge_requests/229 --- Cc: Gerd Hoffmann Cc: Marc-André Lureau Cc: Dmitry Osipenko Cc: Frediano Ziglio Cc: Michael Scherle Cc: Dongwon Kim Cc: Alex Bennée Vivek Kasireddy (7): ui/egl-helpers: Error check the fds in egl_dmabuf_export_texture() ui/spice:

[PATCH v4 7/7] ui/spice: Blit the scanout texture if its memory layout is not linear

2025-05-14 Thread Vivek Kasireddy
nsure that there is no corruption seen regardless of which encoder or decoder is used. Cc: Gerd Hoffmann Cc: Marc-André Lureau Cc: Dmitry Osipenko Cc: Frediano Ziglio Cc: Dongwon Kim Signed-off-by: Vivek Kasireddy --- include/ui/spice-display.h | 3 ++ ui/spice-display.c

[PATCH v4 0/7] ui/spice: Enable gl=on option for non-local or remote clients

2025-05-14 Thread Vivek Kasireddy
Hoffmann Cc: Marc-André Lureau Cc: Dmitry Osipenko Cc: Frediano Ziglio Cc: Michael Scherle Cc: Dongwon Kim Cc: Alex Bennée Vivek Kasireddy (7): ui/egl-helpers: Error check the fds in egl_dmabuf_export_texture() ui/spice: Add an option for users to provide a preferred codec ui/spice: Ena

[PATCH v4 4/7] ui/spice: Add an option to submit gl_draw requests at fixed rate

2025-05-14 Thread Vivek Kasireddy
be sent as soon as the Guest submits a new frame which is not optimal as it would lead to increased network traffic and wastage of GPU cycles if the frames get dropped. Cc: Gerd Hoffmann Cc: Marc-André Lureau Cc: Dmitry Osipenko Cc: Frediano Ziglio Cc: Dongwon Kim Signed-off-by: Vivek

[PATCH v4 3/7] ui/spice: Enable gl=on option for non-local or remote clients

2025-05-14 Thread Vivek Kasireddy
located on a different machine. Cc: Gerd Hoffmann Cc: Marc-André Lureau Cc: Dmitry Osipenko Cc: Frediano Ziglio Cc: Dongwon Kim Signed-off-by: Vivek Kasireddy --- include/ui/spice-display.h | 1 + ui/spice-core.c| 4 ui/spice-display.c | 1 + 3 files changed, 6

[PATCH v4 2/7] ui/spice: Add an option for users to provide a preferred codec

2025-05-14 Thread Vivek Kasireddy
Giving users an option to choose a particular codec will enable them to make an appropriate decision based on their hardware and use-case. Cc: Gerd Hoffmann Cc: Marc-André Lureau Cc: Dmitry Osipenko Cc: Frediano Ziglio Cc: Dongwon Kim Signed-off-by: Vivek Kasireddy --- qemu-options.hx | 5

[PATCH v4 6/7] ui/spice: Create a new texture with linear layout when gl=on is enabled

2025-05-14 Thread Vivek Kasireddy
diano Ziglio Cc: Dongwon Kim Signed-off-by: Vivek Kasireddy --- ui/spice-display.c | 76 ++ 1 file changed, 76 insertions(+) diff --git a/ui/spice-display.c b/ui/spice-display.c index ed91521ac2..fb56da4ab0 100644 --- a/ui/spice-display.c +++ b/ui/

[PATCH v4 1/7] ui/egl-helpers: Error check the fds in egl_dmabuf_export_texture()

2025-05-14 Thread Vivek Kasireddy
Osipenko Cc: Frediano Ziglio Cc: Dongwon Kim Signed-off-by: Vivek Kasireddy --- ui/egl-helpers.c | 6 ++ 1 file changed, 6 insertions(+) diff --git a/ui/egl-helpers.c b/ui/egl-helpers.c index 9cda2bbbee..07d8edd3dc 100644 --- a/ui/egl-helpers.c +++ b/ui/egl-helpers.c @@ -289,6 +289,7 @@ bool

[PATCH v4 5/7] ui/console-gl: Add a helper to create a texture with linear memory layout

2025-05-14 Thread Vivek Kasireddy
situations. Cc: Gerd Hoffmann Cc: Marc-André Lureau Cc: Dmitry Osipenko Cc: Frediano Ziglio Cc: Dongwon Kim Signed-off-by: Vivek Kasireddy --- include/ui/console.h | 2 ++ ui/console-gl.c | 32 2 files changed, 34 insertions(+) diff --git a/include/ui

[PATCH v3 4/6] ui/console-gl: Add a helper to create a texture with linear memory layout

2025-04-28 Thread Vivek Kasireddy
situations. Cc: Gerd Hoffmann Cc: Marc-André Lureau Cc: Dmitry Osipenko Cc: Frediano Ziglio Cc: Dongwon Kim Signed-off-by: Vivek Kasireddy --- include/ui/console.h | 2 ++ ui/console-gl.c | 28 2 files changed, 30 insertions(+) diff --git a/include/ui/console.h

[PATCH v3 6/6] ui/spice: Blit the scanout texture if its memory layout is not linear

2025-04-28 Thread Vivek Kasireddy
nsure that there is no corruption seen regardless of which encoder or decoder is used. Cc: Gerd Hoffmann Cc: Marc-André Lureau Cc: Dmitry Osipenko Cc: Frediano Ziglio Cc: Dongwon Kim Signed-off-by: Vivek Kasireddy --- include/ui/spice-display.h | 3 ++ ui/spice-display.c

[PATCH v3 3/6] ui/spice: Submit the gl_draw requests at 60 FPS for remote clients

2025-04-28 Thread Vivek Kasireddy
60 FPS (assuming the underlying mode is WxY@60). Cc: Gerd Hoffmann Cc: Marc-André Lureau Cc: Dmitry Osipenko Cc: Frediano Ziglio Cc: Dongwon Kim Signed-off-by: Vivek Kasireddy --- ui/spice-display.c | 53 +- 1 file changed, 43 insertions(+), 10

[PATCH v3 1/6] ui/spice: Add an option for users to provide a preferred codec

2025-04-28 Thread Vivek Kasireddy
Giving users an option to choose a particular codec will enable them to make an appropriate decision based on their hardware and use-case. Cc: Gerd Hoffmann Cc: Marc-André Lureau Cc: Dmitry Osipenko Cc: Frediano Ziglio Cc: Dongwon Kim Signed-off-by: Vivek Kasireddy --- qemu-options.hx | 5

[PATCH v3 5/6] ui/spice: Create a new texture with linear layout when gl=on is enabled

2025-04-28 Thread Vivek Kasireddy
diano Ziglio Cc: Dongwon Kim Signed-off-by: Vivek Kasireddy --- ui/spice-display.c | 63 +- 1 file changed, 62 insertions(+), 1 deletion(-) diff --git a/ui/spice-display.c b/ui/spice-display.c index 2c4daa0707..047d453a0b 100644 --- a/ui/spice-display.c +++

[PATCH v3 0/6] ui/spice: Enable gl=on option for non-local or remote clients

2025-04-28 Thread Vivek Kasireddy
/spice/spice/-/merge_requests/229 --- Cc: Gerd Hoffmann Cc: Marc-André Lureau Cc: Dmitry Osipenko Cc: Frediano Ziglio Cc: Michael Scherle Cc: Dongwon Kim Cc: Alex Bennée Vivek Kasireddy (6): ui/spice: Add an option for users to provide a preferred codec ui/spice: Enable gl=on option for non

[PATCH v3 2/6] ui/spice: Enable gl=on option for non-local or remote clients

2025-04-28 Thread Vivek Kasireddy
located on a different machine. Cc: Gerd Hoffmann Cc: Marc-André Lureau Cc: Dmitry Osipenko Cc: Frediano Ziglio Cc: Dongwon Kim Signed-off-by: Vivek Kasireddy --- include/ui/spice-display.h | 1 + ui/spice-core.c| 4 ui/spice-display.c | 1 + 3 files changed, 6

[PATCH v2 0/6] ui/spice: Enable gl=on option for non-local or remote clients

2025-03-25 Thread Vivek Kasireddy
--- Cc: Gerd Hoffmann Cc: Marc-André Lureau Cc: Dmitry Osipenko Cc: Frediano Ziglio Cc: Michael Scherle Cc: Dongwon Kim Vivek Kasireddy (6): ui/spice: Add an option for users to provide a preferred codec ui/spice: Enable gl=on option for non-local or remote clients ui/spice: Submit the

[PATCH v2 6/6] ui/spice: Blit the scanout texture if its memory layout is not linear

2025-03-25 Thread Vivek Kasireddy
nsure that there is no corruption seen regardless of which encoder or decoder is used. Cc: Gerd Hoffmann Cc: Marc-André Lureau Cc: Dmitry Osipenko Cc: Frediano Ziglio Cc: Dongwon Kim Signed-off-by: Vivek Kasireddy --- include/ui/spice-display.h | 3 ++ ui/spice-display.c

[PATCH v2 4/6] ui/console-gl: Add a helper to create a texture with linear memory layout

2025-03-25 Thread Vivek Kasireddy
situations. Cc: Gerd Hoffmann Cc: Marc-André Lureau Cc: Dmitry Osipenko Cc: Frediano Ziglio Cc: Dongwon Kim Signed-off-by: Vivek Kasireddy --- include/ui/console.h | 2 ++ ui/console-gl.c | 26 ++ 2 files changed, 28 insertions(+) diff --git a/include/ui/console.h b

[PATCH v2 1/6] ui/spice: Add an option for users to provide a preferred codec

2025-03-25 Thread Vivek Kasireddy
Giving users an option to choose a particular codec will enable them to make an appropriate decision based on their hardware and use-case. Cc: Gerd Hoffmann Cc: Marc-André Lureau Cc: Dmitry Osipenko Cc: Frediano Ziglio Cc: Dongwon Kim Signed-off-by: Vivek Kasireddy --- qemu-options.hx | 5

[PATCH v2 3/6] ui/spice: Submit the gl_draw requests at 60 FPS for remote clients

2025-03-25 Thread Vivek Kasireddy
60 FPS (assuming the underlying mode is WxY@60). Cc: Gerd Hoffmann Cc: Marc-André Lureau Cc: Dmitry Osipenko Cc: Frediano Ziglio Cc: Dongwon Kim Signed-off-by: Vivek Kasireddy --- ui/spice-display.c | 53 +- 1 file changed, 43 insertions(+), 10

[PATCH v2 2/6] ui/spice: Enable gl=on option for non-local or remote clients

2025-03-25 Thread Vivek Kasireddy
located on a different machine. Cc: Gerd Hoffmann Cc: Marc-André Lureau Cc: Dmitry Osipenko Cc: Frediano Ziglio Cc: Dongwon Kim Signed-off-by: Vivek Kasireddy --- include/ui/spice-display.h | 1 + ui/spice-core.c| 4 ui/spice-display.c | 1 + 3 files changed, 6

[PATCH v2 5/6] ui/spice: Create a new texture with linear layout when gl=on is enabled

2025-03-25 Thread Vivek Kasireddy
diano Ziglio Cc: Dongwon Kim Signed-off-by: Vivek Kasireddy --- ui/spice-display.c | 63 +- 1 file changed, 62 insertions(+), 1 deletion(-) diff --git a/ui/spice-display.c b/ui/spice-display.c index 2c4daa0707..047d453a0b 100644 --- a/ui/spice-display.c +++

[PATCH v1 3/7] ui/spice: Submit the gl_draw requests at 60 FPS for remote clients

2024-01-19 Thread Vivek Kasireddy
60 FPS (assuming the underlying mode is WxY@60). Cc: Gerd Hoffmann Cc: Marc-André Lureau Cc: Frediano Ziglio Cc: Dongwon Kim Signed-off-by: Vivek Kasireddy --- ui/spice-display.c | 38 -- 1 file changed, 28 insertions(+), 10 deletions(-) diff --git a/ui

[PATCH v1 5/7] ui/spice: Override the surface's glformat when gl=on is enabled

2024-01-19 Thread Vivek Kasireddy
work regardless of the Host's endianness but let us limit this change only to this specific use-case for now. Cc: Gerd Hoffmann Cc: Marc-André Lureau Cc: Frediano Ziglio Cc: Dongwon Kim Signed-off-by: Vivek Kasireddy --- ui/spice-display.c | 3 +++ 1 file changed, 3 insertions(+) diff

[PATCH v1 1/7] ui/spice: Add an option for users to provide a preferred codec

2024-01-19 Thread Vivek Kasireddy
Giving users an option to choose a particular codec will enable them to make an appropriate decision based on their hardware and use-case. Cc: Gerd Hoffmann Cc: Marc-André Lureau Cc: Frediano Ziglio Cc: Dongwon Kim Signed-off-by: Vivek Kasireddy --- v2: - Don't override the default

[PATCH v1 4/7] ui/console-gl: Add an option to override a surface's glformat

2024-01-19 Thread Vivek Kasireddy
. Cc: Gerd Hoffmann Cc: Marc-André Lureau Cc: Frediano Ziglio Cc: Dongwon Kim Signed-off-by: Vivek Kasireddy --- include/ui/surface.h | 1 + ui/console-gl.c | 6 ++ 2 files changed, 7 insertions(+) diff --git a/include/ui/surface.h b/include/ui/surface.h index 4244e0ca4a..a39fee55a2

[PATCH v1 0/7] ui/spice: Enable gl=on option for non-local or remote clients

2024-01-19 Thread Vivek Kasireddy
/053288.html Cc: Gerd Hoffmann Cc: Marc-André Lureau Cc: Frediano Ziglio Cc: Dongwon Kim Vivek Kasireddy (7): ui/spice: Add an option for users to provide a preferred codec ui/spice: Enable gl=on option for non-local or remote clients ui/spice: Submit the gl_draw requests at 60 FPS for

[PATCH v1 7/7] ui/spice: Create another texture with linear layout when gl=on is enabled

2024-01-19 Thread Vivek Kasireddy
g the memory object as the texture storage mechanism. Cc: Gerd Hoffmann Cc: Marc-André Lureau Cc: Frediano Ziglio Cc: Dongwon Kim Signed-off-by: Vivek Kasireddy --- ui/spice-display.c | 33 + 1 file changed, 33 insertions(+) diff --git a/ui/spice-display.c

[PATCH v1 2/7] ui/spice: Enable gl=on option for non-local or remote clients

2024-01-19 Thread Vivek Kasireddy
located on a different machine. Cc: Gerd Hoffmann Cc: Marc-André Lureau Cc: Frediano Ziglio Cc: Dongwon Kim Signed-off-by: Vivek Kasireddy --- include/ui/spice-display.h | 1 + ui/spice-core.c| 4 ui/spice-display.c | 1 + 3 files changed, 6 insertions(+) diff --git a

[PATCH v1 6/7] ui/console-gl: Add a helper to create a texture with linear memory layout

2024-01-19 Thread Vivek Kasireddy
: Vivek Kasireddy --- include/ui/console.h | 2 ++ ui/console-gl.c | 26 ++ 2 files changed, 28 insertions(+) diff --git a/include/ui/console.h b/include/ui/console.h index a4a49ffc64..e53e3ce03e 100644 --- a/include/ui/console.h +++ b/include/ui/console.h @@ -444,6

[PATCH v2] target/i386/host-cpu: Use iommu phys_bits with VFIO assigned devices on Intel h/w

2024-01-18 Thread Vivek Kasireddy
hang Liu Signed-off-by: Vivek Kasireddy --- v2: - Replace the term passthrough with assigned (Laszlo) - Update the commit message to note that both OVMF and Seabios guests are affected (Cédric) - Update the subject to indicate what is done in the patch --- target/i386/host-cp

[PATCH v1] target/i386/host-cpu: Use IOMMU addr width for passthrough devices on Intel platforms

2023-11-12 Thread Vivek Kasireddy
bits value as shown in this patch. Previous attempt at solving this issue in OVMF: https://edk2.groups.io/g/devel/topic/102359124 Cc: Gerd Hoffmann Cc: Philippe Mathieu-Daudé Cc: Alex Williamson Cc: Laszlo Ersek Cc: Dongwon Kim Signed-off-by: Vivek Kasireddy --- target/i386/ho

[PATCH v1] virtio-gpu: Make non-gl display updates work again when blob=true

2023-06-22 Thread Vivek Kasireddy
("virtio-gpu: splitting one extended mode guest fb into n-scanouts") Cc: Gerd Hoffmann Cc: Marc-André Lureau Cc: Dongwon Kim Signed-off-by: Vivek Kasireddy --- hw/display/virtio-gpu.c | 27 ++- 1 file changed, 22 insertions(+), 5 deletions(-) diff --git a/

[RFC v2 1/2] spice: Add an option for users to provide a preferred codec

2023-01-23 Thread Vivek Kasireddy
Giving users an option to choose a particular codec will enable them to make an appropriate decision based on their hardware and use-case. Cc: Gerd Hoffmann Cc: Marc-André Lureau Cc: Dongwon Kim Signed-off-by: Vivek Kasireddy --- qemu-options.hx | 5 + ui/spice-core.c | 14

[RFC v2 0/2] spice: Add an option to forward the dmabuf directly to the encoder (v2)

2023-01-23 Thread Vivek Kasireddy
Vivek Kasireddy (2): spice: Add an option for users to provide a preferred codec spice: Add an option to forward the dmabuf directly to the encoder (v2) include/ui/spice-display.h | 1 + qemu-options.hx| 11 +- ui/spice-core.c| 36 -- ui/spice

[RFC v2 2/2] spice: Add an option to forward the dmabuf directly to the encoder (v2)

2023-01-23 Thread Vivek Kasireddy
cookie is received. v2: - Use the existing gl_scanout and gl_draw_async APIs instead of adding new ones. Cc: Gerd Hoffmann Cc: Marc-André Lureau Cc: Dongwon Kim Signed-off-by: Vivek Kasireddy --- include/ui/spice-display.h | 1 + qemu-options.hx| 6 ++- ui/spice-core.c

[RFC v1 0/2] spice: Add an option to forward the dmabuf directly to the encoder

2023-01-10 Thread Vivek Kasireddy
: https://lists.freedesktop.org/archives/spice-devel/2023-January/052927.html Cc: Gerd Hoffmann Cc: Marc-André Lureau Cc: Dongwon Kim Vivek Kasireddy (2): spice: Add an option for users to provide a preferred codec spice: Add an option to forward the dmabuf directly to the encoder include/ui

[RFC v1 1/2] spice: Add an option for users to provide a preferred codec

2023-01-10 Thread Vivek Kasireddy
Giving users an option to choose a particular codec will enable them to make an appropriate decision based on their hardware and use-case. Cc: Gerd Hoffmann Cc: Marc-André Lureau Cc: Dongwon Kim Signed-off-by: Vivek Kasireddy --- qemu-options.hx | 5 + ui/spice-core.c | 14

[RFC v1 2/2] spice: Add an option to forward the dmabuf directly to the encoder

2023-01-10 Thread Vivek Kasireddy
) which in turn gets it from the scanout. Once the encoder is done encoding the dmabuf, it triggers an async that would indicate to Qemu to unblock the pipeline. Cc: Gerd Hoffmann Cc: Marc-André Lureau Cc: Dongwon Kim Signed-off-by: Vivek Kasireddy --- include/ui/spice-display.h | 2 + qemu

[PATCH v2 5/6] ui/gtk: Factor out tab window creation into a separate function

2022-11-17 Thread Vivek Kasireddy
-by: Vivek Kasireddy --- ui/gtk.c | 65 +++- 1 file changed, 36 insertions(+), 29 deletions(-) diff --git a/ui/gtk.c b/ui/gtk.c index 4ac3655694..6b0369e3ed 100644 --- a/ui/gtk.c +++ b/ui/gtk.c @@ -1400,6 +1400,41 @@ static gboolean gd_win_grab

[PATCH v2 0/6] ui/gtk: Add a new parameter to assign connectors/monitors (v2)

2022-11-17 Thread Vivek Kasireddy
eDP-1,connector.1=DP-1. Cc: Dongwon Kim Cc: Gerd Hoffmann Cc: Markus Armbruster Cc: Marc-André Lureau Vivek Kasireddy (6): ui/gtk: Consider the scaling factor when getting the root coordinates ui/gtk-gl-area: Don't forget to calculate the scaling factors in draw ui/gtk: Handl

[PATCH v2 2/6] ui/gtk-gl-area: Don't forget to calculate the scaling factors in draw

2022-11-17 Thread Vivek Kasireddy
draw. Cc: Gerd Hoffmann Cc: Dongwon Kim Signed-off-by: Vivek Kasireddy --- ui/gtk-gl-area.c | 5 + ui/gtk.c | 9 +++-- 2 files changed, 12 insertions(+), 2 deletions(-) diff --git a/ui/gtk-gl-area.c b/ui/gtk-gl-area.c index 682638a197..6799805f8e 100644 --- a/ui/gtk-gl-area.c

[PATCH v2 3/6] ui/gtk: Handle relative mode events correctly with Wayland compositors

2022-11-17 Thread Vivek Kasireddy
Cc: Dongwon Kim Signed-off-by: Vivek Kasireddy --- include/ui/gtk.h | 2 ++ ui/gtk.c | 71 ++-- 2 files changed, 65 insertions(+), 8 deletions(-) diff --git a/include/ui/gtk.h b/include/ui/gtk.h index ae0f53740d..f8df042f95 100644 --- a/include

[PATCH v2 4/6] ui/gtk: Disable the scanout when a detached tab is closed

2022-11-17 Thread Vivek Kasireddy
: Dongwon Kim Signed-off-by: Vivek Kasireddy --- ui/gtk-egl.c | 2 ++ ui/gtk-gl-area.c | 2 ++ ui/gtk.c | 1 + 3 files changed, 5 insertions(+) diff --git a/ui/gtk-egl.c b/ui/gtk-egl.c index 35f917ceb1..396cb6590a 100644 --- a/ui/gtk-egl.c +++ b/ui/gtk-egl.c @@ -214,6 +214,8 @@ void

[PATCH v2 6/6] ui/gtk: Add a new parameter to assign connectors/monitors to GFX VCs (v2)

2022-11-17 Thread Vivek Kasireddy
fullscreen option is enabled. Cc: Dongwon Kim Cc: Gerd Hoffmann Cc: Markus Armbruster Cc: Marc-André Lureau Acked-by: Markus Armbruster (QAPI schema) Signed-off-by: Vivek Kasireddy --- include/ui/gtk.h | 1 + qapi/ui.json | 10 +- qemu-options.hx | 5 +- ui/gtk.c

[PATCH v2 1/6] ui/gtk: Consider the scaling factor when getting the root coordinates

2022-11-17 Thread Vivek Kasireddy
Since gdk_window_get_root_coords() expects a position within the window, we need to translate Guest's cooridinates to window local coordinates by multiplying them with the scaling factor. Cc: Gerd Hoffmann Cc: Dongwon Kim Signed-off-by: Vivek Kasireddy --- ui/gtk.c | 3 ++- 1 file chang

[PATCH v1] ui/gtk: Add support for extended absolute mode for the pointer device

2022-11-17 Thread Vivek Kasireddy
these situations but the user experience is not as seamless as the absolute mode. Cc: Gerd Hoffmann Cc: Dongwon Kim Signed-off-by: Vivek Kasireddy --- include/ui/gtk.h | 1 + qapi/ui.json | 6 - qemu-options.hx | 5 +++- ui/gtk.c | 63 +++---

[PATCH v1 1/2] virtio-gpu: Provide position info (x, y) to the Guest

2022-11-17 Thread Vivek Kasireddy
#L343 Cc: Dongwon Kim Cc: Gerd Hoffmann Signed-off-by: Vivek Kasireddy --- hw/display/virtio-gpu-base.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/hw/display/virtio-gpu-base.c b/hw/display/virtio-gpu-base.c index a29f191aa8..3b6b480131 100644 --- a/hw/display/virtio-gpu-base.c +++ b/hw

[PATCH v1 0/2] virtio-gpu: Provide display position info (x, y) to the Guest

2022-11-17 Thread Vivek Kasireddy
#L343 Cc: Dongwon Kim Cc: Gerd Hoffmann Vivek Kasireddy (2): virtio-gpu: Provide position info (x, y) to the Guest ui/gtk: Include the position info while setting the ui info hw/display/virtio-gpu-base.c | 2 ++ ui/gtk.c | 20 2 files changed, 22

[PATCH v1 2/2] ui/gtk: Include the position info while setting the ui info

2022-11-17 Thread Vivek Kasireddy
In situtations where the Guest uses multiple displays/outputs, this position info is useful for aligning the Guest's outputs with that of the Host's. Cc: Dongwon Kim Cc: Gerd Hoffmann Signed-off-by: Vivek Kasireddy --- ui/gtk.c | 20 1 file changed, 20 insertion

[PATCH v1 3/3] ui/gtk: Add a new parameter to assign connectors/monitors to GFX VCs

2022-09-16 Thread Vivek Kasireddy
Armbruster Cc: Philippe Mathieu-Daudé Cc: Marc-André Lureau Cc: Thomas Huth Signed-off-by: Vivek Kasireddy --- qapi/ui.json| 9 ++- qemu-options.hx | 1 + ui/gtk.c| 168 3 files changed, 177 insertions(+), 1 deletion(-) diff --

[PATCH v1 0/3] ui/gtk: Add a new parameter to assign connectors/monitors to Guests' windows

2022-09-16 Thread Vivek Kasireddy
Markus Armbruster Cc: Philippe Mathieu-Daudé Cc: Marc-André Lureau Cc: Thomas Huth Vivek Kasireddy (3): ui/gtk: Disable the scanout when a detached tab is closed ui/gtk: Factor out tab window creation into a separate function ui/gtk: Add a new parameter to assign connectors/monitors to G

[PATCH v1 1/3] ui/gtk: Disable the scanout when a detached tab is closed

2022-09-16 Thread Vivek Kasireddy
: Dongwon Kim Signed-off-by: Vivek Kasireddy --- ui/gtk-egl.c | 2 ++ ui/gtk-gl-area.c | 2 ++ ui/gtk.c | 1 + 3 files changed, 5 insertions(+) diff --git a/ui/gtk-egl.c b/ui/gtk-egl.c index b5bffbab25..0f9ef11f4c 100644 --- a/ui/gtk-egl.c +++ b/ui/gtk-egl.c @@ -211,6 +211,8 @@ void

[PATCH v1 2/3] ui/gtk: Factor out tab window creation into a separate function

2022-09-16 Thread Vivek Kasireddy
-by: Vivek Kasireddy --- ui/gtk.c | 65 +++- 1 file changed, 36 insertions(+), 29 deletions(-) diff --git a/ui/gtk.c b/ui/gtk.c index 0ff31cb852..945c550909 100644 --- a/ui/gtk.c +++ b/ui/gtk.c @@ -1335,6 +1335,41 @@ static gboolean gd_win_grab

[PATCH v1] ui/gtk-egl: Check for a valid context before making EGL calls

2022-03-06 Thread Vivek Kasireddy
rovider of eglCreateImageKHR found. Requires one of: EGL_KHR_image EGL_KHR_image_base Fixes: 7cc712e9862ff ("ui: dispatch GL events to all listeners") Cc: Marc-André Lureau Cc: Gerd Hoffmann Cc: Dongwon Kim Signed-off-by: Vivek Kasireddy --- ui/gtk-egl.c | 8 1 file c

[PATCH v6 2/5] ui/egl: Add egl helpers to help with synchronization

2021-09-14 Thread Vivek Kasireddy
These egl helpers would be used for creating and waiting on a sync object. Cc: Gerd Hoffmann Reviewed-by: Gerd Hoffmann Signed-off-by: Vivek Kasireddy --- include/ui/console.h | 2 ++ include/ui/egl-helpers.h | 2 ++ ui/egl-helpers.c | 26 ++ 3 files

[PATCH v6 5/5] virtio-gpu: Add gl_flushed callback

2021-09-14 Thread Vivek Kasireddy
Adding this callback provides a way to resume the processing of cmds in fenceq and cmdq that were not processed because the UI was waiting on a fence and blocked cmd processing. Cc: Gerd Hoffmann Reviewed-by: Gerd Hoffmann Signed-off-by: Vivek Kasireddy --- hw/display/virtio-gpu.c | 32

[PATCH v6 4/5] ui/gtk-egl: Wait for the draw signal for dmabuf blobs

2021-09-14 Thread Vivek Kasireddy
Instead of immediately drawing and submitting, queue and wait for the draw signal if the dmabuf submitted is a blob. Cc: Gerd Hoffmann Reviewed-by: Gerd Hoffmann Signed-off-by: Vivek Kasireddy --- include/ui/gtk.h | 2 ++ ui/gtk-egl.c | 15 +++ ui/gtk.c | 2 +- 3

[PATCH v6 1/5] ui/gtk: Create a common release_dmabuf helper

2021-09-14 Thread Vivek Kasireddy
Since the texture release mechanism is same for both gtk-egl and gtk-glarea, move the helper from gtk-egl to common gtk code so that it can be shared by both gtk backends. Cc: Gerd Hoffmann Reviewed-by: Gerd Hoffmann Signed-off-by: Vivek Kasireddy --- include/ui/gtk.h | 2 -- ui/gtk-egl.c

[PATCH v6 0/5] virtio-gpu: Add a default synchronization mechanism for blobs (v6)

2021-09-14 Thread Vivek Kasireddy
main loop and wait for it to be signalled. (suggested by Gerd Hoffmann) v4: - Replace the field 'blob' with 'allow_fences' in QemuDmabuf struct. (Gerd) v5: rebase v6: Fixed the compilation error on platforms that do not have GBM. Cc: Gerd Hoffmann Cc: Dongwon Kim Vive

[PATCH v6 3/5] ui: Create sync objects and fences only for blobs

2021-09-14 Thread Vivek Kasireddy
Create sync objects and fences only for dmabufs that are blobs. Once a fence is created (after glFlush) and is signalled, graphic_hw_gl_flushed() will be called and virtio-gpu cmd processing will be resumed. Cc: Gerd Hoffmann Signed-off-by: Vivek Kasireddy --- hw/display/virtio-gpu-udmabuf.c

[RFC v2 1/2] virtio-gpu: Add support for VIRTIO_GPU_F_RELEASE_FENCE

2021-09-13 Thread Vivek Kasireddy
To support this feature, we add a new queue named rel_fenceq to enqueue finished set_scanout_blob cmds. Cc: Gerd Hoffmann Signed-off-by: Vivek Kasireddy --- hw/display/virtio-gpu-base.c| 3 ++ hw/display/virtio-gpu-udmabuf.c | 4 +- hw/display/virtio-gpu.c

[RFC v2 2/2] ui: Add a plain Wayland backend for Qemu UI

2021-09-13 Thread Vivek Kasireddy
Cc: Gerd Hoffmann Signed-off-by: Vivek Kasireddy --- configure | 8 +- meson.build | 33 +++ meson_options.txt | 2 + qapi/ui.json | 3 + ui/meson.build| 52 ui/wayland.c | 628 ++ 6 files changed, 725

[RFC v2 0/2] ui: Add a Wayland backend for Qemu UI (v2)

2021-09-13 Thread Vivek Kasireddy
-threaded environment. - Rebase Cc: Gerd Hoffmann Cc: Marc-André Lureau Cc: Dongwon Kim Cc: Tina Zhang Cc: Satyeshwar Singh Vivek Kasireddy (2): virtio-gpu: Add support for VIRTIO_GPU_F_RELEASE_FENCE ui: Add a plain Wayland backend for Qemu UI configure | 8

[PATCH v5 5/5] virtio-gpu: Add gl_flushed callback

2021-09-01 Thread Vivek Kasireddy
Adding this callback provides a way to resume the processing of cmds in fenceq and cmdq that were not processed because the UI was waiting on a fence and blocked cmd processing. Cc: Gerd Hoffmann Reviewed-by: Gerd Hoffmann Signed-off-by: Vivek Kasireddy --- hw/display/virtio-gpu.c | 32

[PATCH v5 4/5] ui/gtk-egl: Wait for the draw signal for dmabuf blobs

2021-09-01 Thread Vivek Kasireddy
Instead of immediately drawing and submitting, queue and wait for the draw signal if the dmabuf submitted is a blob. Cc: Gerd Hoffmann Reviewed-by: Gerd Hoffmann Signed-off-by: Vivek Kasireddy --- include/ui/gtk.h | 2 ++ ui/gtk-egl.c | 15 +++ ui/gtk.c | 2 +- 3

[PATCH v5 2/5] ui/egl: Add egl helpers to help with synchronization

2021-09-01 Thread Vivek Kasireddy
These egl helpers would be used for creating and waiting on a sync object. Cc: Gerd Hoffmann Reviewed-by: Gerd Hoffmann Signed-off-by: Vivek Kasireddy --- include/ui/console.h | 2 ++ include/ui/egl-helpers.h | 2 ++ ui/egl-helpers.c | 26 ++ 3 files

[PATCH v5 3/5] ui: Create sync objects and fences only for blobs

2021-09-01 Thread Vivek Kasireddy
Create sync objects and fences only for dmabufs that are blobs. Once a fence is created (after glFlush) and is signalled, graphic_hw_gl_flushed() will be called and virtio-gpu cmd processing will be resumed. Cc: Gerd Hoffmann Signed-off-by: Vivek Kasireddy --- hw/display/virtio-gpu-udmabuf.c

[PATCH v5 1/5] ui/gtk: Create a common release_dmabuf helper

2021-09-01 Thread Vivek Kasireddy
Since the texture release mechanism is same for both gtk-egl and gtk-glarea, move the helper from gtk-egl to common gtk code so that it can be shared by both gtk backends. Cc: Gerd Hoffmann Reviewed-by: Gerd Hoffmann Signed-off-by: Vivek Kasireddy --- include/ui/gtk.h | 2 -- ui/gtk-egl.c

[PATCH v5 0/5] virtio-gpu: Add a default synchronization mechanism for blobs

2021-09-01 Thread Vivek Kasireddy
main loop and wait for it to be signalled. (suggested by Gerd Hoffmann) v4: - Replace the field 'blob' with 'allow_fences' in QemuDmabuf struct. (Gerd) v5: rebase Cc: Gerd Hoffmann Cc: Dongwon Kim Cc: Tina Zhang Vivek Kasireddy (5): ui/gtk: Create a common relea

[PATCH v4 3/5] ui: Create sync objects and fences only for blobs

2021-06-24 Thread Vivek Kasireddy
Create sync objects and fences only for dmabufs that are blobs. Once a fence is created (after glFlush) and is signalled, graphic_hw_gl_flushed() will be called and virtio-gpu cmd processing will be resumed. Cc: Gerd Hoffmann Signed-off-by: Vivek Kasireddy --- hw/display/virtio-gpu-udmabuf.c

[PATCH v4 4/5] ui/gtk-egl: Wait for the draw signal for dmabuf blobs

2021-06-24 Thread Vivek Kasireddy
Instead of immediately drawing and submitting, queue and wait for the draw signal if the dmabuf submitted is a blob. Cc: Gerd Hoffmann Reviewed-by: Gerd Hoffmann Signed-off-by: Vivek Kasireddy --- include/ui/gtk.h | 2 ++ ui/gtk-egl.c | 15 +++ ui/gtk.c | 2 +- 3

[PATCH v4 0/5] virtio-gpu: Add a default synchronization mechanism for blobs

2021-06-24 Thread Vivek Kasireddy
h 'allow_fences' in QemuDmabuf struct. (Gerd) Cc: Gerd Hoffmann Cc: Dongwon Kim Cc: Tina Zhang Vivek Kasireddy (5): ui/gtk: Create a common release_dmabuf helper ui/egl: Add egl helpers to help with synchronization ui: Create sync objects and fences only for blobs ui/gtk-egl:

[PATCH v4 2/5] ui/egl: Add egl helpers to help with synchronization

2021-06-24 Thread Vivek Kasireddy
These egl helpers would be used for creating and waiting on a sync object. Cc: Gerd Hoffmann Reviewed-by: Gerd Hoffmann Signed-off-by: Vivek Kasireddy --- include/ui/console.h | 2 ++ include/ui/egl-helpers.h | 2 ++ ui/egl-helpers.c | 26 ++ 3 files

[PATCH v4 1/5] ui/gtk: Create a common release_dmabuf helper

2021-06-24 Thread Vivek Kasireddy
Since the texture release mechanism is same for both gtk-egl and gtk-glarea, move the helper from gtk-egl to common gtk code so that it can be shared by both gtk backends. Cc: Gerd Hoffmann Reviewed-by: Gerd Hoffmann Signed-off-by: Vivek Kasireddy --- include/ui/gtk.h | 2 -- ui/gtk-egl.c

[PATCH v4 5/5] virtio-gpu: Add gl_flushed callback

2021-06-24 Thread Vivek Kasireddy
Adding this callback provides a way to resume the processing of cmds in fenceq and cmdq that were not processed because the UI was waiting on a fence and blocked cmd processing. Cc: Gerd Hoffmann Reviewed-by: Gerd Hoffmann Signed-off-by: Vivek Kasireddy --- hw/display/virtio-gpu.c | 32

[RFC v1 1/1] ui: Add a plain Wayland backend for Qemu UI

2021-06-23 Thread Vivek Kasireddy
Cc: Gerd Hoffmann Signed-off-by: Vivek Kasireddy --- configure | 17 ++ meson.build | 25 +++ meson_options.txt | 2 + qapi/ui.json | 19 ++- ui/meson.build| 52 ++ ui/wayland.c | 402 ++ 6 files changed, 516

[RFC v1 0/1] ui: Add a Wayland backend for Qemu UI

2021-06-23 Thread Vivek Kasireddy
ng on: https://lists.nongnu.org/archive/html/qemu-devel/2021-03/msg04331.html Cc: Gerd Hoffmann Cc: Marc-André Lureau Cc: Dongwon Kim Cc: Tina Zhang Vivek Kasireddy (1): ui: Add a plain Wayland backend for Qemu UI configure | 17 ++ meson.build | 25 +++ meson_options.txt

[PATCH v3 1/5] ui/gtk: Create a common release_dmabuf helper

2021-06-21 Thread Vivek Kasireddy
Since the texture release mechanism is same for both gtk-egl and gtk-glarea, move the helper from gtk-egl to common gtk code so that it can be shared by both gtk backends. Cc: Gerd Hoffmann Reviewed-by: Gerd Hoffmann Signed-off-by: Vivek Kasireddy --- include/ui/gtk.h | 2 -- ui/gtk-egl.c

[PATCH v3 5/5] virtio-gpu: Add gl_flushed callback

2021-06-21 Thread Vivek Kasireddy
Adding this callback provides a way to resume the processing of cmds in fenceq and cmdq that were not processed because the UI was waiting on a fence and blocked cmd processing. Cc: Gerd Hoffmann Signed-off-by: Vivek Kasireddy --- hw/display/virtio-gpu.c | 32

[PATCH v3 4/5] ui/gtk-egl: Wait for the draw signal for dmabuf blobs

2021-06-21 Thread Vivek Kasireddy
Instead of immediately drawing and submitting, queue and wait for the draw signal if the dmabuf submitted is a blob. Cc: Gerd Hoffmann Signed-off-by: Vivek Kasireddy --- include/ui/gtk.h | 2 ++ ui/gtk-egl.c | 15 +++ ui/gtk.c | 2 +- 3 files changed, 18 insertions

[PATCH v3 2/5] ui/egl: Add egl helpers to help with synchronization

2021-06-21 Thread Vivek Kasireddy
These egl helpers would be used for creating and waiting on a sync object. Cc: Gerd Hoffmann Signed-off-by: Vivek Kasireddy --- include/ui/console.h | 2 ++ include/ui/egl-helpers.h | 2 ++ ui/egl-helpers.c | 26 ++ 3 files changed, 30 insertions(+) diff

  1   2   3   >