Re: [PATCH] target/riscv: Add a property to set vill bit on reserved usage of vsetvli instruction

2025-06-18 Thread Vasilis Liaskovitis
Hi, On Wed, Jun 18, 2025 at 4:22 PM Daniel Henrique Barboza wrote: > > +if ((sew > cpu->cfg.elen) || vill || (ediv != 0) || (reserved != 0) || > > +(cpu->cfg.rvv_vsetvl_x0_vill && x0 && (env->vl != vl))) { > > In this particular case I don't mind replicating code. The first existing

[PATCH v2] target/riscv: Add a property to set vill bit on reserved usage of vsetvli instruction

2025-06-18 Thread Vasilis Liaskovitis
above use cases are reserved, and "Implementations may set vill in either case." Resolves: https://gitlab.com/qemu-project/qemu/-/issues/2422 Signed-off-by: Vasilis Liaskovitis --- target/riscv/cpu.c | 1 + target/riscv/cpu_cfg_fields.h.inc | 1 + target/risc

[PATCH] target/riscv: Add a property to set vill bit on reserved usage of vsetvli instruction

2025-06-18 Thread Vasilis Liaskovitis
above use cases are reserved, and "Implementations may set vill in either case." Resolves: https://gitlab.com/qemu-project/qemu/-/issues/2422 Signed-off-by: Vasilis Liaskovitis --- target/riscv/cpu.c | 1 + target/riscv/cpu_cfg_fields.h.inc | 1 + target/risc

[RFC PATCH] target/riscv: set vill bit if VLMAX is changed when vsetvli rs1 and rd arguments are x0

2025-04-05 Thread Vasilis Liaskovitis
andle this. Resolves: https://gitlab.com/qemu-project/qemu/-/issues/2422 Signed-off-by: Vasilis Liaskovitis --- target/riscv/helper.h | 2 +- target/riscv/insn_trans/trans_rvv.c.inc | 4 ++-- target/riscv/vector_helper.c| 9 - 3 files changed, 11 insert

[RFC PATCH] vfio/pci-quirks: Exclude non-ioport BAR from ATI quirk

2025-03-10 Thread Vasilis Liaskovitis
he card to test. Resolves: https://gitlab.com/qemu-project/qemu/-/issues/2856 Signed-off-by: Vasilis Liaskovitis --- hw/vfio/pci-quirks.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/vfio/pci-quirks.c b/hw/vfio/pci-quirks.c index c53591fe2b..15598bbaf4 100644 --- a/hw/vfio/pci

[PATCH v3] hw/riscv/virt: Add serial alias in DTB

2025-01-16 Thread Vasilis Liaskovitis
Add an "aliases" node with a "serial0" entry for the single UART in the riscv virt machine. Resolves: https://gitlab.com/qemu-project/qemu/-/issues/2774 Signed-off-by: Vasilis Liaskovitis Reviewed-by: Andrew Jones --- hw/riscv/virt.c | 3 +++ 1 file changed, 3 insertions

[PATCH v2] hw/riscv/virt: Add serial alias in DTB

2025-01-16 Thread Vasilis Liaskovitis
This patch adds an "aliases" node with a "serial0" entry for the single UART in the riscv64 virt machine. Resolves: https://gitlab.com/qemu-project/qemu/-/issues/2774 Signed-off-by: Vasilis Liaskovitis --- hw/riscv/virt.c | 3 +++ 1 file changed, 3 insertions(+) diff --git

Re: [RFC PATCH] hw/riscv/virt: Add serial alias in DTB

2025-01-16 Thread Vasilis Liaskovitis
On Thu, Jan 16, 2025 at 10:23:56AM +0100, Andrew Jones wrote: > > s/Fixes/Resolves/ (see docs/devel/submitting-a-patch.rst) > [..] > > qemu_fdt_setprop_string(ms->fdt, "/chosen", "stdout-path", name); > > +qemu_fdt_add_subnode(ms->fdt, "/aliases"); > > create_fdt_uart() is called at mac

[RFC PATCH] hw/riscv/virt: Add serial alias in DTB

2025-01-16 Thread Vasilis Liaskovitis
lab.com/qemu-project/qemu/-/issues/2774 Signed-off-by: Vasilis Liaskovitis --- hw/riscv/virt.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/hw/riscv/virt.c b/hw/riscv/virt.c index 2bc5a9dd98..67b80e9430 100644 --- a/hw/riscv/virt.c +++ b/hw/riscv/virt.c @@ -971,6 +971,8 @@ static void creat

[Qemu-devel] virtio_gpu testing

2014-12-08 Thread Vasilis Liaskovitis
Hi, I am testing virtio_gpu/virgl and have followed the instructions at: https://www.kraxel.org/slides/qemu-gfx/#resources https://docs.google.com/document/d/1CNiN0rHdfh7cp9tQ3coebNEJtHJzm4OCWvF3qL4nucc/pub Host runs 3.13 with drm.rnodes=1 My fc20 guest boots fine with virgl and sdl2.0 support.

Re: [Qemu-devel] [PATCH v2] qtest/bios-tables: Add DMAR unit test on intel_iommu for q35

2014-12-02 Thread Vasilis Liaskovitis
On Mon, Nov 23, 2014 at 04:25:05PM +0200, Marcel Apfelbaum wrote: > On Mon, 2014-11-24 at 14:37 +0100, Vasilis Liaskovitis wrote: > > The test enables intel_iommu on q35, looks for and reads the DMAR table as > > well > > as its only DRHC structure (for now), checking the

[Qemu-devel] [PATCH v3] qtest/bios-tables: Add DMAR aml file and enable intel_iommu for q35

2014-12-02 Thread Vasilis Liaskovitis
We generate the expected DMAR table and enable intel_iommu on q35 to test the table. Signed-off-by: Vasilis Liaskovitis --- tests/acpi-test-data/q35/DMAR | Bin 0 -> 64 bytes tests/bios-tables-test.c | 2 +- 2 files changed, 1 insertion(+), 1 deletion(-) create mode 100644 tests/a

Re: [Qemu-devel] [PATCH] qtest/bios-tables: Add DMAR unit test on intel_iommu for q35

2014-11-24 Thread Vasilis Liaskovitis
Hi, On Mon, Nov 24, 2014 at 11:37:05AM +0200, Marcel Apfelbaum wrote: > On Sat, 2014-11-22 at 20:05 +0100, Vasilis Liaskovitis wrote: > > The test enables intel_iommu on q35 and reads the DMAR table and its only > > DRHC structure (for now), checking only the header and checksums.

[Qemu-devel] [PATCH v2] qtest/bios-tables: Add DMAR unit test on intel_iommu for q35

2014-11-24 Thread Vasilis Liaskovitis
The test enables intel_iommu on q35, looks for and reads the DMAR table as well as its only DRHC structure (for now), checking the header and checksums. Signed-off-by: Vasilis Liaskovitis --- tests/bios-tables-test.c | 46 +- 1 file changed, 45

[Qemu-devel] [PATCH] qtest/bios-tables: Add DMAR unit test on intel_iommu for q35

2014-11-22 Thread Vasilis Liaskovitis
The test enables intel_iommu on q35 and reads the DMAR table and its only DRHC structure (for now), checking only the header and checksums. Signed-off-by: Vasilis Liaskovitis --- tests/bios-tables-test.c | 34 +- 1 file changed, 33 insertions(+), 1 deletion

Re: [Qemu-devel] [PATCH 0/2] pc: memory hotplug fixes

2014-06-19 Thread Vasilis Liaskovitis
On Mon, Jun 09, 2014 at 07:27:59PM +0200, Igor Mammedov wrote: > Series is build on mst/pci tree that includes memory hotplug bits. > > patch 2/2, fixes incorrect address auto-allocation caused by wrong > sorting order due to overflow in pc_dimm_addr_sort() comparator. > thanks for the fixes. Fo

Re: [Qemu-devel] [PATCH 33/35] pc: ACPI BIOS: reserve SRAT entry for hotplug mem hole

2014-06-02 Thread Vasilis Liaskovitis
On Thu, May 29, 2014 at 11:12:37AM +0200, Igor Mammedov wrote: > On Wed, 28 May 2014 18:38:13 +0200 > Vasilis Liaskovitis wrote: > > > On Wed, May 28, 2014 at 03:26:42PM +0200, Igor Mammedov wrote: > > > On Wed, 28 May 2014 14:23:13 +0200 > > > Vasilis Liaskovi

Re: [Qemu-devel] [PATCH 33/35] pc: ACPI BIOS: reserve SRAT entry for hotplug mem hole

2014-05-28 Thread Vasilis Liaskovitis
On Wed, May 28, 2014 at 03:26:42PM +0200, Igor Mammedov wrote: > On Wed, 28 May 2014 14:23:13 +0200 > Vasilis Liaskovitis wrote: > > > On Wed, May 28, 2014 at 10:07:22AM +0200, Igor Mammedov wrote: > > > On Tue, 27 May 2014 17:57:31 +0200 > > > Anshul

Re: [Qemu-devel] [PATCH 33/35] pc: ACPI BIOS: reserve SRAT entry for hotplug mem hole

2014-05-28 Thread Vasilis Liaskovitis
On Wed, May 28, 2014 at 10:07:22AM +0200, Igor Mammedov wrote: > On Tue, 27 May 2014 17:57:31 +0200 > Anshul Makkar wrote: > > > Hi, > > > > I tested the hot unplug patch and doesn't seem to work properly with Debian > > 6 and Ubuntu host. > > > > Scenario: > > I added 3 dimm devices of 1G each

Re: [Qemu-devel] [PATCH 33/35] pc: ACPI BIOS: reserve SRAT entry for hotplug mem hole

2014-05-06 Thread Vasilis Liaskovitis
On Tue, May 06, 2014 at 09:52:39AM +0800, Hu Tao wrote: > On Mon, May 05, 2014 at 05:59:15PM +0200, Vasilis Liaskovitis wrote: > > Hi, > > > > On Mon, Apr 14, 2014 at 06:44:42PM +0200, Igor Mammedov wrote: > > > On Mon, 14 Apr 2014 15:25:01 +0800 > > > Hu Ta

Re: [Qemu-devel] [PATCH 20/35] acpi: memory hotplug ACPI hardware implementation

2014-05-06 Thread Vasilis Liaskovitis
On Tue, May 06, 2014 at 09:13:13AM +0200, Igor Mammedov wrote: > On Mon, 5 May 2014 14:20:25 +0200 > Vasilis Liaskovitis wrote: > > On Fri, Apr 04, 2014 at 03:36:45PM +0200, Igor Mammedov wrote: > > > +if (data == 1) { > > > +/* TODO:

Re: [Qemu-devel] [PATCH 33/35] pc: ACPI BIOS: reserve SRAT entry for hotplug mem hole

2014-05-05 Thread Vasilis Liaskovitis
Hi, On Mon, Apr 14, 2014 at 06:44:42PM +0200, Igor Mammedov wrote: > On Mon, 14 Apr 2014 15:25:01 +0800 > Hu Tao wrote: > > > On Fri, Apr 04, 2014 at 03:36:58PM +0200, Igor Mammedov wrote: > Could you be more specific, what and how doesn't work and why there is > need for SRAT entries per DIMM?

Re: [Qemu-devel] [PATCH 20/35] acpi: memory hotplug ACPI hardware implementation

2014-05-05 Thread Vasilis Liaskovitis
Hi, On Fri, Apr 04, 2014 at 03:36:45PM +0200, Igor Mammedov wrote: > - implements QEMU hardware part of memory hotplug protocol > described at "docs/specs/acpi_mem_hotplug.txt" > - handles only memory add notification event for now > [...] > + [0x4-0x7] OST event code reported by OSPM > +

Re: [Qemu-devel] status of cpu hotplug work for x86_64?

2014-05-02 Thread Vasilis Liaskovitis
Hi, On Mon, Apr 28, 2014 at 11:58:38AM -0600, Chris Friesen wrote: > Hi, > > I'm trying to figure out what the current status is for cpu hotplug > and hot-remove on x86_64. > > As far as I can tell, it seems like currently there is a QMP > "cpu-add" command but no matching remove...is that corre

Re: [Qemu-devel] [RFC PATCH v2] i386: Add _PXM ACPI method to CPU objects

2013-11-29 Thread Vasilis Liaskovitis
On Wed, Nov 27, 2013 at 04:58:51PM +0100, Paolo Bonzini wrote: > Il 27/11/2013 16:53, Igor Mammedov ha scritto: > > Patch looks good, > > Please add patch to update hw/i386/ssdt-proc.hex.generated for hosts > > without iasl > > for completness > > Also please rename PXM to CPXM or CPPX for consis

[Qemu-devel] [PATCH v3] i386: Add _PXM ACPI method to CPU objects

2013-11-27 Thread Vasilis Liaskovitis
aster + cpu-del patches v2->v3: Add changed hw/i386/sdt-proc.hex.generated file Change PXM constant name to CPXM Signed-off-by: Vasilis Liaskovitis Reviewed-by: Thilo Fromm --- hw/i386/acpi-build.c|5 hw/i386/ssdt-proc.dsl |5 hw/i386/ssdt

[Qemu-devel] [RFC PATCH v2] i386: Add _PXM ACPI method to CPU objects

2013-11-27 Thread Vasilis Liaskovitis
aster + cpu-del patches Signed-off-by: Vasilis Liaskovitis Reviewed-by: Thilo Fromm --- hw/i386/acpi-build.c |5 + hw/i386/ssdt-proc.dsl |5 + 2 files changed, 10 insertions(+) diff --git a/hw/i386/acpi-build.c b/hw/i386/acpi-build.c index d089e1e..3c11ddc 100644 --- a/hw/i38

Re: [Qemu-devel] [RFC qom-cpu v4 09/10] piix4: implement function cpu_status_write() for vcpu ejection

2013-11-25 Thread Vasilis Liaskovitis
On Fri, Nov 22, 2013 at 09:02:27AM +0100, Vasilis Liaskovitis wrote: > Hi, > > On Wed, Oct 09, 2013 at 05:43:17PM +0800, Chen Fan wrote: > > When OS eject a vcpu (like: echo 1 > /sys/bus/acpi/devices/LNXCPUXX/eject), > > it will call acpi EJ0 method, the firmware will wr

Re: [Qemu-devel] [RFC qom-cpu v4 09/10] piix4: implement function cpu_status_write() for vcpu ejection

2013-11-22 Thread Vasilis Liaskovitis
Hi, On Wed, Oct 09, 2013 at 05:43:17PM +0800, Chen Fan wrote: > When OS eject a vcpu (like: echo 1 > /sys/bus/acpi/devices/LNXCPUXX/eject), > it will call acpi EJ0 method, the firmware will write the new cpumap, QEMU > will know which vcpu need to be ejected. I think that the _EJ0 callback (CPEJ

Re: [Qemu-devel] [RFC PATCH] i386: Add _PXM method to ACPI CPU objects

2013-11-08 Thread Vasilis Liaskovitis
Hi, On Thu, Nov 07, 2013 at 03:03:42PM +0200, Michael S. Tsirkin wrote: > On Thu, Nov 07, 2013 at 01:41:59PM +0100, Vasilis Liaskovitis wrote: > > This patch adds a _PXM method to ACPI CPU objects for the pc machine. The > > _PXM > > value is derived from the passed in gu

[Qemu-devel] [RFC PATCH] i386: Add _PXM method to ACPI CPU objects

2013-11-07 Thread Vasilis Liaskovitis
lists see http://www.spinics.net/lists/linux-acpi/msg47058.html Signed-off-by: Vasilis Liaskovitis Reviewed-by: Thilo Fromm --- hw/i386/acpi-build.c |2 ++ hw/i386/ssdt-proc.dsl |2 ++ 2 files changed, 4 insertions(+) diff --git a/hw/i386/acpi-build.c b/hw/i386/acpi-build.c index 6cfa044..9373f

Re: [Qemu-devel] [PATCH 00/16 RFC v6] ACPI memory hotplug

2013-07-24 Thread Vasilis Liaskovitis
On Wed, Jul 24, 2013 at 12:02:46PM +0200, Igor Mammedov wrote: > On Wed, 24 Jul 2013 17:52:50 +0800 > Hu Tao wrote: > > > v6 doesn't work here, things are going fine until online hotplugged > > memory in guest. > > > > steps: > > > > 1. qemu cmd: > > > > ./x86_64-softmmu/qemu-system-x86_64 -

Re: [Qemu-devel] [PATCH v5 7/7] pci: Use paravirt interface for pcimem_start and pcimem64_start

2013-07-15 Thread Vasilis Liaskovitis
Hi, 2013/6/26 Hu Tao > From: Vasilis Liaskovitis > > Initialize the 32-bit and 64-bit pci starting offsets from values passed > in by > the qemu paravirt interface QEMU_CFG_PCI_WINDOW. Qemu calculates the > starting > offsets based on initial memory and hotplug-able dim

Re: [Qemu-devel] [PATCH v5 05/14] vl: handle "-device dimm"

2013-07-15 Thread Vasilis Liaskovitis
On Mon, Jul 15, 2013 at 07:10:30PM +0200, Paolo Bonzini wrote: > Il 15/07/2013 19:05, Vasilis Liaskovitis ha scritto: > > from what i understand, we are currently favoring this numa option? (I saw > > it > > mentioned in Gao's numa patchset series as well) > > The

Re: [Qemu-devel] [PATCH v5 05/14] vl: handle "-device dimm"

2013-07-15 Thread Vasilis Liaskovitis
Hi, On Thu, Jun 27, 2013 at 08:55:25AM +0200, Paolo Bonzini wrote: > Il 27/06/2013 07:08, Wanlong Gao ha scritto: > > Do we really need to specify the memory range? I suspect that we can > > follow current design of normal memory in hot-plug memory. > > I think we can do both. I'm afraid that th

Re: [Qemu-devel] [PATCH v11 11/15] rdma: core logic

2013-06-25 Thread Vasilis Liaskovitis
Hi, On Mon, Jun 24, 2013 at 09:58:01PM -0400, mrhi...@linux.vnet.ibm.com wrote: > From: "Michael R. Hines" > [...] > +/* > + * Put in the log file which RDMA device was opened and the details > + * associated with that device. > + */ > +static void qemu_rdma_dump_id(const char *who, struct ibv_co

Re: [Qemu-devel] [RFC PATCH v4 00/30] ACPI memory hotplug

2013-03-28 Thread Vasilis Liaskovitis
Hi, [...] >> > > >> > > I haven't updated the series for a while, but I can rework if there is a >> > > more >> > > clear direction for the community. >> > > >> > > Another open issue is reference counting of memoryregions in qemu memory >> > > model. In order to make memory hot-remove operations

Re: [Qemu-devel] [RFC PATCH v4 00/30] ACPI memory hotplug

2013-03-26 Thread Vasilis Liaskovitis
Hi, On Tue, Mar 26, 2013 at 10:47:01AM -0400, Luiz Capitulino wrote: > On Tue, 18 Dec 2012 13:41:28 +0100 > Vasilis Liaskovitis wrote: > > > This is v4 of the ACPI memory hotplug functionality. Only x86_64 target is > > supported (both i440fx and q35). There are still sev

Re: [Qemu-devel] [RFC PATCH v4 00/30] ACPI memory hotplug

2013-03-26 Thread Vasilis Liaskovitis
Hi, On Tue, Mar 19, 2013 at 02:30:25PM +0800, li guang wrote: > 在 2013-01-10四的 19:57 +0100,Vasilis Liaskovitis写道: > > > > > > > > IIRC q35 supports memory hotplug natively (picked up in some > > > > discussion). Is that correct? > > > > > &

Re: [Qemu-devel] [RFC PATCH v4 00/30] ACPI memory hotplug

2013-03-26 Thread Vasilis Liaskovitis
Hi, On Tue, Mar 19, 2013 at 03:28:38PM +0800, li guang wrote: [...] > > > > This is v4 of the ACPI memory hotplug functionality. Only x86_64 target > > > > is > > > > supported (both i440fx and q35). There are still several issues, but > > > > it's > > > > been a while since v3 and I wanted to g

Re: [Qemu-devel] Some questions for PATCH: ACPI memory hotplug, TKS

2013-03-12 Thread Vasilis Liaskovitis
Hi, On Mon, Mar 11, 2013 at 09:16:34AM +, Chijianchun wrote: > http://lists.gnu.org/archive/html/qemu-devel/2012-12/msg02693.html > > > > one this patch, you say it does not support for windows, Does it support > now? > no,it still does not work for windows. It is most likely some seabi

Re: [Qemu-devel] [RFC PATCH v4 00/30] ACPI memory hotplug

2013-02-28 Thread Vasilis Liaskovitis
Hi, sorry for the delay. On Tue, Feb 19, 2013 at 07:39:40PM -0300, Erlon Cruz wrote: > On Tue, Dec 18, 2012 at 10:41 AM, Vasilis Liaskovitis < > vasilis.liaskovi...@profitbricks.com> wrote: > > > This is v4 of the ACPI memory hotplug functionality. Only x86_64 target i

Re: [Qemu-devel] [RFC v1 3/3] make address_space_map safe

2013-02-13 Thread Vasilis Liaskovitis
Hi, I am looking at this old ref/unref patchset for safely removing hot-plugged dimms/MemoryRegions. I am not sure if the set is still actively worked on or relevant for qemu-master, but I had a small comment below: On Fri, Nov 09, 2012 at 11:14:30AM +0800, Liu Ping Fan wrote: > From: Liu Ping Fa

Re: [Qemu-devel] Want to be part of Memory Hotplug

2013-02-07 Thread Vasilis Liaskovitis
Hi Senthil, On Mon, Feb 04, 2013 at 04:17:30PM +0530, kumaran wrote: > Hi, > > I am Senthil, doing post graduation in IIT Bombay,India. > > I am looking for some problems related to KVM as part of my research > work. I read about memory hotplug and other open issues in KVM. > > Can i be part of

Re: [Qemu-devel] [RFC PATCH v4 13/30] piix_pci and pc_piix: refactor

2013-01-16 Thread Vasilis Liaskovitis
Hi, On Wed, Jan 16, 2013 at 12:17:05PM +0100, Andreas Färber wrote: > Hi, > > Am 16.01.2013 10:36, schrieb Vasilis Liaskovitis: > > On Wed, Jan 16, 2013 at 03:20:40PM +0800, Hu Tao wrote: > >> On Tue, Dec 18, 2012 at 01:41:41PM +0100, Vasilis Liaskovitis wrote: >

Re: [Qemu-devel] [RFC PATCH v4 13/30] piix_pci and pc_piix: refactor

2013-01-16 Thread Vasilis Liaskovitis
Hi, On Wed, Jan 16, 2013 at 03:20:40PM +0800, Hu Tao wrote: > Hi Vasilis, > > On Tue, Dec 18, 2012 at 01:41:41PM +0100, Vasilis Liaskovitis wrote: > > Refactor code so that chipset initialization is similar to q35. This will > > allow memory map initialization at chipset qd

Re: [Qemu-devel] [RFC PATCH v4 00/30] ACPI memory hotplug

2013-01-10 Thread Vasilis Liaskovitis
> > > > IIRC q35 supports memory hotplug natively (picked up in some > > discussion). Is that correct? > > > From previous discussion I also understand that q35 supports native hotplug. > Sections 5.1 and 5.2 of the spec describe the MCH registers but the native > memory hotplug specifics are n

Re: [Qemu-devel] [RFC PATCH v4 21/30] Implement dimm-info

2013-01-10 Thread Vasilis Liaskovitis
On Tue, Jan 08, 2013 at 04:20:26PM -0700, Eric Blake wrote: > On 12/18/2012 05:41 AM, Vasilis Liaskovitis wrote: > > "query-dimm-info" and "info dimm" will give current state of all dimms in > > the > > system e.g. > > > > dimm0: o

Re: [Qemu-devel] [RFC PATCH v4 19/30] Implement "info memory-total" and "query-memory-total"

2013-01-10 Thread Vasilis Liaskovitis
On Fri, Jan 04, 2013 at 09:21:08AM -0700, Eric Blake wrote: > On 12/18/2012 05:41 AM, Vasilis Liaskovitis wrote: > > Returns total physical memory available to guest in bytes, including > > hotplugged > > memory. Note that the number reported here may be different fro

Re: [Qemu-devel] [RFC PATCH v4 00/30] ACPI memory hotplug

2013-01-10 Thread Vasilis Liaskovitis
Hi, On Wed, Jan 09, 2013 at 01:08:52AM +0100, Andreas Färber wrote: > Am 18.12.2012 13:41, schrieb Vasilis Liaskovitis: > > Because dimm layout needs to be configured on machine-boot, all dimm devices > > need to be specified on startup command line (either with populated=

Re: [Qemu-devel] [RFC PATCH v4 00/30] ACPI memory hotplug

2012-12-19 Thread Vasilis Liaskovitis
On Wed, Dec 19, 2012 at 12:45:46AM +0800, Zhi Yong Wu wrote: > HI, > > One stupid question, 'dimm' presents one guest memory, then why it is > called as "dimm"? what is its full name? it's a bad name coming from dram technology (dual in-line memory module). Memory-slot or memory-module is probabl

Re: [Qemu-devel] [RFC PATCH v4 00/30] ACPI memory hotplug

2012-12-19 Thread Vasilis Liaskovitis
Hi, On Wed, Dec 19, 2012 at 08:27:36AM +0100, Gerd Hoffmann wrote: > Hi, > > > - multiple memory buses can be registered. Memory buses of the real > > hw/chipset > > or a paravirtual memory bus can be added. > > IIRC q35 supports memory hotplug natively (picked up in some > discussion). Is

[Qemu-devel] [RFC PATCH v4 24/30] acpi_piix4: add hot-remove capability

2012-12-18 Thread Vasilis Liaskovitis
--- docs/specs/acpi_hotplug.txt |8 hw/acpi_piix4.c | 29 - 2 files changed, 36 insertions(+), 1 deletions(-) diff --git a/docs/specs/acpi_hotplug.txt b/docs/specs/acpi_hotplug.txt index 8391713..cf86242 100644 --- a/docs/specs/acpi_hotplug.t

[Qemu-devel] [RFC PATCH v4 22/30] [SeaBIOS] acpi: add _EJ0 operation and eject port for memory devices

2012-12-18 Thread Vasilis Liaskovitis
This will allow hot-remove signalling from/to qemu and acpi-enabled guest. --- src/acpi-dsdt-mem-hotplug.dsl | 15 +++ src/ssdt-mem.dsl |3 +++ 2 files changed, 18 insertions(+), 0 deletions(-) diff --git a/src/acpi-dsdt-mem-hotplug.dsl b/src/acpi-dsdt-mem-hotplug.d

[Qemu-devel] [RFC PATCH v4 26/30] Implement qmp and hmp commands for notification lists

2012-12-18 Thread Vasilis Liaskovitis
tems should probably be part of migration state (not yet implemented). Signed-off-by: Vasilis Liaskovitis --- hmp-commands.hx |2 + hmp.c| 17 +++ hmp.h|1 + hw/dimm.c| 61 ++ hw/

[Qemu-devel] [RFC PATCH v4 16/30] pc: Add dimm paravirt SRAT info

2012-12-18 Thread Vasilis Liaskovitis
t Signed-off-by: Vasilis Liaskovitis --- docs/specs/fwcfg.txt | 28 hw/pc.c | 28 +++- hw/pc.h |1 + hw/pc_piix.c |1 + hw/pc_q35.c |8 +--- sysemu.h |1 + 6 files ch

[Qemu-devel] [RFC PATCH v4 13/30] piix_pci and pc_piix: refactor

2012-12-18 Thread Vasilis Liaskovitis
Refactor code so that chipset initialization is similar to q35. This will allow memory map initialization at chipset qdev init time for both machines, as well as more similar code structure overall. Signed-off-by: Vasilis Liaskovitis --- hw/pc_piix.c | 57 --- hw/piix_pci.c

[Qemu-devel] [RFC PATCH v4 12/30] acpi_ich9 : Implement memory device hotplug registers

2012-12-18 Thread Vasilis Liaskovitis
cared [...] Disabling IRQ #9" where #9 is the acpi irq Signed-off-by: Vasilis Liaskovitis --- hw/acpi_ich9.c | 61 +-- hw/acpi_ich9.h |7 +- hw/lpc_ich9.c |2 +- 3 files changed, 65 insertions(+), 5 deletions(-) diff --git a/hw/acpi_i

[Qemu-devel] [RFC PATCH v4 19/30] Implement "info memory-total" and "query-memory-total"

2012-12-18 Thread Vasilis Liaskovitis
, since a guest can be using ACPI memory hotplug without using a balloon device. v3->v4: Moved qmp command implementation to vl.c. This prevents a circular header dependency problem. Signed-off-by: Vasilis Liaskovitis --- hmp-commands.hx |2 ++ hmp.c|7 +++ hm

[Qemu-devel] [RFC PATCH v4 05/30] [SeaBIOS] q35: Add memory hotplug handler

2012-12-18 Thread Vasilis Liaskovitis
--- src/q35-acpi-dsdt.dsl |6 -- 1 files changed, 4 insertions(+), 2 deletions(-) diff --git a/src/q35-acpi-dsdt.dsl b/src/q35-acpi-dsdt.dsl index c031d83..5b28d72 100644 --- a/src/q35-acpi-dsdt.dsl +++ b/src/q35-acpi-dsdt.dsl @@ -403,7 +403,7 @@ DefinitionBlock ( } #include "acpi

[Qemu-devel] [RFC PATCH v4 08/30] qemu-option: export parse_option_number

2012-12-18 Thread Vasilis Liaskovitis
Signed-off-by: Vasilis Liaskovitis --- qemu-option.c |2 +- qemu-option.h |2 ++ 2 files changed, 3 insertions(+), 1 deletions(-) diff --git a/qemu-option.c b/qemu-option.c index 38e0a11..88fd370 100644 --- a/qemu-option.c +++ b/qemu-option.c @@ -185,7 +185,7 @@ static void

[Qemu-devel] [RFC PATCH v4 03/30] [SeaBIOS] acpi-dsdt: Implement functions for memory hotplug

2012-12-18 Thread Vasilis Liaskovitis
Extend the DSDT to include methods for handling memory hot-add and hot-remove notifications and memory device status requests. These functions are called from the memory device SSDT methods. --- src/acpi-dsdt-mem-hotplug.dsl | 57 + src/acpi-dsdt.dsl

[Qemu-devel] [RFC PATCH v4 25/30] acpi_ich9: add hot-remove capability

2012-12-18 Thread Vasilis Liaskovitis
--- hw/acpi_ich9.c | 28 +++- hw/acpi_ich9.h |1 + 2 files changed, 28 insertions(+), 1 deletions(-) diff --git a/hw/acpi_ich9.c b/hw/acpi_ich9.c index abafbb5..f5dc1c9 100644 --- a/hw/acpi_ich9.c +++ b/hw/acpi_ich9.c @@ -105,12 +105,29 @@ static uint32_t memhp_readb

[Qemu-devel] [RFC PATCH v4 10/30] vl: handle "-device dimm"

2012-12-18 Thread Vasilis Liaskovitis
Signed-off-by: Vasilis Liaskovitis --- vl.c | 51 +++ 1 files changed, 51 insertions(+), 0 deletions(-) diff --git a/vl.c b/vl.c index a3ab384..8406933 100644 --- a/vl.c +++ b/vl.c @@ -169,6 +169,7 @@ int main(int argc, char **argv) #include

[Qemu-devel] [RFC PATCH v4 18/30] Introduce paravirt interface QEMU_CFG_PCI_WINDOW

2012-12-18 Thread Vasilis Liaskovitis
Qemu calculates the 32-bit and 64-bit PCI starting offsets based on initial memory and hotplug-able dimms. This info needs to be passed to Seabios for PCI initialization. Signed-off-by: Vasilis Liaskovitis --- hw/fw_cfg.h |1 + hw/pc_piix.c | 10 ++ hw/pc_q35.c |9

[Qemu-devel] [RFC PATCH v4 20/30] balloon: update with hotplugged memory

2012-12-18 Thread Vasilis Liaskovitis
t does not online hotplugged-memory, it's easy for a balloon inflate command to OOM a guest. Signed-off-by: Vasilis Liaskovitis --- hw/virtio-balloon.c | 13 + 1 files changed, 9 insertions(+), 4 deletions(-) diff --git a/hw/virtio-balloon.c b/hw/virtio-balloon.c index dd1a650.

[Qemu-devel] [RFC PATCH v4 04/30] [SeaBIOS] acpi: generate hotplug memory devices

2012-12-18 Thread Vasilis Liaskovitis
The memory device generation is guided by qemu paravirt info. Seabios first uses the info to setup SRAT entries for the hotplug-able memory slots. Afterwards, build_memssdt uses the created SRAT entries to generate appropriate memory device objects. One memory device (and corresponding SRAT entry)

[Qemu-devel] [RFC PATCH v4 09/30] Implement dimm device abstraction

2012-12-18 Thread Vasilis Liaskovitis
through normal device_add commands. Also add properties to DimmDevice. v3->v4: Removed hot-remove functions. Will be offered in separate patches. Signed-off-by: Vasilis Liaskovitis --- hw/Makefile.objs |2 +- hw/dimm.c| 245 ++

[Qemu-devel] [RFC PATCH v4 02/30] [SeaBIOS] Add SSDT memory device support

2012-12-18 Thread Vasilis Liaskovitis
Define SSDT hotplug-able memory devices in _SB namespace. The dynamically generated SSDT includes per memory device hotplug methods. These methods just call methods defined in the DSDT. Also dynamically generate a MTFY method and a MEON array of the online/available memory devices. ACPI extraction

[Qemu-devel] [RFC PATCH v4 11/30] acpi_piix4 : Implement memory device hotplug registers

2012-12-18 Thread Vasilis Liaskovitis
the future). _EJ array is reduced to a single byte. Add documentation in docs/specs/acpi_hotplug.txt v3->v4: Removed hot-remove functions, will be added separately. Updated for memory API. Signed-off-by: Vasilis Liaskovitis --- docs/specs/acpi_hotplug.txt | 14 + hw/

[Qemu-devel] [RFC PATCH v4 00/30] ACPI memory hotplug

2012-12-18 Thread Vasilis Liaskovitis
emu-devel/2012-11/msg02699.html - seabios master (commit a810e4e7) Can also be found at: http://github.com/vliaskov/qemu-kvm/commits/memhp-v4 http://github.com/vliaskov/seabios/commits/memhp-v4 Vasilis Liaskovitis (21): qapi: make visit_type_size fallback to type_int Add SIZE type

[Qemu-devel] [RFC PATCH v4 23/30] dimm: add hot-remove capability

2012-12-18 Thread Vasilis Liaskovitis
-off-by: Vasilis Liaskovitis --- hw/dimm.c | 51 +++ hw/dimm.h |1 + 2 files changed, 52 insertions(+), 0 deletions(-) diff --git a/hw/dimm.c b/hw/dimm.c index e79f23d..0b4e22d 100644 --- a/hw/dimm.c +++ b/hw/dimm.c @@ -120,6 +120,18 @@ static

[Qemu-devel] [RFC PATCH v4 29/30] [SeaBIOS] Implement _PS3 method for memory device

2012-12-18 Thread Vasilis Liaskovitis
--- src/acpi-dsdt-mem-hotplug.dsl | 15 +++ src/ssdt-mem.dsl |4 2 files changed, 19 insertions(+), 0 deletions(-) diff --git a/src/acpi-dsdt-mem-hotplug.dsl b/src/acpi-dsdt-mem-hotplug.dsl index a648bee..7d7c078 100644 --- a/src/acpi-dsdt-mem-hotplug.dsl +++ b

[Qemu-devel] [RFC PATCH v4 21/30] Implement dimm-info

2012-12-18 Thread Vasilis Liaskovitis
"query-dimm-info" and "info dimm" will give current state of all dimms in the system e.g. dimm0: on dimm1: off dimm2: off dimm3: on etc. Signed-off-by: Vasilis Liaskovitis --- hmp-commands.hx |2 ++ hmp.c| 17 + hmp.h

[Qemu-devel] [RFC PATCH v4 28/30] Add _OST dimm support

2012-12-18 Thread Vasilis Liaskovitis
This allows qemu to receive notifications from the guest OS on success or failure of a memory hotplug request. The guest OS needs to implement the _OST functionality for this to work (linux-next: http://lkml.org/lkml/2012/6/25/321) This patch also updates dimm bitmap state and hot-remove pending f

[Qemu-devel] [RFC PATCH v4 17/30] [SeaBIOS] pci: Use paravirt interface for pcimem_start and pcimem64_start

2012-12-18 Thread Vasilis Liaskovitis
Initialize the 32-bit and 64-bit pci starting offsets from values passed in by the qemu paravirt interface QEMU_CFG_PCI_WINDOW. Qemu calculates the starting offsets based on initial memory and hotplug-able dimms. It's possible to avoid the new paravirt interface, and calculate pci ranges from srat

[Qemu-devel] [RFC PATCH v4 07/30] Add SIZE type to qdev properties

2012-12-18 Thread Vasilis Liaskovitis
See: http://patchwork.ozlabs.org/patch/38835/ Signed-off-by: Vasilis Liaskovitis --- hw/qdev-properties.c | 60 ++ hw/qdev-properties.h |3 ++ qemu-option.c|2 +- qemu-option.h|2 + 4 files changed, 66 insertions(+), 1 deletions(-) di

[Qemu-devel] [RFC PATCH v4 30/30] Implement _PS3 for dimm

2012-12-18 Thread Vasilis Liaskovitis
This will allow us to update dimm state on OSPM-initiated eject operations e.g. with "echo 1 > /sys/bus/acpi/devices/PNP0C80\:00/eject" v3->v4: Add support for ich9 --- docs/specs/acpi_hotplug.txt |7 +++ hw/acpi_ich9.c |7 +-- hw/acpi_ich9.h |1 + hw

[Qemu-devel] [RFC PATCH v4 27/30] [SeaBIOS] Add _OST dimm method

2012-12-18 Thread Vasilis Liaskovitis
Add support for _OST method. _OST method will write into the correct I/O byte to signal success / failure of hot-add or hot-remove to qemu. --- src/acpi-dsdt-mem-hotplug.dsl | 51 - src/ssdt-mem.dsl |4 +++ 2 files changed, 54 insertions(+

[Qemu-devel] [RFC PATCH v4 15/30] q35: Add i440fx dram controller initialization

2012-12-18 Thread Vasilis Liaskovitis
Create memory buses and introduce function to adjust memory map for hotplug-able dimms. Signed-off-by: Vasilis Liaskovitis --- hw/pc_q35.c |1 + hw/q35.c| 27 +++ hw/q35.h|5 + 3 files changed, 33 insertions(+), 0 deletions(-) diff --git a/hw

[Qemu-devel] [RFC PATCH v4 14/30] piix_pci: Add i440fx dram controller initialization

2012-12-18 Thread Vasilis Liaskovitis
Also introduce function to adjust memory map for hotplug-able dimms. Signed-off-by: Vasilis Liaskovitis --- hw/pc_piix.c |6 +++--- hw/piix_pci.c | 30 -- 2 files changed, 31 insertions(+), 5 deletions(-) diff --git a/hw/pc_piix.c b/hw/pc_piix.c index 6a9b508

[Qemu-devel] [RFC PATCH v4 06/30] qapi: make visit_type_size fallback to type_int

2012-12-18 Thread Vasilis Liaskovitis
Currently visit_type_size checks if the visitor's type_size function pointer is NULL. If not, it calls it, otherwise it calls v->type_uint64(). But neither of these pointers are ever set. Fallback to calling v->type_int() in this third (default) case. Signed-off-by: Vasilis Liaskovitis

[Qemu-devel] [RFC PATCH v4 01/30] [SeaBIOS] Add ACPI_EXTRACT_DEVICE* macros

2012-12-18 Thread Vasilis Liaskovitis
This allows to extract the beginning, end and name of a Device object. --- tools/acpi_extract.py | 28 1 files changed, 28 insertions(+), 0 deletions(-) diff --git a/tools/acpi_extract.py b/tools/acpi_extract.py index 3295678..3191f53 100755 --- a/tools/acpi_extract

Re: [Qemu-devel] [PATCH] add bochs dispi interface framebuffer driver

2012-11-02 Thread Vasilis Liaskovitis
On Thu, Nov 01, 2012 at 02:30:35PM +0100, Gerd Hoffmann wrote: > On 10/19/12 12:35, Vasilis Liaskovitis wrote: > > Hi, > > > > On Thu, Mar 08, 2012 at 11:13:46AM +0100, Gerd Hoffmann wrote: > >> This patchs adds a frame buffer driver for (virtual/emulated) vga car

Re: [Qemu-devel] [RFC PATCH v3 00/19] ACPI memory hotplug

2012-11-01 Thread Vasilis Liaskovitis
On Wed, Oct 31, 2012 at 01:16:56PM +0200, Avi Kivity wrote: > On 10/31/2012 12:58 PM, Stefan Hajnoczi wrote: > > On Fri, Sep 21, 2012 at 1:17 PM, Vasilis Liaskovitis > > wrote: > >> This is v3 of the ACPI memory hotplug functionality. Only x86_64 target is >

Re: [Qemu-devel] [RFC PATCH v3 05/19] Implement dimm device abstraction

2012-10-24 Thread Vasilis Liaskovitis
Hi, On Wed, Oct 24, 2012 at 12:15:17PM +0200, Stefan Hajnoczi wrote: > On Wed, Oct 24, 2012 at 10:06 AM, liu ping fan wrote: > > On Tue, Oct 23, 2012 at 8:25 PM, Stefan Hajnoczi wrote: > >> On Fri, Sep 21, 2012 at 01:17:21PM +0200, Vasilis Liaskovitis wrote: > >>&

Re: [Qemu-devel] [RFC PATCH v3 06/19] Implement "-dimm" command line option

2012-10-22 Thread Vasilis Liaskovitis
Hi, On Thu, Oct 18, 2012 at 02:33:02PM +0200, Avi Kivity wrote: > On 10/18/2012 11:27 AM, Vasilis Liaskovitis wrote: > > On Wed, Oct 17, 2012 at 12:03:51PM +0200, Avi Kivity wrote: > >> On 10/17/2012 11:19 AM, Vasilis Liaskovitis wrote: > >> >> > >> &

Re: [Qemu-devel] [PATCH] add bochs dispi interface framebuffer driver

2012-10-19 Thread Vasilis Liaskovitis
Hi, On Thu, Mar 08, 2012 at 11:13:46AM +0100, Gerd Hoffmann wrote: > This patchs adds a frame buffer driver for (virtual/emulated) vga cards > implementing the bochs dispi interface. Supported hardware are the > bochs vga card with vbe extension and the qemu standard vga. > > The driver uses a f

Re: [Qemu-devel] [RFC PATCH v3 06/19] Implement "-dimm" command line option

2012-10-18 Thread Vasilis Liaskovitis
On Wed, Oct 17, 2012 at 12:03:51PM +0200, Avi Kivity wrote: > On 10/17/2012 11:19 AM, Vasilis Liaskovitis wrote: > >> > >> I don't think so, but probably there's a limit of DIMMs that real > >> controllers have, something like 8 max. > > > >

Re: [Qemu-devel] [RFC PATCH v3 06/19] Implement "-dimm" command line option

2012-10-17 Thread Vasilis Liaskovitis
On Sat, Oct 13, 2012 at 08:57:19AM +, Blue Swirl wrote: > On Tue, Oct 9, 2012 at 5:04 PM, Vasilis Liaskovitis > wrote: > >> snip > >> Maybe even the dimmbus device shouldn't exist by itself after all, or > >> it should be pretty much invisible to users.

[Qemu-devel] slower live-migration with XBZRLE

2012-10-11 Thread Vasilis Liaskovitis
Hi, I am testing XBZRLE compression with qemu-1.2 for live migration of large VM and/or memory-intensive workloads. I have a 4GB guest that runs the memory r/w load generator from the original patchset, see docs/xbzrle.txt or http://lists.gnu.org/archive/html/qemu-devel/2012-07/msg01207.html I ha

Re: [Qemu-devel] [RFC PATCH 0/9] qom: improve reference counting and hotplug

2012-10-09 Thread Vasilis Liaskovitis
Hi, On Sun, Aug 26, 2012 at 10:51:29AM -0500, Anthony Liguori wrote: > Right now, you need to pair up object_new with object_delete. This is > impractical when using reference counting because we would like to ensure that > object_unref() also frees memory when needed. > > The first few patches

Re: [Qemu-devel] [RFC PATCH v3 06/19] Implement "-dimm" command line option

2012-10-09 Thread Vasilis Liaskovitis
Hi, sorry for the delayed answer. On Sat, Sep 29, 2012 at 11:13:04AM +, Blue Swirl wrote: > > > > The "-dimm" option is supposed to specify the dimm/memory layout, and not > > create > > any devices. > > > > If we don't want this new option, I have a question: > > > > A "-device/device_add"

Re: [Qemu-devel] [RFC PATCH v3 08/19] pc: calculate dimm physical addresses and adjust memory map

2012-09-24 Thread Vasilis Liaskovitis
On Sat, Sep 22, 2012 at 02:15:28PM +, Blue Swirl wrote: > > + > > +/* Function to configure memory offsets of hotpluggable dimms */ > > + > > +target_phys_addr_t pc_set_hp_memory_offset(uint64_t size) > > +{ > > +target_phys_addr_t ret; > > + > > +/* on first call, initialize ram_hp_off

Re: [Qemu-devel] [RFC PATCH v3 11/19] Implement qmp and hmp commands for notification lists

2012-09-24 Thread Vasilis Liaskovitis
Hi, On Fri, Sep 21, 2012 at 04:03:26PM -0600, Eric Blake wrote: > On 09/21/2012 05:17 AM, Vasilis Liaskovitis wrote: > > Guest can respond to ACPI hotplug events e.g. with _EJ or _OST method. > > This patch implements a tail queue to store guest notifications for memory > > h

Re: [Qemu-devel] [RFC PATCH v3 20/19][SeaBIOS] alternative: Use paravirt interface for pci windows

2012-09-24 Thread Vasilis Liaskovitis
On Mon, Sep 24, 2012 at 02:35:30PM +0800, Wen Congyang wrote: > At 09/21/2012 07:20 PM, Vasilis Liaskovitis Wrote: > > Initialize the 32-bit and 64-bit pci starting offsets from values passed in > > by > > the qemu paravirt interface QEMU_CFG_PCI_WINDOW. Qemu calcula

Re: [Qemu-devel] [RFC PATCH v3 06/19] Implement "-dimm" command line option

2012-09-24 Thread Vasilis Liaskovitis
On Sat, Sep 22, 2012 at 01:46:57PM +, Blue Swirl wrote: > On Fri, Sep 21, 2012 at 11:17 AM, Vasilis Liaskovitis > wrote: > > Example: > > "-dimm id=dimm0,size=512M,node=0,populated=off" > > There should not be a need to introduce a new top level option, >

[Qemu-devel] [RFC PATCH v3 00/19] ACPI memory hotplug

2012-09-21 Thread Vasilis Liaskovitis
ockers are resolved)? The patchset has been revised every few months, but I will provide quicker version updates onwards. I can also bring this up on a weekly meeting agenda if needed. series is based on uq/master for qemu-kvm, and master for seabios. Can be found also at: http://github.com/vlias

[Qemu-devel] [RFC PATCH v3 08/19] pc: calculate dimm physical addresses and adjust memory map

2012-09-21 Thread Vasilis Liaskovitis
. Signed-off-by: Vasilis Liaskovitis --- hw/pc.c | 41 + hw/pc.h |6 ++ hw/pc_piix.c | 20 ++-- vl.c |1 + 4 files changed, 62 insertions(+), 6 deletions(-) diff --git a/hw/pc.c b/hw/pc.c index 112739a..2c9664d

[Qemu-devel] [RFC PATCH v3 20/19][SeaBIOS] alternative: Use paravirt interface for pci windows

2012-09-21 Thread Vasilis Liaskovitis
Initialize the 32-bit and 64-bit pci starting offsets from values passed in by the qemu paravirt interface QEMU_CFG_PCI_WINDOW. Qemu calculates the starting offsets based on initial memory and hotplug-able dimms. Signed-off-by: Vasilis Liaskovitis --- src/paravirt.c |6 ++ src

  1   2   >