On 2025/01/11 0:08, Peter Xu wrote:
On Fri, Jan 10, 2025 at 07:11:27PM +0900, Tomoyuki HIROSE wrote:
MR implementation to be safe when unaligned accessing (current xHCI
implementation does not handle unaligned accesses but the spec allows
unaligned accesses).
In addition, maybe it would be
On 2025/01/09 1:50, Peter Xu wrote:
Hi, Tomoyuki,
On Wed, Jan 08, 2025 at 11:58:10AM +0900, Tomoyuki HIROSE wrote:
Happy new year, Peter.
I had another job and was late in replying to your email, sorry.
Happy new year. That's fine. :)
[...]
So.. it turns out we shouldn&#
Happy new year, Peter.
I had another job and was late in replying to your email, sorry.
On 2024/12/13 0:46, Peter Xu wrote:
On Thu, Dec 12, 2024 at 02:39:41PM +0900, Tomoyuki HIROSE wrote:
On 2024/12/12 7:54, Peter Xu wrote:
On Wed, Dec 11, 2024 at 06:35:57PM +0900, Tomoyuki HIROSE wrote
On 2024/12/12 7:54, Peter Xu wrote:
On Wed, Dec 11, 2024 at 06:35:57PM +0900, Tomoyuki HIROSE wrote:
Sorry for late reply.
On 2024/12/07 1:42, Peter Xu wrote:
On Fri, Dec 06, 2024 at 05:31:33PM +0900, Tomoyuki HIROSE wrote:
In this email, I explain what this patch set will resolve and an
Sorry for late reply.
On 2024/12/07 1:42, Peter Xu wrote:
On Fri, Dec 06, 2024 at 05:31:33PM +0900, Tomoyuki HIROSE wrote:
In this email, I explain what this patch set will resolve and an
overview of this patch set. I will respond to your specific code
review comments in a separate email.
Yes
In this email, I explain what this patch set will resolve and an
overview of this patch set. I will respond to your specific code
review comments in a separate email.
On 2024/12/03 6:23, Peter Xu wrote:
On Fri, Nov 08, 2024 at 12:29:46PM +0900, Tomoyuki HIROSE wrote:
The previous code ignored
On 2024/12/02 23:17, Peter Maydell wrote:
On Fri, 29 Nov 2024 at 03:33, Tomoyuki HIROSE
wrote:
OK, thanks! I got understand. I thought MemoryRegionOps had to be
'static const' .
I will try to improve code so that it does not require the use of
memaccess-testdev.h.inc .
Great. The o
On 2024/11/28 20:15, Peter Maydell wrote:
On Thu, 28 Nov 2024 at 06:19, Tomoyuki HIROSE
wrote:
Hi, thank you for your comment.
On 2024/11/27 20:23, Peter Maydell wrote:
On Wed, 27 Nov 2024 at 04:34, Tomoyuki HIROSE
wrote:
I would be happy to receive your comments.
ping.
Hi; this one is
Hi, thank you for your comment.
On 2024/11/27 20:23, Peter Maydell wrote:
On Wed, 27 Nov 2024 at 04:34, Tomoyuki HIROSE
wrote:
I would be happy to receive your comments.
ping.
Hi; this one is on my to-review list (along, sadly, with 23 other
series); I had a quick look a while back and it
I would be happy to receive your comments.
ping.
On 2024/11/08 12:29, Tomoyuki HIROSE wrote:
This patch set aims to support unaligned access to xHCI Capability
Registers.
To achieve this, we introduce the emulation of an unaligned access
through multiple aligned accesses. This patch set also
This commit adds a test device for checking memory access. The test
device generates memory regions that covers all the parameter
patterns. With this device, we can check the handling of
reading/writing the MemoryRegion is correct.
Signed-off-by: Tomoyuki HIROSE
---
hw/misc/Kconfig
h multiple aligned
accesses. Additionally, the overwriting of the max access size is
removed to retrive the actual max access size.
Signed-off-by: Tomoyuki HIROSE
---
system/memory.c | 147 ++-
system/physmem.c | 8 ---
2 files changed, 119 inserti
This commit adds a qtest for accessing various memory regions. The
qtest checks the correctness of handling the access to memory regions
by using 'memaccess-testdev'.
Signed-off-by: Tomoyuki HIROSE
---
tests/qtest/memaccess-test.c | 598 +++
t
the 'valid' field in MemoryRegionOps of CMB and
the CMB area can be accessed in units of 8 bytes.
Signed-off-by: Tomoyuki HIROSE
---
hw/nvme/ctrl.c | 5 +
1 file changed, 5 insertions(+)
diff --git a/hw/nvme/ctrl.c b/hw/nvme/ctrl.c
index 8e4612e035..acbd10628f 100644
--- a/hw/nvme/ctrl.c
+
n in '.inc'
files. I followed this approach for the test functions but would
appreciate feedback on whether this is appropriate.
Tomoyuki HIROSE (5):
hw/nvme/ctrl: specify the 'valid' field in MemoryRegionOps
system/memory: support unaligned access
hw/misc: add test de
unaligned access and 8-byte access to
Host Controller Capability Registers.
Resolves: https://gitlab.com/qemu-project/qemu/-/issues/143
Signed-off-by: Tomoyuki HIROSE
---
hw/usb/hcd-xhci.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/hw/usb/hcd-xhci.c b/hw/usb/hcd-xhci.c
ping.
On Mon, Feb 26, 2024 at 4:28 PM Tomoyuki Hirose
wrote:
>
> Hello,
> I would be happy if you could give me some comments.
>
> ping.
>
> On Thu, Feb 1, 2024 at 5:14 PM Tomoyuki HIROSE
> wrote:
> >
> > The previous code ignored 'impl.unaligned'
Hello,
I would be happy if you could give me some comments.
ping.
On Thu, Feb 1, 2024 at 5:14 PM Tomoyuki HIROSE
wrote:
>
> The previous code ignored 'impl.unaligned' and handled unaligned accesses
> as is. But this implementation cannot emulate specific registers of some
&
unaligned access and 8-byte access
to Host Controller Capability Registers.
Resolves: https://gitlab.com/qemu-project/qemu/-/issues/143
Signed-off-by: Tomoyuki HIROSE
---
hw/usb/hcd-xhci.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/hw/usb/hcd-xhci.c b/hw/usb/hcd-xhci.c
if it is false, QEMU emulates
unaligned access with multiple aligned access.
Signed-off-by: Tomoyuki HIROSE
---
system/memory.c | 38 +-
1 file changed, 25 insertions(+), 13 deletions(-)
diff --git a/system/memory.c b/system/memory.c
index a229a79988..a7ca0c9f54
hes contain 2 changes:
1. support unaligned access to 'MemoryRegion' .
2. allow unaligned access to Host Controller Capability Registers.
Tomoyuki HIROSE (2):
system/memory.c: support unaligned access
hw/usb/hcd-xhci.c: allow unaligned access to Capability Registers
hw/usb/hcd-xhci.c |
Hello,
Thank you for reviewing my patches.
Examples of corner case you explained is very helpful.
I'm currently working on patches. I will submit v2 as soon
as it's completed, so please wait a little longer.
thanks,
Tomoyuki HIROSE
On Tue, Dec 19, 2023 at 8:26 PM Peter Maydell wrote:
>
> On Tue, 19 Dec 2023 at 04:49, Tomoyuki Hirose
> wrote:
> >
> > I would be grateful if you would any comments on my patch.
>
> It's on my todo list, but at this point I'm afraid I'm
> not goi
I would be grateful if you would any comments on my patch.
ping,
Tomoyuki HIROSE
On Mon, Dec 11, 2023 at 4:12 PM Tomoyuki HIROSE
wrote:
>
> According to xHCI spec rev 1.2, unaligned access to xHCI Host
> Controller Capability Registers are not prohibited. But current
> implementat
On Tue, Dec 12, 2023 at 7:26 PM Peter Maydell wrote:
>
> On Tue, 12 Dec 2023 at 01:43, Tomoyuki Hirose
> wrote:
> >
> > Thanks for comment.
> >
> > On Mon, Dec 11, 2023 at 10:57 PM Peter Maydell
> > wrote:
> > > We should definitely look at
his patch is an RFC, and unfortunately it doesn't seem to have been merged.
This feature is useful for devices that allow unaligned access.
Regards,
Tomoyuki HIROSE
On Mon, Dec 11, 2023 at 10:31 PM Cédric Le Goater wrote:
>
> Hello,
>
> On 12/11/23 08:12, Tomoyuki HI
e capability registers in the xHCI spec
> are also all at offsets and sizes that mean that a natural
> read of them is not unaligned.
Shouldn't I link this bug report?
Or is it not appropriate to allow unaligned access?
thanks,
Tomoyuki HIROSE
unaligned access and 8-byte access
to Host Controller Capability Registers.
Resolves: https://gitlab.com/qemu-project/qemu/-/issues/143
Signed-off-by: Tomoyuki HIROSE
---
hw/usb/hcd-xhci.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/hw/usb/hcd-xhci.c b/hw/usb/hcd-xhci.c
low unaligned access to Host Controller Capability Registers.
Tomoyuki HIROSE (2):
system/memory.c: support unaligned access
hw/usb/hcd-xhci.c: allow unaligned access to Capability Registers
hw/usb/hcd-xhci.c | 4 +++-
system/memory.c | 22 --
2 files changed, 19 insert
if it is false, QEMU emulates
unaligned access with multiple aligned access.
Signed-off-by: Tomoyuki HIROSE
---
system/memory.c | 22 --
1 file changed, 16 insertions(+), 6 deletions(-)
diff --git a/system/memory.c b/system/memory.c
index 798b6c0a17..b0caa90fef 100644
--- a/s
30 matches
Mail list logo
