Re: [Qemu-devel] [PATCH] qga-win: don't hang if vss hold writes timeout

2017-09-22 Thread Tomoki Sekiyama
2017-09-23 12:11 GMT+09:00 Chen Hanxiao : > > 在 2017-09-23 05:12:20,"Tomoki Sekiyama" 写道: > > > > > Thanks for your patch. > > Which version of Windows have you found the hang? > > > > > I tested on win08, win 08 r2 and win2012. > Thank

Re: [Qemu-devel] [PATCH] qga-win: don't hang if vss hold writes timeout

2017-09-22 Thread Tomoki Sekiyama
Thanks for your patch. Which version of Windows have you found the hang? Regards, Tomoki 2017-09-22 11:46 GMT+09:00 Chen Hanxiao : > From: Chen Hanxiao > > When VM is in a heavy IO, if the command "guest-fsfreeze-freeze" > is executed, VSS may timeout when trying to hold writes. > > Inside gues

Re: [Qemu-devel] How to build qga-vss.dll?

2015-06-20 Thread Tomoki Sekiyama
--with-vss-sdk=inc - make qemu-ga.exe qga/vss-win32/qga-vss.{dll,tlb} I hope this helps. Thanks, Tomoki From: Markus Armbruster [arm...@redhat.com] Sent: Saturday, June 20, 2015 5:30 AM To: Tomoki Sekiyama Cc: qemu-devel@nongnu.org; Michael Roth Su

Re: [Qemu-devel] [libvirt] Where to get precompiled qga-vss.dll from ?

2014-07-10 Thread Tomoki Sekiyama
​ >Hi, > >[Rephrasing my earlier post with more clarity.] > >I need to work with "guest-fsfreeze-*" commands in Windows 2008 guest VM >(Host is CentOS 6.4) to quisce the applications. > > > >Windows 2008 Guest Machine Is this 32bit or 64bit? FYI, qga-vss.dll must be built for corresponding archit

Re: [Qemu-devel] [RESEND PATCH v5 0/3] qga: Add guest-fsfreeze-freeze-list command

2014-07-07 Thread Tomoki Sekiyama
Any comments for this patch? On 6/30/14 17:51 , "Tomoki Sekiyama" wrote: >Hi, > >As patch 3/3 was missing in the last post, I'm resending this patchset. > >=== >This is v5 patch for qemu-ga to add functions to freeze specific file >systems >mounted in a

[Qemu-devel] [RESEND PATCH v5 3/3] qga: Disable unsupported commands by default

2014-06-30 Thread Tomoki Sekiyama
abled' property of the result from 'guest-info' command. Signed-off-by: Tomoki Sekiyama --- qga/commands-posix.c | 38 ++ qga/commands-win32.c | 32 +++- qga/guest-agent-core.h |1 + qga/main.c |

[Qemu-devel] [RESEND PATCH v5 1/3] qga: Add guest-fsfreeze-freeze-list command

2014-06-30 Thread Tomoki Sekiyama
t wants to create partial disk snapshots. Signed-off-by: Tomoki Sekiyama Reviewed-by: Eric Blake --- qga/commands-posix.c | 32 +++- qga/commands-win32.c |9 + qga/qapi-schema.json | 17 + 3 files changed, 57 insertions(+), 1 deletion(-)

[Qemu-devel] [RESEND PATCH v5 2/3] qga: Add guest-get-fsinfo command

2014-06-30 Thread Tomoki Sekiyama
us-type":"virtio","bus":0,"unit":0,"target":0, "pci-controller":{"bus":0,"slot":6,"domain":0,"function":0}}], "type":"ext4"}]} In Linux guest, the disk information

[Qemu-devel] [RESEND PATCH v5 0/3] qga: Add guest-fsfreeze-freeze-list command

2014-06-30 Thread Tomoki Sekiyama
more generic rename functions to avoid leading '__' improve compatibility with older Linux - PATCH 3 (new in v5): disable unsupported commands by default (v4: http://lists.gnu.org/archive/html/qemu-devel/2014-06/msg01357.html) --- Tomoki Sekiyama (3): qga: Add

[Qemu-devel] [PATCH v5 2/3] qga: Add guest-get-fsinfo command

2014-06-23 Thread Tomoki Sekiyama
us-type":"virtio","bus":0,"unit":0,"target":0, "pci-controller":{"bus":0,"slot":6,"domain":0,"function":0}}], "type":"ext4"}]} In Linux guest, the disk information

[Qemu-devel] [PATCH v5 1/3] qga: Add guest-fsfreeze-freeze-list command

2014-06-23 Thread Tomoki Sekiyama
t wants to create partial disk snapshots. Signed-off-by: Tomoki Sekiyama Reviewed-by: Eric Blake --- qga/commands-posix.c | 32 +++- qga/commands-win32.c |9 + qga/qapi-schema.json | 17 + 3 files changed, 57 insertions(+), 1 deletion(-)

[Qemu-devel] [PATCH v5 0/3] qga: Add guest-fsfreeze-freeze-list command

2014-06-23 Thread Tomoki Sekiyama
improve compatibility with older Linux - PATCH 3 (new in v5): disable unsupported commands by default (v4: http://lists.gnu.org/archive/html/qemu-devel/2014-06/msg01357.html) --- Tomoki Sekiyama (3): qga: Add guest-fsfreeze-freeze-list command qga: Add guest-get-fsinfo command

Re: [Qemu-devel] [PATCH v4 2/2] qga: Add guest-get-fsinfo command

2014-06-20 Thread Tomoki Sekiyama
On 6/20/14 11:21 , "Eric Blake" wrote: >On 06/19/2014 06:34 PM, Tomoki Sekiyama wrote: > >>>> +} >>>> +if (S_ISBLK(st.st_mode)) { >>>> +*devmajor = major(st.st_rdev); >>>> +*devminor = minor(st.st_rdev);

Re: [Qemu-devel] [PATCH v4 2/2] qga: Add guest-get-fsinfo command

2014-06-19 Thread Tomoki Sekiyama
Hi Eric, Thank you for the review. On 6/19/14 17:23 , "Eric Blake" wrote: >On 06/05/2014 08:57 AM, Tomoki Sekiyama wrote: >> Add command to get mounted filesystems information in the guest. >> The returned value contains a list of mountpoint paths and >> corres

Re: [Qemu-devel] [PATCH v4 0/2] qga: Add guest-fsfreeze-freeze-list command

2014-06-16 Thread Tomoki Sekiyama
Any comments for this patch? -- Tomoki Sekiyama On 6/5/14 10:57 , "Tomoki Sekiyama" wrote: >Hi, > >This is v4 patch for qemu-ga to add functions to freeze specific file >systems >mounted in a guest. > >PATCH 1 adds a guest-fsfreeze-freeze-list command, which

[Qemu-devel] [PATCH v4 1/2] qga: Add guest-fsfreeze-freeze-list command

2014-06-05 Thread Tomoki Sekiyama
t wants to create partial disk snapshots. Signed-off-by: Tomoki Sekiyama --- qga/commands-posix.c | 32 +++- qga/commands-win32.c |9 + qga/qapi-schema.json | 17 + 3 files changed, 57 insertions(+), 1 deletion(-) diff --git a/qga/commands

[Qemu-devel] [PATCH v4 0/2] qga: Add guest-fsfreeze-freeze-list command

2014-06-05 Thread Tomoki Sekiyama
o discover optional params are accepted or not. - PATCH 2: code cleanups... (v3: http://lists.gnu.org/archive/html/qemu-devel/2014-05/msg04571.html) --- Tomoki Sekiyama (2): qga: Add guest-fsfreeze-freeze-list command qga: Add guest-get-fsinfo command qga/commands-posi

[Qemu-devel] [PATCH v4 2/2] qga: Add guest-get-fsinfo command

2014-06-05 Thread Tomoki Sekiyama
us-type":"virtio","bus":0,"unit":0,"target":0, "pci-controller":{"bus":0,"slot":6,"domain":0,"function":0}}], "type":"ext4"}]} In Linux guest, the disk information

Re: [Qemu-devel] [PATCH v3 1/2] qga: Add 'mountpoints' argument to guest-fsfreeze-freeze command

2014-06-03 Thread Tomoki Sekiyama
live with 'guest-fsfreeze-freeze-list'. I'm okay with 'guest-fsfreeze-freeze-list' too. >Do we need a guest-fsfreeze-thaw-list counterpart, or is it sufficient >to always thaw all systems without worrying about listing them? I think current guest-fsfreeze-thaw is sufficient; don't want to risk leaving some filesystems unfrozen that may cause deadlocks.. Thanks, Tomoki Sekiyama

[Qemu-devel] [PATCH v3 0/2] qga: Add 'mountpoints' argument to guest-fsfreeze-freeze command

2014-05-22 Thread Tomoki Sekiyama
ts.gnu.org/archive/html/qemu-devel/2014-04/msg04433.html) --- Tomoki Sekiyama (2): qga: Add 'mountpoints' argument to guest-fsfreeze-freeze command qga: Add guest-get-fs-info command qga/commands-posix.c | 437 ++ qga/commands-

[Qemu-devel] [PATCH v3 1/2] qga: Add 'mountpoints' argument to guest-fsfreeze-freeze command

2014-05-22 Thread Tomoki Sekiyama
When an array of mount point paths is specified as 'mountpoints' argument of guest-fsfreeze-freeze, qemu-ga with this patch will only freeze the file systems mounted on specified paths in Linux. This would be useful when the host wants to create partial disk snapshots. Signed-off-

[Qemu-devel] [PATCH v3 2/2] qga: Add guest-get-fs-info command

2014-05-22 Thread Tomoki Sekiyama
us-type":"virtio","bus":0,"unit":0,"target":0, "pci-controller":{"bus":0,"slot":6,"domain":0,"function":0}}], "type":"ext4"}]} In Linux guest, the disk information

Re: [Qemu-devel] [PATCH v2] qga: Add 'mountpoints' argument to guest-fsfreeze-freeze command

2014-05-21 Thread Tomoki Sekiyama
Hi Eric, thank you for the comments. On 5/20/14 18:46 , "Eric Blake" wrote: >On 05/20/2014 04:01 PM, Tomoki Sekiyama wrote: >> The patch below is for the command to get filesystems list. >> >> === >> From: Tomoki Sekiyama > >You'll want to

Re: [Qemu-devel] [PATCH v2] qga: Add 'mountpoints' argument to guest-fsfreeze-freeze command

2014-05-20 Thread Tomoki Sekiyama
> On 04/28/2014 09:25 AM, Tomoki Sekiyama wrote: >> When an array of mount point paths is specified as 'mountpoints' argument >> of guest-fsfreeze-freeze, qemu-ga with this patch will only freeze the file >> systems mounted on specified paths in Linux. > > How

Re: [Qemu-devel] [PATCH v2] qga: Add 'mountpoints' argument to guest-fsfreeze-freeze command

2014-05-20 Thread Tomoki Sekiyama
> On 04/28/2014 09:25 AM, Tomoki Sekiyama wrote: >> When an array of mount point paths is specified as 'mountpoints' argument >> of guest-fsfreeze-freeze, qemu-ga with this patch will only freeze the file >> systems mounted on specified paths in Linux. > > How

Re: [Qemu-devel] [PATCH v2] qga: Add 'mountpoints' argument to guest-fsfreeze-freeze command

2014-05-20 Thread Tomoki Sekiyama
Any comments for this patch? Thanks, Tomoki Sekiyama On 4/28/14 11:25 , "Tomoki Sekiyama" wrote: >Hi, > >This is v2 patch for qemu-ga to add argument to specify which filesystems >to be frozen by guest-fsfreeze-freeze command. > >Changes to v1: > added docum

[Qemu-devel] [PATCH v2] qga: Add 'mountpoints' argument to guest-fsfreeze-freeze command

2014-04-28 Thread Tomoki Sekiyama
Hi, This is v2 patch for qemu-ga to add argument to specify which filesystems to be frozen by guest-fsfreeze-freeze command. Changes to v1: added documentation of the new field (v1: http://lists.gnu.org/archive/html/qemu-devel/2014-04/msg04085.html) --- Tomoki Sekiyama (1): qga: Add

[Qemu-devel] [PATCH v2] qga: Add 'mountpoints' argument to guest-fsfreeze-freeze command

2014-04-28 Thread Tomoki Sekiyama
When an array of mount point paths is specified as 'mountpoints' argument of guest-fsfreeze-freeze, qemu-ga with this patch will only freeze the file systems mounted on specified paths in Linux. This would be useful when the host wants to create partial disk snapshots. Signed-off-

[Qemu-devel] [PATCH] qga: Add 'mountpoints' argument to guest-fsfreeze-freeze command

2014-04-25 Thread Tomoki Sekiyama
When an array of mount point paths is specified as 'mountpoints' argument of guest-fsfreeze-freeze, qemu-ga with this patch will only freeze the file systems mounted on specified paths in Linux. This would be useful when the host wants to create partial disk snapshots. Signed-off-

[Qemu-devel] [PATCH 2/2] vss-win32: Fix build with mingw64-headers-3.1.0

2014-03-26 Thread Tomoki Sekiyama
In mingw64-headers-3.1.0, definition of _com_issue_error() is added, which conflicts with definition in install.cpp. This adds version checking for mingw headers to disable the definition when the headers>=3.1 is used. Signed-off-by: Tomoki Sekiyama --- qga/vss-win32/install.cpp |3 +++

[Qemu-devel] [PATCH 1/2] Makefile: add qga-vss-dll-obj-y to nested variables

2014-03-26 Thread Tomoki Sekiyama
The build rule for qga/vss-win32/qga-vss.dll is broken by commit ba1183da9a10b94611cad88c44a5c6df005f9b55, because it misses qga-vss-dll-obj-y in the list of nested variables. This fixes build of qga-vss.dll by adding qga-vss-dll-obj-y to the list. Signed-off-by: Tomoki Sekiyama --- Makefile

[Qemu-devel] [PATCH 0/2] qga: vss-win32: Fix build failure

2014-03-26 Thread Tomoki Sekiyama
Hello, These patches are to fix recent build failures of qemu-guest-agent for Windows when fsfreeze using VSS is enabled by: ./configure --cross-prefix=i686-w64-mingw32- --with-vss-sdk=yes --- Tomoki Sekiyama (2): Makefile: add qga-vss-dll-obj-y to nested variables vss-win32: Fix

[Qemu-devel] [PATCH 3/3] qga: vss-win32: Fix interference with snapshot deletion by other VSS request

2014-01-13 Thread Tomoki Sekiyama
mu-ga VSS provider. Signed-off-by: Tomoki Sekiyama --- qga/vss-win32/provider.cpp |4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/qga/vss-win32/provider.cpp b/qga/vss-win32/provider.cpp index b233646..d5129f8 100644 --- a/qga/vss-win32/provider.cpp +++ b/qga/vss-

[Qemu-devel] [PATCH 1/3] qga: vss-win32: Use NULL as an invalid pointer for OpenEvent and CreateEvent

2014-01-13 Thread Tomoki Sekiyama
OpenEvent and CreateEvent WinAPI return NULL when failed to open/create events handles, instead of INVALID_HANDLE_VALUE (although their return types are HANDLE). This replaces INVALID_HANDLE_VALUE related to event handles with NULL. Signed-off-by: Tomoki Sekiyama --- qga/vss-win32/provider.cpp

[Qemu-devel] [PATCH 2/3] qga: vss-win32: Fix interference with snapshot creation by other VSS requesters

2014-01-13 Thread Tomoki Sekiyama
when CQGAVssProvider::IsVolumeSupported() is called, it moves the initialization earlier. Signed-off-by: Tomoki Sekiyama --- qga/vss-win32/provider.cpp | 11 - qga/vss-win32/requester.cpp | 52 ++- 2 files changed, 36 insertions(+), 27 dele

[Qemu-devel] [PATCH 0/3] qga: vss-win32: Fix interference with other VSS requesters

2014-01-13 Thread Tomoki Sekiyama
Event WinAPI, which returns NULL instead of INVALID_HANDLE_VALUE on errors. https://bugzilla.redhat.com/show_bug.cgi?id=1036341 --- Tomoki Sekiyama (3): qga: vss-win32: Use NULL as an invalid pointer for OpenEvent and CreateEvent qga: vss-win32: Fix interference with snapshot creati

Re: [Qemu-devel] Buildbot failure: qga/vss-win32/requester.h compile error

2013-11-20 Thread Tomoki Sekiyama
to investigate? >> >> If not, please CC folks who can help. >> >> Thanks, >> Stefan Thanks for letting me know this. I'm investigating the issue, but it looks already fixed in the code in the upstream git tree, by commit ba1c293109: "qga: Fix compilation for old version of MinGW" Could you try this fix? Thanks, Tomoki Sekiyama

[Qemu-devel] Ping [PATCH] qemu-ga: vss-win32: Install VSS provider COM+ application service

2013-11-15 Thread Tomoki Sekiyama
On 11/3/13 3:59 , "Gal Hammer" wrote: >Reviewed-by: Gal Hammer > >On 01/11/2013 23:47, Tomoki Sekiyama wrote: >> Currently, qemu-ga for Windows fails to execute guset-fsfreeze-freeze >>when >> no user is logging in to Windows, with an error message:

[Qemu-devel] [PATCH] qemu-ga: vss-win32: Install VSS provider COM+ application service

2013-11-01 Thread Tomoki Sekiyama
ICOMAdminCatalog interface with ICOMAdminCatalog2 interface that contains CreateServiceForApplication() method in addition. Signed-off-by: Tomoki Sekiyama --- qga/vss-win32/install.cpp | 16 ++-- 1 file changed, 10 insertions(+), 6 deletions(-) diff --git a/qga/vss-win32/install.cpp

[Qemu-devel] [PATCH] qemu-ga: execute fsfreeze-freeze in reverse order of mounts

2013-10-01 Thread Tomoki Sekiyama
filesystems in reverse order of mounts. Signed-off-by: Tomoki Sekiyama --- qga/commands-posix.c |4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/qga/commands-posix.c b/qga/commands-posix.c index e199738..f453132 100644 --- a/qga/commands-posix.c +++ b/qga/commands-posix.c

[Qemu-devel] [PATCH v10 09/10] qemu-ga: Install Windows VSS provider on `qemu-ga -s install'

2013-08-07 Thread Tomoki Sekiyama
Register QGA VSS provider library into Windows when qemu-ga is installed as Windows service ('-s install' option). It is deregistered when the service is uninstalled ('-s uninstall' option). Signed-off-by: Tomoki Sekiyama Reviewed-by: Michael Roth --- qga/main.c | 10

[Qemu-devel] [PATCH v10 10/10] QMP/qemu-ga-client: Make timeout longer for guest-fsfreeze-freeze command

2013-08-07 Thread Tomoki Sekiyama
guest-fsfreeze-freeze command can take longer than 3 seconds when heavy disk I/O is running. To avoid unexpected timeout, this changes the timeout to 60 seconds (timeout of pre-commit phase of VSS). Signed-off-by: Tomoki Sekiyama Reviewed-by: Paolo Bonzini Reviewed-by: Laszlo Ersek Reviewed-by

[Qemu-devel] [PATCH v10 04/10] Add a script to extract VSS SDK headers on POSIX system

2013-08-07 Thread Tomoki Sekiyama
VSS SDK(*) setup.exe is only runnable on Windows. This adds a script to extract VSS SDK headers on POSIX-systems using msitools. * http://www.microsoft.com/en-us/download/details.aspx?id=23490 From: Paolo Bonzini Signed-off-by: Paolo Bonzini Signed-off-by: Tomoki Sekiyama Reviewed-by

[Qemu-devel] [PATCH v10 06/10] error: Add error_set_win32 and error_setg_win32

2013-08-07 Thread Tomoki Sekiyama
These functions help maintaining homogeneous formatting of error messages with Windows error code and description (generated by g_win32_error_message()). Signed-off-by: Tomoki Sekiyama Reviewed-by: Michael Roth --- include/qapi/error.h | 13 + util/error.c | 35

[Qemu-devel] [PATCH v10 00/10] qemu-ga: fsfreeze on Windows using VSS

2013-08-07 Thread Tomoki Sekiyama
--without-systems --without-tools - make qemu-ga.exe qga/vss-win32/qga-vss.{dll,tlb} - Install qemu-ga.exe, qga/vss-win32/qga-vss.{dll,tlb}, and the other required mingw libraries into the same directory in guests - Run `qemu-ga.exe -s install' and `net start qemu-ga

[Qemu-devel] [PATCH v10 02/10] Add c++ keywords to QAPI helper script

2013-08-07 Thread Tomoki Sekiyama
Add c++ keywords to avoid errors in compiling with c++ compiler. This also renames class member of PciDeviceInfo to q_class. Signed-off-by: Tomoki Sekiyama Reviewed-by: Laszlo Ersek Reviewed-by: Michael Roth --- hmp.c |2 +- hw/pci/pci.c|2 +- scripts/qapi.py | 12

[Qemu-devel] [PATCH v10 05/10] qemu-ga: Add configure options to specify path to Windows/VSS SDK

2013-08-07 Thread Tomoki Sekiyama
qemu-ga VSS provider. However, this is usually unnecessary because pre-compiled .tlb file is included. Signed-off-by: Tomoki Sekiyama Reviewed-by: Laszlo Ersek Reviewed-by: Michael Roth --- .gitignore |1 + Makefile |1 + configure | 78 +

[Qemu-devel] [PATCH v10 08/10] qemu-ga: Call Windows VSS requester in fsfreeze command handler

2013-08-07 Thread Tomoki Sekiyama
the VSS requester. Signed-off-by: Tomoki Sekiyama Reviewed-by: Michael Roth --- qga/Makefile.objs|1 qga/commands-win32.c | 82 ++--- qga/vss-win32.c | 141 ++ qga/vss-win32.h | 24 + 4 files

[Qemu-devel] [PATCH v10 03/10] checkpatch.pl: Check .cpp files

2013-08-07 Thread Tomoki Sekiyama
method()) - : used in class declaration (e.g. class T : public Super) - ~ used in destructor method name (e.g. T::~T()) - spacing around 'catch'(e.g. catch (...)) Signed-off-by: Tomoki Sekiyama Reviewed-by: Michael Roth --- scripts/checkpatch.pl | 34 +

[Qemu-devel] [PATCH v10 01/10] configure: Support configuring C++ compiler

2013-08-07 Thread Tomoki Sekiyama
+ services in qemu-guest-agent for Windows. Signed-off-by: Tomoki Sekiyama Reviewed-by: Laszlo Ersek Reviewed-by: Micael Roth --- configure | 13 + rules.mak |9 - 2 files changed, 21 insertions(+), 1 deletion(-) diff --git a/configure b/configure index 18fa608..eabd8e5

[Qemu-devel] [PATCH v9 09/10] qemu-ga: Install Windows VSS provider on `qemu-ga -s install'

2013-07-31 Thread Tomoki Sekiyama
Register QGA VSS provider library into Windows when qemu-ga is installed as Windows service ('-s install' option). It is deregistered when the service is uninstalled ('-s uninstall' option). Signed-off-by: Tomoki Sekiyama Reviewed-by: Michael Roth --- qga/main.c | 10

[Qemu-devel] [PATCH v9 03/10] checkpatch.pl: Check .cpp files

2013-07-31 Thread Tomoki Sekiyama
method()) - : used in class declaration (e.g. class T : public Super) - ~ used in destructor method name (e.g. T::~T()) - spacing around 'catch'(e.g. catch (...)) Signed-off-by: Tomoki Sekiyama Reviewed-by: Michael Roth --- scripts/checkpatch.pl | 34 +

[Qemu-devel] [PATCH v9 08/10] qemu-ga: Call Windows VSS requester in fsfreeze command handler

2013-07-31 Thread Tomoki Sekiyama
the VSS requester. Signed-off-by: Tomoki Sekiyama Reviewed-by: Michael Roth --- qga/Makefile.objs|1 qga/commands-win32.c | 82 ++--- qga/vss-win32.c | 141 ++ qga/vss-win32.h | 24 + 4 files

[Qemu-devel] [PATCH v9 04/10] Add a script to extract VSS SDK headers on POSIX system

2013-07-31 Thread Tomoki Sekiyama
VSS SDK(*) setup.exe is only runnable on Windows. This adds a script to extract VSS SDK headers on POSIX-systems using msitools. * http://www.microsoft.com/en-us/download/details.aspx?id=23490 From: Paolo Bonzini Signed-off-by: Paolo Bonzini Signed-off-by: Tomoki Sekiyama Reviewed-by

[Qemu-devel] [PATCH v9 02/10] Add c++ keywords to QAPI helper script

2013-07-31 Thread Tomoki Sekiyama
Add c++ keywords to avoid errors in compiling with c++ compiler. This also renames class member of PciDeviceInfo to q_class. Signed-off-by: Tomoki Sekiyama Reviewed-by: Laszlo Ersek Reviewed-by: Michael Roth --- hmp.c |2 +- hw/pci/pci.c|2 +- scripts/qapi.py | 12

[Qemu-devel] [PATCH v9 00/10] qemu-ga: fsfreeze on Windows using VSS

2013-07-31 Thread Tomoki Sekiyama
DK directory to configure option as: ./configure -with-vss-sdk="path/to/VSS SDK" --cross-prefix=i686-w64-mingw32- - make qemu-ga.exe qga/vss-win32/qga-vss.{dll,tlb} - Install qemu-ga.exe, qga/vss-win32/qga-vss.{dll,tlb}, and the other required mingw libraries into the same direct

[Qemu-devel] [PATCH v9 05/10] qemu-ga: Add configure options to specify path to Windows/VSS SDK

2013-07-31 Thread Tomoki Sekiyama
qemu-ga VSS provider. However, this is usually unnecessary because pre-compiled .tlb file is included. Signed-off-by: Tomoki Sekiyama Reviewed-by: Laszlo Ersek Reviewed-by: Michael Roth --- .gitignore |1 + Makefile |1 + configure | 78 +

[Qemu-devel] [PATCH v9 10/10] QMP/qemu-ga-client: Make timeout longer for guest-fsfreeze-freeze command

2013-07-31 Thread Tomoki Sekiyama
guest-fsfreeze-freeze command can take longer than 3 seconds when heavy disk I/O is running. To avoid unexpected timeout, this changes the timeout to 60 seconds (timeout of pre-commit phase of VSS). Signed-off-by: Tomoki Sekiyama Reviewed-by: Paolo Bonzini Reviewed-by: Laszlo Ersek Reviewed-by

[Qemu-devel] [PATCH v9 01/10] configure: Support configuring C++ compiler

2013-07-31 Thread Tomoki Sekiyama
+ services in qemu-guest-agent for Windows. Signed-off-by: Tomoki Sekiyama Reviewed-by: Laszlo Ersek Reviewed-by: Micael Roth --- configure | 13 + rules.mak |9 - 2 files changed, 21 insertions(+), 1 deletion(-) diff --git a/configure b/configure index f0761ea..94cff69

[Qemu-devel] [PATCH v9 06/10] error: Add error_set_win32 and error_setg_win32

2013-07-31 Thread Tomoki Sekiyama
These functions help maintaining homogeneous formatting of error messages with Windows error code and description (generated by g_win32_error_message()). Signed-off-by: Tomoki Sekiyama Reviewed-by: Michael Roth --- include/qapi/error.h | 13 + util/error.c | 35

Re: [Qemu-devel] [PATCH v8 07/10] qemu-ga: Add Windows VSS provider and requester as DLL

2013-07-30 Thread Tomoki Sekiyama
On 7/30/13 18:24 , "Michael Roth" wrote: >Quoting Tomoki Sekiyama (2013-07-30 15:54:05) >>On 7/30/13 15:35 , "Michael Roth" wrote: >>>>>One small issue I noticed was that this error will get overwritten >>>>>with the VSS writer timeout

Re: [Qemu-devel] [PATCH v8 07/10] qemu-ga: Add Windows VSS provider and requester as DLL

2013-07-30 Thread Tomoki Sekiyama
this wouldn't break anything. The waiting code in CQGAVssProvider::CommitSnapshots would be like this: ... /* Wait until the snapshot is taken by the host. */ wait = WaitForSingleObject(hEventThaw, VSS_TIMEOUT_MSEC); switch (wait) { case WAIT_TIMEOUT: /* * We return S_OK, but the qemu-ga will get E_VSS_HOLD_WRITES_TIMEOUT * because 10 seconds fsfreeze timeout is exceeded. (If we return some * error here, it results in VSS_E_UNEXPECTED_PROVIDER_ERROR that can * be caused by the other reasons.) */ case WAIT_OBJECT_0: hr = S_OK; break; default: hr = E_ABORT; } ... Thanks, Tomoki Sekiyama

Re: [Qemu-devel] [PATCH v8 07/10] qemu-ga: Add Windows VSS provider and requester as DLL

2013-07-29 Thread Tomoki Sekiyama
VSS_TIMEOUT_EVENT_MSEC); >> +if (wait_status != WAIT_TIMEOUT) { >> +break; >> + } >> +} >> +if (wait_status != WAIT_OBJECT_0) { >> +err_set(errset, E_FAIL, >> +"Couldn't receive Frozen event from VSS provider"); >> +goto out; >> +} > >One small issue I noticed was that this error will get overwritten >with the VSS writer timeout error if we wait longer than 60s before >calling guest-fsfreeze-thaw. It might give some users false assurances >about what aspects of their snapshot may be volatile so it's >probably worth addressing. This is an error returned against guest-fsfreeze-freeze, when the writers or filesystems take more than 60s to quiesce. (CQGAVssProvider::CommitSnapshots that issues FrozenEvent is called after this quiescing succeeded.) The VSS sequence is aborted at "out:". If this happens, as the system remains thawed state, the following guest-fsfreeze-thaw will just return 0. >> diff --git a/qga/vss-win32/requester.h b/qga/vss-win32/requester.h >> new file mode 100644 >> index 000..ccd197c >> --- /dev/null >> +++ b/qga/vss-win32/requester.h >> +typedef void (*QGAVSSReuqesterFunc)(int *, ErrorSet *); > >Should be QGAVSSRequesterFunc Oops, thank you for catching this. Will fix these typo in the next version. Thanks, -- Tomoki Sekiyama

[Qemu-devel] [PATCH v8 08/10] qemu-ga: Call Windows VSS requester in fsfreeze command handler

2013-07-23 Thread Tomoki Sekiyama
the VSS requester. Signed-off-by: Tomoki Sekiyama --- qga/Makefile.objs|1 qga/commands-win32.c | 82 ++--- qga/vss-win32.c | 141 ++ qga/vss-win32.h | 24 + 4 files changed, 240 insertions

[Qemu-devel] [PATCH v8 09/10] qemu-ga: Install Windows VSS provider on `qemu-ga -s install'

2013-07-23 Thread Tomoki Sekiyama
Register QGA VSS provider library into Windows when qemu-ga is installed as Windows service ('-s install' option). It is deregistered when the service is uninstalled ('-s uninstall' option). Signed-off-by: Tomoki Sekiyama --- qga/main.c | 10 +- qg

[Qemu-devel] [PATCH v8 06/10] error: Add error_set_win32 and error_setg_win32

2013-07-23 Thread Tomoki Sekiyama
These functions help maintaining homogeneous formatting of error messages with Windows error code and description (generated by g_win32_error_message()). Signed-off-by: Tomoki Sekiyama Reviewed-by: Michael Roth --- include/qapi/error.h | 13 + util/error.c | 35

[Qemu-devel] [PATCH v8 02/10] Add c++ keywords to QAPI helper script

2013-07-23 Thread Tomoki Sekiyama
Add c++ keywords to avoid errors in compiling with c++ compiler. This also renames class member of PciDeviceInfo to q_class. Signed-off-by: Tomoki Sekiyama Reviewed-by: Laszlo Ersek Reviewed-by: Michael Roth --- hmp.c |2 +- hw/pci/pci.c|2 +- scripts/qapi.py | 12

[Qemu-devel] [PATCH v8 10/10] QMP/qemu-ga-client: Make timeout longer for guest-fsfreeze-freeze command

2013-07-23 Thread Tomoki Sekiyama
guest-fsfreeze-freeze command can take longer than 3 seconds when heavy disk I/O is running. To avoid unexpected timeout, this changes the timeout to 60 seconds (timeout of pre-commit phase of VSS). Signed-off-by: Tomoki Sekiyama Reviewed-by: Paolo Bonzini Reviewed-by: Laszlo Ersek --- QMP

[Qemu-devel] [PATCH v8 05/10] qemu-ga: Add configure options to specify path to Windows/VSS SDK

2013-07-23 Thread Tomoki Sekiyama
qemu-ga VSS provider. However, this is usually unnecessary because pre-compiled .tlb file is included. Signed-off-by: Tomoki Sekiyama Reviewed-by: Laszlo Ersek Reviewed-by: Michael Roth --- .gitignore |1 + Makefile |1 + configure | 69 +

[Qemu-devel] [PATCH v8 00/10] qemu-ga: fsfreeze on Windows using VSS

2013-07-23 Thread Tomoki Sekiyama
ga-vss.{dll,tlb}, and the other required mingw libraries into the same directory in guests - Run `qemu-ga.exe -s install' and `net start qemu-ga' in the guests Any feedback are appreciated. --- Tomoki Sekiyama (10): configure: Support configuring C++ compiler Add c++ keywor

[Qemu-devel] [PATCH v8 03/10] checkpatch.pl: Check .cpp files

2013-07-23 Thread Tomoki Sekiyama
method()) - : used in class declaration (e.g. class T : public Super) - ~ used in destructor method name (e.g. T::~T()) - spacing around 'catch'(e.g. catch (...)) Signed-off-by: Tomoki Sekiyama --- scripts/checkpatch.pl | 34 -- 1

[Qemu-devel] [PATCH v8 04/10] Add a script to extract VSS SDK headers on POSIX system

2013-07-23 Thread Tomoki Sekiyama
VSS SDK(*) setup.exe is only runnable on Windows. This adds a script to extract VSS SDK headers on POSIX-systems using msitools. * http://www.microsoft.com/en-us/download/details.aspx?id=23490 From: Paolo Bonzini Signed-off-by: Paolo Bonzini Signed-off-by: Tomoki Sekiyama Reviewed-by

[Qemu-devel] [PATCH v8 01/10] configure: Support configuring C++ compiler

2013-07-23 Thread Tomoki Sekiyama
+ services in qemu-guest-agent for Windows. Signed-off-by: Tomoki Sekiyama Reviewed-by: Laszlo Ersek --- configure | 13 + rules.mak |9 - 2 files changed, 21 insertions(+), 1 deletion(-) diff --git a/configure b/configure index 7c45db2..5e89e5d 100755 --- a/configure

Re: [Qemu-devel] [PATCH v7 03/10] checkpatch.pl: Check .cpp files

2013-07-23 Thread Tomoki Sekiyama
On 7/22/13 17:21 , "Michael Roth" wrote: >Quoting Tomoki Sekiyama (2013-07-15 11:20:37) >> Enable checkpatch.pl to apply the same checks as C source files for >> C++ files with .cpp extensions. It also adds some exceptions for C++ >> sources to suppress errors for:

Re: [Qemu-devel] [PATCH v7 01/10] configure: Support configuring C++ compiler

2013-07-23 Thread Tomoki Sekiyama
Hi Michael, Thanks for your review. On 7/22/13 16:53 , "Michael Roth" wrote: >Quoting Tomoki Sekiyama (2013-07-15 11:20:29) >> Add configuration for C++ compiler in configure and Makefiles. >> The C++ compiler is choosed as following: >> - ${CXX}, if it is sp

Re: [Qemu-devel] [PATCH v7 00/10] qemu-ga: fsfreeze on Windows using VSS

2013-07-22 Thread Tomoki Sekiyama
ving COM+ Application: QEMU Guest Agent VSS Provider > Removing COM+ Application: QEMU Guest Agent VSS Provider ). This seems a side effect of removal of "unregistration before registration" code in v5. I will fix this by checking if the provider with the same n

Re: [Qemu-devel] [PATCH v7 00/10] qemu-ga: fsfreeze on Windows using VSS

2013-07-22 Thread Tomoki Sekiyama
;t know how to avoid it...) Could you tell me which arch (32bit/64bit) of Windows and mingw (mingw32-* or mingw64-* in Fedora package) are you using? Thanks, Tomoki Sekiyama From: fluxion [fluks...@gmail.com] on behalf of Michael Roth [mdr...@linux.vne

Re: [Qemu-devel] [PATCH v7 00/10] qemu-ga: fsfreeze on Windows using VSS

2013-07-18 Thread Tomoki Sekiyama
ated log in Event Viewer (maybe in System or Application log) , please let me know. Thanks, Tomoki Sekiyama From: fluxion [fluks...@gmail.com] on behalf of Michael Roth [mdr...@linux.vnet.ibm.com] Sent: Thursday, July 18, 2013 6:19 PM To: Tomoki Sekiyama; q

[Qemu-devel] [PATCH v7 07/10] qemu-ga: Add Windows VSS provider and requester as DLL

2013-07-15 Thread Tomoki Sekiyama
atch, we just ignore this error. To solve this fundamentally, we need a framework to handle mount writable snapshot on guests, which is required by VSS auto-recovery feature (cleanup phase after a snapshot is taken). Signed-off-by: Tomoki Sekiyama --- Makefile|2 Makefile.

[Qemu-devel] [PATCH v7 05/10] qemu-ga: Add configure options to specify path to Windows/VSS SDK

2013-07-15 Thread Tomoki Sekiyama
qemu-ga VSS provider. However, this is usually unnecessary because pre-compiled .tlb file is included. Signed-off-by: Tomoki Sekiyama Reviewed-by: Laszlo Ersek --- .gitignore |1 + Makefile |1 + configure | 69 3 files ch

[Qemu-devel] [PATCH v7 10/10] QMP/qemu-ga-client: Make timeout longer for guest-fsfreeze-freeze command

2013-07-15 Thread Tomoki Sekiyama
guest-fsfreeze-freeze command can take longer than 3 seconds when heavy disk I/O is running. To avoid unexpected timeout, this changes the timeout to 60 seconds (timeout of pre-commit phase of VSS). Signed-off-by: Tomoki Sekiyama Reviewed-by: Paolo Bonzini Reviewed-by: Laszlo Ersek --- QMP

[Qemu-devel] [PATCH v7 08/10] qemu-ga: Call Windows VSS requester in fsfreeze command handler

2013-07-15 Thread Tomoki Sekiyama
the VSS requester. Signed-off-by: Tomoki Sekiyama --- qga/Makefile.objs|1 qga/commands-win32.c | 82 +--- qga/vss-win32.c | 129 ++ qga/vss-win32.h | 24 + 4 files changed, 228 insertions

[Qemu-devel] [PATCH v7 06/10] error: Add error_set_win32 and error_setg_win32

2013-07-15 Thread Tomoki Sekiyama
These functions help maintaining homogeneous formatting of error messages with Windows error code and description (generated by g_win32_error_message()). Signed-off-by: Tomoki Sekiyama --- include/qapi/error.h | 13 + util/error.c | 35

[Qemu-devel] [PATCH v7 04/10] Add a script to extract VSS SDK headers on POSIX system

2013-07-15 Thread Tomoki Sekiyama
VSS SDK(*) setup.exe is only runnable on Windows. This adds a script to extract VSS SDK headers on POSIX-systems using msitools. * http://www.microsoft.com/en-us/download/details.aspx?id=23490 From: Paolo Bonzini Signed-off-by: Paolo Bonzini Signed-off-by: Tomoki Sekiyama Reviewed-by

[Qemu-devel] [PATCH v7 01/10] configure: Support configuring C++ compiler

2013-07-15 Thread Tomoki Sekiyama
+ services in qemu-guest-agent for Windows. Signed-off-by: Tomoki Sekiyama Reviewed-by: Laszlo Ersek --- configure | 13 + rules.mak |9 - 2 files changed, 21 insertions(+), 1 deletion(-) diff --git a/configure b/configure index cb0f870..6923b65 100755 --- a/configure

[Qemu-devel] [PATCH v7 09/10] qemu-ga: Install Windows VSS provider on `qemu-ga -s install'

2013-07-15 Thread Tomoki Sekiyama
Register QGA VSS provider library into Windows when qemu-ga is installed as Windows service ('-s install' option). It is deregistered when the service is uninstalled ('-s uninstall' option). Signed-off-by: Tomoki Sekiyama --- qga/main.c | 10 +- qg

[Qemu-devel] [PATCH v7 03/10] checkpatch.pl: Check .cpp files

2013-07-15 Thread Tomoki Sekiyama
method()) - : used in class declaration (e.g. class T : public Super) - ~ used in destructor method name (e.g. T::~T()) - spacing around 'catch'(e.g. catch (...)) Signed-off-by: Tomoki Sekiyama --- scripts/checkpatch.pl | 37 + 1

[Qemu-devel] [PATCH v7 02/10] Add c++ keywords to QAPI helper script

2013-07-15 Thread Tomoki Sekiyama
Add c++ keywords to avoid errors in compiling with c++ compiler. This also renames class member of PciDeviceInfo to q_class. Signed-off-by: Tomoki Sekiyama Reviewed-by: Laszlo Ersek --- hmp.c |2 +- hw/pci/pci.c|2 +- scripts/qapi.py | 12 +++- 3 files changed

[Qemu-devel] [PATCH v7 00/10] qemu-ga: fsfreeze on Windows using VSS

2013-07-15 Thread Tomoki Sekiyama
s-win32/qga-vss.{dll,tlb} - Install qemu-ga.exe, qga/vss-win32/qga-vss.{dll,tlb}, and the other required mingw libraries into the same directory in guests - Run `qemu-ga.exe -s install' and `net start qemu-ga' in the guests Any feedback are appreciated. --- Tomoki Sekiyama (10):

Re: [Qemu-devel] [PATCH v6 00/10] qemu-ga: fsfreeze on Windows using VSS

2013-07-15 Thread Tomoki Sekiyama
Hi Baiqing, Thank you for reporting the problem. I found a initialization issue for the Windows service thread in the v6 patch. The patch attached should fix the problem. I will submit the v7 patch including this soon. Thanks, Tomoki Sekiyama On 7/15/13 5:23 , "Libaiqing" wrote:

[Qemu-devel] [PATCH v6 05/10] qemu-ga: Add configure options to specify path to Windows/VSS SDK

2013-07-10 Thread Tomoki Sekiyama
qemu-ga VSS provider. However, this is usually unnecessary because pre-compiled .tlb file is included. Signed-off-by: Tomoki Sekiyama Reviewed-by: Laszlo Ersek --- .gitignore |1 + Makefile |1 + configure | 69 3 files ch

[Qemu-devel] [PATCH v6 01/10] configure: Support configuring C++ compiler

2013-07-10 Thread Tomoki Sekiyama
+ services in qemu-guest-agent for Windows. Signed-off-by: Tomoki Sekiyama Reviewed-by: Laszlo Ersek --- configure | 13 + rules.mak |9 - 2 files changed, 21 insertions(+), 1 deletion(-) diff --git a/configure b/configure index 0e0adde..687966e 100755 --- a/configure

[Qemu-devel] [PATCH v6 02/10] Add c++ keywords to QAPI helper script

2013-07-10 Thread Tomoki Sekiyama
Add c++ keywords to avoid errors in compiling with c++ compiler. This also renames class member of PciDeviceInfo to q_class. Signed-off-by: Tomoki Sekiyama Reviewed-by: Laszlo Ersek --- hmp.c |2 +- hw/pci/pci.c|2 +- scripts/qapi.py | 12 +++- 3 files changed

[Qemu-devel] [PATCH v6 04/10] Add a script to extract VSS SDK headers on POSIX system

2013-07-10 Thread Tomoki Sekiyama
VSS SDK(*) setup.exe is only runnable on Windows. This adds a script to extract VSS SDK headers on POSIX-systems using msitools. * http://www.microsoft.com/en-us/download/details.aspx?id=23490 From: Paolo Bonzini Signed-off-by: Paolo Bonzini Signed-off-by: Tomoki Sekiyama Reviewed-by

[Qemu-devel] [PATCH v6 09/10] qemu-ga: Install Windows VSS provider on `qemu-ga -s install'

2013-07-10 Thread Tomoki Sekiyama
Register QGA VSS provider library into Windows when qemu-ga is installed as Windows service ('-s install' option). It is deregistered when the service is uninstalled ('-s uninstall' option). Signed-off-by: Tomoki Sekiyama --- qga/main.c | 10 +- qg

[Qemu-devel] [PATCH v6 07/10] qemu-ga: Add Windows VSS provider and requester as DLL

2013-07-10 Thread Tomoki Sekiyama
atch, we just ignore this error. To solve this fundamentally, we need a framework to handle mount writable snapshot on guests, which is required by VSS auto-recovery feature (cleanup phase after a snapshot is taken). Signed-off-by: Tomoki Sekiyama --- Makefile|2 Makefile.

[Qemu-devel] [PATCH v6 06/10] error: Add error_set_win32 and error_setg_win32

2013-07-10 Thread Tomoki Sekiyama
These functions help maintaining homogeneous formatting of error messages with Windows error code and description (generated by g_win32_error_message()). Signed-off-by: Tomoki Sekiyama --- include/qapi/error.h | 13 + util/error.c | 35

[Qemu-devel] [PATCH v6 10/10] QMP/qemu-ga-client: Make timeout longer for guest-fsfreeze-freeze command

2013-07-10 Thread Tomoki Sekiyama
guest-fsfreeze-freeze command can take longer than 3 seconds when heavy disk I/O is running. To avoid unexpected timeout, this changes the timeout to 60 seconds (timeout of pre-commit phase of VSS). Signed-off-by: Tomoki Sekiyama Reviewed-by: Paolo Bonzini Reviewed-by: Laszlo Ersek --- QMP

[Qemu-devel] [PATCH v6 03/10] checkpatch.pl: Check .cpp files

2013-07-10 Thread Tomoki Sekiyama
method()) - : used in class declaration (e.g. class T : public Super) - ~ used in destructor method name (e.g. T::~T()) - spacing around 'catch'(e.g. catch (...)) Signed-off-by: Tomoki Sekiyama --- scripts/checkpatch.pl | 37 + 1

[Qemu-devel] [PATCH v6 08/10] qemu-ga: Call Windows VSS requester in fsfreeze command handler

2013-07-10 Thread Tomoki Sekiyama
the VSS requester. Signed-off-by: Tomoki Sekiyama --- qga/Makefile.objs|1 qga/commands-win32.c | 82 +--- qga/vss-win32.c | 129 ++ qga/vss-win32.h | 24 + 4 files changed, 228 insertions

  1   2   3   >