Re: [v2] tests/qtest: Add qtest for NPCM8XX PSPI module

2025-05-11 Thread Tim Lee
0, 8); +ssi_transfer(s->spi, data_l); +s->regs[R_PSPI_DATA] = (data_h | data_l); Peter Maydell 於 2025年5月11日 週日 下午9:58寫道: > > On Sun, 11 May 2025 at 14:47, Peter Maydell wrote: > > > > On Wed, 7 May 2025 at 10:19, Tim Lee wrote: > > > > >

Re: [v2] hw/arm/npcm8xx_boards: Add auto zero flash image and device part number

2025-05-08 Thread Tim Lee
Philippe Mathieu-Daudé 於 2025年5月8日 週四 下午2:19寫道: > > Hi Tim, > > On 8/5/25 04:15, Tim Lee wrote: > > Fix flash device part number to `mx66l1g45g` according image-bmc run on > > npcm8xx > > evb board (SPIFlash...SF: Detected mx66l1g45g, total 128 MiB) > > >

[v2] hw/arm/npcm8xx_boards: Add auto zero flash image and device part number

2025-05-07 Thread Tim Lee
: qemu-system-aarch64: mx66l1g45g device '/machine/unattached/device[73]' requires 134217728 bytes, mtd0 block backend provides 67108864 bytes Tested: Build passes and runs ./qemu-system-aarch64 -machine npcm845-evb normally Signed-off-by: Tim Lee --- Changes since v1: - Add a stat

[v2] tests/qtest: Add qtest for NPCM8XX PSPI module

2025-05-07 Thread Tim Lee
- Created qtest to check initialization of registers in PSPI Module - Implemented test into Build File Tested: ./build/tests/qtest/npcm8xx-pspi_test Signed-off-by: Tim Lee --- Changes since v1: - MAINTAINERS file not need to change - Add comment for copyright/license information - Correct CTL

Re: [PATCH] tests/qtest: Add qtest for NPCM8XX PSPI module

2025-05-07 Thread Tim Lee
Hi Peter, Thanks for your suggestion. Those changes will be included in v2. Peter Maydell 於 2025年5月6日 週二 下午8:52寫道: > > On Fri, 18 Apr 2025 at 10:12, Tim Lee wrote: > > > > - Created qtest to check initialization of registers in PSPI Module > > - Implemented test into B

Re: [PATCH] hw/arm/npcm8xx_boards: Add auto zero flash image and device part number

2025-05-05 Thread Tim Lee
// Handle writable storage if (blk_size < fiu->flash_size) { blk_get_perm(blk, &perm, &shared_perm); blk_set_perm(blk, BLK_PERM_ALL, BLK_PERM_ALL, &error_abort); blk_truncate(blk, fiu->flash_size, true, PREALLOC_MODE_OFF, BDRV_REQ_ZERO_WRITE, &error_abort); blk_set_perm(blk, perm, shared_perm, &error_abort); } } -- Best regards, Tim Lee

Re: [PATCH] tests/qtest: Add qtest for NPCM8XX PSPI module

2025-05-05 Thread Tim Lee
rtion failed > (pspi_read_ctl(qts, pspi) == CTL_SPIEN): (0x == 0x0001) > Bail out! > [I +0.037909] CLOSED > Aborted (core dumped) Thank you for testing it. I think the failure seems to be related to the following commit which, has not been merged yet. https://patchew.org/QEM

Re: [PATCH] hw/arm/npcm8xx_boards: Correct valid_cpu_types setting of NPCM8XX SoC

2025-05-04 Thread Tim Lee
to different ARMCPUInfo which could cause some features to not be applied correctly in specific initial functions: "cortex_a9_initfn" and "aarch64_a35_initfn". Sincerely, Tim Lee

[PATCH] hw/arm/npcm8xx_boards: Correct valid_cpu_types setting of NPCM8XX SoC

2025-04-27 Thread Tim Lee
NPCM8XX SoC is the successor of the NPCM7XX. It features quad-core Cortex-A35 (Armv8, 64-bit) CPUs and some additional peripherals. Correct the `valid_cpu_types` setting to match the NPCM8XX SoC. Signed-off-by: Tim Lee --- hw/arm/npcm8xx_boards.c | 2 +- 1 file changed, 1 insertion(+), 1

[PATCH] tests/qtest: Add qtest for NPCM8XX PSPI module

2025-04-18 Thread Tim Lee
- Created qtest to check initialization of registers in PSPI Module - Implemented test into Build File Tested: ./build/tests/qtest/npcm8xx-pspi_test Signed-off-by: Tim Lee --- MAINTAINERS | 1 + tests/qtest/meson.build | 3 + tests/qtest/npcm8xx_pspi-test.c

[PATCH] hw/arm: Attach PSPI module to NPCM8XX SoC

2025-04-13 Thread Tim Lee
Nuvoton's PSPI is a general purpose SPI module which enables connections to SPI-based peripheral devices. Attach it to the NPCM8XX. Tested: NPCM8XX PSPI driver probed successfully from dmesg log. Signed-off-by: Tim Lee --- hw/arm/npcm8xx.c | 11 ++- include/hw/arm/npcm

[PATCH] hw/arm/npcm8xx_boards: Add auto zero flash image and device part number

2025-04-05 Thread Tim Lee
: qemu-system-aarch64: mx66l1g45g device '/machine/unattached/device[73]' requires 134217728 bytes, mtd0 block backend provides 67108864 bytes Tested: Build passes and runs ./qemu-system-aarch64 -machine npcm845-evb normally Signed-off-by: Tim Lee --- hw/arm/npcm8xx_boa

Re: [PATCH v3 0/5] Generate x86 cpu features

2024-03-11 Thread Tim Wiederhake
On Tue, 2024-03-05 at 14:17 +, Daniel P. Berrangé wrote: > > On Tue, Feb 06, 2024 at 02:47:34PM +0100, Tim Wiederhake wrote: > > > > Synchronizing the list of cpu features and models with qemu is > > > > a > > > > recurring > > > > task in

Re: [PATCH v3 0/5] Generate x86 cpu features

2024-03-04 Thread Tim Wiederhake
ping On Tue, 2024-02-06 at 14:47 +0100, Tim Wiederhake wrote: > Synchronizing the list of cpu features and models with qemu is a > recurring > task in libvirt. For x86, this is done by reading qom-list-properties > for > max-x86_64-cpu and manually filtering out everthing that

[PATCH v3 1/5] target/i386: Split out feature_word_info

2024-02-06 Thread Tim Wiederhake
The isolated part will be generated by a script. Signed-off-by: Tim Wiederhake --- target/i386/cpu.c | 679 +--- target/i386/feature_word_info.c.inc | 678 +++ 2 files changed, 679 insertions(+), 678 deletions(-) create mode

[PATCH v3 4/5] target/i386: Fix feature_word_info.c.inc formatting

2024-02-06 Thread Tim Wiederhake
Make the formatting of the file more regular. This reduces the diff to the generated version. Signed-off-by: Tim Wiederhake --- target/i386/feature_word_info.c.inc | 136 ++-- 1 file changed, 86 insertions(+), 50 deletions(-) diff --git a/target/i386

[PATCH v3 2/5] target/i386: Translate feature_word_info to yaml

2024-02-06 Thread Tim Wiederhake
This is the data file that will be used to generate the C code. All information, including the comments, is preserved. Signed-off-by: Tim Wiederhake --- target/i386/feature_word_info.yaml | 699 + 1 file changed, 699 insertions(+) create mode 100644 target/i386

[PATCH v3 5/5] target/i386: Generate feature_word_info.c.inc

2024-02-06 Thread Tim Wiederhake
Signed-off-by: Tim Wiederhake --- target/i386/feature_word_info.c.inc | 30 ++-- target/i386/feature_word_info.py| 71 + target/i386/feature_word_info.yaml | 2 + 3 files changed, 99 insertions(+), 4 deletions(-) create mode 100755 target/i386

[PATCH v3 3/5] target/i386: Remove comments from feature_word_info.c.inc

2024-02-06 Thread Tim Wiederhake
The comments are preserved in the yaml file. Signed-off-by: Tim Wiederhake --- target/i386/feature_word_info.c.inc | 56 - 1 file changed, 15 insertions(+), 41 deletions(-) diff --git a/target/i386/feature_word_info.c.inc b/target/i386/feature_word_info.c.inc index

[PATCH v3 0/5] Generate x86 cpu features

2024-02-06 Thread Tim Wiederhake
ion. * Changes to the generator script reduce the changes in formatting to the current feature_word_info even further to address the concern about code legibility. See Patch 5, "target/i386: Generate feature_word_info.c.inc" for all non-whitespace changes. Tim Wiederhake (5): target/i386:

Qemu on mac os question

2024-01-18 Thread Tim Murphy
@8.1.4' doesn't work returning...   Error: No formulae or casks found for qemu@8.1.4. I'd be grateful for any help/direction you can give. Thanks, Tim

Re: [PATCH v2 00/10] Generate x86 cpu features

2023-09-15 Thread Tim Wiederhake
On Mon, 2023-09-11 at 13:26 +0200, Igor Mammedov wrote: > On Fri, 8 Sep 2023 17:55:12 +0100 > Daniel P. Berrangé wrote: > > > On Fri, Sep 08, 2023 at 04:48:46PM +0200, Igor Mammedov wrote: > > > On Fri,  8 Sep 2023 14:45:24 +0200 > > > Tim Wiederhake wrote: &

Re: [PATCH v2 03/10] target/i386: Fix duplicated feature name in FEAT_KVM

2023-09-15 Thread Tim Wiederhake
On Fri, 2023-09-08 at 16:21 +0200, Igor Mammedov wrote: > On Fri,  8 Sep 2023 14:45:27 +0200 > Tim Wiederhake wrote: > > > The mistake became apparent as there were two features with the > > same name > > in this cpuid leaf. The names are now in line with the >

[PATCH v2 05/10] target/i386: Translate feature_word_info to yaml

2023-09-08 Thread Tim Wiederhake
This is the data file that will be used to generate the C code. All information, including the comments, is preserved. Signed-off-by: Tim Wiederhake --- target/i386/feature_word_info.yaml | 695 + 1 file changed, 695 insertions(+) create mode 100644 target/i386

[PATCH v2 10/10] target/i386: Autogenerate feature_word_info.c.inc

2023-09-08 Thread Tim Wiederhake
This introduces no semantic changes to the file. Signed-off-by: Tim Wiederhake --- target/i386/feature_word_info.c.inc | 2 + target/i386/feature_word_info.py| 62 + target/i386/feature_word_info.yaml | 2 + 3 files changed, 66 insertions(+) create mode

[PATCH v2 08/10] target/i386: Format feature_word_info.c.inc: Unfold cpuid member

2023-09-08 Thread Tim Wiederhake
Having a consistent formatting minimizes the diff to the generated code. Signed-off-by: Tim Wiederhake --- target/i386/feature_word_info.c.inc | 101 +--- 1 file changed, 75 insertions(+), 26 deletions(-) diff --git a/target/i386/feature_word_info.c.inc b/target/i386

[PATCH v2 06/10] target/i386: Format feature_word_info.c.inc: Remove comments

2023-09-08 Thread Tim Wiederhake
The comments are preserved in the yaml file. Signed-off-by: Tim Wiederhake --- target/i386/feature_word_info.c.inc | 56 - 1 file changed, 15 insertions(+), 41 deletions(-) diff --git a/target/i386/feature_word_info.c.inc b/target/i386/feature_word_info.c.inc index

[PATCH v2 07/10] target/i386: Format feature_word_info.c.inc: Fill out feat_names

2023-09-08 Thread Tim Wiederhake
This member is an array of length 64. Initializing all entries in this array allows for some simplification in the generating code. Signed-off-by: Tim Wiederhake --- target/i386/feature_word_info.c.inc | 355 +++- 1 file changed, 351 insertions(+), 4 deletions(-) diff

[PATCH v2 09/10] target/i386: Format feature_word_info.c.inc: Whitespaces and trailing commas

2023-09-08 Thread Tim Wiederhake
Having a consistent formatting minimizes the diff to the generated code. Signed-off-by: Tim Wiederhake --- target/i386/feature_word_info.c.inc | 44 + 1 file changed, 13 insertions(+), 31 deletions(-) diff --git a/target/i386/feature_word_info.c.inc b/target/i386

[PATCH v2 04/10] target/i386: Split out feature_word_info

2023-09-08 Thread Tim Wiederhake
The isolated part will be generated by a script. Signed-off-by: Tim Wiederhake --- target/i386/cpu.c | 677 +--- target/i386/feature_word_info.c.inc | 676 +++ 2 files changed, 677 insertions(+), 676 deletions(-) create mode

[PATCH v2 00/10] Generate x86 cpu features

2023-09-08 Thread Tim Wiederhake
before merging. Tim Wiederhake (10): target/i386: Add missing feature names in FEAT_VMX_EPT_VPID_CAPS target/i386: Fix feature names in FEAT_VMX_EPT_VPID_CAPS target/i386: Fix duplicated feature name in FEAT_KVM target/i386: Split out feature_word_info target/i386: Translate

[PATCH v2 02/10] target/i386: Fix feature names in FEAT_VMX_EPT_VPID_CAPS

2023-09-08 Thread Tim Wiederhake
ned-off-by: Tim Wiederhake --- target/i386/cpu.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/target/i386/cpu.c b/target/i386/cpu.c index 7c2c48ac06..f10d343935 100644 --- a/target/i386/cpu.c +++ b/target/i386/cpu.c @@ -1322,8 +1322,8 @@ FeatureWordInfo feature

[PATCH v2 03/10] target/i386: Fix duplicated feature name in FEAT_KVM

2023-09-08 Thread Tim Wiederhake
The mistake became apparent as there were two features with the same name in this cpuid leaf. The names are now in line with the documentation from https://kernel.org/doc/html/latest/virt/kvm/x86/cpuid.html Fixes: 642258c6c7 ("kvm: add kvmclock to its second bit") Signed-off-by: Tim

[PATCH v2 01/10] target/i386: Add missing feature names in FEAT_VMX_EPT_VPID_CAPS

2023-09-08 Thread Tim Wiederhake
Add the missing feature names for two bits in the FEAT_VMX_EPT_VPID_CAPS cpuid leaf. "vmx-ept-uc" is currently unused, but "vmx-ept-wb" is enabled for multiple cpu models. Signed-off-by: Tim Wiederhake --- target/i386/cpu.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deleti

Re: [PATCH 3/3] target/i386: Fix duplicated feature name in FEAT_KVM

2023-08-25 Thread Tim Wiederhake
On Thu, 2023-08-24 at 17:12 +0200, Philippe Mathieu-Daudé wrote: > On 24/8/23 15:57, Tim Wiederhake wrote: > > The mistake became apparent as there were two features with the > > same name > > in this cpuid leaf. The names are now in line with the > > documentation from

[PATCH 2/3] target/i386: Fix feature names in FEAT_VMX_EPT_VPID_CAPS

2023-08-24 Thread Tim Wiederhake
ned-off-by: Tim Wiederhake --- target/i386/cpu.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/target/i386/cpu.c b/target/i386/cpu.c index e6b8c62b92..0b74d80371 100644 --- a/target/i386/cpu.c +++ b/target/i386/cpu.c @@ -1322,8 +1322,8 @@ FeatureWordInfo feature

[PATCH 1/3] target/i386: Add missing feature names in FEAT_VMX_EPT_VPID_CAPS

2023-08-24 Thread Tim Wiederhake
Add the missing feature names for two bits in the FEAT_VMX_EPT_VPID_CAPS cpuid leaf. "vmx-ept-uc" is currently unused, but "vmx-ept-wb" is enabled for multiple cpu models. Signed-off-by: Tim Wiederhake --- target/i386/cpu.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deleti

[PATCH 0/3] Fix some feature names for i386

2023-08-24 Thread Tim Wiederhake
Some feature names were missing, wrong, or duplicated in the feature_word_info table. See individual commits for details. This introduces some merge conflicts for https://lists.nongnu.org/archive/html/qemu-devel/2023-08/msg02005.html but that series might need to be reworked anyway. Regards, Tim

[PATCH 3/3] target/i386: Fix duplicated feature name in FEAT_KVM

2023-08-24 Thread Tim Wiederhake
The mistake became apparent as there were two features with the same name in this cpuid leaf. The names are now in line with the documentation from https://kernel.org/doc/html/latest/virt/kvm/x86/cpuid.html Signed-off-by: Tim Wiederhake --- target/i386/cpu.c | 2 +- 1 file changed, 1 insertion

Re: [PATCH 2/4] target/i386: Translate feature_word_info to xml

2023-08-21 Thread Tim Wiederhake
On Thu, 2023-08-17 at 12:07 +0100, Daniel P. Berrangé wrote: > On Fri, Aug 11, 2023 at 03:50:09PM +0200, Tim Wiederhake wrote: > > This is the data file that will be used to generate the C code. > > All information, including the comments, is preserved. > > > > Si

[PATCH 2/4] target/i386: Translate feature_word_info to xml

2023-08-11 Thread Tim Wiederhake
This is the data file that will be used to generate the C code. All information, including the comments, is preserved. Signed-off-by: Tim Wiederhake --- target/i386/feature_word_info.xml | 1607 + 1 file changed, 1607 insertions(+) create mode 100644 target/i386

[PATCH 4/4] target/i386: Autogenerate feature_word_info.c.inc

2023-08-11 Thread Tim Wiederhake
This introduces no semantic changes to the file. Signed-off-by: Tim Wiederhake --- target/i386/feature_word_info.c.inc | 2 + target/i386/feature_word_info.py| 110 target/i386/feature_word_info.xml | 3 + 3 files changed, 115 insertions(+) create mode

[PATCH 1/4] target/i386: Split out feature_word_info

2023-08-11 Thread Tim Wiederhake
The isolated part will be generated by a script. Signed-off-by: Tim Wiederhake --- target/i386/cpu.c | 677 +--- target/i386/feature_word_info.c.inc | 676 +++ 2 files changed, 677 insertions(+), 676 deletions(-) create mode

[PATCH 3/4] target/i386: Format feature_word_info.c.inc

2023-08-11 Thread Tim Wiederhake
Harmonize the formatting: Use trailing commas, fix indentation and empty line usage, define "cpuid" fields one per line, unwind index- assignment in arrays, and remove comments. The information in the comments is preserved in the xml file. Signed-off-by: Tim Wiederhake --- t

[PATCH 0/4] Generate x86 cpu features

2023-08-11 Thread Tim Wiederhake
information present in target/i386/cpu.c (`feature_word_info`) into an xml file and adds a script to generate the c code from this xml. A patch set to convert the cpu model data (`builtin_x86_defs`) in the same way will follow. Tim Wiederhake (4): target/i386: Split out feature_word_info target/i386

Re: [PATCH v2 RESEND] xen: Fix SEGV on domain disconnect

2023-04-26 Thread Tim Smith
them in my collection so maybe I'm misremembering. Tim

Re: [PATCH v2 RESEND] xen: Fix SEGV on domain disconnect

2023-04-24 Thread Tim Smith
On Mon, Apr 24, 2023 at 1:08 PM Mark Syms wrote: > > Copying in Tim who did the final phase of the changes. > > On Mon, 24 Apr 2023 at 11:32, Paul Durrant wrote: > > > > On 20/04/2023 12:02, mark.s...@citrix.com wrote: > > > From: Mark Syms > > &

[Bug 1920784] Re: qemu-system-ppc64le fails with kvm acceleration

2021-03-24 Thread Tim Gardner
** Also affects: glibc (Ubuntu Hirsute) Importance: Undecided Status: Invalid ** Also affects: qemu (Ubuntu Hirsute) Importance: Undecided Status: Invalid ** Also affects: linux (Ubuntu Hirsute) Importance: Undecided Assignee: Frank Heimes (fheimes) Status: In P

[PATCH] i386/cpu: Fix Icelake Server model number

2020-12-02 Thread Tim Wiederhake
See arch/x86/include/asm/intel-family.h in the Kernel: #define INTEL_FAM6_ICELAKE_X 0x6A Signed-off-by: Tim Wiederhake --- target/i386/cpu.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/target/i386/cpu.c b/target/i386/cpu.c index 5a8c96072e..67e3f92f98 100644

Domain backup file explodes on s3fs

2020-04-07 Thread Tim Haley
brary: libvirt 6.1.0 Using API: QEMU 6.1.0 Running hypervisor: QEMU 4.2.0 thanks for any ideas, -tim

[Qemu-devel] [Bug 1819343] Re: Qcow2 image stuck as locked after host crash

2019-03-18 Thread Tim Schuster
Yes, it would be v3, I'll use v4 then, thanks! -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1819343 Title: Qcow2 image stuck as locked after host crash Status in QEMU: New Bug description: A

[Qemu-devel] [Bug 1819343] Re: Qcow2 image stuck as locked after host crash

2019-03-18 Thread Tim Schuster
Hi, I used both the standard qemu package from the archlinux repositories as well as one I compiled myself with a few patches on top to improve audio performance. According to my logs, the compiled version used 2.28-4, I don't know what archlinux compiles them against. 2.28-5 is currently deploye

[Qemu-devel] [Bug 1819343] [NEW] Qcow2 image stuck as locked after host crash

2019-03-10 Thread Tim Schuster
Public bug reported: After a host crash, the qcow2 image of the VM, stored on a remote NFS share, has become inaccessible. Libvirt/QEMU reports that 'failed to get "write" lock\nIs another process using the image [/path/nfs/image.qcow2]?'. No process is accessing the image from either host or the

Re: [Qemu-devel] Very slow finding extents in QCOW2-backed nbd

2019-01-28 Thread Tim Smith
On Monday, 28 January 2019 14:41:35 GMT Vladimir Sementsov-Ogievskiy wrote: > 28.01.2019 14:58, Tim Smith wrote: > > > Hi all, I have a question about the intent of the last call to > > bdrv_co_block_status() in bdrv_co_block_status(), in block/io.c about > > line > &g

[Qemu-devel] Very slow finding extents in QCOW2-backed nbd

2019-01-28 Thread Tim Smith
ll removed, and the only discernable difference was that everything went a lot faster. So I'm wondering what the intent is for that code, and in what circumstances it is useful? -- Tim Smith

[Qemu-devel] [PATCH 1/3] Improve xen_disk batching behaviour

2018-11-02 Thread Tim Smith
amount proportional to the number which were already in flight at the time we started reading the ring. Signed-off-by: Tim Smith --- hw/block/xen_disk.c | 30 ++ 1 file changed, 30 insertions(+) diff --git a/hw/block/xen_disk.c b/hw/block/xen_disk.c index 36eff94f84

[Qemu-devel] [PATCH 2/3] Improve xen_disk response latency

2018-11-02 Thread Tim Smith
reads as soon as possible adds latency to the guest. To alleviate that, complete IO requests as soon as they come back. blk_send_response() already returns a value indicating whether a notify should be sent, which is all the batching we need. Signed-off-by: Tim Smith --- hw/block/xen_disk.c | 43

[Qemu-devel] [PATCH 3/3] Avoid repeated memory allocation in xen_disk

2018-11-02 Thread Tim Smith
BLKIF_MAX_SEGMENTS_PER_REQUEST pages (currently 11 pages) when the ioreq is created, and keep that allocation until it is destroyed. Since the ioreqs themselves are re-used via a free list, this should actually improve memory usage. Signed-off-by: Tim Smith --- hw/block/xen_disk.c | 11

[Qemu-devel] [PATCH 0/3] Performance improvements for xen_disk v2

2018-11-02 Thread Tim Smith
posix_memalign() reduced the dirty heap from 25MB to 5MB in the case of a single datapath process while also improving performance. v2 removes some checkpatch complaints and fixes the CCs --- Tim Smith (3): Improve xen_disk batching behaviour Improve xen_disk response latency Avoid

[Qemu-devel] [PATCH 3/3] Avoid repeated memory allocation in xen_disk

2018-11-02 Thread Tim Smith
BLKIF_MAX_SEGMENTS_PER_REQUEST pages (currently 11 pages) when the ioreq is created, and keep that allocation until it is destroyed. Since the ioreqs themselves are re-used via a free list, this should actually improve memory usage. Signed-off-by: Tim Smith --- hw/block/xen_disk.c | 10

[Qemu-devel] [PATCH 1/3] Improve xen_disk batching behaviour

2018-11-02 Thread Tim Smith
amount proportional to the number which were already in flight at the time we started reading the ring. Signed-off-by: Tim Smith --- hw/block/xen_disk.c | 29 + 1 file changed, 29 insertions(+) diff --git a/hw/block/xen_disk.c b/hw/block/xen_disk.c index 36eff94f84

[Qemu-devel] [PATCH 2/3] Improve xen_disk response latency

2018-11-02 Thread Tim Smith
reads as soon as possible adds latency to the guest. To alleviate that, complete IO requests as soon as they come back. blk_send_response() already returns a value indicating whether a notify should be sent, which is all the batching we need. Signed-off-by: Tim Smith --- hw/block/xen_disk.c | 43

[Qemu-devel] [PATCH 0/3] Performance improvements for xen_disk

2018-11-02 Thread Tim Smith
posix_memalign() reduced the dirty heap from 25MB to 5MB in the case of a single datapath process while also improving performance. --- Tim Smith (3): Improve xen_disk batching behaviour Improve xen_disk response latency Avoid repeated memory allocation in xen_disk hw/block

[Qemu-devel] [PATCH 2/3] Improve xen_disk response latency

2018-09-07 Thread Tim Smith
reads as soon as possible adds latency to the guest. To alleviate that, complete IO requests as soon as they come back. blk_send_response() already returns a value indicating whether a notify should be sent, which is all the batching we need. Signed-off-by: Tim Smith --- hw/block/xen_disk.c | 43

[Qemu-devel] [PATCH 3/3] Avoid repeated memory allocation in xen_disk

2018-09-07 Thread Tim Smith
BLKIF_MAX_SEGMENTS_PER_REQUEST pages (currently 11 pages) when the ioreq is created, and keep that allocation until it is destroyed. Since the ioreqs themselves are re-used via a free list, this should actually improve memory usage. Signed-off-by: Tim Smith --- hw/block/xen_disk.c | 10

[Qemu-devel] [PATCH 1/3] Improve xen_disk batching behaviour

2018-09-07 Thread Tim Smith
amount proportional to the number which were already in flight at the time we started reading the ring. Signed-off-by: Tim Smith --- hw/block/xen_disk.c | 29 + 1 file changed, 29 insertions(+) diff --git a/hw/block/xen_disk.c b/hw/block/xen_disk.c index 36eff94f84

Re: [Qemu-devel] [PATCH 1/2] target/openrisc: Implement EVBAR register

2017-04-26 Thread Tim Ansell
soc - Configured to match the default of minsoc (which is different to misoc) Thoughts? Tim 'mithro' Ansell On Apr 18, 2017 10:47 PM, "Stafford Horne" wrote: On Tue, Apr 18, 2017 at 04:15:50PM +1000, Tim 'mithro' Ansell wrote: > Exception Vector Base Address Regist

[Qemu-devel] [PATCH 2/2] target/openrisc: Implement EPH bit

2017-04-17 Thread Tim 'mithro' Ansell
, the vector offset is logically ORed with the offset 0xF000. This means if EPH is; * 0 - Exceptions vectors start at EVBAR * 1 - Exception vectors start at EVBAR | 0xF000 Signed-off-by: Tim 'mithro' Ansell --- target/openrisc/interrupt.c | 3 +++ 1 file changed, 3 insertions(+

[Qemu-devel] [PATCH 1/2] target/openrisc: Implement EVBAR register

2017-04-17 Thread Tim 'mithro' Ansell
ption Vector Base Address Register (EVBAR). Its presence is indicated by the EVBARP bit in the CPU Configuration Register (CPUCFGR). Signed-off-by: Tim 'mithro' Ansell --- target/openrisc/cpu.c| 2 ++ target/openrisc/cpu.h| 7 +++ target/openrisc/interrupt.c | 6

[Qemu-devel] [PATCH 0/2] targets/openrisc: Improve exception vectoring.

2017-04-17 Thread Tim 'mithro' Ansell
Hi, This patch series improves the exception vectoring on the OpenRISC platform by adding support for both the EVBAR register and EPH bit. This is my first patch to upstream QEMU, so please do point of if I have done anything silly. Tim 'mithro' Ansell (2): target/openrisc: Imple

[Qemu-devel] [PATCH] linux-user: Fix fork() and vfork()

2017-02-27 Thread Tim Hentenaar
A check was introduced in 5ea2fc84da1bffce749c9d0848f5336def2818bb which causes fork() and vfork() to fail if TARGET_SIGCHLD != SIGCHLD. Signed-off-by: Tim Hentenaar --- linux-user/syscall.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/linux-user/syscall.c b/linux

[Qemu-devel] Question regarding Snapshots

2017-02-22 Thread Tim Cusack
ked one day and next could not write to any snapshot, but could still load the base and work on it fine. This might be the wrong mailing list to post to, if so, could anyone point out a more appropriate one? Tim

[Qemu-devel] [Bug 1633508] [NEW] libvirt cannot hot insert interfaces to qemu

2016-10-14 Thread Tim Epkes
Public bug reported: When attempting to hot insert an interface using Ubuntu 16.04.1, I get the following $ virsh attach-interface --domain gluster1 --type direct \ > --source test0 --model virtio \ > --mac 2a:b6:b0:dc:c7:c4 --config --live error: Failed to attach interface error:

[Qemu-devel] [Bug 1587065] Re: btrfs qemu-ga - multiple mounts block fsfreeze

2016-08-28 Thread Tim Rose
: unable to execute QEMU agent command 'guest- fsfreeze-freeze': failed to freeze /: Device or resource busy Thank you Tim -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1587065 Title: btr

[Qemu-devel] forking a virtual machine

2016-07-26 Thread Tim Newsham
u VM? Are there any single-threaded variants of qemu that would work well here? Are there any interesting tricks to pause and resume a cpu across forks in a clean fashion? Has anyone else already worked on this problem? -- Tim Newsham | www.thenewsh.com/~newsham | @newshtwit | thenewsh.blogspot.com

Re: [Qemu-devel] qemu_chr_open_pipe

2016-04-28 Thread Tim Sander
strcmp matching the new device name. qemu-options.hx also seems to need some changes. Currently unclear is to me is how the argument parsing callback works and how serial_hds should be replaced by properties? Any pointers are welcome. Best regards Tim

[Qemu-devel] qemu_chr_open_pipe

2016-04-19 Thread Tim Sander
some usage examples. So dear qemu-hackers is this the recommended way to connect to serial devices within qemu and are there any examples available? Best regards Tim

[Qemu-devel] basic block tracing question

2016-03-19 Thread Tim Newsham
IT_REQUESTED here? What is causing execution to resume at "...285d" afterwards? Is there a simple way to filter out any extraneous basic blocks that get started midpoint (if that is the case) and keep the true basic block starts? Thank you in advance for any insights. -- Tim Newsham | www.thenewsh.com/~newsham | @newshtwit | thenewsh.blogspot.com

Re: [Qemu-devel] basic block tracing question

2016-03-18 Thread Tim Newsham
fused. > The default tracing will tell you when we chain TBs together so you > can sort of unconfuse yourself, but it's easier to just turn it off > if you care about the TB logging.) > I was not using "-d nochain". Thank you! > thanks > -- PMM > -- Tim Newsham | www.thenewsh.com/~newsham | @newshtwit | thenewsh.blogspot.com

[Qemu-devel] [PATCH v6] i2c-tiny-usb: a small usb to i2c bridge

2016-02-16 Thread Tim Sander
available named i2c-tiny-usb. + * + * Below is an example how to use this device from command line: + * -device usb-i2c-tiny,id=i2c-0 -device tmp105,bus=i2c,address=0x50 + * + * Copyright (c) 2015 Tim Sander + * + * Loosly based on usb dev-serial.c: + * Copyright (c) 2006 CodeSourcery

[Qemu-devel] [PATCH RESEND v5] i2c-tiny-usb is a small usb to i2c bridge

2016-02-11 Thread Tim Sander
/msg04237.html Here are some pointers to the old discussion: https://lists.gnu.org/archive/html/qemu-devel/2016-01/msg00111.html https://lists.gnu.org/archive/html/qemu-devel/2015-12/msg02634.html Best regards Tim i2c-tiny-usb is a small usb to i2c bridge: http://www.harbaum.org/till/i2c_tiny_usb

Re: [Qemu-devel] [PATCH v5] i2c-tiny-usb is a small usb to i2c bridge

2016-01-25 Thread Tim Sander
Hi This is my third attempt to send this patch to the list. The patch is unchanged but this time i have the qemu-devel mailing list included. Sorry for the noise. Tim i2c-tiny-usb is a small usb to i2c bridge: http://www.harbaum.org/till/i2c_tiny_usb/index.shtml It is pretty simple and has no

[Qemu-devel] [PATCH v5] i2c-tiny-usb is a small usb to i2c bridge

2016-01-22 Thread Tim Sander
,id=i2c-0 -device tmp105,bus=i2c,address=0x50 --- Signed-off-by: Tim Sander default-configs/usb.mak | 1 + hw/usb/Makefile.objs| 1 + hw/usb/dev-i2c-tiny.c | 314 trace-events| 11 ++ 4 files changed, 327 insertions(+) create

Re: [Qemu-devel] [PATCH] i2c-tiny-usb: add new usb to i2c bridge

2016-01-13 Thread Tim Sander
Hi Am Donnerstag, 7. Januar 2016, 02:14:23 schrieb Peter Crosthwaite: > Patch subject prefix should contain the version number. Use the > --subject-prefix or -v options to git format-patch. Ok, i will try to remember this next time. > > On Wed, Jan 6, 2016 at 6:58 AM, Tim S

[Qemu-devel] [PATCH] i2c-tiny-usb: add new usb to i2c bridge

2016-01-06 Thread Tim Sander
Version 4 with improvements suggested by Gerd Hoffmann: Signed-off-by: Tim Sander i2c-tiny-usb is a small usb to i2c bridge: http://www.harbaum.org/till/i2c_tiny_usb/index.shtml It is pretty simple and has no usb endpoints just a control. Reasons for adding this device: * Linux device driver

Re: [Qemu-devel] [PATCH] i2c-tiny-usb: add new usb to i2c bridge

2016-01-05 Thread Tim Sander
[0], data[1], data[2], > > data[3]); > > +if (i2c_start_transfer(s->i2cbus, /*address*/ index, 1)) { > > +trace_usb_i2c_tiny_i2c_start_transfer_failed(); > > +p->actual_length = 0; > > +break; > > +} > > Doesn't look like this request is unknown ... > > > +for (i = 0; i < length; i++) { > > +data[i] = i2c_recv(s->i2cbus); > > Can this fail? I think failure is just returning 255 as a value? AFAIK thats what real i2c hardware returns. Best regards Tim

[Qemu-devel] [PATCH] i2c-tiny-usb: add new usb to i2c bridge

2016-01-04 Thread Tim Sander
Version 3 with improvements suggested by Gerd Hoffmann Signed-off-by: Tim Sander i2c-tiny-usb is a small usb to i2c bridge

[Qemu-devel] [PATCH RFC] i2c: Add AT24Cxx EEPROM model

2015-12-17 Thread Tim Sander
this effort. Best regards Tim Original patch descriptions: Some devices react on multiple addresses. To emulate this, we could register them multiple times, but that is cumbersome. The AT24C16, e.g. listens on 8 different addresses. Instead, introduce a device address mask that is applied on the

[Qemu-devel] [PATCH] i2c-tiny-usb: add new usb to i2c bridge

2015-12-16 Thread Tim Sander
Signed-off-by: Tim Sander i2c-tiny-usb is a small usb to i2c bridge: http://www.harbaum.org/till/i2c_tiny_usb/index.shtml It is pretty simple and has no usb endpoints just a control. Reasons for adding this device: * Linux device driver available * adding an additional i2c bus via command line

Re: [Qemu-devel] qemu AT24Cxx

2015-12-10 Thread Tim Sander
could send your most recent state of this work this year i would appreciate it, as i have still some hours left this year. Best regards Tim

[Qemu-devel] qemu AT24Cxx

2015-12-10 Thread Tim Sander
Hi Jan I have seen your patches for AT24Cxx functionality in qemu: https://lists.gnu.org/archive/html/qemu-devel/2013-04/msg05714.html As i am interested in this work i am wondering what happend to this effort? Best regards Tim

[Qemu-devel] i2c data address question was Re: [PATCH RFC] i2c-tiny-usb

2015-12-09 Thread Tim Sander
Hi Paolo and List Am Freitag, 27. November 2015, 13:53:22 schrieb Paolo Bonzini: > On 27/11/2015 13:39, Tim Sander wrote: > > I have one more thing, i2cdetect looks like this: > > 0 1 2 3 4 5 6 7 8 9 a b c d e f > > > > 00: 03 04 05 06

[Qemu-devel] target i386 compile problem for hw/core/nmi.c

2015-11-27 Thread Tim Sander
defines and works from command line. The question is what needs to be done that inject_nmi gets compiled for the right context (configure --target-list=softmmu-i386) with the TARGET_I386 define enabled? Best regards Tim

Re: [Qemu-devel] [PATCH RFC] i2c-tiny-usb

2015-11-27 Thread Tim Sander
Hi Paolo Am Freitag, 27. November 2015, 10:32:25 schrieb Paolo Bonzini: > On 26/11/2015 17:35, Tim Sander wrote: > > Below is a patch implementing the i2c-tiny-usb device. > > I am currently not sure about the i2c semantics. I think > > incrementing the address on longer rea

Re: [Qemu-devel] [PATCH RFC] i2c-tiny-usb

2015-11-27 Thread Tim Sander
Am Freitag, 27. November 2015, 07:48:21 schrieb Gerd Hoffmann: > On Do, 2015-11-26 at 17:35 +0100, Tim Sander wrote: > > Hi > > > > Below is a patch implementing the i2c-tiny-usb device. > > Is there a specification for this kind of device? http://www.harbaum.org/ti

Re: [Qemu-devel] [PATCH RFC] i2c-tiny-usb

2015-11-27 Thread Tim Sander
Hi Alex Thanks for your feedback, answers as usual inline. Am Donnerstag, 26. November 2015, 18:07:35 schrieb Alex Bennée: > Tim Sander writes: > > Hi > > > > Below is a patch implementing the i2c-tiny-usb device. > > I am currently not sure about the i2c semantic

[Qemu-devel] [PATCH RFC] i2c-tiny-usb

2015-11-26 Thread Tim Sander
ossible to define i2c busses via command line e.g: -device usb-i2c-tiny,id=i2c-0 -device tmp105,bus=i2c,address=0x50 have been used for the first test. Best regards Tim --- default-configs/usb.mak | 1 + hw/usb/Makefile.objs| 1 + hw/usb/dev-i2c-tiny

Re: [Qemu-devel] i2c-tiny-usb noob question

2015-11-17 Thread Tim Sander
line option: -device usb-i2c-tiny,id=i2c-0 Now i would like to add child devices to this device instance. Unfortunatly i could not find out how to add e.g. the tmp105 sensor to this i2c-bus. It always apears on its own bus. Is this possible? Best regards Tim

Re: [Qemu-devel] i2c-tiny-usb noob question

2015-11-17 Thread Tim Sander
Hi Paolo Am Dienstag, 17. November 2015, 15:12:29 schrieb Paolo Bonzini: > On 17/11/2015 14:45, Tim Sander wrote: > > I just gave it a try and now i have a device which is detected by linux > > and > > allows simple reads (without i2c backend though). But unfortunatly i am &

Re: [Qemu-devel] i2c-tiny-usb noob question

2015-11-17 Thread Tim Sander
Hi Paolo Thanks for your reply. Am Dienstag, 17. November 2015, 15:12:29 schrieb Paolo Bonzini: > On 17/11/2015 14:45, Tim Sander wrote: > > I just gave it a try and now i have a device which is detected by linux > > and > > allows simple reads (without i2c backend though).

  1   2   3   >