Re: [Qemu-devel] i386: EFER vs 32-bit CPU

2019-05-30 Thread TeLeMan
On Wed, May 29, 2019 at 7:27 PM Pavel Dovgalyuk wrote: > > Hello! > > > > I found this while debugging the inconsistent saved/restored state of the > virtual machine. > > > > i386 (32 bit) emulation uses this register (in wrmsr and in MMU fault > processing). > > But it does not included in VMSt

Re: [Qemu-devel] [PULL 3/4] cputlb: Fix for self-modifying writes across page boundaries

2016-07-28 Thread TeLeMan
On Sat, Jul 9, 2016 at 4:38 AM, Richard Henderson wrote: > From: Samuel Damashek > > As it currently stands, QEMU does not properly handle self-modifying code > when the write is unaligned and crosses a page boundary. The procedure > for handling a write to the current translation block is to wri

Re: [Qemu-devel] flushing before updating pc.ram

2016-02-18 Thread TeLeMan
On Fri, Feb 19, 2016 at 12:53 AM, Egbert S. wrote: > I have here a case (over at GitHub unicorn-engine/unicorn > tests/unit/test_tb_x86.c) that is running a stack-based Alpha-Mixed sample > that contains an instruction that changed an operand of the next > instruction, the one that QEMU does not d

Re: [Qemu-devel] [PATCH] tcg/arm: improve direct jump

2015-12-10 Thread TeLeMan
On Thu, Dec 10, 2015 at 4:02 PM, Aurelien Jarno wrote: > Use ldr pc, [pc, #-4] kind of branch for direct jump. This removes the > need to flush the icache on TB linking, and allow to remove the limit > on the code generation buffer. > > Cc: Richard Henderson > Cc: TeLe

Re: [Qemu-devel] tcg: improve MAX_CODE_GEN_BUFFER_SIZE for arm

2015-12-08 Thread TeLeMan
On Tue, Dec 8, 2015 at 7:21 PM, Aurelien Jarno wrote: > On 2015-12-08 11:51, Laurent Desnogues wrote: >> Hello, >> >> On Tue, Dec 8, 2015 at 11:39 AM, Aurelien Jarno wrote: >> [...] >> > I already posted a patch a long time ago to remove the 16MB limit on ARM >> > hosts: >> > >> > http://lists.gn

[Qemu-devel] tcg: improve MAX_CODE_GEN_BUFFER_SIZE for arm

2015-12-07 Thread TeLeMan
I know MAX_CODE_GEN_BUFFER_SIZE is limited by the host direct branch instructions.But the arm's MAX_CODE_GEN_BUFFER_SIZE is so small.I tried improving MAX_CODE_GEN_BUFFER_SIZE.I wrote some check codes for the overflow offset in tcg_out_b(), tcg_out_bl(), tcg_out_blx_imm(),reloc_pc24(). But I didn't

Re: [Qemu-devel] [PATCH v2] target-i386: update fp status fix

2014-09-17 Thread TeLeMan
ing settings of the FPU and softfloat. > > v2 changes: > * Added missed calls and intoduced setter function (as suggested by TeLeMan) > > Reviewed-by: Paolo Bonzini > > Signed-off-by: Pavel Dovgalyuk > --- > target-i386/cpu.c|2 +- > target-i386/cpu.h

Re: [Qemu-devel] [PATCH] target-i386: update fp status fix

2014-09-15 Thread TeLeMan
I suggest using cpu_set_fpuc() like cpu_set_mxcsr(). On Tue, Sep 16, 2014 at 1:51 PM, TeLeMan wrote: > On Tue, Sep 16, 2014 at 1:42 PM, TeLeMan wrote: >> update_fp_status() should be used after all of env->fpuc changes : >> helper_fldcw(), helper_fninit(), helper_fldenv()

Re: [Qemu-devel] [PATCH] target-i386: update fp status fix

2014-09-15 Thread TeLeMan
On Tue, Sep 16, 2014 at 1:42 PM, TeLeMan wrote: > update_fp_status() should be used after all of env->fpuc changes : > helper_fldcw(), helper_fninit(), helper_fldenv() > ,helper_fxrstor(), helper_fsave(), x86_cpu_reset(), cpu_post_load(). missing one: x86_cpu_gdb_write_register().

Re: [Qemu-devel] [PATCH] target-i386: update fp status fix

2014-09-15 Thread TeLeMan
update_fp_status() should be used after all of env->fpuc changes : helper_fldcw(), helper_fninit(), helper_fldenv() ,helper_fxrstor(), helper_fsave(), x86_cpu_reset(), cpu_post_load(). On Mon, Sep 15, 2014 at 7:17 PM, Pavel Dovgalyuk wrote: > This patch adds calls to update_fp_status() function f

Re: [Qemu-devel] [PATCH] aio-win32: avoid out-of-bounds access to the events array

2014-09-15 Thread TeLeMan
ust move the event[ret - WAIT_OBJECT_0] > assignment inside the existin conditional. > > Reported-by: TeLeMan > Signed-off-by: Paolo Bonzini > --- > aio-win32.c | 4 +--- > 1 file changed, 1 insertion(+), 3 deletions(-) > > diff --git a/aio-win32.c b/aio-win32.c > index

Re: [Qemu-devel] [PATCH V5 1/6] icount: Add QemuOpts for icount

2014-09-15 Thread TeLeMan
On Fri, Jul 25, 2014 at 5:56 PM, Sebastian Tanase wrote: > Make icount parameter use QemuOpts style options in order > to easily add other suboptions. > > Signed-off-by: Sebastian Tanase > Tested-by: Camille Bégué > Signed-off-by: Paolo Bonzini > --- > cpus.c| 10 +- >

Re: [Qemu-devel] [PATCH 10/10] aio-win32: add support for sockets

2014-09-14 Thread TeLeMan
On Sat, Sep 13, 2014 at 6:33 PM, Paolo Bonzini wrote: > Il 13/09/2014 04:22, TeLeMan ha scritto: >> On Fri, Sep 12, 2014 at 6:05 PM, Paolo Bonzini wrote: >>> Il 12/09/2014 03:39, TeLeMan ha scritto: >>>> On Wed, Jul 9, 2014 at 5:53 PM, Paolo Bonzini wrote: >&g

Re: [Qemu-devel] [PATCH 10/10] aio-win32: add support for sockets

2014-09-12 Thread TeLeMan
On Fri, Sep 12, 2014 at 6:05 PM, Paolo Bonzini wrote: > Il 12/09/2014 03:39, TeLeMan ha scritto: >> On Wed, Jul 9, 2014 at 5:53 PM, Paolo Bonzini wrote: >>> diff --git a/aio-win32.c b/aio-win32.c >>> index 4542270..61e3d2d 100644 >>> --- a/aio-win32.c

Re: [Qemu-devel] [PATCH 10/10] aio-win32: add support for sockets

2014-09-11 Thread TeLeMan
On Wed, Jul 9, 2014 at 5:53 PM, Paolo Bonzini wrote: > Uses the same select/WSAEventSelect scheme as main-loop.c. > WSAEventSelect() is edge-triggered, so it cannot be used > directly, but it is still used as a way to exit from a > blocking g_poll(). > > Before g_poll() is called, we poll sockets

Re: [Qemu-devel] [PATCH 10/10] aio-win32: add support for sockets

2014-09-11 Thread TeLeMan
On Wed, Jul 9, 2014 at 5:53 PM, Paolo Bonzini wrote: > Uses the same select/WSAEventSelect scheme as main-loop.c. > WSAEventSelect() is edge-triggered, so it cannot be used > directly, but it is still used as a way to exit from a > blocking g_poll(). > > Before g_poll() is called, we poll sockets

Re: [Qemu-devel] FPU x86 instructions error

2013-05-26 Thread TeLeMan
On Sat, May 25, 2013 at 5:39 AM, Clemens Kolbitsch wrote: > Hi guys, > > we recently had an issue with running a program using FPU instructions > to obtain the current EIP (basically a weird way of "call 0; pop eax") > that was not working on QEMU (with TCG). > > Looking at the problem, we found t

Re: [Qemu-devel] [PATCH for-1.5 0/2] main-loop: fix slirp on win32

2013-05-16 Thread TeLeMan
On Thu, May 16, 2013 at 11:35 PM, Stefan Hajnoczi wrote: > User networking is broken on win32. These patches resolve the issues. > > TeLeMan and therock247uk: Please apply these patches and confirm that they fix > the bug. > > Paolo: Please let me know if you want to take A

Re: [Qemu-devel] [Bug 1179731] [NEW] is networking broken on windows hosts?

2013-05-16 Thread TeLeMan
On Thu, May 16, 2013 at 4:59 PM, Paolo Bonzini wrote: > Il 16/05/2013 07:52, TeLeMan ha scritto: >> The patch is working on 134a03e0b3d34b01b68107104c525c3bff1211d4 and >> is not working from cbff4b342b000a7642125dbdabf61113e05eee44. > > Thanks. > > Fabien or

Re: [Qemu-devel] [Bug 1179731] [NEW] is networking broken on windows hosts?

2013-05-15 Thread TeLeMan
The patch is working on 134a03e0b3d34b01b68107104c525c3bff1211d4 and is not working from cbff4b342b000a7642125dbdabf61113e05eee44. -- SUN OF A BEACH On Wed, May 15, 2013 at 4:37 PM, Paolo Bonzini wrote: > Il 15/05/2013 03:38, TeLeMan ha scritto: >> On Tue, May 14, 2013 at 7:55 PM, Paol

Re: [Qemu-devel] [Bug 1179731] [NEW] is networking broken on windows hosts?

2013-05-14 Thread TeLeMan
On Tue, May 14, 2013 at 7:55 PM, Paolo Bonzini wrote: > Il 14/05/2013 13:48, Paolo Bonzini ha scritto: >> Il 14/05/2013 13:39, TeLeMan ha scritto: >>> On Tue, May 14, 2013 at 6:46 PM, Paolo Bonzini wrote: >>>> Il 14/05/2013 12:24, TeLeMan ha scritto: >>>>

Re: [Qemu-devel] [Bug 1179731] [NEW] is networking broken on windows hosts?

2013-05-14 Thread TeLeMan
On Tue, May 14, 2013 at 6:46 PM, Paolo Bonzini wrote: > Il 14/05/2013 12:24, TeLeMan ha scritto: >> On Tue, May 14, 2013 at 3:51 PM, Stefan Hajnoczi wrote: >>> On Tue, May 14, 2013 at 12:02:24AM -, therock247uk wrote: >>>> just wondering as i just compiled the

Re: [Qemu-devel] [Bug 1179731] [NEW] is networking broken on windows hosts?

2013-05-14 Thread TeLeMan
On Tue, May 14, 2013 at 3:51 PM, Stefan Hajnoczi wrote: > On Tue, May 14, 2013 at 12:02:24AM -, therock247uk wrote: >> just wondering as i just compiled the latest git and qemu goes into none >> responding mode when i try to do any networking stuff on guests (both >> linux and windows) > > Wor

Re: [Qemu-devel] [PATCH] v6 revamp acpitable parsing and allow to specify complete (headerful) table

2013-01-17 Thread TeLeMan
On Thu, May 12, 2011 at 10:44 PM, Michael Tokarev wrote: > This patch almost rewrites acpi_table_add() function > (but still leaves it using old get_param_value() interface). > The result is that it's now possible to specify whole table > (together with a header) in an external file, instead of ju

Re: [Qemu-devel] [PATCH v2 1/5] compiler: support Darwin weak references

2012-11-04 Thread TeLeMan
On Fri, Nov 2, 2012 at 10:43 PM, Paolo Bonzini wrote: > Weakrefs only tell you if the symbol was defined elsewhere, so you > need a further check at runtime to pick the default definition > when needed. > > This could be automated by the compiler, but it does not do it. > > Signed-off-by: Paolo Bo

Re: [Qemu-devel] [PATCH] exec: fix breakpoint_invalidate() breakage

2012-05-24 Thread TeLeMan
On Fri, May 25, 2012 at 3:51 AM, Anthony Liguori wrote: > On 05/24/2012 02:42 PM, Stefan Weil wrote: >> >> Am 24.05.2012 20:36, schrieb Anthony Liguori: >>> >>> On 05/24/2012 01:12 PM, Stefan Weil wrote: This discussion looks strange for me. >>> >>> >>> I'm not going to commit patches wi

Re: [Qemu-devel] [PATCH] exec: fix breakpoint_invalidate() breakage

2012-05-23 Thread TeLeMan
On Thu, May 24, 2012 at 10:00 AM, Jan Kiszka wrote: > On 2012-05-23 22:29, TeLeMan wrote: >> On Thu, May 24, 2012 at 1:36 AM, Jan Kiszka wrote: >>> On 2012-05-23 13:02, Jan Kiszka wrote: >>>> On 2012-05-23 11:11, TeLeMan wrote: >>>>> On Wed, May

Re: [Qemu-devel] [PATCH] exec: fix breakpoint_invalidate() breakage

2012-05-23 Thread TeLeMan
12 at 3:41 AM, Andreas Färber >>>>  wrote: >>>>> >>>>> Am 18.05.2012 11:49, schrieb TeLeMan: >>>>>> >>>>>> This breakage was introduced by the commit "memory: make >>>>>> phys_page_find() return an u

Re: [Qemu-devel] [PATCH] exec: fix breakpoint_invalidate() breakage

2012-05-23 Thread TeLeMan
On Thu, May 24, 2012 at 1:36 AM, Jan Kiszka wrote: > On 2012-05-23 13:02, Jan Kiszka wrote: >> On 2012-05-23 11:11, TeLeMan wrote: >>> On Wed, May 23, 2012 at 7:22 PM, Jan Kiszka wrote: >>>> On 2012-05-23 04:09, TeLeMan wrote: >>>>> On Wed, Ma

Re: [Qemu-devel] [PATCH] exec: fix breakpoint_invalidate() breakage

2012-05-23 Thread TeLeMan
On Wed, May 23, 2012 at 7:22 PM, Jan Kiszka wrote: > On 2012-05-23 04:09, TeLeMan wrote: >> On Wed, May 23, 2012 at 11:41 AM, Andreas Färber wrote: >>> Am 18.05.2012 11:49, schrieb TeLeMan: >>>> This breakage was introduced by the commit "memory: make >>

Re: [Qemu-devel] [PATCH] exec: fix breakpoint_invalidate() breakage

2012-05-23 Thread TeLeMan
On Wed, May 23, 2012 at 11:41 AM, Andreas Färber wrote: > Am 18.05.2012 11:49, schrieb TeLeMan: >> This breakage was introduced by the commit "memory: make >> phys_page_find() return an unadjusted". > > You seem to have found the origin of your problem. If you al

Re: [Qemu-devel] [PATCH] exec: fix breakpoint_invalidate() breakage

2012-05-22 Thread TeLeMan
On Friday, May 18, 2012, TeLeMan wrote: > This breakage was introduced by the commit "memory: make > phys_page_find() return an unadjusted". > > Signed-off-by: TeLeMan > --- > exec.c |3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --

[Qemu-devel] [PATCH] exec: fix breakpoint_invalidate() breakage

2012-05-18 Thread TeLeMan
This breakage was introduced by the commit "memory: make phys_page_find() return an unadjusted". Signed-off-by: TeLeMan --- exec.c |3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/exec.c b/exec.c index 0607c9b..ad99476 100644 --- a/exec.c +++ b/exec.c @@ -1475

Re: [Qemu-devel] [PATCH 5/5] memory: get rid of cpu_register_io_memory()

2012-03-19 Thread TeLeMan
On Mon, Mar 19, 2012 at 17:16, Avi Kivity wrote: > On 03/19/2012 06:52 AM, TeLeMan wrote: >> >  static bool memory_region_wrong_endianness(MemoryRegion *mr) >> > @@ -942,7 +940,7 @@ void memory_region_init_io(MemoryRegion *mr, >> >     mr->opaque = opaqu

Re: [Qemu-devel] [PATCH 5/5] memory: get rid of cpu_register_io_memory()

2012-03-18 Thread TeLeMan
On Fri, Mar 9, 2012 at 01:20, Avi Kivity wrote: > The return value of cpu_register_io_memory() is no longer used anywhere, so > we can remove it and all associated data and code. > > Signed-off-by: Avi Kivity > --- >  cpu-all.h       |    8 --- >  exec-all.h      |    1 - >  exec-obsolete.h |

Re: [Qemu-devel] [MASCOT CONTEST] Clare Liguori #2

2012-02-15 Thread TeLeMan
+1 -- SUN OF A BEACH On Wed, Feb 15, 2012 at 22:46, Anthony Liguori wrote: > Please respond to this note with an '+1', or an Ack, to vote for this icon. >

Re: [Qemu-devel] [MASCOT CONTEST] Wei-Ren Chen #5

2012-02-15 Thread TeLeMan
+1 -- SUN OF A BEACH On Wed, Feb 15, 2012 at 22:40, Anthony Liguori wrote: > Please respond to this note with an '+1', or an Ack, to vote for this icon. >

Re: [Qemu-devel] [help]how to make qemu-img utility to support writting file or directory to the image file

2012-01-31 Thread TeLeMan
On Sun, Jan 29, 2012 at 17:02, 马磊 wrote: > Hi, >     qemu-img is only to support create/info and so on whithout writting > operation to the image file. >      I have ported the reading operation for a image file form grub2 to > qemu-img. But NTFS document online  is not detailed enough, how to do

Re: [Qemu-devel] add debugger command

2011-12-27 Thread TeLeMan
2011/12/28 Peter Cheung : > Hi, I am chinese too. Am I welcome to add some debug command to the qemu > internal debugger? I have some bad experiment before on other project, the > project owner is not willing to add feature by other people. I think you would be disappointed again. http://lists.gnu.

Re: [Qemu-devel] [PATCH v2] w32: Build windows and console executables

2011-12-25 Thread TeLeMan
On Fri, Dec 23, 2011 at 21:47, Stefan Weil wrote: > Am 23.12.2011 03:31, schrieb TeLeMan: > >> On Thu, Dec 22, 2011 at 18:20, Stefan Weil wrote: >>> >>> System emulation executables with SDL are typically windows >>> executables. Sometimes console executab

Re: [Qemu-devel] [PATCH v2] w32: Build windows and console executables

2011-12-22 Thread TeLeMan
On Thu, Dec 22, 2011 at 18:20, Stefan Weil wrote: > System emulation executables with SDL are typically windows > executables. Sometimes console executables are more useful, > so create both variants if linker option -mwindows was detected. > > v2: > This version uses QEMU_PROGW / QEMU_PROG instea

Re: [Qemu-devel] [PATCH] w32: Build windows and console executables

2011-12-22 Thread TeLeMan
On Thu, Dec 22, 2011 at 16:03, Stefan Weil wrote: > System emulation executables with SDL are typically windows > executables. Sometimes console executables are more useful, > so create both variants if linker option -mwindows was detected. > > Signed-off-by: Stefan Weil > --- >  Makefile.target

Re: [Qemu-devel] [PATCH] w32: QEMU applications with SDL are always GUI applications

2011-12-21 Thread TeLeMan
On Thu, Dec 22, 2011 at 14:45, Stefan Weil wrote: > Am 22.12.2011 02:50, schrieb TeLeMan: > >> SDL-1.3 removed the stdio-redirect feature, so we should ignore it. >> >> Blue Swirl, can you revert this commit? > > > I'd prefer to keep it. There are good reaso

Re: [Qemu-devel] [PATCH] w32: QEMU applications with SDL are always GUI applications

2011-12-21 Thread TeLeMan
-- SUN OF A BEACH On Mon, Dec 19, 2011 at 16:15, Stefan Weil wrote: > Am 19.12.2011 03:12, schrieb TeLeMan: > >> On Sat, Dec 17, 2011 at 07:12, Stefan Weil wrote: >>> >>> Am 16.12.2011 04:24, schrieb TeLeMan: >>> >>>> On Sun, Dec 4, 2011 at

Re: [Qemu-devel] [PATCH] w32: QEMU applications with SDL are always GUI applications

2011-12-19 Thread TeLeMan
On Mon, Dec 19, 2011 at 16:15, Stefan Weil wrote: > Am 19.12.2011 03:12, schrieb TeLeMan: > >> On Sat, Dec 17, 2011 at 07:12, Stefan Weil wrote: >>> >>> Am 16.12.2011 04:24, schrieb TeLeMan: >>> >>>> On Sun, Dec 4, 2011 at 05:32,

Re: [Qemu-devel] [PATCH] w32: QEMU applications with SDL are always GUI applications

2011-12-18 Thread TeLeMan
On Sat, Dec 17, 2011 at 07:12, Stefan Weil wrote: > Am 16.12.2011 04:24, schrieb TeLeMan: > >> On Sun, Dec 4, 2011 at 05:32, Stefan Weil wrote: >>> >>> Since commit 1d14ffa97eacd3cb722271eaf6f093038396eac4 (in 2005), >>> QEMU applications on W32 d

Re: [Qemu-devel] [PATCH] w32: QEMU applications with SDL are always GUI applications

2011-12-15 Thread TeLeMan
On Sun, Dec 4, 2011 at 05:32, Stefan Weil wrote: > Since commit 1d14ffa97eacd3cb722271eaf6f093038396eac4 (in 2005), > QEMU applications on W32 don't use the default SDL compiler flags: > > Instead of a GUI application, a console application is created. > > This has disadvantages (there is always a

Re: [Qemu-devel] [PATCH v3 03/13] qemu-timer: move common code to qemu_rearm_alarm_timer

2011-10-31 Thread TeLeMan
On Sat, Oct 22, 2011 at 00:26, Paolo Bonzini wrote: > Reviewed-by: Anthony Liguori > Signed-off-by: Paolo Bonzini > --- >  qemu-timer.c |  129 > -- >  1 files changed, 53 insertions(+), 76 deletions(-) > > diff --git a/qemu-timer.c b/qemu-

Re: [Qemu-devel] [PATCH] usb-hid: activate usb tablet / mouse after migration.

2011-10-16 Thread TeLeMan
On Thu, Oct 13, 2011 at 18:48, Gerd Hoffmann wrote: > On 10/13/11 04:09, TeLeMan wrote: >> >> On Wed, Oct 12, 2011 at 19:30, Gerd Hoffmann  wrote: >>> >>> qemu uses the ps/2 mouse by default.  The usb tablet (or mouse) is >>> activated as soon as q

Re: [Qemu-devel] [PATCH] usb-hid: activate usb tablet / mouse after migration.

2011-10-12 Thread TeLeMan
On Wed, Oct 12, 2011 at 19:30, Gerd Hoffmann wrote: > qemu uses the ps/2 mouse by default.  The usb tablet (or mouse) is > activated as soon as qemu sees some guest activity on the device, > i.e. polling for HID events.  That used to work fine for both fresh > boot and migration. It does not fix u

Re: [Qemu-devel] [PATCH 1/3] Don't use g_thread_get_initialized.

2011-09-21 Thread TeLeMan
On Wed, Sep 7, 2011 at 21:02, Gerd Hoffmann wrote: > Initialize glib threads unconditionally in main() instead > of using g_thread_get_initialized in the 9p code. > > Fixes a build failure on RHEL-5, which ships glib 2.12. > g_thread_get_initialized was added in 2.20. > > Signed-off-by: Gerd Hoffm

Re: [Qemu-devel] [PATCH] hid: vmstat fix

2011-09-18 Thread TeLeMan
On Thu, Sep 15, 2011 at 21:40, Gerd Hoffmann wrote: > On 09/14/11 09:59, Paolo Bonzini wrote: >> >> On 09/14/2011 09:40 AM, TeLeMan wrote: >>>>> >>>>> >> >>>>> >> The commit "usb/hid: add hid_pointer_activate, us

Re: [Qemu-devel] [PATCH] hid: vmstat fix

2011-09-14 Thread TeLeMan
On Wed, Sep 14, 2011 at 15:15, Paolo Bonzini wrote: > On 09/14/2011 05:03 AM, TeLeMan wrote: >> >> The commit "usb/hid: add hid_pointer_activate, use it" used >> HIDMouseState.mouse_grabbed in hid_pointer_activate(), so >> mouse_grabbed should be added

[Qemu-devel] [PATCH] hid: vmstat fix

2011-09-13 Thread TeLeMan
The commit "usb/hid: add hid_pointer_activate, use it" used HIDMouseState.mouse_grabbed in hid_pointer_activate(), so mouse_grabbed should be added into vmstat. Signed-off-by: TeLeMan --- hw/hid.c |3 ++- 1 files changed, 2 insertions(+), 1 deletions(-) diff --git a/hw/hid.c

Re: [Qemu-devel] [PATCH 0/7] Fix packing for MinGW with -mms-bitfields

2011-08-29 Thread TeLeMan
On Mon, Aug 29, 2011 at 13:01, Stefan Weil wrote: > Am 28.08.2011 23:43, schrieb Blue Swirl: >> >> On Sun, Aug 28, 2011 at 8:43 PM, Stefan Weil wrote: >>> >>> These patches fix the packing of structures which were affected by >>> the new compiler attribute -mms-bitfields (which is needed for glib

Re: [Qemu-devel] [PULL] slirp: Fix issues with -mms-bitfields

2011-08-25 Thread TeLeMan
On Thu, Aug 25, 2011 at 19:04, Jan Kiszka wrote: > On 2011-08-25 03:14, TeLeMan wrote: >> On Wed, Aug 24, 2011 at 17:11, Jan Kiszka wrote: >>> On 2011-08-23 12:49, TeLeMan wrote: >>>> On Sun, Aug 21, 2011 at 04:00, Stefan Weil wrote: >>>>

Re: [Qemu-devel] [PULL] slirp: Fix issues with -mms-bitfields

2011-08-24 Thread TeLeMan
On Wed, Aug 24, 2011 at 17:11, Jan Kiszka wrote: > On 2011-08-23 12:49, TeLeMan wrote: >> On Sun, Aug 21, 2011 at 04:00, Stefan Weil wrote: >>> Am 15.08.2011 08:39, schrieb Jan Kiszka: >>>> >>>> The following changes since commit >>>> 3b6ff

Re: [Qemu-devel] [PULL] slirp: Fix issues with -mms-bitfields

2011-08-23 Thread TeLeMan
On Sun, Aug 21, 2011 at 04:00, Stefan Weil wrote: > Am 15.08.2011 08:39, schrieb Jan Kiszka: >> >> The following changes since commit >> 3b6ffe50300f13240e1b46420ad05da1116df410: >> >> hw/scsi-bus.c: Fix use of uninitialised variable (2011-08-14 19:34:25 >> +) >> >> are available in the git re

Re: [Qemu-devel] [PATCH -V4 01/26] coroutine: add gthread dependency

2011-08-19 Thread TeLeMan
On Tue, Aug 9, 2011 at 01:03, Aneesh Kumar K.V wrote: > From: Stefan Hajnoczi > > Commit 1fc7bd4a86a2bfeafcec29445871eb97469a2699 removed the gthread and > gio dependency since qemu-ga did not require it.  Coroutines require > gthread, so add it back in. > > Signed-off-by: Stefan Hajnoczi > ---

Re: [Qemu-devel] Get execution trace and tcg fatal error!

2011-08-17 Thread TeLeMan
On Thu, Aug 18, 2011 at 12:14, shbi shb wrote: > Hi, > > I am new to QEMU and I need to get guest Windows instructions traceon Qemu. > I added the following codes to Qemu but I got tcg fatal error : > > 1- I added a helper function in helper.h : DEF_HELPER_1(get_trace, void, > i32) > 2- I added a

Re: [Qemu-devel] [PATCH 13/16] usb-hid: add hid_has_events()

2011-08-10 Thread TeLeMan
On Wed, Aug 10, 2011 at 23:17, Gerd Hoffmann wrote: >  Hi, > >>> - >>> -    /* Force poll routine to be run and grab input the first time.  */ >>> -    us->changed = 1; >> >> USB tablet does not work on the winxp guest. I think this code can't be >> removed. >> > > Attached patch should fix that.

Re: [Qemu-devel] [PATCH 13/16] usb-hid: add hid_has_events()

2011-08-08 Thread TeLeMan
On Thu, Aug 4, 2011 at 23:10, Gerd Hoffmann wrote: > Add hid_has_events function, use it to figure whenever there are pending > events instead of checking and updating USBHIDState->changed. > > Setting ->changed to 1 on init is removed, that should have absolutely > no effect as the initial state

Re: [Qemu-devel] 0.15.0-rc2 (any version past 0.14.1) having issues with SLIRP on Windows XP host

2011-08-05 Thread TeLeMan
On Sat, Aug 6, 2011 at 04:46, Blue Swirl wrote: > On Fri, Aug 5, 2011 at 8:09 PM, Kenneth Salerno > wrote: >> Hi, >> >> I'm not sure if any defaults (build or runtime) have changed since 0.14.1, >> but I can no longer get the following to work anymore for QEMU versions >> 0.15.0-rc2 or recent d

Re: [Qemu-devel] [PATCH 04/25] Add hard build dependency on glib

2011-08-01 Thread TeLeMan
This patch introduces "-mms-bitfields" cflag on MinGW but this cflag breaks gcc packed structures("__attribute__((packed))"). For example, slirp does not work on Win32.

Re: [Qemu-devel] [PATCH] console: Don't expose the the ui module's functions when the module is not available.

2011-07-25 Thread TeLeMan
On Tue, Jul 26, 2011 at 10:32, Anthony Liguori wrote: > On 07/25/2011 09:24 PM, TeLeMan wrote: >> >> If there is no sdl support, the implement of sdl_display_init() is missing >> and its declaration should not be exposed. >> vnc, cocoa, curses and other ui

[Qemu-devel] [PATCH] console: Don't expose the the ui module's functions when the module is not available.

2011-07-25 Thread TeLeMan
If there is no sdl support, the implement of sdl_display_init() is missing and its declaration should not be exposed. vnc, cocoa, curses and other ui modules are the same as sdl. Signed-off-by: TeLeMan --- console.h |9 - 1 files changed, 8 insertions(+), 1 deletions(-) diff --git

[Qemu-devel] [PATCH] monitor: fix build breakage with --disable-vnc

2011-07-25 Thread TeLeMan
The breakage was introduced by the commit 13661089810d3e59931f3e80d7cb541b99af7071 Signed-off-by: TeLeMan --- monitor.c |2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff --git a/monitor.c b/monitor.c index 92cdd05..52ae5f2 100644 --- a/monitor.c +++ b/monitor.c @@ -1200,10

Re: [Qemu-devel] [PATCH] qemu-char: fix the commit "qemu-char: Print strerror message on failure"

2011-07-25 Thread TeLeMan
Oh, Blue Swirl did it, please ignore this. -- SUN OF A BEACH On Mon, Jul 25, 2011 at 16:16, TeLeMan wrote: > The commit 6e1db57b2ac9025c2443c665a0d9e78748637b26 missed patching > qemu_chr_open_win_file(). > > Signed-off-by: TeLeMan > --- >  qemu-char.c |    8 +--- >

[Qemu-devel] [PATCH] qemu-char: fix the commit "qemu-char: Print strerror message on failure"

2011-07-25 Thread TeLeMan
The commit 6e1db57b2ac9025c2443c665a0d9e78748637b26 missed patching qemu_chr_open_win_file(). Signed-off-by: TeLeMan --- qemu-char.c |8 +--- 1 files changed, 5 insertions(+), 3 deletions(-) diff --git a/qemu-char.c b/qemu-char.c index dcf7065..ea7abfe 100644 --- a/qemu-char.c +++ b

Re: [Qemu-devel] "cpu-exec.c: avoid AREG0 use" breaks x86 emulation on x86-64

2011-06-30 Thread TeLeMan
On Fri, Jul 1, 2011 at 00:47, Jan Kiszka wrote: > Hi Blue, > > commit cea5f9a28f breaks here, just starting qemu without any > parameters: > > Starting program: qemu-system-x86_64 > [Thread debugging using libthread_db enabled] > > Program received signal SIGSEGV, Segmentation fault. > 0x7

Re: [Qemu-devel] [Qemu-trivial] [PATCH] fix MinGW compilation when --enable-vnc-jpeg is specified

2011-06-26 Thread TeLeMan
This patch breaks the compilation with --enable-vnc-png: CCui/vnc-enc-tight.o In file included from /usr/include/png.h:518, from ui/vnc-enc-tight.c:34: /usr/include/pngconf.h:371: error: expected '=', ',', ';', 'asm' or '__attribute__' before '.' token /usr/include/pngconf.h

Re: [Qemu-devel] [PATCH v7 3/4] piix_pci: optimize set irq path

2011-05-22 Thread TeLeMan
I did a patch for it. http://lists.gnu.org/archive/html/qemu-devel/2011-05/msg01239.html On Sun, May 22, 2011 at 20:24, Stefan Weil wrote: > > Hi, > > I got a regression report which was obviously caused by this commit: > > $ git bisect bad > ab431c283e7055bcd6fb622f212bb29e84a6a134 is the first

[Qemu-devel] [PATCH] piix_pci: fix piix3_set_irq_pic()

2011-05-16 Thread TeLeMan
If pic_irq is greater than 7, the irq level is always 0 on 32bits. Signed-off-by: TeLeMan --- hw/piix_pci.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/hw/piix_pci.c b/hw/piix_pci.c index 7f1c4cc..85a320e 100644 --- a/hw/piix_pci.c +++ b/hw/piix_pci.c @@ -312,7

Re: [Qemu-devel] [PATCH] Fix conversions from pointer to tcg_target_long

2011-04-13 Thread TeLeMan
On Sat, Apr 2, 2011 at 19:36, Stefan Weil wrote: > tcg_gen_exit_tb takes a parameter of type tcg_target_long, > so the type casts of pointer to long should be replaced by > type casts of pointer to tcg_target_long (suggested by Blue Swirl). > > These changes are needed for build environments where

Re: [Qemu-devel] Re: Windows 7 on pure qemu-0.14

2011-03-16 Thread TeLeMan
I tried. This issue should be associated with some IO device or bus. On 2011-03-16, Gleb Natapov wrote: > On Wed, Mar 16, 2011 at 06:49:27PM +0800, TeLeMan wrote: >> I have another problem: Windows 7 x86 setup hangs when "Setup Is >> Starting Windows". Any suggestions?

Re: [Qemu-devel] Re: Windows 7 on pure qemu-0.14

2011-03-16 Thread TeLeMan
I have another problem: Windows 7 x86 setup hangs when "Setup Is Starting Windows". Any suggestions?

Re: [Qemu-devel] [PATCH 28/37] Move debug exception handling out of cpu_exec

2011-03-07 Thread TeLeMan
On Mon, Mar 7, 2011 at 16:54, Jan Kiszka wrote: > On 2011-03-07 09:26, Jan Kiszka wrote: >> On 2011-03-07 02:52, TeLeMan wrote: >>> This patch breaks the support for x86 hardware breakpoints because >>> cpu_resume_from_signal() and raise_exception_env() are use

Re: [Qemu-devel] [PATCH 28/37] Move debug exception handling out of cpu_exec

2011-03-06 Thread TeLeMan
This patch breaks the support for x86 hardware breakpoints because cpu_resume_from_signal() and raise_exception_env() are used in breakpoint_handler().

[Qemu-devel] Re: [PATCH] raw-win32: Fix bdrv_flush return value

2011-01-28 Thread TeLeMan
Thanks, It works very well on win7 and winxp. -- SUN OF A BEACH On Fri, Jan 28, 2011 at 23:04, Kevin Wolf wrote: > Reported-by: TeLeMan > Signed-off-by: Kevin Wolf > --- > > Hi TeLeMan, > > this seems to be the bug that was exposed by the recent qcow2 cache changes. &g

Re: [Qemu-devel] [PATCH v5 0/3] qcow2 metadata cache

2011-01-28 Thread TeLeMan
Host: Win7 Guest: WinXP Reproduce: qemu-img create -f qcow2 winxp.qcow2 80G qemu -L pc-bios -m 256 -hda winxp.qcow2 -cdrom WXPVOL_EN.iso -boot d Error: An unexpected error (3073) occurred at line 5137 in d:\xp\client\base\boot\setup\setup.c I tried adding "-snapshot" into the command line, it wo

Re: [Qemu-devel] [PATCH v5 0/3] qcow2 metadata cache

2011-01-26 Thread TeLeMan
These patches break booting Windows.

[Qemu-devel] [PATCH] pci: fix pcibus_get_dev_path()

2011-01-20 Thread TeLeMan
The commit 6a7005d14b3c32d4864a718fb1cb19c789f58a5 used snprintf() incorrectly. Signed-off-by: TeLeMan --- hw/pci.c |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/hw/pci.c b/hw/pci.c index 8d0e3df..9f8800d 100644 --- a/hw/pci.c +++ b/hw/pci.c @@ -2050,14 +2050,14

Re: [Qemu-devel] [PATCH 4/4] target-xxx: Use fprintf_function (format checking)

2010-11-01 Thread TeLeMan
-- SUN OF A BEACH On Mon, Nov 1, 2010 at 15:05, Stefan Weil wrote: > Am 01.11.2010 03:24, schrieb TeLeMan: >> >> On Sat, Oct 23, 2010 at 05:03, Stefan Weil wrote: >>> >>>    int eflags, i, nb; >>> @@ -335,9 +333,11 @@

Re: [Qemu-devel] [PATCH 4/4] target-xxx: Use fprintf_function (format checking)

2010-10-31 Thread TeLeMan
On Sat, Oct 23, 2010 at 05:03, Stefan Weil wrote: >     int eflags, i, nb; > @@ -335,9 +333,11 @@ void cpu_dump_state(CPUState *env, FILE *f, >                     (uint32_t)env->cr[2], >                     (uint32_t)env->cr[3], >                     (uint32_t)env->cr[4]); > -        for(i = 0; i

Re: [Qemu-devel] [PATCH, RFT] mingw32: use ASLR, no-SEH and DEP if available

2010-09-28 Thread TeLeMan
GDB can not insert breakpoints on Windows Vista/7 because of the flag -dynamicbase. -- SUN OF A BEACH

Re: [Qemu-devel] debugging apic

2010-09-28 Thread TeLeMan
I reported this bug two year ago, but nobody cared. http://www.mail-archive.com/qemu-devel@nongnu.org/msg15330.html -- SUN OF A BEACH On Tue, Sep 28, 2010 at 23:15, Sam King wrote: > Hello, > > I am seeing a weird crash in my system and I am trying to figure out if it > is a software bug or a q

[Qemu-devel] [PATCH] vmstate: fix vmstate_load_state for subsections

2010-08-10 Thread TeLeMan
. I think vmstate subsections needs to be redesigned. Signed-off-by: TeLeMan --- savevm.c |8 +--- 1 files changed, 5 insertions(+), 3 deletions(-) diff --git a/savevm.c b/savevm.c index 2082b8c..feca8fa 100644 --- a/savevm.c +++ b/savevm.c @@ -1286,9 +1286,11 @@ int vmstate_load_state

[Qemu-devel] Re: [PATCH] vmstate: fix vmstate_subsection_load

2010-07-28 Thread TeLeMan
-- SUN OF A BEACH On Wed, Jul 28, 2010 at 20:32, Juan Quintela wrote: > TeLeMan wrote: >> On Wed, Jul 28, 2010 at 19:51, Juan Quintela wrote: >>> I hope this hepls to understand how subsections are supposed to work. >>> >>> Thanks for the comments, Jua

[Qemu-devel] Re: [PATCH] vmstate: fix vmstate_subsection_load

2010-07-28 Thread TeLeMan
On Wed, Jul 28, 2010 at 19:51, Juan Quintela wrote: > TeLeMan wrote: >> On Wed, Jul 28, 2010 at 18:43, Juan Quintela wrote: >>> TeLeMan wrote: >>>>  If the new version adds the new subsection for some vmstate, the old >>>> version will load the new ve

[Qemu-devel] Re: [PATCH] vmstate: fix vmstate_subsection_load

2010-07-28 Thread TeLeMan
On Wed, Jul 28, 2010 at 18:43, Juan Quintela wrote: > TeLeMan wrote: >>  If the new version adds the new subsection for some vmstate, the old >> version will load the new version's vmstate unsuccessfully. So we have >> to ignore the unrecognized subsections. > >

[Qemu-devel] [PATCH] vmstate: fix vmstate_subsection_load

2010-07-27 Thread TeLeMan
If the new version adds the new subsection for some vmstate, the old version will load the new version's vmstate unsuccessfully. So we have to ignore the unrecognized subsections. Signed-off-by: TeLeMan --- savevm.c | 11 +-- 1 files changed, 5 insertions(+), 6 deletions(-)

Re: [Qemu-devel] [PATCH 8/8] Rework debug exception processing for gdb use

2010-07-22 Thread TeLeMan
On Fri, Jun 25, 2010 at 22:56, Jan Kiszka wrote: > Guest debugging is currently broken under CONFIG_IOTHREAD. The reason is > inconsistent or even lacking signaling the debug events from the source > VCPU to the main loop and the gdbstub. > > This patch addresses the issue by pushing this signalin

[Qemu-devel] Re: [PATCH][RESEND] usb-uhci: fix commit 8e65b7c04965c8355e4ce43211582b6b83054e3d for vmstate

2010-06-04 Thread TeLeMan
no comments? On Tue, Jun 1, 2010 at 12:26, TeLeMan wrote: > The commit 8e65b7c04965c8355e4ce43211582b6b83054e3d introduced > expire_time of UHCIState. But expire_time is not in vmstate, the > second uhci_frame_timer will not be fired immediately after loadvm. > > Signed-

[Qemu-devel] [PATCH][RESEND] usb-uhci: fix commit 8e65b7c04965c8355e4ce43211582b6b83054e3d for vmstate

2010-05-31 Thread TeLeMan
The commit 8e65b7c04965c8355e4ce43211582b6b83054e3d introduced expire_time of UHCIState. But expire_time is not in vmstate, the second uhci_frame_timer will not be fired immediately after loadvm. Signed-off-by: TeLeMan --- hw/usb-uhci.c |3 ++- 1 files changed, 2 insertions(+), 1 deletions

[Qemu-devel] [PATCH v2] sdl: fix setenv for win32

2010-05-31 Thread TeLeMan
setenv() is not implemented on MinGW, so we have to use putenv(). Signed-off-by: TeLeMan --- sdl.c |7 +++ 1 files changed, 7 insertions(+), 0 deletions(-) diff --git a/sdl.c b/sdl.c index add1148..eac898a 100644 --- a/sdl.c +++ b/sdl.c @@ -850,7 +850,14 @@ void sdl_display_init

[Qemu-devel] [PATCH] usb-uhci: fix commit 8e65b7c04965c8355e4ce43211582b6b83054e3d for vmstate

2010-05-31 Thread TeLeMan
The commit 8e65b7c04965c8355e4ce43211582b6b83054e3d introduced expire_time of UHCIState. But expire_time is not in vmstate, the second uhci_frame_timer will not be fired immediately after loadvm. Signed-off-by: TeLeMan --- hw/usb-uhci.c |3 ++- 1 files changed,[PATCH] usb-uhci: fix commit

[Qemu-devel] [PATCH] sdl: fix setenv for win32

2010-05-24 Thread TeLeMan
setenv() is not implemented on MinGW, so we have to use putenv(). Signed-off-by: TeLeMan --- sdl.c |4 1 files changed, 4 insertions(+), 0 deletions(-) diff --git a/sdl.c b/sdl.c index add1148..eb4a87f 100644 --- a/sdl.c +++ b/sdl.c @@ -850,7 +850,11 @@ void sdl_display_init

[Qemu-devel] [PATCH][RESEND] vmstate: fix breakage by 7e72abc382b700a72549e8147bdea413534eeedc

2010-05-11 Thread TeLeMan
cirrus_post_load() will be executed twice when loading vm states and then the wrong physical memory will be registered. This issue may lead to crash qemu. Signed-off-by: TeLeMan --- hw/cirrus_vga.c |1 - 1 files changed, 0 insertions(+), 1 deletions(-) diff --git a/hw/cirrus_vga.c b/hw

Re: [Qemu-devel] [PATCH 2/3] Compile vl.c once

2010-05-03 Thread TeLeMan
This patch breaks cpu list("-cpu ?"). -- SUN OF A BEACH On Fri, Apr 16, 2010 at 03:08, Blue Swirl wrote: > Since kvm.h can be used in files compiled once, > we can partially revert > b33612d03540fda7fa67485f1c20395beb7a2bf0. > > Signed-off-by: Blue Swirl > --- >  Makefile.objs   |    2 +- >  

[Qemu-devel] [PATCH] fix chardev_init for win32

2010-04-14 Thread TeLeMan
chardev_init functions use socket,so socket_init() shoud be placed at the front of chardev_init on win32. Signed-off-by: TeLeMan --- vl.c |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/vl.c b/vl.c index 460e050..96835e2 100644 --- a/vl.c +++ b/vl.c @@ -3468,6

  1   2   >