[PATCH RESEND] firmware: qemu_fw_cfg: Do not hard depend on CONFIG_HAS_IOPORT_MAP

s. If CONFIG_HAS_IOPORT_MAP=n, qemu_fw_cfg is built without support for ioport based access. Signed-off-by: Fabian Vogt Signed-off-by: Takashi Iwai --- Resent, as the original submission seems overlooked: https://lore.kernel.org/2294036.elgaqsp...@linux-e202.suse.de/ The patch has been on openSUSE / SUSE ke

Re: [Qemu-devel] [PATCH] gtk: Keep the pointer within window during input grab

At Fri, 11 Apr 2014 15:07:34 +0200, Gerd Hoffmann wrote: > On Di, 2014-04-08 at 14:46 +0200, Takashi Iwai wrote: > > The current code shows annoying behavior where the X pointer can move > > out of the window during the input grab in the absolute mode. Due to > > this

[Qemu-devel] [PATCH] gtk: Keep the pointer within window during input grab

, this patch limits the pointer movement only within the qemu window during the input grab in the absolute mode. When the pointer goes out, it's moved back to the boundary again. Signed-off-by: Takashi Iwai --- ui/gtk.c | 51 ++- 1 file change

[Qemu-devel] [PATCH] gtk: Implement grab-on-click behavior in relative mode

even though it should have been switched in X11 input driver side. Signed-off-by: Takashi Iwai --- I tested a version with the internal implicit grab flag, but this simpler behavior is less-confusing in the end (and of course the code is simpler), so I took this version. ui/gtk.c | 19

Re: [Qemu-devel] [PATCH v3 4/4] gtk: Add "Grab On Click" option

; > On Mo, 2014-04-07 at 23:38 +0300, Michael S. Tsirkin wrote: > > > > > On Mon, Apr 07, 2014 at 10:07:43AM +0200, Gerd Hoffmann wrote: > > > > > > On Fr, 2014-04-04 at 12:41 +0200, Takashi Iwai wrote: > > > > > > > I simply like it better, yo

Re: [Qemu-devel] [PATCH v3 4/4] gtk: Add "Grab On Click" option

At Mon, 07 Apr 2014 10:07:43 +0200, Gerd Hoffmann wrote: > > On Fr, 2014-04-04 at 12:41 +0200, Takashi Iwai wrote: > > I simply like it better, you don't? :) > > I still think we should make this simply depend on absolute/relative > pointer mode instead of asking the

[Qemu-devel] [PATCH v3 0/4] Fix relative pointer tracking on Gtk UI

Hi, this is the revisited patch series. The only difference from v2 is that now they are checkpatch-clean and Cole's acks have been added to patches 1-3. Takashi

[Qemu-devel] [PATCH v3 2/4] gtk: Fix the relative pointer tracking mode

https://bugzilla.novell.com/show_bug.cgi?id=849587 Tested-by: Cole Robinson Reviewed-by: Cole Robinson Signed-off-by: Takashi Iwai --- ui/gtk.c | 18 +- 1 file changed, 9 insertions(+), 9 deletions(-) diff --git a/ui/gtk.c b/ui/gtk.c index c9f6d24eeb1a..913cc3f70c02 100644 --- a/ui/

[Qemu-devel] [PATCH v3 1/4] gtk: Use gtk generic event signal instead of motion-notify-event

is and pick the motion notify events manually there instead. Reference: https://bugzilla.novell.com/show_bug.cgi?id=849587 Tested-by: Cole Robinson Reviewed-by: Cole Robinson Signed-off-by: Takashi Iwai --- ui/gtk.c | 12 ++-- 1 file changed, 10 insertions(+), 2 deletions(-) diff --git

[Qemu-devel] [PATCH v3 3/4] gtk: Remember the last grabbed pointer position

Cole Robinson Signed-off-by: Takashi Iwai --- ui/gtk.c | 16 ++-- 1 file changed, 14 insertions(+), 2 deletions(-) diff --git a/ui/gtk.c b/ui/gtk.c index 913cc3f70c02..6668bd8226d5 100644 --- a/ui/gtk.c +++ b/ui/gtk.c @@ -159,6 +159,8 @@ typedef struct GtkDisplayState gboolean las

[Qemu-devel] [PATCH v3 4/4] gtk: Add "Grab On Click" option

I simply like it better, you don't? :) Signed-off-by: Takashi Iwai --- ui/gtk.c | 15 +++ 1 file changed, 15 insertions(+) diff --git a/ui/gtk.c b/ui/gtk.c index 6668bd8226d5..4427d9f6c1e9 100644 --- a/ui/gtk.c +++ b/ui/gtk.c @@ -141,6 +141,7 @@ typedef struct GtkDisplay

Re: [Qemu-devel] [PATCH] gtk: Grab pointer on click when in relative mode

At Wed, 02 Apr 2014 16:18:15 -0400, Cole Robinson wrote: > > On 04/02/2014 11:25 AM, Takashi Iwai wrote: > > At Wed, 02 Apr 2014 17:19:51 +0200, > > Gerd Hoffmann wrote: > >> > >> On Mi, 2014-04-02 at 11:07 -0400, Cole Robinson wrote: > >>> +

Re: [Qemu-devel] [PATCH v2 1/4] gtk: Use gtk generic event signal instead of motion-notify-event

At Wed, 02 Apr 2014 17:17:54 +0200, Gerd Hoffmann wrote: > > On Mi, 2014-04-02 at 14:32 +0200, Takashi Iwai wrote: > > +static gboolean gd_event(GtkWidget *widget, GdkEvent *event, void > > *opaque) > > +{ > > +if (event->type == GDK_MOTION_NOTIFY) > >

Re: [Qemu-devel] [PATCH] gtk: Grab pointer on click when in relative mode

At Wed, 02 Apr 2014 17:19:51 +0200, Gerd Hoffmann wrote: > > On Mi, 2014-04-02 at 11:07 -0400, Cole Robinson wrote: > > +if (button->button == 1 && > > +button->type == GDK_BUTTON_PRESS && > > +!gd_is_grab_active(s) && > > +!qemu_input_is_absolute()) { > > + > > gtk_che

Re: [Qemu-devel] [PATCH v2 4/4] gtk: Add "Grab On Click" option

At Wed, 02 Apr 2014 09:28:54 -0400, Cole Robinson wrote: > > On 04/02/2014 08:32 AM, Takashi Iwai wrote: > > I simply like it better, you don't? :) > > > > In fact, relative mouse mode is a pain without this feature, you need to > manually initiate a grab with

[Qemu-devel] [PATCH v2 2/4] gtk: Fix the relative pointer tracking mode

https://bugzilla.novell.com/show_bug.cgi?id=849587 Signed-off-by: Takashi Iwai --- ui/gtk.c | 18 +- 1 file changed, 9 insertions(+), 9 deletions(-) diff --git a/ui/gtk.c b/ui/gtk.c index 54b835428a28..c407fc8dd1a3 100644 --- a/ui/gtk.c +++ b/ui/gtk.c @@ -156,6 +156,7 @@ typedef s

[Qemu-devel] [PATCH v2 1/4] gtk: Use gtk generic event signal instead of motion-notify-event

is and pick the motion notify events manually there instead. Reference: https://bugzilla.novell.com/show_bug.cgi?id=849587 Signed-off-by: Takashi Iwai --- ui/gtk.c | 11 +-- 1 file changed, 9 insertions(+), 2 deletions(-) diff --git a/ui/gtk.c b/ui/gtk.c index f056e4034b3e..54b835428a28

[Qemu-devel] [PATCH v2 3/4] gtk: Remember the last grabbed pointer position

It's pretty annoying that the pointer reappears at a random place once after grabbing and ungrabbing the input. Better to restore to the original position where the pointer was grabbed. Reference: https://bugzilla.novell.com/show_bug.cgi?id=849587 Signed-off-by: Takashi Iwai --- ui/gtk.c

[Qemu-devel] [PATCH v2 0/4] Fix relative pointer tracking on Gtk UI (v2)

Hi, this is the renewed patch series, just rebased the previous ones on top of the current git tree. Below is the original description: *** Hi, this is a series of patches to fix / improve the behavior of Gtk UI in the relative pointer tracking mode. Most people didn't notice the bug likely

[Qemu-devel] [PATCH v2 4/4] gtk: Add "Grab On Click" option

I simply like it better, you don't? :) Signed-off-by: Takashi Iwai --- ui/gtk.c | 15 +++ 1 file changed, 15 insertions(+) diff --git a/ui/gtk.c b/ui/gtk.c index 9b8df1224fdb..ffaf91ea453a 100644 --- a/ui/gtk.c +++ b/ui/gtk.c @@ -141,6 +141,7 @@ typedef struct GtkDisplay

Re: [Qemu-devel] [PATCH 0/4] Fix relative pointer tracking on Gtk UI

At Tue, 01 Apr 2014 16:34:15 -0400, Cole Robinson wrote: > > On 02/13/2014 06:15 AM, Takashi Iwai wrote: > > Hi, > > > > this is a series of patches to fix / improve the behavior of Gtk UI > > in the relative pointer tracking mode. Most people didn't notice &g

[Qemu-devel] [PATCH 1/4] gtk: Use gtk generic event signal instead of motion-notify-event

is and pick the motion notify events manually there instead. Reference: https://bugzilla.novell.com/show_bug.cgi?id=849587 Signed-off-by: Takashi Iwai --- ui/gtk.c | 11 +-- 1 file changed, 9 insertions(+), 2 deletions(-) diff --git a/ui/gtk.c b/ui/gtk.c index a633d8934633..4d5ea8e6bb38

[Qemu-devel] [PATCH 0/4] Fix relative pointer tracking on Gtk UI

Hi, this is a series of patches to fix / improve the behavior of Gtk UI in the relative pointer tracking mode. Most people didn't notice the bug likely because it doesn't appear as long as the aboslute mode is used, e.g. when vmmouse input driver is enabled. But I hit this annoying behavior beca

[Qemu-devel] [PATCH 4/4] gtk: Add "Grab On Click" option

I simply like it better, you don't? :) Signed-off-by: Takashi Iwai --- ui/gtk.c | 15 +++ 1 file changed, 15 insertions(+) diff --git a/ui/gtk.c b/ui/gtk.c index e04f0781ae6c..4942c8330505 100644 --- a/ui/gtk.c +++ b/ui/gtk.c @@ -133,6 +133,7 @@ typedef struct GtkDisplay

[Qemu-devel] [PATCH 3/4] gtk: Remember the last grabbed pointer position

It's pretty annoying that the pointer reappears at a random place once after grabbing and ungrabbing the input. Better to restore to the original position where the pointer was grabbed. Reference: https://bugzilla.novell.com/show_bug.cgi?id=849587 Signed-off-by: Takashi Iwai --- ui/gtk.c

[Qemu-devel] [PATCH 2/4] gtk: Fix the relative pointer tracking mode

https://bugzilla.novell.com/show_bug.cgi?id=849587 Signed-off-by: Takashi Iwai --- ui/gtk.c | 18 +- 1 file changed, 9 insertions(+), 9 deletions(-) diff --git a/ui/gtk.c b/ui/gtk.c index 4d5ea8e6bb38..b72272ebac3f 100644 --- a/ui/gtk.c +++ b/ui/gtk.c @@ -148,6 +148,7 @@ typedef s

Re: [Qemu-devel] Wierd hack to sound/pci/intel8x0.c

At Mon, 07 Nov 2011 11:35:49 +0100, Gerd Hoffmann wrote: > > Hi, > > > We discuss Intel ICH/AC'97 (snd-intel8x0) here, but I hope that PCI SSID > > is same. > > Hmm, it's not, the ac97 emulation doesn't use the default qemu subsystem > id for some reason. Here is the entry: > > [root@fedora

Re: [Qemu-devel] Wierd hack to sound/pci/intel8x0.c

At Mon, 07 Nov 2011 10:25:24 +0100, Gerd Hoffmann wrote: > > Hi, > > > Agreed. If we can know the virtual device for KVM in a better way > > (e.g. any specific PCI SSID or such), we can narrow the condition more > > safely. > > PCI Subsystem ID 1af4:1100 is qemu/kvm (not only Intel HDA, most

Re: [Qemu-devel] Wierd hack to sound/pci/intel8x0.c

At Sun, 06 Nov 2011 18:31:42 +0200, Avi Kivity wrote: > > On 11/06/2011 06:15 PM, Denis V. Lunev wrote: > > On 11/6/11 6:51 PM, Avi Kivity wrote: > >> The recently merged 228cf79376f1 ("ALSA: intel8x0: Improve performance > >> in virtual environment") is hacky and somewhat wrong. > >> > >> First,

Re: [Qemu-devel] Wierd hack to sound/pci/intel8x0.c

At Sun, 6 Nov 2011 20:15:01 +0400, Denis V. Lunev wrote: > > On 11/6/11 6:51 PM, Avi Kivity wrote: > > The recently merged 228cf79376f1 ("ALSA: intel8x0: Improve performance > > in virtual environment") is hacky and somewhat wrong. > > > > First, the detection code > > > > + if (inside_vm<