Hi Paolo:
On 03/30/2016 08:48 PM, Paolo Bonzini wrote:
The missing check on dataplane_disabled caused a segmentation
fault in notify_guest_bh, because s->guest_notifier was NULL.
Signed-off-by: Paolo Bonzini
---
hw/block/dataplane/virtio-blk.c | 7 +++
hw/block/virtio-blk.c |
Hi Cornelia:
On 03/31/2016 10:43 AM, tu bo wrote:
Hi Cornelia:
I saw qemu crash for this patch on qemu master yesterday.
However, scsi disks of my lpar is not available because of s38 firmware
update. I'll double check the test when it's ready. thx
I still can see crash like be
703696) at util/coroutine-ucontext.c:78
#2 0x03ffa85d150a in __makecontext_ret () from /lib64/libc.so.6
On 03/30/2016 12:27 AM, Christian Borntraeger wrote:
On 03/29/2016 03:50 PM, Paolo Bonzini wrote:
On 29/03/2016 13:45, Cornelia Huck wrote:
Hi Tu Bo,
please always include the assertion
Hi Christian:
On 03/29/2016 07:54 PM, Christian Borntraeger wrote:
On 03/29/2016 11:14 AM, tu bo wrote:
Hi Paolo:
On 03/29/2016 02:11 AM, Paolo Bonzini wrote:
On 28/03/2016 05:55, TU BO wrote:
Hi Cornelia:
I got two crash with qemu master + "[PATCH 0/6] virtio: refactor host
noti
Hi Cornelia:
I saw qemu crash for this patch on qemu master yesterday.
However, scsi disks of my lpar is not available because of s38 firmware
update. I'll double check the test when it's ready. thx
On 03/29/2016 10:17 PM, Cornelia Huck wrote:
The ->set_host_notifier() callback is invoked w
Hi Christian:
On 03/30/2016 12:27 AM, Christian Borntraeger wrote:
On 03/29/2016 03:50 PM, Paolo Bonzini wrote:
On 29/03/2016 13:45, Cornelia Huck wrote:
Hi Tu Bo,
please always include the assertion patch at
https://lists.gnu.org/archive/html/qemu-block/2016-03/msg00546.html in
your tests
Hi Christian:
On 03/30/2016 12:31 AM, Christian Borntraeger wrote:
On 03/29/2016 03:42 PM, Michael S. Tsirkin wrote:
This works around races that data plane introduces
simply by exiting immediately if we detect
that dataplane is active.
It's a small but ugly patch, it's only justification
is t
Hi Paolo:
On 03/29/2016 02:11 AM, Paolo Bonzini wrote:
On 28/03/2016 05:55, TU BO wrote:
Hi Cornelia:
I got two crash with qemu master + "[PATCH 0/6] virtio: refactor host
notifiers",
Hi Tu Bo,
please always include the assertion patch at
https://lists.gnu.org/archive/html/qemu-
Hi Cornelia:
I got two crash with qemu master + "[PATCH 0/6] virtio: refactor host
notifiers",
I can get first crash very often.
(gdb) bt
#0 blk_aio_read_entry (opaque=0x0) at block/block-backend.c:922
#1 0x02aa17a65f0e in coroutine_trampoline (i0=,
i1=-1677713216) at util/coroutine-uco
we run into trouble if the event notifier is set from some
other path before the callbacks are set up properly?
The reentrancy check should catch that... But:
1) the patch really makes no difference, your fix is enough for me
Tu Bo, can you test with master + Cornelias 6 refactoring patches and no
Hi Fam:
On 03/21/2016 06:57 PM, Fam Zheng wrote:
On Thu, 03/17 19:03, tu bo wrote:
On 03/17/2016 08:39 AM, Fam Zheng wrote:
On Wed, 03/16 14:45, Paolo Bonzini wrote:
On 16/03/2016 14:38, Christian Borntraeger wrote:
If you just remove the calls to virtio_queue_host_notifier_read, here
On 16/3/18 下午11:03, Paolo Bonzini wrote:
On 17/03/2016 17:08, Christian Borntraeger wrote:
Good (or bad?) news is the assert also triggers on F23, it just seems
to take longer.
I guess good news, because we can rule out the kernel (not that I
believed it was a kernel problem, but the thought i
in)?
With these changes and patch 2-4 it does no longer locks up.
I keep it running some hour to check if a crash happens.
Tu Bo, your setup is currently better suited for reproducing. Can you also
check?
Great, I'll prepare a patch to virtio then sketching the solution that
Conny agreed
, does it work
(keeping patches 2-4 in)?
With these changes and patch 2-4 it does no longer locks up.
I keep it running some hour to check if a crash happens.
Tu Bo, your setup is currently better suited for reproducing. Can you also
check?
remove the calls to virtio_queue_host_notifier_read
On 03/15/2016 08:45 PM, Fam Zheng wrote:
On Fri, 03/11 11:28, Paolo Bonzini wrote:
On 10/03/2016 10:40, Christian Borntraeger wrote:
On 03/10/2016 10:03 AM, Christian Borntraeger wrote:
On 03/10/2016 02:51 AM, Fam Zheng wrote:
[...]
The aio_poll() inside "blk_set_aio_context(s->conf->conf
Using the latest qemu from master, and got a new qemu crash as below,
(gdb) bt
#0 0x03ffabb3b650 in raise () from /lib64/libc.so.6
#1 0x03ffabb3ced8 in abort () from /lib64/libc.so.6
#2 0x10384c30 in qemu_coroutine_enter (co=0x10a2ed40,
opaque=0x0) at util/qemu-coroutine.c:112
Hi Max:
On 12/02/2015 11:48 PM, Max Reitz wrote:
On 01.12.2015 08:35, tu bo wrote:
Hi Max:
在 2015/12/1 3:38, Max Reitz 写道:
On 26.11.2015 10:53, Bo Tu wrote:
From: Bo Tu
The tests for device type "ide_cd" should only be tested for the pc
platform.
The default device id of hard d
Hi Max:
On 11/25/2015 11:41 PM, Max Reitz wrote:
On 24.11.2015 22:17, Sascha Silbe wrote:
This PC/s390x-only hunk looks like an oversight to me.
Not really, see
http://lists.nongnu.org/archive/html/qemu-devel/2015-02/msg01906.html
and
http://lists.nongnu.org/archive/html/qemu-devel/2015-04/ms
Hi Max, Sascha:
On 11/21/2015 12:24 AM, Max Reitz wrote:
On 19.11.2015 08:28, tu bo wrote:
Hi Max:
On 11/19/2015 12:52 AM, Max Reitz wrote:
On 04.11.2015 03:26, Bo Tu wrote:
The tests for device type "ide_cd" should only be tested for the pc
platform.
The default device id of ha
Hi Fam, Max:
On 11/23/2015 10:33 AM, Fam Zheng wrote:
On Mon, 11/23 10:29, tu bo wrote:
Hi Max:
On 11/21/2015 12:17 AM, Max Reitz wrote:
On 20.11.2015 10:35, Fam Zheng wrote:
Otherwise, a window flashes on my desktop (built with SDL). Other
iotest cases have that.
Signed-off-by: Fam Zheng
Hi Max:
On 11/21/2015 12:17 AM, Max Reitz wrote:
On 20.11.2015 10:35, Fam Zheng wrote:
Otherwise, a window flashes on my desktop (built with SDL). Other
iotest cases have that.
Signed-off-by: Fam Zheng
---
tests/qemu-iotests/120 | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff -
Hi Max:
On 11/19/2015 12:52 AM, Max Reitz wrote:
On 04.11.2015 03:26, Bo Tu wrote:
The tests for device type "ide_cd" should only be tested for the pc
platform.
The default device id of hard disk on the s390 platform differs to that
of the x86 platform. A new variable device_id is defined and "
Hi Max:
On 11/19/2015 12:56 AM, Max Reitz wrote:
On 04.11.2015 03:26, Bo Tu wrote:
Ever since qemu-iotest 120 was introduced, its expected output didn't
include the output from the built-in VNC server:
QA output created by 120
Formatting 'TEST_DIR/t.IMGFMT', fmt=IMGFMT size=67108864
QMP_
Hi Max:
On 11/19/2015 12:45 AM, Max Reitz wrote:
On 04.11.2015 03:26, Bo Tu wrote:
Replacing sed with awk, then it's easier to read.
I think you meant "awk with sed".
It's my fault. thanks :-)
Replacing "[ ! -z "$default_alias_machine" ]" with
"[[ $default_alias_machine ]]", then it's s
Hi Eric:
thanks for your review.
On 10/31/2015 01:36 AM, Eric Blake wrote:
On 10/30/2015 01:13 AM, Bo Tu wrote:
Be easier to read, and be slightly shorter.
You mentioned a very short "what" in the subject line (good), but the
"why" in the commit body ("easier to read, shorter") is rather ters
vm 0 |\
+$QEMU $platform_parm -nographic -monitor stdio -serial none -hda
"$TEST_IMG" -loadvm 0 -machine accel=kvm |\
_filter_qemu
On 09/02/2015 05:13 PM, Christian Borntraeger wrote:
Am 20.08.2015 um 16:57 schrieb Alexander Graf:
On 20.08.15 01:20, tu bo wrote:
Hi Alex
emu-system-s390x
-nodefaults -nographic -monitor stdio -serial none -hda scratch/t.qcow2"
2. disable test case 068 for s390x
What's your opinion? thanks
On 08/20/2015 10:57 PM, Alexander Graf wrote:
On 20.08.15 01:20, tu bo wrote:
Hi Alex:
Ping you again just in case you did not g
Hi Alex:
Ping you again just in case you did not get my mail :-)
On 08/13/2015 03:52 PM, tu bo wrote:
Hi Alex:
I added one disk device for test case 068(qemu/tests/qemu-iotests/068,
which is for for loading a saved VM state from a qcow2 image ),
and got the same problem for s390-virtio-ccw
Max replied that ignoring the UTF-8 error for 130 patch reported by
checkpatch.pl is fine.
Could you please apply the series if there are no further objections.
thanks
On 07/03/2015 03:28 PM, Bo Tu wrote:
v11.
1. Add Reviewed-by of Sascha
2. Refine code change in common.config in order to be
I got one issue after running checkpatch.pl below,
[gavin@oc646435 qemu]$ ./scripts/checkpatch.pl
home/gavin/patch/v8/0007-qemu-iotests-s390x-fix-test-130.patch //
ERROR: Invalid UTF-8, patch and commit message should be encoded in
UTF-8//
#52: FILE: tests/qemu-iotests/130.out:12://
+(qemu)
Hi Thomas:
thanks a lot. I'll remove 'RFC' from the subject line and drop the
backslash according to Max's advice, and create v10.
On 05/28/2015 06:01 PM, Thomas Huth wrote:
Hi Tu Bo!
On Thu, 28 May 2015 12:29:57 +0800
tu bo wrote:
Hi Kevin:
On 05/26/2015 07:55
Hi Kevin:
On 05/26/2015 07:55 PM, Kevin Wolf wrote:
Am 25.05.2015 um 05:30 hat Bo Tu geschrieben:
Bo Tu (3):
qemu-iotests: s390x: fix test 049
qemu-iotests: s390x: fix test 051
qemu-iotests: s390x: fix test 130
Xiao Guang Chen (4):
qemu-iotests: qemu machine type support
qemu-io
Hi Kevin:
On 04/28/2015 04:23 PM, Kevin Wolf wrote:
Am 28.04.2015 um 04:59 hat tu bo geschrieben:
Hi Kevin:
On 04/27/2015 07:34 PM, Kevin Wolf wrote:
Am 27.04.2015 um 13:24 hat Max Reitz geschrieben:
On 27.04.2015 09:15, tu bo wrote:
Hi Max:
On 04
Dears,
Xiao Guang Chen left IBM last week, and I changed owner from XiangGuang
to me for this issue.
XiaoGuang told me this is by design, and probably I can close it if no
news. My understanding is that I can close it now. If I'm wrong, please
correct me. thanks a lot
From:Kevin Wol
Hi Kevin:
On 04/27/2015 07:34 PM, Kevin Wolf wrote:
Am 27.04.2015 um 13:24 hat Max Reitz geschrieben:
On 27.04.2015 09:15, tu bo wrote:
Hi Max:
On 04/24/2015 01:07 AM, Max Reitz wrote:
Well, that's a peculiar commit title. :-)
I guess it's supposed t
Hi Max:
On 04/24/2015 01:07 AM, Max Reitz wrote:
Well, that's a peculiar commit title. :-)
I guess it's supposed to be "qemu-iotests: s390x: fix test 130"?
You're right. I will change it in the next version :-)
On 23.04.2015 04:42, Xiao Guang Chen wrote:
From: Bo Tu
The tests for device t
Hi Max:
On 04/24/2015 01:00 AM, Max Reitz wrote:
On 23.04.2015 04:42, Xiao Guang Chen wrote:
The tests for device type "ide_cd" should only be tested for the pc
platform.
The default device id of hard disk on the s390 platform differs to that
of the x86 platform. A new variable device_id is de
Hello Max:
Xiao Guang Chen left IBM last week, and I took over this job. thanks for
your comments :-)
On 04/24/2015 12:47 AM, Max Reitz wrote:
On 23.04.2015 04:42, Xiao Guang Chen wrote:
From: Bo Tu
Hm, why is Bo Tu the patch author, but doesn't have an S-o-b in the
commit message?
I cre
38 matches
Mail list logo
