Hello,
Shall we commit this patch?
Very best,
Sylvain
> Le 22 avr. 2016 à 14:42, Sylvain Garrigues a
> écrit :
>
> As the framebuffer settings are copied into the result message before it is
> reconfigured, inconsistent behavior can happen when, for instance, you set
&g
Le 22 avr. 2016 à 13:44, Andrew Baumann a écrit :
> You got further on this than I did. I considered a couple of options, of
> varying complexity/compatibility:
>
> 0. The status quo: we support -kernel (for Linux images) and -bios (e.g.
> Windows), but otherwise all the options that can be set
Le 22 avr. 2016 à 13:30, Andrew Baumann a écrit :
> But I won't be merging this patch (hopefully Peter can do that?), so it's
> probably best if you make the tweak and resend with my Reviewed-by.
Made the tweak and resent the patch with your reviewed-by.
Have a good day.
, the reported pitch and size would be incorrect as they were
computed with the initial values of width, height and depth, not the ones the
client requested.
Signed-off-by: Sylvain Garrigues
Reviewed-by: Andrew Baumann
---
hw/misc/bcm2835_property.c | 31 ++-
1 file
Le 22 avr. 2016 à 13:22, Andrew Baumann a écrit :
>> +stl_le_phys(&s->dma_as, value + 16, tmp_xres * tmp_yres *
>> + (tmp_bpp >> 3));
>
> Personal style nit: I prefer * 8 rather than >> 3, because it's more
> immediately obvious what you're computing, a trivial optimisation for the
Le 21 avr. 2016 à 15:42, Peter Maydell a écrit :
>
> There may be something we can do here to make FreeBSD's life
> easier, but we definitely can't do it on the eve of a release.
I didn’t know it was release day, my timing is not perfect then, sorry about
that, I didn’t intend to put stress on
Le 21 avr. 2016 à 14:54, Peter Maydell a écrit :
> On 21 April 2016 at 13:50, Sylvain Garrigues
> wrote:
>> It does prevent FreeBSD to boot correctly.
>>
>> With that patch and
>> #define KERNEL_LOAD_ADDR 0x0020
>> in arm/boot/boot.c, official F
ter Maydell a écrit :
>
> On 21 April 2016 at 11:41, Sylvain Garrigues
> wrote:
>> As the framebuffer settings are copied into the result message before
>> it is reconfigured, inconsistent behavior can happen when, for instance,
>> you set with a sinle message the width,
, the reported pitch and size would be incorrect as they were
computed with the initial values of width, height and depth, not the ones the
client requested.
Signed-off-by: Sylvain Garrigues
---
hw/misc/bcm2835_property.c | 31 ++-
1 file changed, 22 insertions(+), 9
Signed-off-by: Sylvain Garrigues
---
hw/arm/boot.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/hw/arm/boot.c b/hw/arm/boot.c
index 5975fbf..5876945 100644
--- a/hw/arm/boot.c
+++ b/hw/arm/boot.c
@@ -68,7 +68,7 @@ static const ARMInsnFixup bootloader_aarch64
Signed-off-by: Sylvain Garrigues
Fix link register patch follows:
diff --git a/hw/arm/boot.c b/hw/arm/boot.c
index 5975fbf..5876945 100644
--- a/hw/arm/boot.c
+++ b/hw/arm/boot.c
@@ -68,7 +68,7 @@ static const ARMInsnFixup bootloader_aarch64[] = {
*/
static const ARMInsnFixup bootloader
11 matches
Mail list logo
