://lore.kernel.org/all/20250206051856.323651-1-suravee.suthikulpa...@amd.com)
* Add patch 1/2
Suravee Suthikulpanit (2):
hw/i386/amd_iommu: Isolate AMDVI-PCI from amd-iommu device to allow
full control over the PCI device creation
hw/i386/amd_iommu: Allow migration when explicitly create the
AMDVI
Add migration support for AMD IOMMU model by saving necessary AMDVIState
parameters for MMIO registers, device table, command buffer, and event
buffers.
Also change devtab_len type from size_t to uint64_t to avoid 32-bit build
issue.
Signed-off-by: Suravee Suthikulpanit
---
hw/i386/amd_iommu.c
n,xtsup=on,pci-id=iommupci0 \
For backward-compatibility, internally create the AMDVI-PCI device if not
specified on the CLI.
Co-developed-by: Daniel P. Berrangé
Reviewed-by: Daniel P. Berrangé
Signed-off-by: Suravee Suthikulpanit
---
hw/i386/acpi-build.c | 8 +++
hw/i386/amd_iommu.c |
the issue. This advertise the IOMMU as the AMD
IOMMU device for Family 15h (Models 10h-1fh).
Signed-off-by: Suravee Suthikulpanit
---
Changes from v1
(https://lore.kernel.org/all/20250304183747.639382-1-suravee.suthikulpa...@amd.com/)
* Use the existing device id 0x1419 instead of the proposed new
vendor id to Red Hat and request a new QEMU-specific
device id.
[1]
https://www.amd.com/content/dam/amd/en/documents/processor-tech-docs/specifications/48882_IOMMU.pdf
Cc: Gerd Hoffmann
Signed-off-by: Suravee Suthikulpanit
---
docs/specs/pci-ids.rst | 2 ++
hw/i386/amd_iommu.c| 3 ++-
include
-suravee.suthikulpa...@amd.com)
* Patch 1: Fix build error
* Patch 2: Fix 32-bit build issue.
Changes from v2:
(https://lore.kernel.org/all/20250206051856.323651-1-suravee.suthikulpa...@amd.com)
* Add patch 1/2
Suravee Suthikulpanit (2):
hw/i386/amd_iommu: Isolate AMDVI-PCI from amd-iommu
Add migration support for AMD IOMMU model by saving necessary AMDVIState
parameters for MMIO registers, device table, command buffer, and event
buffers.
Also change devtab_len type from size_t to uint64_t to avoid 32-bit build
issue.
Signed-off-by: Suravee Suthikulpanit
---
hw/i386/amd_iommu.c
nternally create the AMDVI-PCI device if not
specified on the CLI.
Co-developed-by: Daniel P. Berrangé
Signed-off-by: Suravee Suthikulpanit
---
hw/i386/acpi-build.c | 8 +++
hw/i386/amd_iommu.c | 52 +++-
hw/i386/amd_iommu.h | 3 ++-
3 files changed, 38
Add migration support for AMD IOMMU model by saving necessary AMDVIState
parameters for MMIO registers, device table, command buffer, and event
buffers.
Signed-off-by: Suravee Suthikulpanit
---
hw/i386/amd_iommu.c | 58 -
1 file changed, 52 insertions
-suravee.suthikulpa...@amd.com)
* Add patch 1/2
Suravee Suthikulpanit (2):
hw/i386/amd_iommu: Isolate AMDVI-PCI from amd-iommu device to allow
full control over the PCI device creation
hw/i386/amd_iommu: Allow migration when explicitly create the
AMDVI-PCI device
hw/i386/acpi-build.c
ate the AMDVI-PCI device if not
specified on the CLI.
Co-developed-by: Daniel P. Berrangé
Signed-off-by: Suravee Suthikulpanit
---
hw/i386/acpi-build.c | 8 +++
hw/i386/amd_iommu.c | 53 +++-
hw/i386/amd_iommu.h | 3 ++-
3 files changed, 39 insertions
Add migration support for AMD IOMMU model by saving necessary AMDVIState
parameters for MMIO registers, device table, command buffer, and event
buffers.
Signed-off-by: Suravee Suthikulpanit
---
Changes from v1:
(https://lore.kernel.org/all/9ecffa7a-f4c6-45a5-a066-84826ccb5...@amd.com/T
Add migration support for AMD IOMMU model by saving necessary AMDVIState
parameters for MMIO registers, device table, command buffer, and event
buffers.
Signed-off-by: Suravee Suthikulpanit
---
hw/i386/amd_iommu.c | 36 +++-
1 file changed, 35 insertions(+), 1
To use the newly introduced PC machine class local variable.
Suggedted-by: Igor Mammedov
Signed-off-by: Suravee Suthikulpanit
---
hw/i386/pc.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/hw/i386/pc.c b/hw/i386/pc.c
index 33ffb03a32..f8d105e829 100644
--- a/hw/i386/pc.c
with large number of vcpus.
"SMBIOS 2.1 table length 66822 exceeds 65535"
Signed-off-by: Suravee Suthikulpanit
---
hw/i386/pc.c | 4 +++-
hw/i386/pc_piix.c| 5 +
hw/i386/pc_q35.c | 5 +
include/hw/i386/pc.h | 1 +
4 files changed, 14 insertions(+), 1 deletio
:
(https://lore.kernel.org/qemu-devel/20230607024939.703991-1-suravee.suthikulpa...@amd.com/T/#m5a9f0d0e2355aebf81501355a1bf349a9929f4bb)
* Patch 1: Get rid of pc_machine_init_smbios() and simplify the logic
per Igor's suggestion.
* Patch 2: Added reviewed-by tag.
Thank you,
Suravee
Su
: kvm_get_vcpu failed (xxx): Invalid argument
Also, keep max_cpus at 288 for machine version 8.0 and older.
Cc: Igor Mammedov
Cc: Daniel P. Berrangé
Cc: Michael S. Tsirkin
Cc: Julia Suvorova
Reviewed-by: Igor Mammedov
Signed-off-by: Suravee Suthikulpanit
---
hw/i386/pc_q35.c | 3 ++-
1 file changed, 2
with large number of vcpus.
"SMBIOS 2.1 table length 66822 exceeds 65535"
Signed-off-by: Suravee Suthikulpanit
---
hw/i386/pc.c | 6 +-
hw/i386/pc_piix.c| 5 +
hw/i386/pc_q35.c | 5 +
include/hw/i386/pc.h | 1 +
4 files changed, 16 insertions(+), 1 deletio
here is no functional change.
Signed-off-by: Suravee Suthikulpanit
---
hw/i386/pc.c | 24 +++-
hw/i386/pc_piix.c | 9 -
hw/i386/pc_q35.c | 8
3 files changed, 23 insertions(+), 18 deletions(-)
diff --git a/hw/i386/pc.c b/hw/i386/pc.c
index bb62c994fa..
: kvm_get_vcpu failed (xxx): Invalid argument
Also, keep max_cpus at 288 for machine version 8.0 and older.
Cc: Igor Mammedov
Cc: Daniel P. Berrangé
Cc: Michael S. Tsirkin
Cc: Julia Suvorova
Signed-off-by: Suravee Suthikulpanit
---
hw/i386/pc_q35.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion
comment.
Changes from V2:
(https://lore.kernel.org/qemu-devel/20230531225127.331998-1-suravee.suthikulpa...@amd.com/)
* Add patch 1.
Changes from V1:
(https://lore.kernel.org/all/ynkdgsii1vfvx...@redhat.com/T/)
* Bump from 512 to KVM_MAX_VCPUS (per Igor's suggestion)
Thank you,
Suravee
Su
In preparation for subsequent code to upgrade default SMBIOS
entry point type. There is no functional change.
Signed-off-by: Suravee Suthikulpanit
---
hw/i386/pc.c | 12
hw/i386/pc_piix.c | 9 -
hw/i386/pc_q35.c | 8
3 files changed, 12 insertions(+), 17
-suravee.suthikulpa...@amd.com/)
* Add patch 1.
Changes from V1:
(https://lore.kernel.org/all/ynkdgsii1vfvx...@redhat.com/T/)
* Bump from 512 to KVM_MAX_VCPUS (per Igor's suggestion)
Thank you,
Suravee
Suravee Suthikulpanit (3):
hw/i386/pc: Refactor logic to set SMBIOS set defaults
hw/i3
with large number of vcpus.
"SMBIOS 2.1 table length 66822 exceeds 65535"
Note that user can still override the entry point tyme w/ QEMU option
"-M ..., smbios-entry-point-type=[32|64].
Signed-off-by: Suravee Suthikulpanit
---
hw/i386/pc.c | 14 +-
hw/i386/pc
: kvm_get_vcpu failed (xxx): Invalid argument
Cc: Igor Mammedov
Cc: Daniel P. Berrangé
Cc: Michael S. Tsirkin
Cc: Julia Suvorova
Signed-off-by: Suravee Suthikulpanit
---
hw/i386/pc_q35.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/hw/i386/pc_q35.c b/hw/i386/pc_q35.c
index
:
(https://lore.kernel.org/qemu-devel/20230531225127.331998-1-suravee.suthikulpa...@amd.com/)
* Add patch 1.
Changes from V1:
(https://lore.kernel.org/all/ynkdgsii1vfvx...@redhat.com/T/)
* Bump from 512 to KVM_MAX_VCPUS (per Igor's suggestion)
Thank you,
Suravee
Suravee Suthikulpanit (2):
: kvm_get_vcpu failed (xxx): Invalid argument
Cc: Igor Mammedov
Cc: Daniel P. Berrangé
Cc: Michael S. Tsirkin
Cc: Julia Suvorova
Signed-off-by: Suravee Suthikulpanit
---
hw/i386/pc_q35.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/hw/i386/pc_q35.c b/hw/i386/pc_q35.c
index
with large number of vcpus.
"SMBIOS 2.1 table length 66822 exceeds 65535"
Note that user can still override the entry point tyme w/ QEMU option
"-M ..., smbios-entry-point-type=[32|64].
Signed-off-by: Suravee Suthikulpanit
---
hw/i386/pc.c | 5 -
hw/i386/pc
: kvm_get_vcpu failed (xxx): Invalid argument
Signed-off-by: Suravee Suthikulpanit
---
Changes from V1:
(https://lore.kernel.org/all/ynkdgsii1vfvx...@redhat.com/T/)
* Bump from 512 to KVM_MAX_VCPUS (per Igor's suggestion)
Note:
From the last discussion, Daniel mentioned that SMBIO 2.1 tables might
On 5/20/22 12:26 PM, Chao Gao wrote:
On Fri, May 20, 2022 at 10:30:40AM +0700, Suthikulpanit, Suravee wrote:
Hi All,
Currently, we don't have a good way to check whether APICV is active on a VM.
Normally, For AMD SVM AVIC, users either have to check for trace point, or using
"perf kvm stat live
On 5/19/22 7:37 PM, Igor Mammedov wrote:
On Thu, 19 May 2022 13:53:49 +0700
Suravee Suthikulpanit wrote:
On 5/13/22 6:23 PM, Michael S. Tsirkin wrote:
On Mon, May 09, 2022 at 09:12:49AM +0200, Igor Mammedov wrote:
On Wed, 4 May 2022 08:16:39 -0500
Suravee Suthikulpanit wrote:
This
On 5/13/22 6:23 PM, Michael S. Tsirkin wrote:
On Mon, May 09, 2022 at 09:12:49AM +0200, Igor Mammedov wrote:
On Wed, 4 May 2022 08:16:39 -0500
Suravee Suthikulpanit wrote:
This is the maximum number of vCPU supported by
the AMD x2APIC virtualization.
Signed-off-by: Suravee Suthikulpanit
This is the maximum number of vCPU supported by
the AMD x2APIC virtualization.
Signed-off-by: Suravee Suthikulpanit
---
hw/i386/pc_q35.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/hw/i386/pc_q35.c b/hw/i386/pc_q35.c
index 302288342a..e82b1c690d 100644
--- a/hw/i386
Brijesh/Peter,
On 9/13/18 4:14 AM, Brijesh Singh wrote:
On 09/11/2018 11:52 PM, Peter Xu wrote:
...
diff --git a/hw/i386/acpi-build.c b/hw/i386/acpi-build.c
index 5c2c638..1cbc8ba 100644
--- a/hw/i386/acpi-build.c
+++ b/hw/i386/acpi-build.c
@@ -2565,7 +2565,8 @@ build_amd_iommu(GArray *tabl
Brijesh / Peter,
On 9/13/18 10:15 AM, Peter Xu wrote:
On Wed, Sep 12, 2018 at 01:59:06PM -0500, Brijesh Singh wrote:
[...]
}
return &iommu_as[devfn]->as;
}
@@ -1172,6 +1274,10 @@ static void amdvi_realize(DeviceState *dev, Error **err)
return;
}
+/* Pseu
defined in
Table 22 and Figure 17 from IOMMU spec.
Cc: "Michael S. Tsirkin"
Cc: Paolo Bonzini
Cc: Richard Henderson
Cc: Eduardo Habkost
Cc: Marcel Apfelbaum
Cc: Tom Lendacky
Cc: Suravee Suthikulpanit
Signed-off-by: Brijesh Singh
---
hw/i386/amd_iom
: "Michael S. Tsirkin"
Cc: Paolo Bonzini
Cc: Richard Henderson
Cc: Eduardo Habkost
Cc: Marcel Apfelbaum
Cc: Tom Lendacky
Cc: Suravee Suthikulpanit
Signed-off-by: Brijesh Singh
---
hw/i386/acpi-build.c | 3 ++-
hw/i386/amd_iommu.h | 2 +-
2 files changed, 3 insertions(+), 2
37 matches
Mail list logo