RE: [EXTERNAL] [PULL 08/15] whpx nvmm: Drop useless migrate_del_blocker()

2021-08-27 Thread Sunil Muthuswamy
> -Original Message- > From: Markus Armbruster > Sent: Thursday, August 26, 2021 9:51 PM > To: qemu-devel@nongnu.org > Cc: peter.mayd...@linaro.org; Sunil Muthuswamy ; > Kamil Rytarowski ; Reinoud Zandijk > ; Reinoud Zandijk ; Michael S . > Tsirkin > Subj

RE: [EXTERNAL] Re: [PATCH] WHPX: support for the kernel-irqchip on/off

2020-11-30 Thread Sunil Muthuswamy
> It's close enough to the release that you can resend (or if no rebasing > is needed, just tell me). > > Paolo Thank you. No rebasing needed; the same patch applies on the current master.

RE: [EXTERNAL] Re: [PATCH] WHPX: support for the kernel-irqchip on/off

2020-11-25 Thread Sunil Muthuswamy
> Sorry, this has missed the 5.2 soft freeze. Can you please resend it in > about a month? > > Thanks, > > Paolo Paolo, is the branch open now for this kind of change? Where can I track the branch status?

[PATCH] WHPX: Fix WHPX build break

2020-10-21 Thread Sunil Muthuswamy
. Signed-off-by: Sunil Muthuswamy --- meson.build | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/meson.build b/meson.build index 7627a0ae46..2d84e90495 100644 --- a/meson.build +++ b/meson.build @@ -198,7 +198,7 @@ else have_xen_pci_passthrough = false endif if not

RE: [EXTERNAL] Re: [PATCH] configure: Do not intent to build WHPX on 32-bit host

2020-09-09 Thread Sunil Muthuswamy
Signed-off-by: Sunil Muthuswamy > Am 09.09.20 um 20:40 schrieb Thomas Huth: > > > On 09/09/2020 20.24, Philippe Mathieu-Daudé wrote: > >> Hyper-V is available on 64-bit versions of Windows, > >> do not try to build its support on 32-bit versions. > >> >

RE: [PATCH] WHPX: vmware cpuid leaf for tsc and apic frequency

2020-08-31 Thread Sunil Muthuswamy
Can I please get some eyes on this? > -Original Message- > From: Sunil Muthuswamy > Sent: Thursday, July 30, 2020 3:11 PM > To: Paolo Bonzini ; Richard Henderson > ; Eduardo Habkost > Cc: qemu-devel@nongnu.org; Stefan Weil > Subject: [PATCH] WHPX: vmware cpuid

RE: [EXTERNAL] Re: [PATCH v2 0/3] testing: Build WHPX enabled binaries

2020-08-18 Thread Sunil Muthuswamy
> >> It's still shameful that MS is forcing developers to waste time > >> rewriting API headers, just because the MS legal departments are not > >> able to understand the needs of Open Source development. > > There has be a big switch from Microsoft toward Open Source, I attended > > some of there

RE: [EXTERNAL] Re: [PATCH v2 0/3] testing: Build WHPX enabled binaries

2020-07-31 Thread Sunil Muthuswamy
> Hi Justin, Sunil, Justin has moved to a different team is no longer working with WHPX. Moving him to bcc. > > On 5/20/20 12:26 PM, Philippe Mathieu-Daudé wrote: > > +launchpad ticket > > > > On 9/20/19 6:53 PM, Justin Terry (VM) wrote: > >> Hey Phil, > >> > >> I have contacted our legal depart

[PATCH] WHPX: vmware cpuid leaf for tsc and apic frequency

2020-07-30 Thread Sunil Muthuswamy
Newer versions of WHPX provide the capability to query the tsc and apic frequency. Expose these through the vmware cpuid leaf. This patch doesnt support setting the tsc frequency; that will come as a separate fix. Signed-off-by: Sunil Muthuswamy --- target/i386/whp-dispatch.h | 3 +- target

RE: [EXTERNAL] Re: qemu repo lockdown message for a WHPX PR

2020-07-30 Thread Sunil Muthuswamy
> > I was not referring to github pull requests, but rather to a maintainer > pull request. This is also sent to the mailing list. There is no > QEMU-specific documentation since maintainers are generally experienced > enough to have observed how these are sent, but the Linux documentation > mor

RE: [EXTERNAL] Re: qemu repo lockdown message for a WHPX PR

2020-07-29 Thread Sunil Muthuswamy
day, July 29, 2020 1:19 PM > To: Sunil Muthuswamy ; Paolo Bonzini > ; Peter Maydell > Cc: qemu-devel@nongnu.org > Subject: [EXTERNAL] Re: qemu repo lockdown message for a WHPX PR > > On 7/29/20 3:05 PM, Sunil Muthuswamy wrote: > > Adding Peter Maydell as well. > > &g

RE: qemu repo lockdown message for a WHPX PR

2020-07-29 Thread Sunil Muthuswamy
Adding Peter Maydell as well. > -Original Message- > From: Sunil Muthuswamy > Sent: Tuesday, July 28, 2020 12:20 PM > To: Paolo Bonzini > Cc: qemu-devel@nongnu.org > Subject: qemu repo lockdown message for a WHPX PR > > Hey Paolo, > > Following your sugge

qemu repo lockdown message for a WHPX PR

2020-07-28 Thread Sunil Muthuswamy
Hey Paolo, Following your suggestion of creating PRs for WHPX changes, I tried creating a PR https://github.com/qemu/qemu/pull/95 But, I am getting repo-lockdown message. What do I need to do differently? Thanks, Sunil

RE: [EXTERNAL] Re: PATCH] WHPX: TSC get and set should be dependent on VM state

2020-07-14 Thread Sunil Muthuswamy
> > > > Thanks. Ok, I am setup with GPG. Where should I be sending the pull > > requests to? Who is "Peter"? Do I have to send it to you? > > Peter is Peter Maydell, but for now you can send them to me. I'll get > round to documenting the remaining steps. > > Unfortunately all the scripts I hav

RE: [EXTERNAL] Re: [PATCH] WHPX: Assigning maintainer for Windows Hypervisor Platform

2020-05-19 Thread Sunil Muthuswamy
> -Original Message- > From: Stefan Weil > Sent: Thursday, February 20, 2020 11:54 PM > To: Justin Terry (SF) ; Philippe Mathieu-Daudé > ; Sunil Muthuswamy > ; Eduardo Habkost ; Paolo > Bonzini ; Richard > Henderson > Cc: qemu-devel@nongnu.org > Subj

RE: [EXTERNAL] Re: PATCH] WHPX: TSC get and set should be dependent on VM state

2020-03-04 Thread Sunil Muthuswamy
> -Original Message- > From: Paolo Bonzini On Behalf Of Paolo Bonzini > Sent: Tuesday, March 3, 2020 9:53 AM > To: Sunil Muthuswamy ; Richard Henderson > ; Eduardo Habkost > Cc: qemu-devel@nongnu.org; Stefan Weil > Subject: Re: [EXTERNAL] Re: PATCH] WHPX: TSC

RE: [PATCH] WHPX: Use proper synchronization primitives while processing

2020-03-02 Thread Sunil Muthuswamy
> -Original Message- > From: Sunil Muthuswamy > Sent: Monday, February 24, 2020 11:28 AM > To: Paolo Bonzini ; Richard Henderson > ; Eduardo Habkost > Cc: qemu-devel@nongnu.org; Stefan Weil ; Justin Terry (SF) > > Subject: [PATCH] WHPX: Use proper synchron

RE: [EXTERNAL] Re: PATCH] WHPX: TSC get and set should be dependent on VM state

2020-03-02 Thread Sunil Muthuswamy
> >> Looks good. Do you want me to queue this until you can have your GPG > >> key signed? (And also, I can help you sign it of course). > >> > > > > Yes, please. Thanks. > > > > I haven't used GPG keys before. What would I be using it for? > > You'd be using it to include a signed tags in a pul

RE: [EXTERNAL] Re: PATCH] WHPX: TSC get and set should be dependent on VM state

2020-02-28 Thread Sunil Muthuswamy
> -Original Message- > From: Paolo Bonzini > Sent: Friday, February 28, 2020 2:45 AM > To: Sunil Muthuswamy ; Richard Henderson > ; Eduardo Habkost > > Cc: qemu-devel@nongnu.org; Stefan Weil > Subject: [EXTERNAL] Re: PATCH] WHPX: TSC get and set should be

RE: [EXTERNAL] Re: [PATCH] WHPX: Use QEMU values for trapped CPUID

2020-02-27 Thread Sunil Muthuswamy
> -Original Message- > From: Eduardo Habkost > Sent: Thursday, February 27, 2020 1:10 PM > To: Sunil Muthuswamy > Cc: Paolo Bonzini ; Richard Henderson > ; qemu-devel@nongnu.org; Stefan Weil > > Subject: [EXTERNAL] Re: [PATCH] WHPX: Use QEMU values for trapped C

[PATCH] WHPX: Use QEMU values for trapped CPUID

2020-02-27 Thread Sunil Muthuswamy
or at runtime (i.e. after the partition has been setup). That is needed to be able to set the CPUID values in the hypervisor during VCPU init. Until that support comes, use the QEMU values for the trapped CPUIDs. Signed-off-by: Sunil Muthuswamy --- target/i386/whpx-all.c

PATCH] WHPX: TSC get and set should be dependent on VM state

2020-02-26 Thread Sunil Muthuswamy
TSC values as well that considers the VM state. Additionally, while setting the TSC, the partition is suspended to reduce the variance in the TSC value across vCPUs. Signed-off-by: Sunil Muthuswamy --- include/sysemu/whpx.h | 7 +++ target/i386/whp-dispatch.h | 9 target/i386/whpx

RE: [EXTERNAL] Re: [PATCH] WHPX: Assigning maintainer for Windows Hypervisor Platform

2020-02-24 Thread Sunil Muthuswamy
> -Original Message- > From: Stefan Weil > Sent: Thursday, February 20, 2020 11:54 PM > To: Justin Terry (SF) ; Philippe Mathieu-Daudé > ; Sunil Muthuswamy > ; Eduardo Habkost ; Paolo > Bonzini ; Richard Henderson > > Cc: qemu-devel@nongnu.org > Subject: R

[PATCH] WHPX: Use proper synchronization primitives while processing

2020-02-24 Thread Sunil Muthuswamy
WHPX wasn't using the proper synchronization primitives while processing async events, which can cause issues with SMP. Signed-off-by: Sunil Muthuswamy --- target/i386/whpx-all.c | 17 +++-- 1 file changed, 7 insertions(+), 10 deletions(-) diff --git a/target/i386/whpx-al

[PATCH] WHPX: Assigning maintainer for Windows Hypervisor Platform

2020-02-18 Thread Sunil Muthuswamy
Signed-off-by: Sunil Muthuswamy --- MAINTAINERS | 8 1 file changed, 8 insertions(+) diff --git a/MAINTAINERS b/MAINTAINERS index 1740a4fddc..9b3ba4e1b5 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -404,6 +404,14 @@ S: Supported F: target/i386/kvm.c F: scripts/kvm/vmxcap +WHPX

[PATCH V2] WHPX: refactor load library

2019-11-13 Thread Sunil Muthuswamy
This refactors the load library of WHV libraries to make it more modular. It makes a helper routine that can be called on demand. This allows future expansion of load library/functions to support functionality that is dependent on some feature being available. Signed-off-by: Sunil Muthuswamy

RE: [PATCH] WHPX: refactor load library

2019-11-13 Thread Sunil Muthuswamy
> Making it easier for other people to test WHPX would be nice. Yes, we understand the concerns and I generally agree here. I am trying to connect the different teams involved here (legal, SDK here) and connect the dots for them, to see what can be done here. > But in case this is not sorted ou

RE: [PATCH] WHPX: refactor load library

2019-11-13 Thread Sunil Muthuswamy
> Can we wait for approval from the Microsoft legal department first? > So we can start testing WHPX builds, and reduce the possibilities to > introduce regressions. > > Testing is ready, we are waiting for Microsoft to merge, see: > https://nam06.safelinks.protection.outlook.com/?url=https%3A%

RE: [PATCH] WHPX: refactor load library

2019-11-13 Thread Sunil Muthuswamy
> -Original Message- > From: Paolo Bonzini > Sent: Wednesday, November 13, 2019 7:00 AM > To: Sunil Muthuswamy ; Richard Henderson > ; Eduardo Habkost ; > Stefan Weil > Cc: qemu-devel@nongnu.org; Justin Terry (VM) > Subject: Re: [PATCH] WHPX: refactor load lib

RE: [PATCH v2] WHPX: support for xcr0

2019-11-12 Thread Sunil Muthuswamy
> -Original Message- > From: Sunil Muthuswamy > Sent: Thursday, November 7, 2019 11:49 AM > To: Paolo Bonzini ; Richard Henderson > ; Eduardo Habkost > Cc: qemu-devel@nongnu.org > Subject: [PATCH v2] WHPX: support for xcr0 > > Support for xcr0 to be able t

RE: [PATCH] WHPX: refactor load library

2019-11-12 Thread Sunil Muthuswamy
> -Original Message- > From: Sunil Muthuswamy > Sent: Friday, November 8, 2019 12:32 PM > To: 'Paolo Bonzini' ; 'Richard Henderson' > ; 'Eduardo Habkost' ; 'Stefan > Weil' > Cc: 'qemu-devel@nongnu.org' ; Justin

[PATCH] WHPX: refactor load library

2019-11-08 Thread Sunil Muthuswamy
This refactors the load library of WHV libraries to make it more modular. It makes a helper routine that can be called on demand. This allows future expansion of load library/functions to support functionality that is depenedent on some feature being available. Signed-off-by: Sunil Muthuswamy

RE: [PATCH v2] WHPX: support for xcr0

2019-11-07 Thread Sunil Muthuswamy
> > You will need the Windows 10 SDK for RS5 (build 17763) or above to > > to be able to compile this patch because of the definition of the > > XCR0 register. > > > > Changes since v1: > > - Added a sign-off line in the patch. > > > I am not very happy with the current situation which suggests u

[PATCH v2] WHPX: support for xcr0

2019-11-07 Thread Sunil Muthuswamy
Support for xcr0 to be able to enable xsave/xrstor. This by itself is not sufficient to enable xsave/xrstor. WHPX XSAVE API's also needs to be hooked up. Signed-off-by: Sunil Muthuswamy --- You will need the Windows 10 SDK for RS5 (build 17763) or above to to be able to compile this

[PATCH] WHPX: support for xcr0

2019-11-06 Thread Sunil Muthuswamy
Support for xcr0 to be able to enable xsave/xrstor. This by itself is not sufficient to enable xsave/xrstor. WHPX XSAVE API's also needs to be hooked up. --- target/i386/whp-dispatch.h | 3 ++ target/i386/whpx-all.c | 88 ++ 2 files changed, 91 inse