Markus Armbruster writes:
> Peter Maydell writes:
>
>> On Fri, 3 Nov 2023 at 07:02, wrote:
>>>
>>> From: Stephen Brennan
>>>
>>> The QMP dump API represents the dump format as an enumeration. Add three
>>> new enumerators, one for ea
issues. Sorry for the extra work.
Reviewed-by: Stephen Brennan
Marc-André Lureau writes:
> Hi Stephen
>
> On Tue, Sep 19, 2023 at 3:32 AM Stephen Brennan
> wrote:
>>
>> The flattened format (currently output by QEMU) is used by makedumpfile
>> only when it is outputting a vmcore to a file which is not seekable. The
>> fl
Marc-André Lureau writes:
> Hi
>
> On Tue, Sep 19, 2023 at 3:32 AM Stephen Brennan
> wrote:
>>
>> Hello all,
>>
>> This is the third version of the kdump patch series, the first and
>> second revisions being visible at [1] and [2] respectively. You can
Stephen Brennan writes:
> Hi Jon,
>
> Jon Doron writes:
>> Hi Stephen,
>> Like you have said the reason is as I wrote in the commit message,
>> without "fixing" the vaddr GDB is messing up mapping and working with
>> the generated core file.
>
&
Hi Jon,
Jon Doron writes:
> Hi Stephen,
> Like you have said the reason is as I wrote in the commit message,
> without "fixing" the vaddr GDB is messing up mapping and working with
> the generated core file.
For the record I totally love this workaround :)
It's clever and gets the job done an
Hello all,
I've started working on better support and documentation around
hypervisor vmcores in the Drgn debugger[1]. Of course there's quite a
lot of different implementations out there, but recently I'm looking at
Qemu kdump and ELF vmcores generated via dump-guest-memory, and one
thing caught
e flag "-R" to
switch the kdump formats to "raw" mode. The choice of "-R" also
correlates nicely to the "makedumpfile -R" option, which would serve to
reassemble a flattened vmcore.
Signed-off-by: Stephen Brennan
---
dump/dump-hmp-cmds.c | 2
For the next patch, we need a reference to DumpState when writing data.
Signed-off-by: Stephen Brennan
---
dump/dump.c | 40
include/sysemu/dump.h | 2 +-
2 files changed, 21 insertions(+), 21 deletions(-)
diff --git a/dump/dump.c b/dump
l/20230914010315.945705-1-stephen.s.bren...@oracle.com/
Stephen Brennan (3):
dump: Pass DumpState to write_ functions
dump: Allow directly outputting raw kdump format
dump: Add command interface for kdump-raw formats
dump/dump-hmp-cmds.c | 21 +++--
dump/dump.c | 99
bf9b6692668f5a2ac3b6/makedumpfile.c#L5008-L5040
Signed-off-by: Stephen Brennan
---
dump/dump.c | 32 +---
include/sysemu/dump.h | 1 +
2 files changed, 26 insertions(+), 7 deletions(-)
diff --git a/dump/dump.c b/dump/dump.c
index 74071a1565..10aa2c79e0 100644
---
Daniel P. Berrangé writes:
> On Wed, Sep 13, 2023 at 06:03:15PM -0700, Stephen Brennan wrote:
>> This can be used from QMP command line as "-R" to mirror the
>> corresponding flag for makedumpfile. This enables the kdump_reassembled
>> flag introduced in the previ
bf9b6692668f5a2ac3b6/makedumpfile.c#L5008-L5040
Signed-off-by: Stephen Brennan
---
dump/dump.c | 38 +++---
include/sysemu/dump.h | 1 +
2 files changed, 32 insertions(+), 7 deletions(-)
diff --git a/dump/dump.c b/dump/dump.c
index 74071a1565..fb9040cfbc 1006
For the next patch, we need a reference to DumpState when writing data.
Signed-off-by: Stephen Brennan
---
dump/dump.c | 40
include/sysemu/dump.h | 2 +-
2 files changed, 21 insertions(+), 21 deletions(-)
diff --git a/dump/dump.c b/dump
This can be used from QMP command line as "-R" to mirror the
corresponding flag for makedumpfile. This enables the kdump_reassembled
flag introduced in the previous patch.
Signed-off-by: Stephen Brennan
---
dump/dump-hmp-cmds.c | 8 +++-
dump/dump.c | 12 +++
ephen.s.bren...@oracle.com/
[2]:
https://lore.kernel.org/qemu-devel/1390890126-17377-1-git-send-email-qiaonuo...@cn.fujitsu.com/
-> see "changes from v4 to v5" in this patch
Stephen Brennan (3):
dump: Pass DumpState to write_ functions
dump: Allow directly outputting reassembled k
Marc-André Lureau writes:
> Hi
>
> On Wed, Aug 23, 2023 at 2:03 PM Marc-André Lureau
> wrote:
>>
>> Hi
>>
>> On Wed, Aug 23, 2023 at 4:31 AM Stephen Brennan
>> wrote:
>> >
>> > Stephen Brennan writes:
>> > > Marc-André L
Daniel P. Berrangé writes:
> On Tue, Sep 12, 2023 at 10:34:04AM +0400, Marc-André Lureau wrote:
>> Hi
>>
>> On Wed, Aug 23, 2023 at 2:03 PM Marc-André Lureau
>> wrote:
>> >
>> > Hi
>> >
>> > On Wed, Aug 23, 2023 at 4:31 AM Ste
Stephen Brennan writes:
> Marc-André Lureau writes:
>> I am a bit reluctant to change the dump format by default. But since the
>> flatten format is more "complicated" than the "normal" format, perhaps we
>> can assume all users will handle it.
>>
Marc-André Lureau writes:
> Hi
>
> On Mon, Jul 17, 2023 at 8:45 PM Stephen Brennan <
> stephen.s.bren...@oracle.com> wrote:
>
>> The flattened format is used by makedumpfile only when it is outputting
>> a vmcore to a file which is not seekable. The flattened for
ld implement a new option to enable the new
behavior.
I've gone ahead and tested the changes and confirmed that the resulting
dumps are still readable via crash with an x86_64 guest.
Thanks for your consideration and review,
Stephen
Stephen Brennan (2):
dump: Pass DumpState to write_
seeks and writes, in the same strategy as
makedumpfile. However, if the file is not seekable, then we can fall
back to the flattened format.
[1]:
https://github.com/makedumpfile/makedumpfile/blob/f23bb943568188a2746dbf9b6692668f5a2ac3b6/makedumpfile.c#L5008-L5040
Signed-off-by: Stephen Brennan
-
For the next patch, we need a reference to DumpState when writing data.
Signed-off-by: Stephen Brennan
---
dump/dump.c | 40
include/sysemu/dump.h | 2 +-
2 files changed, 21 insertions(+), 21 deletions(-)
diff --git a/dump/dump.c b/dump
23 matches
Mail list logo
