On Fri, Jul 18, 2025 at 10:52:30AM +0200, Paolo Abeni wrote:
If the driver uses any of the extended features (i.e. 64 or above),
store the extended features range (64-127 bits).
At load time, let legacy features initialize the full features range
and pass it to the set helper; sub-states loading
On Fri, Jul 18, 2025 at 10:52:39AM +0200, Paolo Abeni wrote:
When any host or guest GSO over UDP tunnel offload is enabled the
virtio net header includes the additional tunnel-related fields,
update the size accordingly.
Push the GSO over UDP tunnel offloads all the way down to the tap
device ex
On Fri, Jul 18, 2025 at 10:52:33AM +0200, Paolo Abeni wrote:
Similar to virtio infra, vhost core maintains the features status
in the full extended format and allows the devices to implement
extended version of the getter/setter.
Note that 'protocol_features' are not extended: they are only
used
On Fri, Jul 18, 2025 at 03:44:20PM +0200, Paolo Abeni wrote:
On 7/18/25 3:22 PM, Stefano Garzarella wrote:
On Fri, Jul 18, 2025 at 10:52:39AM +0200, Paolo Abeni wrote:
diff --git a/net/tap.c b/net/tap.c
index 23c6c118e7..2dfa843547 100644
--- a/net/tap.c
+++ b/net/tap.c
@@ -62,6 +62,8
On Fri, Jul 18, 2025 at 10:52:39AM +0200, Paolo Abeni wrote:
When any host or guest GSO over UDP tunnel offload is enabled the
virtio net header includes the additional tunnel-related fields,
update the size accordingly.
Push the GSO over UDP tunnel offloads all the way down to the tap
device ex
On Fri, Jul 18, 2025 at 10:52:36AM +0200, Paolo Abeni wrote:
Provide extended version of the features manipulation helpers,
and let the device initialization deal with the full features space,
adjusting the relevant format strings accordingly.
Signed-off-by: Paolo Abeni
---
v2 -> v3:
- use vir
On Fri, Jul 18, 2025 at 10:52:38AM +0200, Paolo Abeni wrote:
Tap devices support GSO over UDP tunnel offload. Probe for such
feature in a similar manner to other offloads.
GSO over UDP tunnel needs to be enabled in addition to a "plain"
offload (TSO or USO).
No need to check separately for the
On Fri, Jul 18, 2025 at 12:23:21PM +0200, Paolo Abeni wrote:
On 7/18/25 12:18 PM, Stefano Garzarella wrote:
On Fri, Jul 18, 2025 at 10:52:34AM +0200, Paolo Abeni wrote:
diff --git a/hw/virtio/virtio-qmp.c b/hw/virtio/virtio-qmp.c
index 3b6377cf0d..03c6163cf4 100644
--- a/hw/virtio/virtio-qmp.c
On Fri, Jul 18, 2025 at 10:52:34AM +0200, Paolo Abeni wrote:
Extend the VirtioDeviceFeatures struct with an additional u64
to track unknown features in the 64-127 bit range and decode
the full virtio features spaces for vhost and virtio devices.
Also add entries for the soon-to-be-supported virt
On Wed, 16 Jul 2025 at 13:31, Daniel P. Berrangé wrote:
>
> On Mon, Jul 14, 2025 at 01:03:06PM +0200, Paolo Bonzini wrote:
> > From: Roy Hopkins
> >
> > The IGVM library allows Independent Guest Virtual Machine files to be
> > parsed and processed. IGVM files are used to configure guest memory
>
From: Stefano Garzarella
Commit 84fe49d94a ("meson: Add optional dependency on IGVM library")
was inconsistent with the contents of meson_options.txt and the one
generated in scripts/meson-buildoptions.sh
Let's regenerate the file in this way to keep them consistent and prevent
On Mon, 14 Jul 2025 at 11:51, Peter Maydell wrote:
>
> On Mon, 14 Jul 2025 at 10:19, Stefano Garzarella wrote:
> > On Thu, Jul 10, 2025 at 12:40:43PM -0400, Michael S. Tsirkin wrote:
> > >> Q: should this file be listed in the "vhost" subcategory of
> >
From: Stefano Garzarella
net/vhost* files should be interesting for vhost maintainers/reviewers.
Suggested-by: Peter Maydell
Signed-off-by: Stefano Garzarella
---
MAINTAINERS | 1 +
1 file changed, 1 insertion(+)
diff --git a/MAINTAINERS b/MAINTAINERS
index e88ed2c0a9..045a896d08 100644
On Mon, 14 Jul 2025 at 11:18, Stefano Garzarella wrote:
>
> On Thu, Jul 10, 2025 at 12:40:43PM -0400, Michael S. Tsirkin wrote:
> >On Thu, Jul 10, 2025 at 04:46:34PM +0100, Peter Maydell wrote:
> >> Hi; Coverity complains about a potential filedescriptor l
From: Stefano Garzarella
Coverity reported a file descriptor leak (CID 1490785) that happens if
`vhost_vdpa_get_max_queue_pairs()` returns 0, since in that case
net_host_vdpa_init(), which should take ownership of the fd, is never
called.
vhost_vdpa_get_max_queue_pairs() returns 1 if
On Thu, Jul 10, 2025 at 12:40:43PM -0400, Michael S. Tsirkin wrote:
On Thu, Jul 10, 2025 at 04:46:34PM +0100, Peter Maydell wrote:
Hi; Coverity complains about a potential filedescriptor leak in
net/vhost-vdpa.c:net_init_vhost_vdpa(). This is CID 1490785.
Specifically, in this function we do:
df6fe2abf2e990f767ce755d426bc439c7bba336) + this
series
SVSM: commit 00b24f830a318a40b56b492b917466e28fde12e2
EDK2: https://github.com/coconut-svsm/edk2/tree/svsm
Guest kernel: Linux 6.16-rc5
[1] https://github.com/coconut-svsm/svsm
Tested-by: Stefano Garzarella
Thanks!
Once again, this is
https://lore.kernel.org/qemu-devel/dmtvkhqkwdv7rzum6c4gs3uiekwckou3yp7w2ql6tijxshoiju@w4rplxvassk6/
I don't know if Michael can fix will applying or you need to resend.
BTW I still didn't completely get the pci bits, but for vhost LGTM:
Acked-by: Stefano Garzarella
Reported-by: Zh
Hi Huaitong Han,
On Thu, 22 May 2025 at 05:39, Huaitong Han wrote:
>
> Hi Stefano,
>
> I’ve implemented the version based on your suggestion. The core logic
> now looks like this:
> if (k->query_guest_notifiers &&
> !k->query_guest_notifiers(qbus->parent) &&
> virtio_queue_vector(vdev, id
On Tue, May 20, 2025 at 08:30:39PM +0800, Huaitong Han wrote:
Stefano Garzarella 于2025年5月20日周二 19:41写道：
On Tue, May 13, 2025 at 07:28:25PM +0800, oen...@gmail.com wrote:
>From: Huaitong Han
>
>The vring call fd is set even when the guest does not use MSI-X (e.g., in the
>case o
On Tue, May 13, 2025 at 07:28:25PM +0800, oen...@gmail.com wrote:
From: Huaitong Han
The vring call fd is set even when the guest does not use MSI-X (e.g., in the
case of virtio PMD), leading to unnecessary CPU overhead for processing
interrupts.
The commit 96a3d98d2c("vhost: don't set vring c
On Fri, May 16, 2025 at 09:03:33PM +0800, Huaitong Han wrote:
Stefano Garzarella 于2025年5月16日周五 16:19写道：
On Tue, May 13, 2025 at 07:28:25PM +0800, oen...@gmail.com wrote:
>From: Huaitong Han
>
>The vring call fd is set even when the guest does not use MSI-X (e.g., in the
>case o
On Tue, May 13, 2025 at 07:28:25PM +0800, oen...@gmail.com wrote:
From: Huaitong Han
The vring call fd is set even when the guest does not use MSI-X (e.g., in the
case of virtio PMD), leading to unnecessary CPU overhead for processing
interrupts.
The commit 96a3d98d2c("vhost: don't set vring c
On Mon, Apr 07, 2025 at 03:53:24PM +0800, Huaitong Han wrote:
Stefano Garzarella 于2025年4月1日周二 18:49写道：
On Wed, Mar 26, 2025 at 04:25:37PM +0800, oen...@gmail.com wrote:
>From: Huaitong Han
>
>The vring call fd is set even when the guest does not use msix (e.g., in the
>case o
On Fri, Mar 14, 2025 at 06:15:33AM -0400, Haoqian He wrote:
The backend maybe crash when vhost_dev_stop and GET_VRING_BASE
would fail, we can return failure to indicate the connection
with the backend is broken.
Signed-off-by: Haoqian He
---
hw/virtio/vhost.c | 27 +++---
On Thu, Mar 27, 2025 at 02:53:24PM +0800, Haoqian He wrote:
2025年3月25日 17:51，Stefano Garzarella 写道：
On Tue, Mar 25, 2025 at 04:39:46PM +0800, Haoqian He wrote:
2025年3月24日 22:31，Stefano Garzarella 写道：
On Thu, Mar 20, 2025 at 08:21:30PM +0800, Haoqian He wrote:
2025年3月19日 23:20，Stefano
On Wed, Mar 26, 2025 at 04:25:37PM +0800, oen...@gmail.com wrote:
From: Huaitong Han
The vring call fd is set even when the guest does not use msix (e.g., in the
case of virtio pmd), leading to unnecessary CPU overhead for processing
interrupts. The previous patch optimized the condition where
On Tue, Mar 25, 2025 at 04:36:53PM +0800, Haoqian He wrote:
2025年3月24日 22:25，Stefano Garzarella 写道：
On Thu, Mar 20, 2025 at 08:21:25PM +0800, Haoqian He wrote:
2025年3月19日 23:11，Stefano Garzarella 写道：
On Fri, Mar 14, 2025 at 06:15:33AM -0400, Haoqian He wrote:
The backend maybe crash when
On Tue, Mar 25, 2025 at 04:39:46PM +0800, Haoqian He wrote:
2025年3月24日 22:31，Stefano Garzarella 写道：
On Thu, Mar 20, 2025 at 08:21:30PM +0800, Haoqian He wrote:
2025年3月19日 23:20，Stefano Garzarella
写道：
On Fri, Mar 14, 2025 at 06:15:34AM -0400, Haoqian He wrote:
[...]
diff --git a/include/hw
On Thu, Mar 20, 2025 at 08:21:30PM +0800, Haoqian He wrote:
2025年3月19日 23:20，Stefano Garzarella 写道：
On Fri, Mar 14, 2025 at 06:15:34AM -0400, Haoqian He wrote:
Live migration should be terminated if the backend crashes before
the migration completes.
Since the vhost device will be stopped
On Thu, Mar 20, 2025 at 08:21:25PM +0800, Haoqian He wrote:
2025年3月19日 23:11，Stefano Garzarella 写道：
On Fri, Mar 14, 2025 at 06:15:33AM -0400, Haoqian He wrote:
The backend maybe crash when vhost_dev_stop and GET_VRING_BASE
would fail, we can return failure to indicate the connection
with
On Thu, Mar 20, 2025 at 08:21:18PM +0800, Haoqian He wrote:
2025年3月19日 22:50，Stefano Garzarella 写道：
On Fri, Mar 14, 2025 at 06:15:32AM -0400, Haoqian He wrote:
This patch contains two changes:
1. Add VM state change cb type VMChangeStateHandlerExt which has return
value for virtio devices
On Fri, Mar 14, 2025 at 06:15:32AM -0400, Haoqian He wrote:
This patch contains two changes:
1. Add VM state change cb type VMChangeStateHandlerExt which has return
value for virtio devices VMChangeStateEntry. When VM state changes,
virtio device will call the _Ext version.
2. Add return value
On Fri, Mar 14, 2025 at 06:15:34AM -0400, Haoqian He wrote:
Live migration should be terminated if the backend crashes before
the migration completes.
Since the vhost device will be stopped when VM is stopped before
the end of the live migration, current implementation if vhost
backend died, vho
Hi Roy,
On Thu, Mar 06, 2025 at 11:48:29AM +, Roy Hopkins wrote:
On Wed, 2025-03-05 at 16:47 +0100, Stefano Garzarella wrote:
[...]
Thanks for testing this. The problem seems to be down to the fact that I
had to introduce an initial parsing of the IGVM file during initialization
to
Hi Roy,
On Thu, 27 Feb 2025 at 14:47, Roy Hopkins wrote:
>
> Here is v7 of the set of patches to add support for IGVM files to QEMU. This
> is
> based on commit 40efe733e10cc00e4fb4f9f5790a28e744e63c62 of qemu.
>
> Firstly, apologies for the amount of time between the last version and this
> on
On Thu, 27 Feb 2025 at 17:12, Roy Hopkins wrote:
>
> On Thu, 2025-02-27 at 16:32 +0100, Stefano Garzarella wrote:
> > Hi Roy,
> >
> > On Thu, Feb 27, 2025 at 01:38:08PM +, Roy Hopkins wrote:
> > > Here is v7 of the set of patches to add support for I
Hi Roy,
On Thu, Feb 27, 2025 at 01:38:08PM +, Roy Hopkins wrote:
Here is v7 of the set of patches to add support for IGVM files to QEMU. This is
based on commit 40efe733e10cc00e4fb4f9f5790a28e744e63c62 of qemu.
Thanks again for this work!
I noticed that the last patch for this series is
On Tue, 25 Feb 2025 at 10:40, Michael Tokarev wrote:
>
> 17.02.2025 17:07, Stefano Garzarella wrote:
> > On Mon, Feb 17, 2025 at 02:12:55PM +0100, Matias Ezequiel Vara Larsen wrote:
> >> Use virtio_get_config_size() rather than sizeof(struct
> >> virtio_snd_conf
On Tue, Feb 18, 2025 at 04:32:08PM +0800, oen...@gmail.com wrote:
From: Huaitong Han
The vring call fd is set even when the guest does not use MSIX (e.g., virtio
PMD). This results in unnecessary CPU overhead for handling virtio interrupts.
The previous patch only optimized the condition when q
ders: update to current kvm/next")
If we want to backport this on stable branches, better to add:
Cc: qemu-sta...@nongnu.org
Resolves: https://gitlab.com/qemu-project/qemu/-/issues/2805
Reviewed-by: Philippe Mathieu-Daudé
Suggested-by: Stefano Garzarella
Signed-off-by: Matias Ezequiel Vara La
On Thu, 13 Feb 2025 at 16:43, Stefano Garzarella wrote:
>
> Unrelated to this patch, but since we are talking about
> VIRTIO_SND_F_CTLS, I think it would be good to send a patch to Linux to
> make it clear that `controls` depends on VIRTIO_SND_F_CTLS.
Patch posted here:
https://lor
maps */
__le32 chmaps;
- /* # of available control elements */
+ /* # of available control elements (if VIRTIO_SND_F_CTLS) */
__le32 controls;
};
Thanks,
Stefano
On Thu, 13 Feb 2025 at 16:31, Stefano Garzarella wrote:
>
> For the title, what about this?
>
&
nds that do not implement
the `controls` field.
I'd suggest to add the fixes tag:
Fixes: ab0c7fb22b ("linux-headers: update to current kvm/next")
And maybe also:
Cc: qemu-sta...@nongnu.org
Resolves: https://gitlab.com/qemu-project/qemu/-/issues/2805
Suggested-by: Stefano Garzarella
naa.1123451234512345/tpg1/luns create
/backstores/fileio/storage02
Signed-off-by: Dongli Zhang
---
hw/scsi/vhost-scsi.c | 3 +++
1 file changed, 3 insertions(+)
LGTM:
Acked-by: Stefano Garzarella
diff --git a/hw/scsi/vhost-scsi.c b/hw/scsi/vhost-scsi.c
index 8039d13fd9..d3a260f6a7 100644
etion(-)
Reviewed-by: Stefano Garzarella
diff --git a/tests/qtest/vhost-user-test.c b/tests/qtest/vhost-user-test.c
index 76d142a158..bd977ef28d 100644
--- a/tests/qtest/vhost-user-test.c
+++ b/tests/qtest/vhost-user-test.c
@@ -1043,7 +1043,8 @@ static void test_multiqueue(void *obj, void
While sending a patch for backends/cryptodev-vhost.c I noticed that
Michael wasn`t in CC so I took a look at the files listed under `vhost`
and tried to fix it increasing the coverage by adding new files.
Signed-off-by: Stefano Garzarella
---
MAINTAINERS | 10 +++---
1 file changed, 7
ryptodev backend")
Cc: qemu-sta...@nongnu.org
Reported-by: mylu...@m.fudan.edu.cn
Signed-off-by: Stefano Garzarella
---
backends/cryptodev-vhost.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/backends/cryptodev-vhost.c b/backends/cryptodev-vhost.c
index 8718c97326..943680a23a
Hi Stefan,
Sorry for the delay, I attach a proposal!
On Wed, 29 Jan 2025 at 18:44, Stefano Garzarella wrote:
>
> +Cc rust-vmm ML, since in past years we have used QEMU as an umbrella
> project for rust-vmm ideas for GSoC.
>
> Thanks,
> Stefano
>
> On Tue, 28 Jan 2025 a
+Cc rust-vmm ML, since in past years we have used QEMU as an umbrella
project for rust-vmm ideas for GSoC.
Thanks,
Stefano
On Tue, 28 Jan 2025 at 17:17, Stefan Hajnoczi wrote:
>
> Dear QEMU and KVM communities,
> QEMU will apply for the Google Summer of Code internship
> program again this year.
On Wed, Jan 22, 2025 at 05:41:15PM +0100, Laurent Vivier wrote:
On 22/01/2025 17:20, Stefano Garzarella wrote:
On Wed, Jan 22, 2025 at 08:59:22AM -0500, Michael S. Tsirkin wrote:
On Wed, Jan 22, 2025 at 02:42:14PM +0100, Stefano Garzarella wrote:
On Tue, Jan 21, 2025 at 11:00:29AM +0100
On Wed, Jan 22, 2025 at 08:59:22AM -0500, Michael S. Tsirkin wrote:
On Wed, Jan 22, 2025 at 02:42:14PM +0100, Stefano Garzarella wrote:
On Tue, Jan 21, 2025 at 11:00:29AM +0100, Laurent Vivier wrote:
> In vhost_user_receive() if vhost_net_notify_migration_done() reports
> an error we disp
On Tue, Jan 21, 2025 at 11:00:29AM +0100, Laurent Vivier wrote:
In vhost_user_receive() if vhost_net_notify_migration_done() reports
an error we display on the console:
Vhost user backend fails to broadcast fake RARP
This message can be useful if there is a problem to execute
VHOST_USER_SEND_R
On Tue, Jan 21, 2025 at 09:31:53AM +0100, Laurent Vivier wrote:
On 20/01/2025 18:33, Eric Auger wrote:
When a guest exposed with a vhost device and protected by an
intel IOMMU gets rebooted, we sometimes observe a spurious warning:
Fail to lookup the translated address e000
We observe that
vhost-user/libvhost-user.h | 6 +-
4 files changed, 3 insertions(+), 21 deletions(-)
The patch LGTM.
Acked-by: Stefano Garzarella
diff --git a/meson.build b/meson.build
index e0b880e4e13..fa6d24e1233 100644
--- a/meson.build
+++ b/meson.build
@@ -354,11 +354,6 @@ elif host_os
gh so I'd wait for a comment from
Michael and Jason.
Acked-by: Stefano Garzarella
---
hw/net/vhost_net.c | 35 ---
1 file changed, 24 insertions(+), 11 deletions(-)
diff --git a/hw/net/vhost_net.c b/hw/net/vhost_net.c
index 997aab0557..891f235a0a 100644
-
On Thu, Nov 14, 2024 at 11:08:35AM +, Zuo,Boqun wrote:
On Thursday, November 14, 2024 6:54 PM, Stefano Garzarella wrote:
>
>When the backend of vhost_net restarts during the vm is running,
>vhost_net is stopped and started. The virtio_device_grab_ioeventfd()
>
On Mon, Nov 11, 2024 at 04:57:25PM +0800, Zuo boqun wrote:
From: zuoboqun
When the backend of vhost_net restarts during the vm is running, vhost_net
is stopped and started. The virtio_device_grab_ioeventfd() fucntion in
vhost_net_enable_notifiers() will result in a call to
virtio_bus_set_host_n
nda Bassey
---
hw/display/virtio-dmabuf.c | 6 --
1 file changed, 4 insertions(+), 2 deletions(-)
Reviewed-by: Stefano Garzarella
diff --git a/hw/display/virtio-dmabuf.c b/hw/display/virtio-dmabuf.c
index 3dba4577ca7..5e0395be77c 100644
--- a/hw/display/virtio-dmabuf.c
+++ b/hw/display/virti
start when such an error occurs.
Signed-off-by: Prasad Pandit
---
hw/virtio/vhost.c | 13 -
1 file changed, 12 insertions(+), 1 deletion(-)
v1:
- Remove VHOST_OPS_DEBUG call.
- Call vhost_set_iotlb_callback and vhost_dev_start with 'false' argument.
LGTM!
Reviewed-by
On Thu, Nov 07, 2024 at 01:52:01PM +0100, Dorinda Bassey wrote:
In `virtio_add_resource` function, the UUID used as a key for
`g_hash_table_insert` was temporary, which could lead to
invalid lookups when accessed later. This patch ensures that
the UUID remains valid by duplicating it into a newly
On Thu, Nov 7, 2024 at 2:43 PM Stefano Garzarella wrote:
>
> On Thu, Nov 07, 2024 at 01:52:01PM +0100, Dorinda Bassey wrote:
> >In `virtio_add_resource` function, the UUID used as a key for
> >`g_hash_table_insert` was temporary, which could lead to
> >invalid lookups w
On Tue, Nov 05, 2024 at 08:24:17PM +0530, Sahil Siddiq wrote:
Hi,
Thank you for the review.
On 11/5/24 3:06 PM, Stefano Garzarella wrote:
On Mon, Nov 04, 2024 at 09:51:24PM +0530, Sahil Siddiq wrote:
Linux commit v5.14-rc1~30^2~8 enabled the vp_vdpa driver to set the
To refer to a commit
On Wed, Nov 06, 2024 at 05:14:24PM +0530, Prasad Pandit wrote:
On Wed, 6 Nov 2024 at 16:05, Stefano Garzarella wrote:
>+fail_iotlb:
>+hdev->vhost_ops->vhost_set_iotlb_callback(hdev, false);
> fail_start:
>+hdev->vhost_ops->vhost_dev_start(hdev, false);
T
On Wed, Nov 06, 2024 at 03:41:24PM +0530, Prasad Pandit wrote:
On Wed, 6 Nov 2024 at 14:21, Stefano Garzarella wrote:
I think we should call that functions in the reverse order, so just add them in
the error path, as we already do for other calls.
===
diff --git a/hw/virtio/vhost.c b/hw
On Wed, Nov 06, 2024 at 06:04:59PM +0530, Prasad Pandit wrote:
On Wed, 6 Nov 2024 at 17:31, Stefano Garzarella wrote:
For vhost_set_iotlb_callback() that is true because for now we go to
that label only if the callback is defined, but this is not the case for
hdev->vhost_ops->vhost_dev
On Wed, Nov 06, 2024 at 01:20:31PM +0530, Prasad Pandit wrote:
On Tue, 5 Nov 2024 at 16:19, Stefano Garzarella wrote:
VHOST_OPS_DEBUG() is usually used in the error path when calling a
`dev->vhost_ops` callback. In addition vhost_device_iotlb_miss() is
already reporting error thro
On Tue, Nov 05, 2024 at 11:30:53AM +0530, Prasad Pandit wrote:
From: Prasad Pandit
While starting a vhost device, updating iotlb entries
via 'vhost_device_iotlb_miss' may return an error.
qemu-kvm: vhost_device_iotlb_miss:
700871,700871: Fail to update device iotlb
Fail device start when
On Mon, Nov 04, 2024 at 09:51:24PM +0530, Sahil Siddiq wrote:
Linux commit v5.14-rc1~30^2~8 enabled the vp_vdpa driver to set the
To refer to a commit, please use the SHA-1 id or even better the form
suggested in
https://www.kernel.org/doc/html/latest/process/submitting-patches.html#describe-yo
On Mon, Oct 21, 2024 at 03:44:26PM +0100, Roy Hopkins wrote:
Here is v6 of the set of patches to add support for IGVM files to QEMU. This
is
based on commit a5dd9ee060 of qemu.
This version addresses all of the review comments from v5 [1].
Hi all. I'm just drawing attention to this series agai
: Michael S. Tsirkin
---
hw/i386/pc.c | 12
hw/i386/pc_piix.c | 10 ++
hw/i386/pc_q35.c | 10 ++
include/hw/i386/x86.h | 3 +++
qemu-options.hx | 28
5 files changed, 63 insertions(+)
Reviewed-by: Stefano Garzarella
diff
On Thu, Oct 17, 2024 at 10:27:30AM +0200, Albert Esteve wrote:
Albert Esteve
Senior Software Engineer
Red Hat
aest...@redhat.com
On Thu, Oct 17, 2024 at 9:38 AM Stefano Garzarella wrote:
On Wed, Oct 16, 2024 at 11:06:06AM +0200, Albert Esteve wrote:
>VHOST_USER_BACKEND_SHARED_OBJECT_
pends if the backends are checking that return value.
Signed-off-by: Albert Esteve
---
hw/virtio/vhost-user.c | 8
1 file changed, 4 insertions(+), 4 deletions(-)
Thanks for the fix!
Reviewed-by: Stefano Garzarella
diff --git a/hw/virtio/vhost-user.c b/hw/virtio/vhost-user.c
+++---
include/hw/virtio/vhost-user.h | 1 +
2 files changed, 27 insertions(+), 20 deletions(-)
LGTM!
Reviewed-by: Stefano Garzarella
diff --git a/hw/virtio/vhost-user.c b/hw/virtio/vhost-user.c
index 00561daa06..d1b0893b4d 100644
--- a/hw/virtio/vhost-user.c
On Thu, Oct 10, 2024 at 02:18:24PM GMT, yaozhenguo wrote:
During the hot-unplugging of vhost-user-net type network cards,
the vhost_user_cleanup function may add the same rcu node to
the rcu linked list.
The function call relationship in this case is as follows:
vhost_user_cleanup
->vhost_use
llback.
LGTM!
Reviewed-by: Stefano Garzarella
+{
+int ret;
+VirtIODevice *vdev = VIRTIO_DEVICE(dev);
+VHostUserBlk *s = VHOST_USER_BLK(vdev);
+
+ret = vhost_dev_get_config(&s->dev, (uint8_t *)&s->blkcfg,
+ vdev->config_len, errp);
+
On Thu, Sep 19, 2024 at 03:29:44PM GMT, yaozhenguo wrote:
During the process of hot-unplug in vhost-user-net NIC, vhost_user_cleanup
may add same rcu node to rcu list. Function calls are as follows:
vhost_user_cleanup
->vhost_user_host_notifier_remove
->call_rcu(n, vhost_user_host_noti
mu and
backend")
Remove them, and their helper vhost_dev_resize_inflight.
Signed-off-by: Dr. David Alan Gilbert
---
hw/virtio/vhost.c | 56 ---
include/hw/virtio/vhost.h | 2 --
2 files changed, 58 deletions(-)
Reviewed-by: Stefano Garzarella
di
: Michael S. Tsirkin
---
hw/i386/pc.c | 12
hw/i386/pc_piix.c | 10 ++
hw/i386/pc_q35.c | 10 ++
include/hw/i386/x86.h | 3 +++
qemu-options.hx | 28
5 files changed, 63 insertions(+)
Reviewed-by: Stefano Garzarella
diff
eturn value.
Signed-off-by: Marc-André Lureau
---
hw/virtio/vhost-shadow-virtqueue.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
Reviewed-by: Stefano Garzarella
diff --git a/hw/virtio/vhost-shadow-virtqueue.c
b/hw/virtio/vhost-shadow-virtqueue.c
index fc5f408f77..3b2beaea24 100644
---
On Fri, Sep 27, 2024 at 3:08 PM Eugenio Perez Martin
wrote:
>
> On Wed, Sep 25, 2024 at 10:08 AM Stefano Garzarella
> wrote:
> >
> > On Tue, Sep 24, 2024 at 05:05:49PM GMT, marcandre.lur...@redhat.com wrote:
> > >From: Marc-André Lureau
> >
> >
On Fri, Sep 27, 2024 at 3:05 PM Eugenio Perez Martin
wrote:
>
> On Tue, Sep 24, 2024 at 3:07 PM wrote:
> >
> > From: Marc-André Lureau
> >
> > ../hw/virtio/vhost-shadow-virtqueue.c:545:13: error: ‘r’ may be used
> > uninitialized [-Werror=maybe-uninitialized]
> >
> > Signed-off-by: Marc-André L
On Tue, Sep 24, 2024 at 05:05:53PM GMT, marcandre.lur...@redhat.com wrote:
From: Marc-André Lureau
vhost_svq_get_buf() may return a VirtQueueElement that should be freed.
It's unclear to me if the vhost_svq_get_buf() call should always return NULL.
Signed-off-by: Marc-André Lureau
---
hw/vir
On Tue, Sep 24, 2024 at 05:05:49PM GMT, marcandre.lur...@redhat.com wrote:
From: Marc-André Lureau
For the title: I don't think it is a false positive, but a real fix,
indeed maybe not a complete one.
../hw/virtio/vhost-shadow-virtqueue.c:545:13: error: ‘r’ may be used
uninitialized [-Werr
| 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
Reviewed-by: Stefano Garzarella
diff --git a/hw/block/virtio-blk.c b/hw/block/virtio-blk.c
index 115795392c..9166d7974d 100644
--- a/hw/block/virtio-blk.c
+++ b/hw/block/virtio-blk.c
@@ -1060,7 +1060,7 @@ static void virtio_blk_dma_restart_cb
/* Use default worker */
if (!per_virtqueue || dev->nvqs == VHOST_SCSI_VQ_NUM_FIXED + 1) {
Another option could have been to edit this check:
if (!per_virtqueue || dev->nvqs <= VHOST_SCSI_VQ_NUM_FIXED + 1) {
return 0;
}
But I'm fine with your change:
Reviewed-by: Stefano Garzarella
On Thu, Aug 29, 2024 at 01:13:43PM GMT, Gao,Shiyuan wrote:
>--- a/hw/virtio/virtio-pci.c
>+++ b/hw/virtio/virtio-pci.c
>@@ -610,19 +610,29 @@ static MemoryRegion
*virtio_address_space_lookup(VirtIOPCIProxy *proxy,
> {
> int i;
> VirtIOPCIRegion *reg;
>+ MemoryRegion *mr = NULL;
`mr`
stUserHostNotifier.
yeah, thank you for this detailed analysis, now it's clear.
My suggestion is to put some of it in the commit description as well,
maybe a summary with the main things.
Stefano Garzarella 于2024年8月27日周二 16:00写道：
On Wed, Aug 07, 2024 at 05:55:08PM GMT, yaozhenguo wrote:
>
x27;t find
anything obviously wrong, so for those feel free to add:
Acked-by: Stefano Garzarella
Thanks,
Stefano
Changes in v5:
* Fix indentation and apply minimum version check for IGVM library in
meson.build
* Remove unneeded duplicate macro definitions in confidential-guest-support.h
and
measurement of a guest.
This commit introduces handling of the initialization sections during
processing of the IGVM file.
Signed-off-by: Roy Hopkins
Acked-by: Michael S. Tsirkin
---
backends/igvm.c | 21 +
1 file changed, 21 insertions(+)
Reviewed-by: Stefano Garzarella
diff
.
Signed-off-by: Roy Hopkins
Reviewed-by: Daniel P. Berrangé
Acked-by: Michael S. Tsirkin
---
backends/confidential-guest-support.c | 12
include/exec/confidential-guest-support.h | 21 +
2 files changed, 33 insertions(+)
Reviewed-by: Stefano Garzarella
state of the guest. The IGVM file may be shared by multiple
+#virtual machine definitions. This corresponds to creating
+# an object on the command line with "-object igvm-cfg,
+#file=@filename".
+#
+# Since: 9.1
Ditto
With them fixed:
ndling for R_LDTR and R_TR in the function.
Signed-off-by: Roy Hopkins
Reviewed-by: Michael S. Tsirkin
---
target/i386/cpu.h | 9 -
1 file changed, 8 insertions(+), 1 deletion(-)
Reviewed-by: Stefano Garzarella
diff --git a/target/i386/cpu.h b/target/i386/cpu.h
index c6cc035df3..
Reviewed-by: Stefano Garzarella
diff --git a/target/i386/sev.c b/target/i386/sev.c
index a0d271f898..fab6d1bfb4 100644
--- a/target/i386/sev.c
+++ b/target/i386/sev.c
@@ -121,7 +121,8 @@ struct SevCommonStateClass {
Error **errp);
int (*la
---
1 file changed, 28 insertions(+), 3 deletions(-)
Reviewed-by: Stefano Garzarella
diff --git a/hw/i386/pc_sysfw.c b/hw/i386/pc_sysfw.c
index ef80281d28..f5e40b3ef6 100644
--- a/hw/i386/pc_sysfw.c
+++ b/hw/i386/pc_sysfw.c
@@ -219,7 +219,13 @@ void pc_system_firmware_init(PCMachineState
On Tue, Aug 13, 2024 at 04:01:06PM GMT, Roy Hopkins wrote:
An IGVM file contains configuration of guest state that should be
applied during configuration of the guest, before the guest is started.
This patch allows the user to add an igvm-cfg object to an X86 machine
configuration that allows an
On Tue, Aug 13, 2024 at 04:01:05PM GMT, Roy Hopkins wrote:
Adds an IGVM loader to QEMU which processes a given IGVM file and
applies the directives within the file to the current guest
configuration.
The IGVM loader can be used to configure both confidential and
non-confidential guests. For conf
ith int, but I'd document the return value, since 0 in
this case is not supported, right?
BTW, code LGTM:
Reviewed-by: Stefano Garzarella
+int (*check_support)(ConfidentialGuestPlatformType platform,
+ uint16_t platform_version, uint8_t highest_vtl,
+
ConfidentialGuestSupport
object.
Signed-off-by: Roy Hopkins
Acked-by: Michael S. Tsirkin
---
backends/meson.build | 3 +++
meson.build | 8
meson_options.txt | 2 ++
scripts/meson-buildoptions.sh | 3 +++
4 files changed, 16 insertions(+)
Reviewed-by: Stefano
On Tue, Aug 20, 2024 at 07:56:31PM GMT, Gao Shiyuan wrote:
When VHOST_USER_PROTOCOL_F_HOST_NOTIFIER feature negotiated and
virtio_queue_set_host_notifier_mr success on system blk
device's queue, the VM can't load MBR if the notify region's
address above 4GB.
Assign the address of notify region i
1 - 100 of 1087 matches
Mail list logo
