Re: [PATCH] rust: centralize config in workspace root

Just realised that I forgot to CC Paolo and also that I didn't strictly enforce the tag order of name, version, authors and then alphabetically like I wanted to. I hope this is still enough of an improvement over the status quo. I also considered centralising the `publish = false` but as the h

[PATCH] rust: centralize config in workspace root

This commit bundles common config option in the workspace root and applies them through .workspace = true Signed-off-by: Stefan Zabka --- rust/Cargo.toml | 7 +++ rust/hw/char/pl011/Cargo.toml | 11 ++- rust/hw/timer/hpet/Cargo.toml | 9 ++--- rust/qemu-api

Re: [PATCH 8/9] rust: enable clippy::ptr_cast_constness

Unrelated to the actual change, but a drive-by observation: If you want to keep the MSRV in sync across all workspace members, you could use workspace.package.rust-version to define it once and inherit it everywhere. (Same goes for edition, license, and resolver.) https://doc.rust-lang.org/car

Re: [PATCH v3 0/7] physmem: teach cpu_memory_rw_debug() to write to more memory regions

Sorry for the delayed engagement, I failed to apply the patch set from the mailing list and had to remember that David had published this change set on GitHub. Tested-by: Stefan Zabka This addresses my initial use case of being able to write to a single MMIO device. I have not set up a

Re: [PATCH v2] physmem: allow cpu_memory_rw_debug to write to MMIO devices

On 21/12/2024 15:55, David Hildenbrand wrote: > Let's wait for opinions from others first. states that two weeks is a reasonable amount of time for follow-up. Should I also ping the origin

[PATCH v2] physmem: allow cpu_memory_rw_debug to write to MMIO devices

Resolves: https://gitlab.com/qemu-project/qemu/-/issues/213 Signed-off-by: Stefan Zabka --- Addressed initial review by David Hildenbrand The other change made more sense to me, so I'd like to write a test to verify that an AddressSpace like 0x00..0x0F MMIO Device A 0x10..0x1F ROM 0x20..0x2F

[PATCH] physmem: allow cpu_memory_rw_debug to write to MMIO devices

Resolves: https://gitlab.com/qemu-project/qemu/-/issues/213 Signed-off-by: Stefan Zabka --- system/physmem.c | 22 ++ 1 file changed, 18 insertions(+), 4 deletions(-) diff --git a/system/physmem.c b/system/physmem.c index dc1db3a384..53cdccefcb 100644 --- a/system/physmem.c