Re: [PATCH] hw/arm: Replace TABs for spaces

Am 03.05.25 um 22:13 schrieb Santiago Monserrat Campanello: replaced for arm code Signed-off-by: Santiago Monserrat Campanello Resolves: https://gitlab.com/qemu-project/qemu/-/issues/373 --- replaced tabs with vim :retab, except in some defines where I tried to put everything in the same colum

Re: [PATCH for-10.0] Fix objdump output parser in "nsis.py"

Am 12.04.25 um 20:08 schrieb Arthur Sengileyev: In msys2 distribution objdump from gcc is using single tab character prefix, but objdump from clang is using 4 white space characters instead. The script will not identify any dll dependencies for a QEMU build generated with clang. This in turn wil

[PATCH for-10.0] docs: Fix some typos (found by codespell and typos)

Signed-off-by: Stefan Weil --- docs/about/deprecated.rst | 4 ++-- docs/devel/codebase.rst| 6 +++--- docs/devel/qapi-domain.rst | 4 ++-- include/exec/memory.h | 4 ++-- qapi/qdev.json | 2 +- 5 files changed, 10 insertions(+), 10 deletions(-) diff --git a/docs/about/depre

Re: [qemu-web PATCH] download/windows: Drop link to 32-bit builds, add aarch64 instead

Am 06.03.25 um 09:05 schrieb Thomas Huth: QEMU does not support 32-bit Windows anymore, so we should not tempt the users to download old builds. OTOH, there is now interest in Windows build on arm computers instead (see e.g.https://gitlab.com/qemu-project/qemu/-/issues/2850 ), so let's add a lin

Re: [PATCH 2/2] tests/functional: Allow running TCG plugins tests on non-Linux/BSD hosts

Am 20.02.25 um 07:02 schrieb Thomas Huth: On 19/02/2025 20.23, Philippe Mathieu-Daudé wrote: @@ -62,6 +62,10 @@ class PluginKernelNormal(PluginKernelBase):   ('https://storage.tuxboot.com/20230331/arm64/Image'), 'ce95a7101a5fecebe0fe630deee6bd97b32ba41bc8754090e9ad8961ea8674c7')   +   

Re: [PATCH v4 0/3] Enable clang build on Windows

Am 19.02.25 um 08:01 schrieb Pierrick Bouvier: On 2/18/25 22:39, Stefan Weil wrote: Am 19.02.25 um 00:17 schrieb Pierrick Bouvier: On 2/18/25 12:59, Stefan Weil wrote: I could run a QEMU cross compile on Debian with the llvm toolchain and msys2 clangarm64 packages installed with pacman. The

Re: [PATCH v4 0/3] Enable clang build on Windows

Am 19.02.25 um 00:17 schrieb Pierrick Bouvier: On 2/18/25 12:59, Stefan Weil wrote: I could run a QEMU cross compile on Debian with the llvm toolchain and msys2 clangarm64 packages installed with pacman. The resulting installer is here: Have you installed the msys2 clangarm64 packages on a

Re: [PATCH v4 0/3] Enable clang build on Windows

Am 18.02.25 um 17:22 schrieb Pierrick Bouvier: On 2/17/25 20:11, Brian Cain wrote: Is this toolchain available publicly or did you build it yourself?  It would be handy if there were a linux x86_64 hosted cross-toolchain that can target Windows-aarch64.  Or linux aarch64 hosted would be pretty g

Re: [PATCH v4 0/3] Enable clang build on Windows

Am 10.01.25 um 21:33 schrieb Pierrick Bouvier: For now, it was only possible to build plugins using GCC on Windows. However, windows-aarch64 only supports Clang. This biggest roadblock was to get rid of gcc_struct attribute, which is not supported by Clang. After investigation, we proved it was s

[PATCH] scripts/nsis.py: Run dependency check for each DLL file only once

Each DLL should only be checked once for dependencies, but several hundred (781 in my test) unneeded checks were done. Now the script is significantly faster (16 s in my build). Signed-off-by: Stefan Weil --- scripts/nsis.py | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff

Re: [PATCH] Fix calculation of minimum in colo_compare_tcp

It looks like nobody has sent a pull request for this fix up to now. Is it trivial enough for qemu-trivial? And maybe qemu-stable could also apply it to older versions. Stefan W. Am 10.09.24 um 04:38 schrieb Zhang, Chen: -Original Message- From: Stefan Weil Sent: Tuesday, September 10

Re: [PULL 3/6] migration/multifd: Fix loop conditions in multifd_zstd_send_prepare and multifd_zstd_recv

Am 17.09.24 um 23:55 schrieb Peter Xu: From: Stefan Weil via How can I avoid that my author name/email is changed so often? Will this be fixed automatically before the commit is merged? Stefan

[PATCH] migration/multifd: Fix loop conditions in multifd_zstd_send_prepare and multifd_zstd_recv

GitHub's CodeQL reports four critical errors which are fixed by this commit: Unsigned difference expression compared to zero An expression (u - v > 0) with unsigned values u, v is only false if u == v, so all changed expressions did not work as expected. Signed-off-by: Stefan Weil --- I do

[PATCH] Fix calculation of minimum in colo_compare_tcp

GitHub's CodeQL reports a critical error which is fixed by using the MIN macro: Unsigned difference expression compared to zero Signed-off-by: Stefan Weil --- net/colo-compare.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/net/colo-compare.c b/net/colo-compare.c ind

Re: [PATCH 1/3] ui/sdl2: reenable the SDL2 Windows keyboard hook procedure

Am 09.09.24 um 09:26 schrieb Marc-André Lureau: Hi On Mon, Sep 9, 2024 at 10:22 AM Volker Rümelin wrote: Windows only: The libSDL2 Windows message loop needs the libSDL2 Windows low level keyboard hook procedure to grab the left and right Windows keys correctly. Reenable the SDL2 Windows key

Re: [PATCH] .travis.yml: Install python3-tomli in all build jobs

Am 24.06.24 um 12:31 schrieb Thomas Huth: On 24/06/2024 12.09, Alex Bennée wrote: Thomas Huth writes: Since commit 1f97715c83 ('Revert "python: use vendored tomli"') this package is a hard requirement for compiling QEMU, so install it now in all Travis jobs, too. AFAICT the only repo curren

Re: [PATCH] meson.build: Check for the availability of __attribute__((gcc_struct)) on MSYS2

Am 15.08.24 um 14:27 schrieb Thomas Huth: Since quite a while MSYS2 now supports Clang as a compiler, too. Unfortunately, this compiler is lacking the __attribute__((gcc_struct)) that we need for compiling on Windows. But since the compiler is available now, some people started to use it to comp

[PATCH-for-9.1] docs: Fix some typos (found by typos) and grammar issues

Fix the misspellings of "overriden" also in code comments. Signed-off-by: Stefan Weil --- docs/devel/migration/uadk-compression.rst | 4 ++-- docs/interop/qemu-ga.rst | 2 +- docs/tools/qemu-vmsr-helper.rst | 4 ++-- hw/arm/smmu-common.c | 2 +- in

Drop support for Python 3.7?

Hi, I just saw that the documentation still mentions that QEMU supports Python 3.7. Python 3.7 is an unsupported Python version since about one year. Therefore I suggest to update the documentation for QEMU 9.1.0 and replace 3.7 by 3.8 as lowest supported version. In addition the code whic

Re: [PATCH 1/7] block/vdi.c: Avoid potential overflow when calculating size of write

Am 31.07.24 um 16:36 schrieb Peter Maydell: In vdi_co_pwritev() we multiply a sector count by SECTOR_SIZE to get the size to write in bytes. Coverity notes that this means that we do the multiply as a 32x32->32 multiply before converting to 64 bits, which has the potential to overflow. This is

Re: [PATCH v7 1/2] hw/misc/riscv_iopmp: Add RISC-V IOPMP device

Am 12.06.24 um 05:17 schrieb Ethan Chen via: Support basic functions of IOPMP specification v0.9.1 rapid-k model. The specification url: https://github.com/riscv-non-isa/iopmp-spec/releases/tag/v0.9.1 IOPMP check memory access from device is valid or not. This implementation uses IOMMU to change

Re: Timeouts in CI jobs

Am 24.04.24 um 19:09 schrieb Daniel P. Berrangé: On Wed, Apr 24, 2024 at 06:27:58PM +0200, Stefan Weil via wrote: I think the timeouts are caused by running too many parallel processes during testing. The CI uses parallel builds: make -j$(expr $(nproc) + 1) all check-build $MAKE_CHECK_ARGS

Timeouts in CI jobs (was: cross-i686-tci CI job is flaky again (timeouts): can somebody who cares about TCI investigate?)

Am 20.04.24 um 22:25 schrieb Stefan Weil: Am 16.04.24 um 14:17 schrieb Stefan Weil: Am 16.04.24 um 14:10 schrieb Peter Maydell: The cross-i686-tci job is flaky again, with persistent intermittent failures due to jobs timing out. [...] Some of these timeouts are very high -- no test should be

Re: cross-i686-tci CI job is flaky again (timeouts): can somebody who cares about TCI investigate?

Am 16.04.24 um 14:17 schrieb Stefan Weil: Am 16.04.24 um 14:10 schrieb Peter Maydell: The cross-i686-tci job is flaky again, with persistent intermittent failures due to jobs timing out. [...] Some of these timeouts are very high -- no test should be taking 10 minutes, even given TCI and a sl

Re: cross-i686-tci CI job is flaky again (timeouts): can somebody who cares about TCI investigate?

Am 16.04.24 um 14:10 schrieb Peter Maydell: The cross-i686-tci job is flaky again, with persistent intermittent failures due to jobs timing out. [...] Some of these timeouts are very high -- no test should be taking 10 minutes, even given TCI and a slowish CI runner -- which suggests to me tha

[PATCH for-9.0] Fix some typos in documentation (found by codespell)

Signed-off-by: Stefan Weil --- docs/devel/atomics.rst | 2 +- docs/devel/ci-jobs.rst.inc | 2 +- docs/devel/clocks.rst | 2 +- docs/system/i386/sgx.rst | 2 +- qapi/qom.json | 2 +- 5 files changed, 5 insertions(+), 5 deletions(-) diff --git a/docs/devel/atomics.rst b/doc

Re: [PATCH 3/7] scripts/nsis.py: Automatically package required DLLs of QEMU executables

Am 26.02.24 um 05:35 schrieb Bin Meng: On Mon, Feb 26, 2024 at 1:37 AM Stefan Weil wrote: Am 10.09.22 um 02:37 schrieb Bin Meng: On Sat, Sep 10, 2022 at 12:49 AM Mark Cave-Ayland wrote: On 08/09/2022 14:28, Bin Meng wrote: From: Bin Meng At present packaging the required DLLs of QEMU ex

Re: [PATCH 3/7] scripts/nsis.py: Automatically package required DLLs of QEMU executables

Am 10.09.22 um 02:37 schrieb Bin Meng: On Sat, Sep 10, 2022 at 12:49 AM Mark Cave-Ayland wrote: On 08/09/2022 14:28, Bin Meng wrote: From: Bin Meng At present packaging the required DLLs of QEMU executables is a manual process, and error prone. Actually build/config-host.mak contains a GL

Files without license statement

Hi Paolo, I just noticed that scripts/fix-multiline-comments.sh has a copyright statement, but no license statement. Should that be fixed? It looks like there exist more files with the same problem (if it is a problem), for example docs/devel/loads-stores.rst (written by Peter). LICENSE say

Re: dropping 32-bit Windows host support

Am 19.02.24 um 17:26 schrieb Thomas Huth: On 19/02/2024 16.53, Daniel P. Berrangé wrote: On Mon, Feb 19, 2024 at 03:37:31PM +, Peter Maydell wrote: Our msys2 32-bit Windows host CI job has been failing recently because upstream MSYS2 are starting to phase out 32-bit windows host support an

GPL 3.0 in TCG test code

Dear all, some QEMU code under tests/tcg uses GPL 3.0 or later: tests/tcg/aarch64/semicall.h: * SPDX-License-Identifier: GPL-3.0-or-later tests/tcg/arm/semicall.h: * SPDX-License-Identifier: GPL-3.0-or-later tests/tcg/i386/system/boot.S: * SPDX-License-Identifier: GPL-3.0-or-later tests/tcg/mult

Re: [PATCH v2 1/4] util/uri: Remove uri_string_unescape()

Am 23.01.24 um 19:22 schrieb Thomas Huth: uri_string_unescape() basically does the same as the glib function g_uri_unescape_segment(). So we can get rid of our implementation completely by simply using the glib function instead. Suggested-by: Stefan Weil [g_uri_unescape_string()] Suggested-by:

Re: [PATCH 2/5] util/uri: Simplify uri_string_unescape()

Am 22.01.24 um 20:17 schrieb Thomas Huth: uri_string_unescape() basically does the same as the glib function g_uri_unescape_string(), with just an additional length parameter. So we can simplify this function a lot by limiting the length with g_strndup() first and then by calling g_uri_unescape_

Re: [PATCH 5/5] util/uri: Remove unused macros ISA_RESERVED() and ISA_GEN_DELIM()

Am 22.01.24 um 20:17 schrieb Thomas Huth: They are not used anywhere, so there's no need to keep them around. Signed-off-by: Thomas Huth --- util/uri.c | 13 - 1 file changed, 13 deletions(-) Reviewed-by: Stefan Weil

Re: [PATCH 4/5] util/uri: Remove unused functions uri_resolve() and uri_resolve_relative()

Am 22.01.24 um 20:17 schrieb Thomas Huth: These rather complex functions have never been used since they've been introduced in 2012, so looks like they are not really useful for QEMU. And since the static normalize_uri_path() function is also only used by uri_resolve(), we can remove that functi

Re: [PATCH 3/5] util/uri: Remove the uri_string_escape() function

Am 22.01.24 um 20:17 schrieb Thomas Huth: It is not used in QEMU - and if somebody needs this functionality, they can simply use g_uri_escape_string() from the glib instead. Signed-off-by: Thomas Huth --- include/qemu/uri.h | 1 - util/uri.c | 64 ---

Re: [PATCH 1/5] util/uri: Remove the unused "target" argument from uri_string_unescape()

Am 22.01.24 um 20:17 schrieb Thomas Huth: All callers pass NULL as target, so we can simplify the code by dropping this parameter. Signed-off-by: Thomas Huth --- include/qemu/uri.h | 2 +- util/uri.c | 32 ++-- 2 files changed, 15 insertions(+), 19 dele

Re: [PATCH] util/uri: Remove is_hex() function

Am 12.01.24 um 07:35 schrieb Markus Armbruster: Thomas Huth writes: We can simply use the g_ascii_isxdigit() from the glib instead. ... or even use unescape_string() from the glib? https://docs.gtk.org/glib/type_func.Uri.unescape_string.html Regards, Stefan

Re: [PATCH] mailmap: Fix Stefan Weil author email again

as willing to do the work and send a patch, not the size of the .mailmap file. Thank you Philippe and Michael. It looks like I have some more identities. :-)    1 Author: Stefan Weil    1 Author: Stefan Weil  697 Author: Stefan Weil  361 Author: Stefan Weil    1 Author: Stefan Weil via M

Re: [PATCH] target/hexagon/idef-parser/prepare: use env to invoke bash

Am 25.12.23 um 09:05 schrieb Michael Tokarev: 23.11.2023 23:57, Samuel Tardieu : This file is the only one involved in the compilation process which still uses the /bin/bash path. Signed-off-by: Samuel Tardieu ---   target/hexagon/idef-parser/prepare | 2 +-   1 file changed, 1 insertion(+), 1

[PATCH] virtio-blk: Fix potential nullpointer read access in virtio_blk_data_plane_destroy

Fixes: CID 1532828 Fixes: b6948ab01d ("virtio-blk: add iothread-vq-mapping parameter") Signed-off-by: Stefan Weil --- hw/block/dataplane/virtio-blk.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/hw/block/dataplane/virtio-blk.c b/hw/block/dataplane/virtio-blk.c index 6debd

[PATCH for-8.2] Fix broken build for QEMU guest agent

Meson setup failed: qga/meson.build:148:4: ERROR: Unknown variable "project". Fixes commit e20d68aa ("configure, meson: use command line options [...]"). Signed-off-by: Stefan Weil --- qga/meson.build | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/qga/meson.build b/qga

Re: [PATCH] spelling: hw/audio/virtio-snd.c: initalize

Am 13.11.23 um 22:20 schrieb Michael Tokarev: Fixes: eb9ad377bb94 "virtio-sound: handle control messages and streams" Signed-off-by: Michael Tokarev --- hw/audio/virtio-snd.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/audio/virtio-snd.c b/hw/audio/virtio-snd.c inde

[PATCH] Fix some typos in documentation and comments

Signed-off-by: Stefan Weil --- This patch was triggered by a spelling check for the generated QEMU documentation using codespell. It does not try to fix all typos which still exist in the QEMU code, but has a focus on those required to fix the documentation. Nevertheless some code comments with t

Re: [PATCH v2 1/1] ui/sdl2: disable SDL_HINT_GRAB_KEYBOARD on Windows

Am 18.04.23 um 08:56 schrieb Volker Rümelin: Windows sends an extra left control key up/down input event for every right alt key up/down input event for keyboards with international layout. Since commit 830473455f ("ui/sdl2: fix handling of AltGr key on Windows") QEMU uses a Windows low level ke

Re: source fails to compile on msys2

Am 12.04.23 um 15:13 schrieb Howard Spoelstra: Hello Peter, My source was cloned today. I just cloned again and I still see the tokens reversed: git clone https://www.gitlab.com/qemu/qemu qemu-master-clean The official URL is https://gitlab.com/qemu-project

Re: source fails to compile on msys2

Am 12.04.23 um 14:12 schrieb BALATON Zoltan: On Wed, 12 Apr 2023, Howard Spoelstra wrote: It seems the current source fails to compile with up to date msys2. See here: https://qemu.weilnetz.de/ I think there are some patches there that aren't upstream. I don't know why and also don't know wh

[PATCH for-8.0] docs/cxl: Fix sentence

Signed-off-by: Stefan Weil --- If my change is okay I suggest to apply the patch for 8.0 because it fixes documentation. Regards, Stefan W. docs/system/devices/cxl.rst | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/docs/system/devices/cxl.rst b/docs/system/devices/cxl.rst

[PATCH for-8.0] docs: Fix typo (wphx => whpx)

Resolves: https://gitlab.com/qemu-project/qemu/-/issues/1529 Signed-off-by: Stefan Weil --- I suggest to apply the patch for 8.0 because it fixes documentation. Regards Stefan W. docs/system/introduction.rst | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/docs/system/introd

[PATCH] hw/arm: Fix some typos in comments (most found by codespell)

Signed-off-by: Stefan Weil --- The patch does not change code and could also be applied for 8.0. hw/arm/Kconfig| 2 +- hw/arm/exynos4210.c | 4 ++-- hw/arm/musicpal.c | 2 +- hw/arm/omap1.c| 2 +- hw/arm/omap2.c| 2 +- hw/arm/virt-acpi-build.c

Re: [PATCH 19/41] compiler.h: replace QEMU_NORETURN with G_NORETURN

Am 07.04.23 um 19:01 schrieb Stefan Weil: Please excuse the late report, but this old patch causes a build failure for me: I just noticed that this is already fixed in latest code (I tested the build with v8.0.0-rc0). So nothing to do. Sorry for the noise. Stefan

Re: [PATCH 19/41] compiler.h: replace QEMU_NORETURN with G_NORETURN

Please excuse the late report, but this old patch causes a build failure for me: Am 20.04.22 um 15:26 schrieb marcandre.lur...@redhat.com: From: Marc-André Lureau G_NORETURN was introduced in glib 2.68, fallback to G_GNUC_NORETURN in glib-compat. Note that this attribute must be placed befor

Re: [PATCH-for-8.0] block/dmg: Ignore C99 prototype declaration mismatch from

Am 27.03.23 um 23:09 schrieb Paolo Bonzini: Il lun 27 mar 2023, 20:58 Philippe Mathieu-Daudé ha scritto: > The warning can also be suppressed if the build uses `-isystem > /opt/homebrew/include` instead of `-I/opt/homebrew/include` as I just > have tested. Is that option adde

Re: [PATCH-for-8.0] block/dmg: Ignore C99 prototype declaration mismatch from

Am 27.03.23 um 17:13 schrieb Philippe Mathieu-Daudé: When liblzfe (Apple LZFSE compression library) is present (for example installed via 'brew') on Darwin, QEMU build fails as: Has header "lzfse.h" : YES Library lzfse found: YES Dependencies lzo support : NO

Re: [PATCH] Updated the FSF address to

Am 20.02.23 um 08:01 schrieb Khadija Kamran: From: Khadija Kamran The Free Software Foundation moved to a new address and some sources in QEMU referred to their old location. The address should be updated and replaced to a pointer to ... replaced by a pointer

Re: [RFC PATCH] docs/about/deprecated: Deprecate 32-bit host systems

Am 19.02.23 um 12:27 schrieb Reinoud Zandijk: On Fri, Feb 17, 2023 at 12:05:46PM +0100, Stefan Weil wrote: So there still seems to be a certain small need for QEMU installers for 32-bit Windows: 170 users für 32 bit only, 339 users for both 32 and 64 bit, 5132 users for 64 bit only. As you see

Re: [RFC PATCH] docs/about/deprecated: Deprecate 32-bit host systems

On Fri, Feb 17, 2023 at 11:36:41AM +0100, Markus Armbruster wrote: Which 32-bit hosts are still useful, and why? Citing my previous mail: I now checked all downloads of the latests installers since 2022-12-30. qemu-w32-setup-20221230.exe – 509 different IP addresses qemu-w64-setup-

Re: [PATCH v2 1/2] qga-win: add logging to Windows event log

Am 23.01.23 um 20:38 schrieb Andrey Drobyshev: Hi Stefan, On 1/23/23 19:28, Stefan Weil wrote: Hi, cross builds fail with this code. Please see details below. Am 29.11.22 um 18:38 schrieb Andrey Drobyshev via: This commit allows QGA to write to Windows event log using Win32 API's ReportEven

Re: [PATCH v2 1/2] qga-win: add logging to Windows event log

Hi, cross builds fail with this code. Please see details below. Am 29.11.22 um 18:38 schrieb Andrey Drobyshev via: This commit allows QGA to write to Windows event log using Win32 API's ReportEvent() [1], much like syslog() under *nix guests. In order to generate log message definitions we use

Re: Announcement of aborting HAXM maintenance

Am 19.01.23 um 11:12 schrieb Daniel P. Berrangé: On Thu, Jan 19, 2023 at 03:56:04AM +, Wang, Wenchao wrote: Hi, Philippe, Intel decided to abort the development of HAXM and the maintenance of its QEMU part. Should we submit a patch to mark the Guest CPU Cores (HAXM) status as Orphan and rem

Re: MSYS2 and libfdt

Am 19.01.23 um 09:14 schrieb Thomas Huth:  Hi all, in some spare minutes, I started playing with a patch to try to remove the dtc submodule from the QEMU git repository - according to https://repology.org/project/dtc/versions our supported build platforms should now all provide the minimum

Re: building qemu on windows 11

Am 12.01.23 um 16:16 schrieb Neal Elliott: Hello,              is it possible, or has anyone built qemu from the master branch using visual studio? I attempted to build the code using mingw64, but it failed to build. is there a current build document for windows? Building with Visual Studio

Re: [PATCH] .gitlab-ci.d/windows: Do not run the qtests in the msys2-32bit job

Am 06.01.23 um 09:19 schrieb Thomas Huth: On 06/01/2023 09.15, Stefan Weil wrote: Download numbers from yesterday for my latest Windows installers: qemu-w32-setup-20221230.exe - 243 qemu-w64-setup-20221230.exe - 6540 On Wednesday the ratio was 288 : 3516. As expected the 64-bit variant is

Re: [PATCH] .gitlab-ci.d/windows: Do not run the qtests in the msys2-32bit job

Am 06.01.23 um 08:49 schrieb Thomas Huth: On 05/01/2023 22.42, Philippe Mathieu-Daudé wrote: > That said, maybe it is time to deprecate the 32-bit > hosts? Certainly fine for me, but that's up to the Windows folks to decide. Maybe you could just suggest a patch to start the discussion?  Tho

Re: [PATCH v3 04/26] configure: don't enable cross compilers unless in target_list

Am 21.10.22 um 00:10 schrieb Richard Henderson: On 10/20/22 21:51, Alex Bennée wrote: This avoids the unfortunate effect of always builds the pc-bios blobs for targets the user isn't interested in. Suggested-by: Paolo Bonzini Signed-off-by: Alex Bennée ---   configure | 9 +   1 file c

Re: [PATCH v2] target/i386: Remove compilation errors when -Werror=maybe-uninitialized

Am 22.12.22 um 12:51 schrieb Philippe Mathieu-Daudé: On 22/12/22 12:18, Eric Auger wrote: Hi All, On 12/22/22 12:09, Daniel P. Berrangé wrote: On Thu, Dec 22, 2022 at 11:07:31AM +0100, Eric Auger wrote: Hi Philippe, On 12/22/22 10:01, Philippe Mathieu-Daudé wrote: On 22/12/22 09:18, Paolo

Re: [PATCH v2] target/i386: Remove compilation errors when -Werror=maybe-uninitialized

Am 21.12.22 um 17:36 schrieb Eric Auger: To avoid compilation errors when -Werror=maybe-uninitialized is used, replace 'case 3' by 'default'. Otherwise we get: ../target/i386/ops_sse.h: In function ‘helper_vpermdq_ymm’: ../target/i386/ops_sse.h:2495:13: error: ‘r3’ may be used uninitialized in

Re: [PATCH 1/6] disas: add G_GNUC_PRINTF to gstring_printf

Am 19.12.22 um 14:02 schrieb Daniel P. Berrangé: Signed-off-by: Daniel P. Berrangé --- disas.c | 1 + 1 file changed, 1 insertion(+) diff --git a/disas.c b/disas.c index 94d3b45042..31df8f5b89 100644 --- a/disas.c +++ b/disas.c @@ -239,6 +239,7 @@ void target_disas(FILE *out, CPUState *cpu,

Re: [PATCH] mailmap: Fix Stefan Weil author email

Qemu-devel +Stefan Weil Stefan Weil via # Next, replace old addresses by a more recent one. Aleksandar Markovic Signed-off-by: Stefan Weil Thanks! OpenPGP_0xE08C21D5677450AD.asc Description: OpenPGP public key OpenPGP_signature Description: OpenPGP digital signature

Re: [PULL 11/21] docs: Build and install all the docs in a single manual

Am 12.01.21 um 17:57 schrieb Peter Maydell: [...] diff --git a/docs/meson.build b/docs/meson.build index fae9849b79b..bb14eaebd3b 100644 --- a/docs/meson.build +++ b/docs/meson.build @@ -46,19 +46,11 @@ if build_docs meson.source_root() / 'docs/sphinx/qmp_lexer.py',

Compiler warnings with maximum warning level (was: Re: [PATCH for 7.2?] target/i386: Remove compilation errors when -Werror=maybe-uninitialized)

Am 07.12.22 um 20:11 schrieb Stefan Weil: On 12/7/22 14:24, Eric Auger wrote: Initialize r0-3 to avoid compilation errors when -Werror=maybe-uninitialized is used ../target/i386/ops_sse.h: In function ‘helper_vpermdq_ymm’: ../target/i386/ops_sse.h:2495:13: error: ‘r3’ may be used uninitialized

Re: [PATCH for 7.2?] target/i386: Remove compilation errors when -Werror=maybe-uninitialized

Am 07.12.22 um 19:22 schrieb Eric Auger: On 12/7/22 17:55, Philippe Mathieu-Daudé wrote: On 7/12/22 15:33, Eric Auger wrote: On 12/7/22 15:09, Stefan Hajnoczi wrote: On Wed, 7 Dec 2022 at 08:31, Eric Auger wrote: On 12/7/22 14:24, Eric Auger wrote: Initialize r0-3 to avoid compilation erro

Re: [PATCH v3 for-7.2 0/6] Add format attributes and fix format strings

Am 27.11.22 um 19:23 schrieb Stefan Hajnoczi: We need to wait for Michael to agree to maintainership in patch 5. If we run out of time I suggest splitting out patch 5. Reviewed-by: Stefan Hajnoczi Citing Michael from a v2 email: "pls do". Stefan Hello Michael, I just noticed tha

Re: [PATCH v3 for-7.2 4/6] libvhost-user: Add format attribute to local function vu_panic

Am 27.11.22 um 19:14 schrieb Stefan Hajnoczi: On Sat, 26 Nov 2022 at 10:25, Stefan Weil wrote: Signed-off-by: Stefan Weil Reviewed-by: Marc-André Lureau Message-Id: <20220422070144.1043697-4...@weilnetz.de> Signed-off-by: Laurent Vivier --- subprojects/libvhost-user/libvhost-user.c | 13 +

[PATCH v3 for-7.2 4/6] libvhost-user: Add format attribute to local function vu_panic

Signed-off-by: Stefan Weil Reviewed-by: Marc-André Lureau Message-Id: <20220422070144.1043697-4...@weilnetz.de> Signed-off-by: Laurent Vivier --- subprojects/libvhost-user/libvhost-user.c | 13 - 1 file changed, 12 insertions(+), 1 deletion(-) diff --git a/subprojects/libvhost-user

[PATCH v3 for-7.2 5/6] MAINTAINERS: Add subprojects/libvhost-user to section "vhost"

Signed-off-by: Stefan Weil --- MAINTAINERS | 1 + 1 file changed, 1 insertion(+) diff --git a/MAINTAINERS b/MAINTAINERS index cf24910249..6966490c94 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -2005,6 +2005,7 @@ F: docs/interop/vhost-user.rst F: contrib/vhost-user-*/ F: backends/vhost-user.c

[PATCH v3 for-7.2 6/6] Add G_GNUC_PRINTF to function qemu_set_info_str and fix related issues

With the G_GNUC_PRINTF function attribute the compiler detects two potential insecure format strings: ../../../net/stream.c:248:31: warning: format string is not a string literal (potentially insecure) [-Wformat-security] qemu_set_info_str(&s->nc, uri); ^~~ ../..

[PATCH v3 for-7.2 3/6] libvhost-user: Fix two more format strings

This fix is required for 32 bit hosts. The bug was detected by CI for arm-linux, but is also relevant for i386-linux. Reported-by: Stefan Hajnoczi Signed-off-by: Stefan Weil --- subprojects/libvhost-user/libvhost-user.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/subpr

[PATCH v3 for-7.2 0/6] Add format attributes and fix format strings

v3: - Fix description for patch 3 - Add patches 5 and 6 The patches 3 and 5 still need reviews! [PATCH v3 for-7.2 1/6] libvhost-user: Fix wrong type of argument to [PATCH v3 for-7.2 2/6] libvhost-user: Fix format strings [PATCH v3 for-7.2 3/6] libvhost-user: Fix two more format strings [PATCH v3

[PATCH v3 for-7.2 2/6] libvhost-user: Fix format strings

Signed-off-by: Stefan Weil Reviewed-by: Marc-André Lureau Message-Id: <20220422070144.1043697-3...@weilnetz.de> Signed-off-by: Laurent Vivier --- subprojects/libvhost-user/libvhost-user.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/subprojects/libvhost-user/libvhost-

[PATCH v3 for-7.2 1/6] libvhost-user: Fix wrong type of argument to formatting function (reported by LGTM)

Reviewed-by: Philippe Mathieu-Daudé Signed-off-by: Stefan Weil Message-Id: <20220422070144.1043697-2...@weilnetz.de> Signed-off-by: Laurent Vivier --- subprojects/libvhost-user/libvhost-user.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/subprojects/libvhost-user/libvhost

Re: [PATCH for 7.2-rc? v2 0/5] continuing efforts to fix vhost-user issues

Am 25.11.22 um 18:30 schrieb Alex Bennée: Hi, This is continuing to attempt to fix the various vhost-user issues that are currently plaguing the release. One concrete bug I've come across is that all qtest MMIO devices where being treated as legacy which caused the VIRTIO_F_VERSION_1 flag to get

Re: [PATCH for-7.2 v2 3/4] libvhost-user: Fix two more format strings

Am 23.11.22 um 07:35 schrieb Stefan Weil: Am 15.11.22 um 08:25 schrieb Stefan Weil: Am 05.11.22 um 11:24 schrieb Stefan Weil: This fix is required for 32 bit host. The bug was detected by CI for arm-linux, but is also relevant for i386-linux. Reported-by: Stefan Hajnoczi Signed-off-by: Stefa

Re: [PATCH for-7.2 v2 3/4] libvhost-user: Fix two more format strings

Am 15.11.22 um 08:25 schrieb Stefan Weil: Am 05.11.22 um 11:24 schrieb Stefan Weil: This fix is required for 32 bit host. The bug was detected by CI for arm-linux, but is also relevant for i386-linux. Reported-by: Stefan Hajnoczi Signed-off-by: Stefan Weil ---   subprojects/libvhost-user/lib

Re: [PATCH for-7.2 v2 3/4] libvhost-user: Fix two more format strings

Am 05.11.22 um 11:24 schrieb Stefan Weil: This fix is required for 32 bit host. The bug was detected by CI for arm-linux, but is also relevant for i386-linux. Reported-by: Stefan Hajnoczi Signed-off-by: Stefan Weil --- subprojects/libvhost-user/libvhost-user.c | 3 ++- 1 file changed, 2 in

[PATCH for-7.2] Add G_GNUC_PRINTF to function qemu_set_info_str and fix related issues

With the G_GNUC_PRINTF function attribute the compiler detects two potential insecure format strings: ../../../net/stream.c:248:31: warning: format string is not a string literal (potentially insecure) [-Wformat-security] qemu_set_info_str(&s->nc, uri); ^~~ ../..

Re: [PATCH] s390x: Fix spelling errors

Am 11.11.22 um 19:28 schrieb Thomas Huth: Fix typos (discovered with the 'codespell' utility). Signed-off-by: Thomas Huth --- hw/s390x/ipl.h | 2 +- pc-bios/s390-ccw/cio.h | 2 +- pc-bios/s390-ccw/iplb.h | 2 +- target/s390x/cpu_models.h

[RFC: PATCH v2] Add new build targets 'check-spelling' and 'check-spelling-docs'

`make check-spelling` can now be used to get a list of spelling errors. It uses the latest version of codespell, a spell checker implemented in Python. 'make check-spelling-docs' checks the generated documentation. Signed-off-by: Stefan Weil --- v2: Additional target check-spelling-docs, update

[PATCH for-7.2] Fix several typos in documentation (found by codespell)

Those typos are in files which are used to generate the QEMU manual. Signed-off-by: Stefan Weil --- I did not fix memory_region_init_resizeable_ram. That might be done after 7.2. Stefan docs/devel/acpi-bits.rst | 2 +- docs/system/devices/can.rst| 2 +- hw/scsi/esp.c

Re: [PATCH trivial for 7.2 1/2] hw/usb/hcd-xhci.c: spelling: tranfer

Am 05.11.22 um 22:24 schrieb Michael Tokarev: 05.11.2022 15:23, Stefan Weil via wrote: .. All typos from this series were also found by codespell. See https://qemu.weilnetz.de/test/typos7 for many more. That list was produced with `make check-spelling` from my previous patch). Yeah

Re: [PATCH trivial for 7.2 1/2] hw/usb/hcd-xhci.c: spelling: tranfer

Am 05.11.22 um 12:57 schrieb Stefan Weil via: Am 05.11.22 um 12:48 schrieb Michael Tokarev: Fixes: effaf5a240e03020f4ae953e10b764622c3e87cc Signed-off-by: Michael Tokarev ---   hw/usb/hcd-xhci.c | 2 +-   1 file changed, 1 insertion(+), 1 deletion(-) All typos from this series were also found

Re: [PATCH trivial for 7.2] hw/ssi/sifive_spi.c: spelling: reigster

Am 05.11.22 um 12:53 schrieb Michael Tokarev: Fixes: 0694dabe9763847f3010b54ab3ec7d367d2f0ff0 Signed-off-by: Michael Tokarev --- hw/ssi/sifive_spi.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/ssi/sifive_spi.c b/hw/ssi/sifive_spi.c index 03540cf5ca..1b4a401ca1 10064

Re: [PATCH trivial for 7.2 2/2] hw/virtio/virtio.c: spelling: suppoted

Am 05.11.22 um 12:48 schrieb Michael Tokarev: Fixes: f3034ad71fcd0a6a58bc37830f182b307f089159 Signed-off-by: Michael Tokarev --- hw/virtio/virtio.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/virtio/virtio.c b/hw/virtio/virtio.c index 808446b4c9..e76218bdd5 100644 -

Re: [PATCH trivial for 7.2 1/2] hw/usb/hcd-xhci.c: spelling: tranfer

Am 05.11.22 um 12:48 schrieb Michael Tokarev: Fixes: effaf5a240e03020f4ae953e10b764622c3e87cc Signed-off-by: Michael Tokarev --- hw/usb/hcd-xhci.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/usb/hcd-xhci.c b/hw/usb/hcd-xhci.c index 8299f35e66..b89b618ec2 100644 ---

[PATCH for-7.2] tests/qtest: Fix two format strings

Signed-off-by: Stefan Weil --- tests/qtest/migration-test.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/tests/qtest/migration-test.c b/tests/qtest/migration-test.c index d2eb107f0c..f574331b7b 100644 --- a/tests/qtest/migration-test.c +++ b/tests/qtest/migration-test.c

[PATCH for-7.2] accel/tcg: Suppress compiler warning with flag -Wclobbered

At least some versions of gcc show a warning when compiler flag -Wclobbered is used (tested with gcc on Debian bookworm i386 and with cross gcc for Windows on Debian bullseye). Signed-off-by: Stefan Weil --- accel/tcg/translate-all.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/accel/t

Re: [PATCH v2 3/4] libvhost-user: Fix two more format strings

Am 05.11.22 um 11:24 schrieb Stefan Weil via: This fix is required for 32 bit host. The bug was detected by CI for arm-linux, but is also relevant for i386-linux. s/host/hosts/ I won't send a v3 for that. Maybe it can be fixed when merging this patch. Stefan

[PATCH v2 for-7.2 0/4] libvhost-user: Add format attribute and fix format strings

v2: Add patch 3 to fix two more format strings before applying patch 4 [PATCH v2 1/4] libvhost-user: Fix wrong type of argument to [PATCH v2 2/4] libvhost-user: Fix format strings [PATCH v2 3/4] libvhost-user: Fix two more format strings [PATCH v2 4/4] libvhost-user: Add format attribute to local

[PATCH v2 1/4] libvhost-user: Fix wrong type of argument to formatting function (reported by LGTM)

Reviewed-by: Philippe Mathieu-Daudé Signed-off-by: Stefan Weil Message-Id: <20220422070144.1043697-2...@weilnetz.de> Signed-off-by: Laurent Vivier --- subprojects/libvhost-user/libvhost-user.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/subprojects/libvhost-user/libvhost

[PATCH v2 4/4] libvhost-user: Add format attribute to local function vu_panic

Signed-off-by: Stefan Weil Reviewed-by: Marc-André Lureau Message-Id: <20220422070144.1043697-4...@weilnetz.de> Signed-off-by: Laurent Vivier --- subprojects/libvhost-user/libvhost-user.c | 13 - 1 file changed, 12 insertions(+), 1 deletion(-) diff --git a/subprojects/libvhost-user

  1   2   >