Re: [Qemu-devel] [PATCH 2/2] linux-user: remove MAX_ARG_PAGES limit

2015-09-14 Thread Stefan Bruens
On Thursday 03 September 2015 18:27:20 Peter Maydell wrote: > On 2 September 2015 at 02:38, Stefan Brüns wrote: > > Instead of creating a temporary copy for the whole environment and > > the arguments, directly copy everything to the target stack. > > > > For this to work, we have to change the

Re: [Qemu-devel] [PATCH] linux-user: remove MAX_ARG_PAGES limit

2015-09-01 Thread Stefan Bruens
On Tuesday 01 September 2015 19:42:26 you wrote: > >> > --- a/linux-user/linuxload.c > >> > +++ b/linux-user/linuxload.c > >> > @@ -137,8 +137,7 @@ int loader_exec(int fdexec, const char *filename, > >> > char > >> > **argv, char **envp,> > >> > > >> > int retval; > >> > int i; > >> > >

Re: [Qemu-devel] [PATCH] linux-user: remove MAX_ARG_PAGES limit

2015-08-30 Thread Stefan Bruens
On Thursday 27 August 2015 21:35:41 Stefan Brüns wrote: PING! > Instead of creating a temporary copy for the whole environment and > the arguments, directly copy everything to the target stack. > > For this to work, we have to change the order of stack creation and > copying the arguments. > >

Re: [Qemu-devel] [PATCH] linux-user: remove MAX_ARG_PAGES limit

2015-08-27 Thread Stefan Bruens
On Sunday 23 August 2015 01:47:52 Stefan Brüns wrote: > Instead of creating a temporary copy for the whole environment and > the arguments, directly copy everything to the target stack. > > For this to work, we have to change the order of stack creation and > copying the arguments. > > Signed-off

Re: [Qemu-devel] [PATCH] linux-user: remove MAX_ARG_PAGES, allow dynamic growth of env/argv space

2015-08-22 Thread Stefan Bruens
On Wednesday 19 August 2015 22:57:53 you wrote: [...] > > I think we have enough repetitions of '32' here to merit a #define. > > But having said all that, I wonder if it would be better to > precalculate how big a page array we need and just do the > allocation once, rather than having this comp