Re: [PULL 0/6] Mostly target/i386 patches for QEMU 10.1 hard freeze

2025-07-20 Thread Stefan Hajnoczi
Applied, thanks. Please update the changelog at https://wiki.qemu.org/ChangeLog/10.1 for any user-visible changes. signature.asc Description: PGP signature

Re: [PULL 0/6] QAPI patches patches for 2025-07-16

2025-07-17 Thread Stefan Hajnoczi
Applied, thanks. Please update the changelog at https://wiki.qemu.org/ChangeLog/10.1 for any user-visible changes. signature.asc Description: PGP signature

Re: [PULL 0/2] 9p queue 2025-07-16

2025-07-17 Thread Stefan Hajnoczi
Applied, thanks. Please update the changelog at https://wiki.qemu.org/ChangeLog/10.1 for any user-visible changes. signature.asc Description: PGP signature

Re: [PULL 0/4] Misc crypto & UI patches

2025-07-17 Thread Stefan Hajnoczi
signal 6 (Aborted) (core dumped) (test program exited with status code -6) https://gitlab.com/qemu-project/qemu/-/jobs/10717452444#L69 Thanks! Stefan > > crypto/tlscredsx509.c | 23 +-- > crypto/x509-utils.c | 6 - > ui/trace-events | 14

Re: [PULL 0/7] vfio queue

2025-07-16 Thread Stefan Hajnoczi
Applied, thanks. Please update the changelog at https://wiki.qemu.org/ChangeLog/10.1 for any user-visible changes. signature.asc Description: PGP signature

Entering QEMU 10.1 soft freeze

2025-07-16 Thread Stefan Hajnoczi
ocess. By the date of the soft feature freeze, maintainers must have sent their pull request to the mailing list. This means that features, and in particular non-trivial ones, must have been merged into maintainer trees before the soft freeze date. Stefan

Re: [PULL v2 00/29] QAPI patches patches for 2025-07-14

2025-07-16 Thread Stefan Hajnoczi
Applied, thanks. Please update the changelog at https://wiki.qemu.org/ChangeLog/10.1 for any user-visible changes. signature.asc Description: PGP signature

Re: [PULL 00/97] virtio,pci,pc: features, fixes, tests

2025-07-16 Thread Stefan Hajnoczi
Applied, thanks. Please update the changelog at https://wiki.qemu.org/ChangeLog/10.1 for any user-visible changes. signature.asc Description: PGP signature

Re: [PULL V2 00/16] Net patches

2025-07-16 Thread Stefan Hajnoczi
Applied, thanks. Please update the changelog at https://wiki.qemu.org/ChangeLog/10.1 for any user-visible changes. signature.asc Description: PGP signature

Re: [PULL v2 00/13] Ui patches

2025-07-16 Thread Stefan Hajnoczi
Applied, thanks. Please update the changelog at https://wiki.qemu.org/ChangeLog/10.1 for any user-visible changes. signature.asc Description: PGP signature

Re: [PULL 00/17] Accelerators patches for 2025-07-15

2025-07-16 Thread Stefan Hajnoczi
Applied, thanks. Please update the changelog at https://wiki.qemu.org/ChangeLog/10.1 for any user-visible changes. signature.asc Description: PGP signature

Re: [PULL 00/57] Block layer patches

2025-07-16 Thread Stefan Hajnoczi
Applied, thanks. Please update the changelog at https://wiki.qemu.org/ChangeLog/10.1 for any user-visible changes. signature.asc Description: PGP signature

Re: [PULL 00/17] MIPS & Co. patches for 2025-07-15

2025-07-16 Thread Stefan Hajnoczi
Applied, thanks. Please update the changelog at https://wiki.qemu.org/ChangeLog/10.1 for any user-visible changes. signature.asc Description: PGP signature

Re: [PULL 00/13] Net patches

2025-07-16 Thread Stefan Hajnoczi
On Wed, Jul 16, 2025 at 6:26 AM Stefan Hajnoczi wrote: > > On Tue, Jul 15, 2025 at 10:23 PM Jason Wang wrote: > > > > Hi Stefan: > > > > On Wed, Jul 16, 2025 at 3:55 AM Stefan Hajnoczi wrote: > > > > > > Applied, thanks. > > > > > &

Re: [PULL 00/13] Net patches

2025-07-16 Thread Stefan Hajnoczi
On Tue, Jul 15, 2025 at 10:23 PM Jason Wang wrote: > > Hi Stefan: > > On Wed, Jul 16, 2025 at 3:55 AM Stefan Hajnoczi wrote: > > > > Applied, thanks. > > > > Please update the changelog at https://wiki.qemu.org/ChangeLog/10.1 for any > > user-vi

Re: [PULL 0/6] Trivial patches for 2025-07-13

2025-07-15 Thread Stefan Hajnoczi
Applied, thanks. Please update the changelog at https://wiki.qemu.org/ChangeLog/10.1 for any user-visible changes. signature.asc Description: PGP signature

Re: [PULL 0/8] maintainer updates for rc0 (gitlab, gdbstub, plugins, docs)

2025-07-15 Thread Stefan Hajnoczi
Applied, thanks. Please update the changelog at https://wiki.qemu.org/ChangeLog/10.1 for any user-visible changes. signature.asc Description: PGP signature

Re: [PULL 00/77] Rust, target/i386 changes for QEMU 10.1 soft freeze

2025-07-15 Thread Stefan Hajnoczi
Applied, thanks. Please update the changelog at https://wiki.qemu.org/ChangeLog/10.1 for any user-visible changes. signature.asc Description: PGP signature

Re: [PULL 00/13] Net patches

2025-07-15 Thread Stefan Hajnoczi
Applied, thanks. Please update the changelog at https://wiki.qemu.org/ChangeLog/10.1 for any user-visible changes. signature.asc Description: PGP signature

Re: [PULL 00/32] QAPI patches patches for 2025-07-14

2025-07-14 Thread Stefan Hajnoczi
7;value is None' (singleton-comparison) qemu/utils/qom.py:245:32: W1309: Using an f-string that does not have any interpolated variables (f-string-without-interpolation) qemu/utils/qom.py:35:0: W0611: Unused ExecuteError imported from qemu.qmp (unused-import) * Module utils.qom_common

Re: [PULL 00/13] Ui patches

2025-07-14 Thread Stefan Hajnoczi
h linear layout when gl=on is > > specified > > ui/spice: Blit the scanout texture if its memory layout is not linear > > > > Weifeng Liu (2): > > ui/gtk: Add keep-aspect-ratio option > > ui/gtk: Add scale option > > NACK, will resend because when Spice is not recent enough: > ../ui/spice-core.c: In function 'qemu_spice_init': > ../ui/spice-core.c:673:17: error: unused variable 'video_codec' > [-Werror=unused-variable] Okay, holding off on this pull request. Stefan

Re: [PULL 000/119] target-arm queue

2025-07-13 Thread Stefan Hajnoczi
Applied, thanks. Please update the changelog at https://wiki.qemu.org/ChangeLog/10.1 for any user-visible changes. signature.asc Description: PGP signature

Re: [PULL 0/9] tcg/linux-user/fpu patch queue

2025-07-13 Thread Stefan Hajnoczi
Applied, thanks. Please update the changelog at https://wiki.qemu.org/ChangeLog/10.1 for any user-visible changes. signature.asc Description: PGP signature

Re: [PULL 00/15] functional tests and s390x patches

2025-07-13 Thread Stefan Hajnoczi
Applied, thanks. Please update the changelog at https://wiki.qemu.org/ChangeLog/10.1 for any user-visible changes. signature.asc Description: PGP signature

Re: [PULL 00/36] target-arm queue

2025-07-13 Thread Stefan Hajnoczi
Applied, thanks. Please update the changelog at https://wiki.qemu.org/ChangeLog/10.1 for any user-visible changes. signature.asc Description: PGP signature

Re: [PULL v2 00/36] Accelerators patches for 2025-07-04

2025-07-13 Thread Stefan Hajnoczi
Applied, thanks. Please update the changelog at https://wiki.qemu.org/ChangeLog/10.1 for any user-visible changes. signature.asc Description: PGP signature

Re: [PULL v2 0/4] loongarch-to-apply queue

2025-07-13 Thread Stefan Hajnoczi
Applied, thanks. Please update the changelog at https://wiki.qemu.org/ChangeLog/10.1 for any user-visible changes. signature.asc Description: PGP signature

Re: [PULL 00/26] Migration patches for 2025-07-11

2025-07-13 Thread Stefan Hajnoczi
Applied, thanks. Please update the changelog at https://wiki.qemu.org/ChangeLog/10.1 for any user-visible changes. signature.asc Description: PGP signature

Re: [PULL 0/4] loongarch-to-apply queue

2025-07-10 Thread Stefan Hajnoczi
~ | %llu /private/var/folders/7m/kxwv39y54d9g6lmkzwbqwk8rgn/T/cirrus-ci-build/include/qemu/log.h:57:30: note: expanded from macro 'qemu_log_mask' 57 | qemu_log(FMT, ## __VA_ARGS__); \ | ~~~ ^~~ https://gitlab.com/qemu-project/qemu/-/jobs/10637285043 Thanks, Stefan > >

Bamboo ppc Linux image URL is 404

2025-07-07 Thread Stefan Hajnoczi
/10592622177#L1047 Please take action to make the job pass again. Thanks! Thanks, Stefan

Re: [PATCH 5/6] target/arm: Share ARM_PSCI_CALL trace event between TCG and HVF

2025-07-07 Thread Stefan Hajnoczi
On Fri, Jul 04, 2025 at 02:14:35PM +0100, Peter Maydell wrote: > On Mon, 30 Jun 2025 at 17:53, Pierrick Bouvier > wrote: > > > > On 6/30/25 6:09 AM, Philippe Mathieu-Daudé wrote: > > > It is useful to compare PSCI calls of the same guest running > > > under TCG or HVF. > > > > > > Signed-off-by: P

Re: [PULL 00/31] Accelerators patches for 2025-07-04

2025-07-04 Thread Stefan Hajnoczi
Applied, thanks. Please update the changelog at https://wiki.qemu.org/ChangeLog/10.1 for any user-visible changes. signature.asc Description: PGP signature

Re: [PULL 00/11] aspeed queue

2025-07-04 Thread Stefan Hajnoczi
Applied, thanks. Please update the changelog at https://wiki.qemu.org/ChangeLog/10.1 for any user-visible changes. signature.asc Description: PGP signature

Re: [PULL 00/40] riscv-to-apply queue

2025-07-04 Thread Stefan Hajnoczi
Applied, thanks. Please update the changelog at https://wiki.qemu.org/ChangeLog/10.1 for any user-visible changes. signature.asc Description: PGP signature

Re: [PULL 00/27] vfio queue

2025-07-04 Thread Stefan Hajnoczi
Applied, thanks. Please update the changelog at https://wiki.qemu.org/ChangeLog/10.1 for any user-visible changes. signature.asc Description: PGP signature

Re: [PULL 0/9] Various fixes for MAINTAINERS, s390x and tests

2025-07-04 Thread Stefan Hajnoczi
Applied, thanks. Please update the changelog at https://wiki.qemu.org/ChangeLog/10.1 for any user-visible changes. signature.asc Description: PGP signature

Re: [PULL 00/15] Maintainer updates for June (gitlab, semihosting, plugins, virtio-gpu)

2025-07-04 Thread Stefan Hajnoczi
Applied, thanks. Please update the changelog at https://wiki.qemu.org/ChangeLog/10.1 for any user-visible changes. signature.asc Description: PGP signature

Re: [PULL 00/43] target-arm queue

2025-07-02 Thread Stefan Hajnoczi
Applied, thanks. Please update the changelog at https://wiki.qemu.org/ChangeLog/10.1 for any user-visible changes. signature.asc Description: PGP signature

Re: [PULL 0/3] Misc QGA fixes for 2025-07-01

2025-07-02 Thread Stefan Hajnoczi
Applied, thanks. Please update the changelog at https://wiki.qemu.org/ChangeLog/10.1 for any user-visible changes. signature.asc Description: PGP signature

Re: [PATCH] tests/functional/test_aarch64_sbsaref_freebsd: Fix the URL of the ISO image

2025-07-02 Thread Stefan Hajnoczi
fer > the XZ compressed image, it's much smaller and thus the download > should be faster. > > Signed-off-by: Thomas Huth > --- > tests/functional/test_aarch64_sbsaref_freebsd.py | 8 > 1 file changed, 4 insertions(+), 4 deletions(-) Reviewed-by: St

Re: FreeBSD 14.1 aarch64 iso URL is down

2025-07-02 Thread Stefan Hajnoczi
Warner: If you want to update the test environment to 14.3 or change which URLs QEMU's test suite uses, please feel free to send additional patches. For now Thomas' patch will let the test pass again. Stefan

Re: [PULL 00/29] tcg patch queue

2025-07-02 Thread Stefan Hajnoczi
Applied, thanks. Please update the changelog at https://wiki.qemu.org/ChangeLog/10.1 for any user-visible changes. signature.asc Description: PGP signature

Re: [PATCH] trace: log.py: human-readable timestamp

2025-06-29 Thread Stefan Hajnoczi
line with date, to be similar with warn_report() as well. > > Signed-off-by: Vladimir Sementsov-Ogievskiy > --- > scripts/tracetool/backend/log.py | 11 --- > 1 file changed, 8 insertions(+), 3 deletions(-) Thanks, applied to my tracing tree: https://gitlab.com/s

Re: [PULL 00/25] vfio queue

2025-06-27 Thread Stefan Hajnoczi
Applied, thanks. Please update the changelog at https://wiki.qemu.org/ChangeLog/10.1 for any user-visible changes. signature.asc Description: PGP signature

Re: [PULL 00/19] s390x and misc patches

2025-06-27 Thread Stefan Hajnoczi
Applied, thanks. Please update the changelog at https://wiki.qemu.org/ChangeLog/10.1 for any user-visible changes. signature.asc Description: PGP signature

Re: [PATCH v3] tracetool: generates conitional checks when needed

2025-06-26 Thread Stefan Hajnoczi
'}', > -'}', > -api_nocheck=e.api(e.QEMU_TRACE_NOCHECK), > -names=", ".join(e.args.names()), > +if hasCondition[0]: > +out('if (%(cond)s) {', > cond=cond) > + > +if "disable" not in e.properties: > +backend.generate(e, group) > + > +if hasCondition[0]: > +out('}') > +out('}') This doesn't handle cases where some backends (like dtrace) do not want trace_event_get_state() but some backends (like simple) do. You can test that case with ./configure --enable-trace-backends=dtrace,simple. Both types of backends need to have their generate function called separately: ...backends without the conditional... if (trace_event_get_state(...)) { ...backends with the conditional... } The hasCondition list argument can be avoided by returning bool from generate_h_conditional() instead of modifying the argument. That's a little cleaner than the pass-by-reference trick where each backend has to logical-or in their value. The generate_h_conditional() function could also be replace with a module variable like the existing PUBLIC variable. That way backends can simply declare what they want instead of implementing a function: CHECK_TRACE_EVENT_GET_STATE = True # or False And the code in h.py would know whether to call the generate function inside the conditional or not. (I snuck in another suggestion: changing the name from "conditional", which is a general term, to "check_trace_event_get_state" to be more specific about what it does.) Stefan signature.asc Description: PGP signature

Re: [PATCH v5 3/3] docs: define policy forbidding use of AI code generators

2025-06-25 Thread Stefan Hajnoczi
ts. > > > The policy we set now must be for today, and be open to revision. It's > > > best to start strict and safe, then relax. > > > > > > Meanwhile requests for exceptions can also be considered on a case by > > > case basis. > > > > > &

Re: [PATCH v2 2/3] tracetool: introduce generate_unconditional

2025-06-25 Thread Stefan Hajnoczi
should have a .condition() interface so that scripts/tracetool/format/h.py:generate() can first collect a dict[cond] -> backend. Then it iterates over the map, calling backend.generate() within "if (%(cond)s) { ... }". That way only the conditions that are actually needed are generated and multiple backends that have the same condition will share the same if statement. Stefan signature.asc Description: PGP signature

Re: [PATCH v5 7/7] vhost-user-devive: Add shmem BAR

2025-06-25 Thread Stefan Hajnoczi
On Mon, Jun 09, 2025 at 04:47:29PM +0200, Albert Esteve wrote: > diff --git a/hw/virtio/vhost-user-device-pci.c > b/hw/virtio/vhost-user-device-pci.c > index f10bac874e..eeb52671a0 100644 > --- a/hw/virtio/vhost-user-device-pci.c > +++ b/hw/virtio/vhost-user-device-pci.c > @@ -8,14 +8,18 @@ > */

Re: [PATCH v5 0/3] docs: define policy forbidding use of "AI" / LLM code generators

2025-06-24 Thread Stefan Hajnoczi
On Tue, Jun 24, 2025 at 1:02 AM Markus Armbruster wrote: > > Alex Bennée writes: > > > Stefan Hajnoczi writes: > > > >> Any final comments before I merge this? > > > > It's well reviewed lets get it merged. > > Stefan, would you like a PR fr

Re: [PATCH 3/3] backends/tpm: Propagate vTPM error on migration failure

2025-06-24 Thread Stefan Berger
rate"} Buglink: https://issues.redhat.com/browse/RHEL-82826 Signed-off-by: Arun Menon Reviewed-by: Stefan Berger --- backends/tpm/tpm_emulator.c | 39 --- include/migration/vmstate.h | 1 + migration/vmstate.c | 4 +++- 3 files changed,

Re: [PULL 00/11] Migration staging patches

2025-06-24 Thread Stefan Hajnoczi
Applied, thanks. Please update the changelog at https://wiki.qemu.org/ChangeLog/10.1 for any user-visible changes. signature.asc Description: PGP signature

Re: [PATCH v5 0/3] docs: define policy forbidding use of "AI" / LLM code generators

2025-06-24 Thread Stefan Hajnoczi
clause [Peter] > > Changes in v4 [Markus Armbruster]: > * PATCH 1: >- Revert v3's "known identity", and instead move existing paragraph > from submitting-a-patch.rst to code-provenance.rst [Philippe] >- Add a paragraph on recording maintainer modification

Re: [PATCH v2 3/3] tracetool: remove redundant event_get_state checks

2025-06-24 Thread Stefan Hajnoczi
On Fri, Jun 20, 2025 at 02:37:20PM +, Tanish Desai wrote: > diff --git a/scripts/tracetool/backend/ftrace.py > b/scripts/tracetool/backend/ftrace.py > index baed2ae61c..2d6d608add 100644 > --- a/scripts/tracetool/backend/ftrace.py > +++ b/scripts/tracetool/backend/ftrace.py > @@ -34,18 +34,15

Re: FreeBSD 14.1 aarch64 iso URL is down

2025-06-24 Thread Stefan Hajnoczi
On Tue, Jun 24, 2025 at 1:41 PM Warner Losh wrote: > > On Tue, Jun 24, 2025 at 11:16 AM Stefan Hajnoczi wrote: > > > > On Tue, Jun 24, 2025 at 12:28 PM Warner Losh wrote: > > > > > > On Tue, Jun 24, 2025 at 10:02 AM Thomas Huth wrote: > > > >

Re: FreeBSD 14.1 aarch64 iso URL is down

2025-06-24 Thread Stefan Hajnoczi
On Tue, Jun 24, 2025 at 12:28 PM Warner Losh wrote: > > On Tue, Jun 24, 2025 at 10:02 AM Thomas Huth wrote: > > > > On 22/06/2025 03.46, Warner Losh wrote: > > > > > > > > > On Sat, Jun 21, 2025, 6:01 PM Stefan Hajnoczi > > <mailto:stef

Re: [PATCH v5 4/7] vhost_user: Add frontend get_shmem_config command

2025-06-24 Thread Stefan Hajnoczi
| 10 +++ > include/hw/virtio/vhost-user.h| 1 + > include/hw/virtio/virtio.h| 2 ++ > 4 files changed, 56 insertions(+) Reviewed-by: Stefan Hajnoczi signature.asc Description: PGP signature

Re: [PATCH v2 2/3] tracetool: introduce generate_unconditional

2025-06-24 Thread Stefan Hajnoczi
n that doesn't hard-code trace_event_get_state() is nicer, but it's okay if you want to introduce the concept of "conditional" meaning specifically trace_event_get_state() since there are no other cases where we want to merge two conditionals. I don't really mind. > >

Re: [PULL 00/11] tcg patch queue

2025-06-24 Thread Stefan Hajnoczi
Applied, thanks. Please update the changelog at https://wiki.qemu.org/ChangeLog/10.1 for any user-visible changes. signature.asc Description: PGP signature

Re: [PULL 24/24] i386/tdx: handle TDG.VP.VMCALL

2025-06-24 Thread Stefan Hajnoczi
On Mon, Jun 23, 2025 at 4:37 PM Cédric Le Goater wrote: > > On 6/23/25 20:57, Stefan Hajnoczi wrote: > > On Mon, Jun 23, 2025 at 9:09 AM Daniel P. Berrangé > > wrote: > >> > >> On Mon, Jun 23, 2025 at 09:04:33AM -0400, Stefan Hajnoczi wrote: > >&

Re: [PULL 00/14] loongarch-to-apply queue

2025-06-23 Thread Stefan Hajnoczi
On Sun, Jun 22, 2025 at 10:39 PM gaosong wrote: > > 在 2025/6/21 上午2:12, Stefan Hajnoczi 写道: > > On Thu, Jun 19, 2025 at 11:11 PM gaosong wrote: > >> 在 2025/6/20 上午4:39, Stefan Hajnoczi 写道: > >>> gpg:using RSA key CA473C44D6A09C189A193FCD452B96

Re: [PATCH v5 0/3] docs: define policy forbidding use of "AI" / LLM code generators

2025-06-23 Thread Stefan Hajnoczi
enerated code. > > Perhaps a few years down the line the legal uncertainty will have > reduced and we can re-evaluate this policy. > > Discuss... Any final comments before I merge this? Stefan > > Changes in v4 [Markus Armbruster]: > * PATCH 2: >- Drop "

Re: [PULL 24/24] i386/tdx: handle TDG.VP.VMCALL

2025-06-23 Thread Stefan Hajnoczi
On Mon, Jun 23, 2025 at 9:09 AM Daniel P. Berrangé wrote: > > On Mon, Jun 23, 2025 at 09:04:33AM -0400, Stefan Hajnoczi wrote: > > On Mon, Jun 23, 2025 at 4:04 AM Daniel P. Berrangé > > wrote: > > > > > > On Mon, Jun 23, 2025 at 03:03:19PM +0800, Xiaoyao Li

Re: [PULL 24/24] i386/tdx: handle TDG.VP.VMCALL

2025-06-23 Thread Stefan Hajnoczi
vm/tdx-quote-generator.c > > > > > > These changes broke the build on 32-bit host. > > > > > > Could you please send a patch to avoid compiling TDX in such environment ? > > > > Paolo is on vacation. > > > > I would like to help, but I don't have 32-bit host environment on hand. Do > > you know how to set up such environment quickly? (I tried to set up within a > > 32-bit VM but the 32-bit OS is too old and I didn't get it work to install > > the required package for building QEMU) > > You should be able to use QEMU's docker containers to get yourself a > Debian i386 container, on a x86_64 host. The cross-i686-system (Debian) build CI job succeeded: https://gitlab.com/qemu-project/qemu/-/jobs/10423776600 I wonder why the CI didn't catch the issue? Stefan

Re: FreeBSD 14.1 aarch64 iso URL is down

2025-06-21 Thread Stefan Hajnoczi
On Sat, Jun 21, 2025 at 7:59 PM Stefan Hajnoczi wrote: (I forgot to CC qemu-devel) > > Hi, > This might only be temporary, but the CI is getting HTTP 404 Not Found > for the following URL: > https://download.freebsd.org/releases/arm64/aarch64/ISO-IMAGES/14.1/FreeBSD-14.1-RELEAS

Re: [PULL 00/14] loongarch-to-apply queue

2025-06-20 Thread Stefan Hajnoczi
On Thu, Jun 19, 2025 at 11:11 PM gaosong wrote: > > 在 2025/6/20 上午4:39, Stefan Hajnoczi 写道: > > gpg:using RSA key CA473C44D6A09C189A193FCD452B96852B268216 > > gpg: Can't check signature: No public key > > > > Why has the GPG key changed? Yo

[PATCH v2 02/12] aio-posix: keep polling enabled with fdmon-io_uring.c

2025-06-19 Thread Stefan Hajnoczi
t == 0. Extend the optimization to handle the case when need_wait() returns true and timeout == 0. Cc: Chao Gao Signed-off-by: Stefan Hajnoczi Reviewed-by: Eric Blake --- util/aio-posix.c | 11 +-- 1 file changed, 9 insertions(+), 2 deletions(-) diff --git a/util/aio-posix.c b/uti

[PATCH v2 03/12] tests/unit: skip test-nested-aio-poll with io_uring

2025-06-19 Thread Stefan Hajnoczi
test-nested-aio-poll relies on internal details of how fdmon-poll.c handles AioContext polling. Skip it when other fdmon implementations are in use. Note that this test is only built on POSIX systems so it is safe to include "util/aio-posix.h". Signed-off-by: Stefan Hajnoczi Reviewe

[PATCH v2 09/12] aio-posix: add aio_add_sqe() API for user-defined io_uring requests

2025-06-19 Thread Stefan Hajnoczi
r, this is why. Signed-off-by: Stefan Hajnoczi Reviewed-by: Eric Blake --- v2: - Fix pre_sqe -> prep_sqe typo [Eric] - Add #endif terminator comment [Eric] --- include/block/aio.h | 84 ++- util/aio-posix.h | 1 + util/aio-posix.c | 9 +++ util/fdmon-io_

[PATCH v2 08/12] aio-posix: gracefully handle io_uring_queue_init() failure

2025-06-19 Thread Stefan Hajnoczi
ercase the error message when converting from error_report() to error_setg_errno() for consistency (but there are instances of lowercase in the codebase). - It's easier to move the #ifdefs from aio-posix.h to aio-posix.c. Signed-off-by: Stefan Hajnoczi --- util/aio-posix.h | 12 ++-

[PATCH v2 01/12] aio-posix: fix race between io_uring CQE and AioHandler deletion

2025-06-19 Thread Stefan Hajnoczi
e this problem by keeping the AioHandler alive but setting a flag so that it will be deleted by fill_sq_ring() when it runs. Signed-off-by: Stefan Hajnoczi --- util/fdmon-io_uring.c | 26 +++--- 1 file changed, 19 insertions(+), 7 deletions(-) diff --git a/util/fdmon-io_uring.

[PATCH v2 11/12] block/io_uring: use aio_add_sqe()

2025-06-19 Thread Stefan Hajnoczi
essages are not supposed to end with punctuation, so I removed a '.' for the non-io_uring build error message. Signed-off-by: Stefan Hajnoczi Reviewed-by: Eric Blake --- include/block/aio.h | 7 - include/block/raw-aio.h | 5 - block/file-posix.c | 40 ++-- bloc

[PATCH v2 07/12] aio: add errp argument to aio_context_setup()

2025-06-19 Thread Stefan Hajnoczi
so that errors can be propagated. The next commit will set errp when fdmon_io_uring_setup() fails. Suggested-by: Kevin Wolf Signed-off-by: Stefan Hajnoczi Reviewed-by: Eric Blake --- include/block/aio.h | 3 ++- util/aio-posix.c| 2 +- util/aio-win32.c| 2 +- util/async.c| 7 ++

[PATCH v2 12/12] block/io_uring: use non-vectored read/write when possible

2025-06-19 Thread Stefan Hajnoczi
The io_uring_prep_readv2/writev2() man pages recommend using the non-vectored read/write operations when possible for performance reasons. I didn't measure a significant difference but it doesn't hurt to have this optimization in place. Suggested-by: Eric Blake Signed-off-by: Stefa

[PATCH v2 00/12] aio: add the aio_add_sqe() io_uring API

2025-06-19 Thread Stefan Hajnoczi
s the following older series that were held off from merging until the QEMU 10.1 development window opened and the performance results were collected: - "[PATCH 0/3] [RESEND] block: unify block and fdmon io_uring" - "[PATCH 0/4] aio-posix: integrate fdmon into glib event loop" St

[PATCH v2 05/12] aio: remove aio_context_use_g_source()

2025-06-19 Thread Stefan Hajnoczi
There is no need for aio_context_use_g_source() now that epoll(7) and io_uring(7) file descriptor monitoring works with the glib event loop. AioContext doesn't need to be notified that GSource is being used. Signed-off-by: Stefan Hajnoczi Reviewed-by: Eric Blake --- include/block/

[PATCH v2 04/12] aio-posix: integrate fdmon into glib event loop

2025-06-19 Thread Stefan Hajnoczi
ng AioContext proved difficult so this commit makes all the changes. The next commit will remove the aio_context_use_g_source() API because it is no longer needed. Signed-off-by: Stefan Hajnoczi Reviewed-by: Eric Blake --- include/block/aio.h | 36 ++ util/aio-posix.h | 5

[PATCH v2 10/12] aio-posix: avoid EventNotifier for cqe_handler_bh

2025-06-19 Thread Stefan Hajnoczi
mentors can reset notify_me themselves. This makes things complex and the other fdmon implementations don't need it, so it doesn't seem like a good solution. So in the end I moved the qemu_bh_schedule() call from fdmon-io_uring.c to aio-posix.c. It's ugly but straightforwa

[PATCH v2 06/12] aio: free AioContext when aio_context_new() fails

2025-06-19 Thread Stefan Hajnoczi
#x27;t release any resources that aio_context_setup() acquired. Signed-off-by: Stefan Hajnoczi Reviewed-by: Eric Blake --- v2: - Fix spacing in aio_ctx_finalize() argument list [Eric] --- include/block/aio.h | 3 +++ util/async.c| 14 +++--- 2 files changed, 14 insertions(+), 3

Re: [PULL 00/14] loongarch-to-apply queue

2025-06-19 Thread Stefan Hajnoczi
On Thu, Jun 19, 2025 at 4:51 AM Song Gao wrote: > > The following changes since commit 6e1571533fd92bec67e5ab9b1dd1e15032925757: > > Merge tag 'tracing-pull-request' of https://gitlab.com/stefanha/qemu into > staging (2025-06-16 13:47:19 -0400) > > are available in the Git repository at: > >

Re: [PULL v2 00/31] Block patches

2025-06-17 Thread Stefan Hajnoczi
Applied, thanks. Please update the changelog at https://wiki.qemu.org/ChangeLog/10.1 for any user-visible changes. signature.asc Description: PGP signature

Re: [PULL 0/9] target-arm queue

2025-06-17 Thread Stefan Hajnoczi
Applied, thanks. Please update the changelog at https://wiki.qemu.org/ChangeLog/10.1 for any user-visible changes. signature.asc Description: PGP signature

Re: [PULL 0/2] QGA patches for 2025-06-12

2025-06-17 Thread Stefan Hajnoczi
Applied, thanks. Please update the changelog at https://wiki.qemu.org/ChangeLog/10.1 for any user-visible changes. signature.asc Description: PGP signature

Re: [PULL v3 0/1] Tracing patches

2025-06-17 Thread Stefan Hajnoczi
Applied, thanks. Please update the changelog at https://wiki.qemu.org/ChangeLog/10.1 for any user-visible changes. signature.asc Description: PGP signature

Re: [PATCH 0/3] tracetool:cleanup "if(true)" check from trace_foo()

2025-06-17 Thread Stefan Hajnoczi
On Mon, Jun 16, 2025 at 08:12:19PM +, Tanish Desai wrote: > This series of patch aims to removes the leftover if (true) condition from > trace_foo, a remnant from the TCG tracing feature removal. > It replaces it with a proper trace_event_get_state(...) check where > necessary(for log/simple/

Re: [PATCH 1/3] tracetool: removed the unused vcpu property

2025-06-17 Thread Stefan Hajnoczi
cetool/backend/log.py| 6 +- > scripts/tracetool/backend/simple.py | 6 +- > scripts/tracetool/backend/syslog.py | 6 +- > 3 files changed, 3 insertions(+), 15 deletions(-) Please also remove "vcpu" from scripts/tracetool/__init__.py:Event: _VALID_PROPS = set([

Re: [PATCH] rust: hpet: fix new warning

2025-06-17 Thread Stefan Hajnoczi
o Bonzini > --- > rust/hw/timer/hpet/src/device.rs | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Reviewed-by: Stefan Hajnoczi signature.asc Description: PGP signature

Re: [PULL 0/2] Seabios 1.17.0 20250611 patches

2025-06-16 Thread Stefan Hajnoczi
On Thu, Jun 12, 2025 at 11:05 AM Thomas Huth wrote: > > On 12/06/2025 15.08, Stefan Hajnoczi wrote: > > On Thu, Jun 12, 2025 at 12:36 AM Thomas Huth wrote: > >> > >> On 11/06/2025 21.09, Stefan Hajnoczi wrote: > >>> On Wed, Jun 11, 2025 at 2:36 PM Thoma

[PULL v3 0/1] Tracing patches

2025-06-16 Thread Stefan Hajnoczi
The following changes since commit a6f02277595136832c9e9bcaf447ab574f7b1128: Merge tag 'block-pull-request' of https://gitlab.com/stefanha/qemu into staging (2025-06-12 14:16:11 -0400) are available in the Git repository at: https://gitlab.com/stefanha/qemu.git tags/tracing-pull-request fo

[PULL v3 1/1] meson: fix Windows build

2025-06-16 Thread Stefan Hajnoczi
prevent warnings in generated files. Signed-off-by: oltolm Message-id: 20250612221521.1109-2-oleg.tolmat...@gmail.com Signed-off-by: Stefan Hajnoczi --- contrib/plugins/meson.build | 2 +- plugins/meson.build | 2 +- scripts/tracetool/__init__.py | 15

Re: New CI error due to mismatched lifetime in hpet device

2025-06-16 Thread Stefan Hajnoczi
On Mon, Jun 16, 2025 at 1:00 PM Paolo Bonzini wrote: > > On 6/16/25 18:46, Stefan Hajnoczi wrote: > > Hi Paolo, > > The CI is hitting the following new issue in rust/hw/hpet/device.rs: > > Thanks! I just saw it as well. > > As you've noticed, this job is allowe

New CI error due to mismatched lifetime in hpet device

2025-06-16 Thread Stefan Hajnoczi
erences and use the anonymous lifetime for paths | 770 | fn decode(&self, mut addr: hwaddr, size: u32) -> HPETAddrDecode<'_> { | error: aborting due to 1 previous error https://gitlab.com/qemu-project/qemu/-/jobs/10338038013#L5165 Stefan

Re: [PATCH RESEND v3] meson: fix Windows build

2025-06-12 Thread Stefan Hajnoczi
ath.relpath(event.filename), > +event_filename=event.filename, > name=event.name, > fmt=event.fmt.rstrip("\n"), > argnames=argnames) > diff --git a/tests/functional/meson.build b/tests/functional/meson.build > index 52b4706cf..ee222888

[PULL v2 0/1] Tracing patches

2025-06-12 Thread Stefan Hajnoczi
The following changes since commit d9ce74873a6a5a7c504379857461e4ae64fcf0cd: Merge tag 'pull-vfio-20250611' of https://github.com/legoater/qemu into staging (2025-06-11 11:39:53 -0400) are available in the Git repository at: https://gitlab.com/stefanha/qemu.git tags/tracing-pull-request fo

[PULL v2 1/1] meson: fix Windows build

2025-06-12 Thread Stefan Hajnoczi
prevent warnings in generated files. Signed-off-by: oltolm Reviewed-by: Stefan Hajnoczi Acked-by: Alex Bennée Message-id: 20250607094503.1307-2-oleg.tolmat...@gmail.com [Edit commit description based on suggestions from BALATON Zoltan and Peter Maydell --Stefan] Signed-off-by: Stefan Hajnoczi

[PULL v2 11/31] hw/audio/marvell_88w8618: skip automatic zero-init of large array

2025-06-12 Thread Stefan Hajnoczi
lly initialized when reading data from device memory. Signed-off-by: Daniel P. Berrangé Reviewed-by: Stefan Hajnoczi Message-id: 20250610123709.835102-12-berra...@redhat.com [Fixed hw/audio/gus in commit message --Stefan] Signed-off-by: Stefan Hajnoczi --- hw/audio/marvell_88w8618.c | 2 +- 1 file

[PULL v2 00/31] Block patches

2025-06-12 Thread Stefan Hajnoczi
zero-init of large array Stefan Hajnoczi (2): include/qemu/compiler: add QEMU_UNINITIALIZED attribute macro hw/virtio/virtio: avoid cost of -ftrivial-auto-var-init in hot path include/qemu/compiler.h| 20 block/linux-aio.c | 2 +- chardev/char-fd.c

Re: [PATCH v5 1/7] vhost-user: Add VirtIO Shared Memory map request

2025-06-12 Thread Stefan Hajnoczi
On Mon, Jun 09, 2025 at 04:47:23PM +0200, Albert Esteve wrote: > Add SHMEM_MAP/UNMAP requests to vhost-user to > handle VIRTIO Shared Memory mappings. > > This request allows backends to dynamically map > fds into a VIRTIO Shared Memory Region indentified identified > by its `shmid`. The map is

Re: [PULL 0/2] Seabios 1.17.0 20250611 patches

2025-06-12 Thread Stefan Hajnoczi
't be a regression from QEMU's POV. > > Also not when looking at seabios release tags. Okay, thanks Gerd and Daniel. The SeaBIOS update has been merged and will not be reverted. Stefan

Re: [PULL 0/2] Seabios 1.17.0 20250611 patches

2025-06-12 Thread Stefan Hajnoczi
ust do a forced update once to get them back in sync. Do you still want me to go ahead with the SeaBIOS update you posted? I'm asking because if QEMU drops the commit I mentioned above, then I guess EDK2 CSM AHCI detection will break. That would be a regression. Stefan

  1   2   3   4   5   6   7   8   9   10   >