RE: [EXTERNAL] [PATCH v3 for 9.1 5/6] vhost/vhost-user: Add VIRTIO_F_NOTIFICATION_DATA to vhost feature bits

2024-03-18 Thread Srujana Challa
ing and providing > support for this feature, and that it can be disabled if the backend does not > support it. > > Tested-by: Lei Yang > Reviewed-by: Eugenio Pérez > Signed-off-by: Jonah Palmer > --- Acked-by: Srujana Challa > hw/block/vhost-user-blk.c| 1 + &g

RE: [EXT] Re: [PATCH] vhost_net: add NOTIFICATION_DATA and IN_ORDER feature bits to vdpa_feature_bits

2024-03-08 Thread Srujana Challa
l S. Tsirkin > > > Sent: Monday, February 19, 2024 3:15 PM > > > To: Srujana Challa > > > Cc: qemu-devel@nongnu.org; Vamsi Krishna Attunuru > > > ; Jerin Jacob ; Jason > > > Wang > > > Subject: [EXT] Re

RE: [PATCH v4] virtio-pci: correctly set virtio pci queue mem multiplier

2024-03-08 Thread Srujana Challa
Ping. > -Original Message- > From: Srujana Challa > Sent: Thursday, February 29, 2024 12:13 PM > To: qemu-devel@nongnu.org > Cc: m...@redhat.com; jasow...@redhat.com; Vamsi Krishna Attunuru > ; Jerin Jacob ; Srujana Challa > > Subject: [PATCH v4] virtio-pci:

[PATCH v4] virtio-pci: correctly set virtio pci queue mem multiplier

2024-02-28 Thread Srujana Challa
Currently, virtio_pci_queue_mem_mult function always returns 4K when VIRTIO_PCI_FLAG_PAGE_PER_VQ is set. But this won't work for vhost vdpa when host has page size other than 4K. This patch introduces a new property(page-per-vdpa-vq) for vdpa use case to fix the same. Signed-off-by: Sr

RE: [EXT] Re: [PATCH v3] virtio-pci: correctly set virtio pci queue mem multiplier

2024-02-28 Thread Srujana Challa
> Subject: Re: [EXT] Re: [PATCH v3] virtio-pci: correctly set virtio pci queue > mem > multiplier > > On Wed, Feb 28, 2024 at 06:13:03AM +, Srujana Challa wrote: > > > Subject: [EXT] Re: [PATCH v3] virtio-pci: correctly set virtio pci > > > queue mem mult

RE: [EXT] Re: [PATCH v3] virtio-pci: correctly set virtio pci queue mem multiplier

2024-02-27 Thread Srujana Challa
> Subject: [EXT] Re: [PATCH v3] virtio-pci: correctly set virtio pci queue mem > multiplier > > External Email > > -- > On Fri, Feb 23, 2024 at 10:56:17AM +0530, Srujana Challa wrote: > > Currently

[PATCH v3] virtio-pci: correctly set virtio pci queue mem multiplier

2024-02-22 Thread Srujana Challa
Currently, virtio_pci_queue_mem_mult function always returns 4K when VIRTIO_PCI_FLAG_PAGE_PER_VQ is set. But this won't work for vhost vdpa when host has page size other than 4K. This patch introduces a new property(host-page-per-vq) for vdpa use case to fix the same. Signed-off-by: Sr

RE: [EXT] Re: [PATCH] vhost_net: add NOTIFICATION_DATA and IN_ORDER feature bits to vdpa_feature_bits

2024-02-21 Thread Srujana Challa
Ping. > Subject: RE: [EXT] Re: [PATCH] vhost_net: add NOTIFICATION_DATA and > IN_ORDER feature bits to vdpa_feature_bits > > > > > -Original Message- > > From: Michael S. Tsirkin > > Sent: Monday, February 19, 2024 3:15 PM > > To: Srujana Chall

[PATCH v2] virtio-pci: correctly set virtio pci queue mem multiplier

2024-02-19 Thread Srujana Challa
Currently, virtio_pci_queue_mem_mult function always returns 4K when VIRTIO_PCI_FLAG_PAGE_PER_VQ is set. But this won't work for vhost vdpa when host has page size other than 4K. This patch introduces a new property(page-per-vdpa-vq) for vdpa use case to fix the same. Signed-off-by: Sr

RE: [EXT] Re: [PATCH] virtio-pci: correctly set virtio pci queue mem multiplier

2024-02-19 Thread Srujana Challa
> -Original Message- > From: Michael S. Tsirkin > Sent: Tuesday, February 13, 2024 9:23 PM > To: Srujana Challa > Cc: qemu-devel@nongnu.org; Vamsi Krishna Attunuru > ; Jerin Jacob > Subject: Re: [EXT] Re: [PATCH] virtio-pci: correctly set virtio pci queue mem >

RE: [EXT] Re: [PATCH] vhost_net: add NOTIFICATION_DATA and IN_ORDER feature bits to vdpa_feature_bits

2024-02-19 Thread Srujana Challa
> -Original Message- > From: Michael S. Tsirkin > Sent: Monday, February 19, 2024 3:15 PM > To: Srujana Challa > Cc: qemu-devel@nongnu.org; Vamsi Krishna Attunuru > ; Jerin Jacob ; Jason Wang > > Subject: [EXT] Re: [PATCH] vhost_net: add NOTIFICATION_DATA and

RE: [PATCH] vhost_net: add NOTIFICATION_DATA and IN_ORDER feature bits to vdpa_feature_bits

2024-02-19 Thread Srujana Challa
ost net client type as part of > feature negotiation to address the concerns raised in below thread. > https://patchew.org/QEMU/1533833677-27512-1-git-send-email- > i.maxim...@samsung.com/ > > Regards > Vamsi > > > -Original Message- > > From: Srujana Cha

RE: [EXT] Re: [PATCH] virtio-pci: correctly set virtio pci queue mem multiplier

2024-02-13 Thread Srujana Challa
> Subject: Re: [EXT] Re: [PATCH] virtio-pci: correctly set virtio pci queue mem > multiplier > > On Tue, Feb 13, 2024 at 11:50:34AM +0000, Srujana Challa wrote: > > > Subject: [EXT] Re: [PATCH] virtio-pci: correctly set virtio pci > > > queue mem multipl

RE: [EXT] Re: [PATCH] virtio-pci: correctly set virtio pci queue mem multiplier

2024-02-13 Thread Srujana Challa
> Subject: [EXT] Re: [PATCH] virtio-pci: correctly set virtio pci queue mem > multiplier > > External Email > > -- > On Mon, Feb 12, 2024 at 01:22:33PM +0530, Srujana Challa wrote: > > Currently

[PATCH] virtio-pci: correctly set virtio pci queue mem multiplier

2024-02-11 Thread Srujana Challa
Currently, virtio_pci_queue_mem_mult function returns 4K when VIRTIO_PCI_FLAG_PAGE_PER_VQ is set. But this is not correct when host has page size as 64K. This patch fixes the same. Signed-off-by: Srujana Challa --- hw/virtio/virtio-pci.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions

[PATCH] vhost_net: add NOTIFICATION_DATA and IN_ORDER feature bits to vdpa_feature_bits

2024-01-02 Thread Srujana Challa
: Srujana Challa --- hw/net/vhost_net.c | 10 ++ net/vhost-vdpa.c | 2 ++ 2 files changed, 12 insertions(+) diff --git a/hw/net/vhost_net.c b/hw/net/vhost_net.c index e8e1661646..65ae8bcece 100644 --- a/hw/net/vhost_net.c +++ b/hw/net/vhost_net.c @@ -117,6 +117,16 @@ static const int

RE: [EXT] Re: Regarding VIRTIO_F_IN_ORDER and VIRTIO_F_NOTIFICATION_DATA feature bits

2023-12-14 Thread Srujana Challa
> > -- > > On Wed, Dec 13, 2023 at 04:27:40PM +0000, Srujana Challa wrote: > > > Hi Michael, > > > > > > While verifying virtio frontend drivers of guest OS on qemu with > > >

RE: [EXT] Re: Regarding VIRTIO_F_IN_ORDER and VIRTIO_F_NOTIFICATION_DATA feature bits

2023-12-13 Thread Srujana Challa
> -- > On Wed, Dec 13, 2023 at 04:27:40PM +, Srujana Challa wrote: > > Hi Michael, > > > > While verifying virtio frontend drivers of guest OS on qemu with > > vhost-vdpa backend, we came across

Regarding VIRTIO_F_IN_ORDER and VIRTIO_F_NOTIFICATION_DATA feature bits

2023-12-13 Thread Srujana Challa
Hi Michael, While verifying virtio frontend drivers of guest OS on qemu with vhost-vdpa backend, we came across feature bits VIRTIO_F_IN_ORDER and VIRTIO_F_NOTIFICATION_DATA, which are introduced in virtio 1.1 spec, are not yet enabled in qemu. These feature flags are very much useful for achiev