Re: [RFC PATCH v1 0/2] vhost-vdpa: cache Virtio states

2023-04-24 Thread Shao-Chien Chiang
ing if the device is the last, whose code is dev->vq_index + dev->nvqs != dev->vq_index_end in vhost_vdpa_dev_start(). I think these are the causes of the problem. Thank you! On Mon, Apr 24, 2023 at 3:04 PM Eugenio Perez Martin wrote: > > On Sat, Apr 22, 2023 at 8:39 AM Shao-Chien

Re: [RFC PATCH v1 0/2] vhost-vdpa: cache Virtio states

2023-04-21 Thread Shao-Chien Chiang
Hi, I found a problem about cache. If there are several devices operating the same backend device, the cache might be inconsistent. I think we could handle this by checking if a device is the first device, but I'm not sure it will be feasible. Is there any better approach to this problem? Than

[RFC PATCH v1 0/2] vhost-vdpa: cache Virtio states

2023-04-18 Thread Shao-Chien Chiang
Repetitive ioctls makes vdpa devices initialization and startup slow. This patch series is to cache Virtio status, features, and config. For each latency test, I use vdpa-sim-net as my vdpa device. Resolves: https://gitlab.com/qemu-project/qemu/-/issues/1579 Shao-Chien Chiang (2): vhost-vdpa

[RFC PATCH v1 2/2] vhost-vdpa: cache device config

2023-04-18 Thread Shao-Chien Chiang
-by: Shao-Chien Chiang --- hw/virtio/vhost-vdpa.c | 44 +++--- include/hw/virtio/vhost-vdpa.h | 2 ++ 2 files changed, 38 insertions(+), 8 deletions(-) diff --git a/hw/virtio/vhost-vdpa.c b/hw/virtio/vhost-vdpa.c index ccde4c7040..92bb09ef4d 100644 --- a/hw

[RFC PATCH v1 1/2] vhost-vdpa: cache device status and features

2023-04-18 Thread Shao-Chien Chiang
After caching the device status and features, the latency is reduced by 0.059 sec. Signed-off-by: Shao-Chien Chiang --- hw/virtio/vhost-vdpa.c | 16 ++-- include/hw/virtio/vhost-vdpa.h | 2 ++ 2 files changed, 12 insertions(+), 6 deletions(-) diff --git a/hw/virtio/vhost

[RFC PATCH] vhost-vdpa: cache Virtio states

2023-04-14 Thread Shao-Chien Chiang
-by: Shao-Chien Chiang --- hw/virtio/vhost-vdpa.c | 44 +++--- include/hw/virtio/vhost-vdpa.h | 3 +++ 2 files changed, 33 insertions(+), 14 deletions(-) diff --git a/hw/virtio/vhost-vdpa.c b/hw/virtio/vhost-vdpa.c index bc6bad23d5..1fccd151cf 100644 --- a/hw