Re: [PATCH v3 05/10] arm/cpu: accessors for writable id registers

2025-04-29 Thread Sebastian Ott
On Mon, 14 Apr 2025, Cornelia Huck wrote: Also add conversion between the different indices. Signed-off-by: Cornelia Huck --- target/arm/cpu.h | 18 ++ 1 file changed, 18 insertions(+) diff --git a/target/arm/cpu.h b/target/arm/cpu.h index bbee7ff2414a..775a8aebc5d3 100644 --- a

Re: [PATCH v3 13/14] arm/cpu: Add sysreg generation scripts

2025-04-05 Thread Sebastian Ott
On Tue, 11 Mar 2025, Cornelia Huck wrote: +++ b/scripts/gen-cpu-sysregs-header.awk [...] +BEGIN { +print "" +} END { +print "" +} + +# skip blank lines and comment lines +/^$/ { next } +/^[\t ]*#/ { next } + +/^Sysreg\t/ || /^Sysreg /{ + + reg = $2 + op0 = $3 + op1 = $

Re: [PATCH v3 00/14] arm: rework id register storage

2025-03-20 Thread Sebastian Ott
00755 scripts/update-aarch64-sysreg-code.sh create mode 100644 target/arm/cpu-sysregs.h create mode 100644 target/arm/cpu-sysregs.h.inc Reviewed-by: Sebastian Ott

Re: [PATCH v3 01/14] arm/cpu: Add sysreg definitions in cpu-sysregs.h

2025-03-20 Thread Sebastian Ott
On Tue, 11 Mar 2025, Cornelia Huck wrote: +++ b/target/arm/cpu.h [...] +/* REG is ID_XXX */ +#define FIELD_DP64_IDREG(ISAR, REG, FIELD, VALUE) \ +({ \ +ARMISARegisters *i_ = (ISAR);

Re: [PATCH v2] pci: ensure valid link status bits for downstream ports

2025-01-07 Thread Sebastian Ott
Hello Michael, Marcel, On Tue, 3 Dec 2024, Alex Williamson wrote: On Tue, 3 Dec 2024 13:19:28 +0100 Sebastian Ott wrote: PCI hotplug for downstream endpoints on arm fails because Linux' PCIe hotplug driver doesn't like the QEMU provided LNKSTA: pcieport :08:01.0: pcie

Re: [PATCH v2] pci: ensure valid link status bits for downstream ports

2024-12-17 Thread Sebastian Ott
Hi, On Tue, 3 Dec 2024, Alex Williamson wrote: On Tue, 3 Dec 2024 13:19:28 +0100 Sebastian Ott wrote: PCI hotplug for downstream endpoints on arm fails because Linux' PCIe hotplug driver doesn't like the QEMU provided LNKSTA: pcieport :08:01.0: pciehp: Slot(2): Ca

Re: [PATCH RFCv2 00/20] kvm/arm: Introduce a customizable aarch64 KVM host model

2024-12-12 Thread Sebastian Ott
On Fri, 6 Dec 2024, Cornelia Huck wrote: A respin/update on the aarch64 KVM cpu models. Also available at gitlab.com/cohuck/qemu arm-cpu-model-rfcv2 Find Eric's original cover letter below, so that I do not need to repeat myself on the aspects that have not changed since RFCv1 :) Changes from R

[PATCH v2] pci: ensure valid link status bits for downstream ports

2024-12-03 Thread Sebastian Ott
e sure downstream ports always have a valid LNKSTA. Signed-off-by: Sebastian Ott Tested-by: Zhenyu Zhang --- hw/pci/pcie.c | 12 1 file changed, 8 insertions(+), 4 deletions(-) diff --git a/hw/pci/pcie.c b/hw/pci/pcie.c index 0b455c8654..1b12db6fa2 100644 --- a/hw/pci/pcie.c +

Re: [PATCH] pci: ensure valid link status bits for downstream ports

2024-11-21 Thread Sebastian Ott
On Mon, 11 Nov 2024, Sebastian Ott wrote: PCI hotplug for downstream endpoints on arm fails because Linux' PCIe hotplug driver doesn't like the QEMU provided LNKSTA: pcieport :08:01.0: pciehp: Slot(2): Card present pcieport :08:01.0: pciehp: Slot(2): Link Up pcieport 00

Re: [PATCH] pci: ensure valid link status bits for downstream ports

2024-11-11 Thread Sebastian Ott
On Mon, 11 Nov 2024, Sebastian Ott wrote: PCI hotplug for downstream endpoints on arm fails because Linux' PCIe hotplug driver doesn't like the QEMU provided LNKSTA: pcieport :08:01.0: pciehp: Slot(2): Card present pcieport :08:01.0: pciehp: Slot(2): Link Up pcieport 00

[PATCH] pci: ensure valid link status bits for downstream ports

2024-11-11 Thread Sebastian Ott
nk: status 0x2000 There's 2 cases where LNKSTA isn't setup properly: * the downstream device has no express capability * max link width of the bridge is 0 Fix these by making the LNKSTA modifications independent of each other. Signed-off-by: Sebastian Ott ---

Re: [PATCH 2/2] virtio-gpu: fix scanout migration post-load

2024-01-17 Thread Sebastian Ott
On Wed, 17 Jan 2024, Marc-André Lureau wrote: On Tue, Jan 16, 2024 at 3:17 PM Sebastian Ott wrote: On Mon, 15 Jan 2024, marcandre.lur...@redhat.com wrote: +scanout->ds = qemu_create_displaysurface_pixman(res->image); +if (!scanout->ds) { +retur

Re: [PATCH v5] arm/kvm: Enable support for KVM_ARM_VCPU_PMU_V3_FILTER

2024-01-17 Thread Sebastian Ott
On Wed, 17 Jan 2024, Eric Auger wrote: On 1/15/24 09:01, Shaoqin Huang wrote: +/* + * The filter only needs to be initialized through one vcpu ioctl and it + * will affect all other vcpu in the vm. + */ +if (pmu_filter_init) { I think I commented on that on the v4. Maybe I m

Re: [PATCH v5] arm/kvm: Enable support for KVM_ARM_VCPU_PMU_V3_FILTER

2024-01-17 Thread Sebastian Ott
1752000 seconds user 0.0 seconds sys As we can see, the cycle counter has been disabled in the guest, but other pmu events are still work. Signed-off-by: Shaoqin Huang Reviewed-by: Sebastian Ott

Re: [PATCH 2/2] virtio-gpu: fix scanout migration post-load

2024-01-16 Thread Sebastian Ott
On Mon, 15 Jan 2024, marcandre.lur...@redhat.com wrote: +scanout->ds = qemu_create_displaysurface_pixman(res->image); +if (!scanout->ds) { +return -EINVAL; +} "qemu_create_displaysurface_pixman() never returns NULL." ;-)

Re: [PATCH v4] arm/kvm: Enable support for KVM_ARM_VCPU_PMU_V3_FILTER

2023-12-15 Thread Sebastian Ott
On Fri, 15 Dec 2023, Sebastian Ott wrote: On Thu, 14 Dec 2023, Eric Auger wrote: On 12/7/23 11:36, Shaoqin Huang wrote: +if (kvm_vcpu_ioctl(cs, KVM_HAS_DEVICE_ATTR, &attr)) { +warn_report("The kernel doesn't support the PMU Event Filter!\n"

Re: [PATCH v4] arm/kvm: Enable support for KVM_ARM_VCPU_PMU_V3_FILTER

2023-12-15 Thread Sebastian Ott
On Thu, 14 Dec 2023, Eric Auger wrote: On 12/7/23 11:36, Shaoqin Huang wrote: +if (kvm_vcpu_ioctl(cs, KVM_HAS_DEVICE_ATTR, &attr)) { +warn_report("The kernel doesn't support the PMU Event Filter!\n"); +return; +} + +/* The filter only needs to be initialized for 1 vcp

Re: [PATCH v3] arm/kvm: Enable support for KVM_ARM_VCPU_PMU_V3_FILTER

2023-11-30 Thread Sebastian Ott
On Tue, 28 Nov 2023, Shaoqin Huang wrote: +static void kvm_arm_pmu_filter_init(CPUState *cs) +{ +static bool pmu_filter_init = false; +struct kvm_pmu_event_filter filter; +struct kvm_device_attr attr = { +.group = KVM_ARM_VCPU_PMU_V3_CTRL, +.attr = KVM_ARM_V

Re: hanging process with commit 69562648f9 ("vl: revert behaviour for -display none")

2023-11-27 Thread Sebastian Ott
On Mon, 27 Nov 2023, Peter Maydell wrote: On Mon, 27 Nov 2023 at 12:29, Sebastian Ott wrote: qemu fails to start a guest using the following command (the process just hangs): qemu-system-aarch64 -machine virt -cpu host -smp 4 -m 8192 -kernel /boot/vmlinuz-6.7.0-rc1 -initrd ~/basic.img -append

hanging process with commit 69562648f9 ("vl: revert behaviour for -display none")

2023-11-27 Thread Sebastian Ott
Hej, qemu fails to start a guest using the following command (the process just hangs): qemu-system-aarch64 -machine virt -cpu host -smp 4 -m 8192 -kernel /boot/vmlinuz-6.7.0-rc1 -initrd ~/basic.img -append "root=/dev/ram console=ttyAMA0" -enable-kvm -device virtio-gpu,hostmem=2G -display none

Re: [PATCH v1] arm/kvm: Enable support for KVM_ARM_VCPU_PMU_V3_FILTER

2023-11-15 Thread Sebastian Ott
Hi, On Mon, 13 Nov 2023, Shaoqin Huang wrote: +``pmu-filter={A,D}:start-end[;...]`` +KVM implements pmu event filtering to prevent a guest from being able to + sample certain events. It has the following format: + + pmu-filter="{A,D}:start-end[;{A,D}:start-end...]" + +

[PATCH] hw/arm: fix PMU IRQ registration

2023-11-03 Thread Sebastian Ott
_IRQ to be a INTID but missed a case where the PMU IRQ is actually referred by its PPI index. Fix that by using INTID_TO_PPI() in that case. Fixes: 9036e917f8 ("{include/}hw/arm: refactor virt PPI logic") Signed-off-by: Sebastian Ott --- hw/arm/virt.c | 3 ++- 1 file changed, 2 inser

[PATCH] hw/pci-bridge: make building pcie-to-pci bridge configurable

2023-05-15 Thread Sebastian Ott
Introduce a CONFIG option to build the pcie-to-pci bridge. No functional change since it's enabled per default for PCIE_PORT=y. Signed-off-by: Sebastian Ott --- hw/pci-bridge/Kconfig | 5 + hw/pci-bridge/meson.build | 3 ++- 2 files changed, 7 insertions(+), 1 deletion(-) diff

Re: [Qemu-devel] [PATCH v4 02/16] s390: cio: export more interfaces

2017-03-23 Thread Sebastian Ott
On Fri, 17 Mar 2017, Dong Jia Shi wrote: > Export the common I/O interfaces those are needed by an I/O > subchannel driver to actually talk to the subchannel. > > Reviewed-by: Pierre Morel > Signed-off-by: Dong Jia Shi > Cc: Sebastian Ott > Cc: Peter Oberparleiter >

Re: [Qemu-devel] [PATCH v4 01/16] s390: cio: introduce cio_cancel_halt_clear

2017-03-23 Thread Sebastian Ott
igned-off-by: Dong Jia Shi > Cc: Sebastian Ott > Cc: Peter Oberparleiter [...] > +/** > + * cio_cancel_halt_clear - Cancel running I/O by performing cancel, halt > + * and clear ordinally if subchannel is valid. > + * @sch: subchannel on which to perform the cancel_halt_clear op

Re: [Qemu-devel] [PATCH v4 01/16] s390: cio: introduce cio_cancel_halt_clear

2017-03-17 Thread Sebastian Ott
On Fri, 17 Mar 2017, Dong Jia Shi wrote: > * Sebastian Ott [2017-03-17 10:26:51 +0100]: > > > On Fri, 17 Mar 2017, Dong Jia Shi wrote: > > > For future code reuse purpose, this decouples the cio code with > > > the ccw device specific parts from ccw_device_cancel

Re: [Qemu-devel] [PATCH v4 02/16] s390: cio: export more interfaces

2017-03-17 Thread Sebastian Ott
On Fri, 17 Mar 2017, Dong Jia Shi wrote: > Export the common I/O interfaces those are needed by an I/O > subchannel driver to actually talk to the subchannel. Which I/O subchannel driver are you talking about? I know of just one and it can't be build as a module. Sebastian

Re: [Qemu-devel] [PATCH v4 01/16] s390: cio: introduce cio_cancel_halt_clear

2017-03-17 Thread Sebastian Ott
On Fri, 17 Mar 2017, Dong Jia Shi wrote: > For future code reuse purpose, this decouples the cio code with > the ccw device specific parts from ccw_device_cancel_halt_clear, > and makes a new common I/O interface named cio_cancel_halt_clear. What would the user of cio_cancel_halt_clear be? Sebast

Re: [Qemu-devel] [PATCH 2/4] s390: Add a mechanism to get the subchannel id.

2012-08-14 Thread Sebastian Ott
On Tue, 14 Aug 2012, Cornelia Huck wrote: > Sebastian Ott wrote: > > On Tue, 7 Aug 2012, Cornelia Huck wrote: > > > +/** > > > + * ccw_device_get_schid - obtain a subchannel id > > > + * @cdev: device to obtain the id for > > > + * @schid: where

Re: [Qemu-devel] [PATCH 2/4] s390: Add a mechanism to get the subchannel id.

2012-08-14 Thread Sebastian Ott
On Tue, 7 Aug 2012, Cornelia Huck wrote: > +/** > + * ccw_device_get_schid - obtain a subchannel id > + * @cdev: device to obtain the id for > + * @schid: where to fill in the values > + */ > +void ccw_device_get_schid(struct ccw_device *cdev, struct subchannel_id > *schid) > +{ > + *schid =

Re: [Qemu-devel] [PATCH 2/4] s390: Add a mechanism to get the subchannel id.

2012-08-13 Thread Sebastian Ott
On Tue, 7 Aug 2012, Cornelia Huck wrote: > This will be needed by the new virtio-ccw transport. We already have ccw_device_get_subchannel_id which is currently used by qdio only and thus buried in an internal header file. So it would be better to just clean up this one and make it available to vir