Re: [Qemu-devel] idea: non-ethernet paravirtual network device

2011-07-26 Thread Sassan Panahinejad
Ok, thanks guys. I don't think I'll proceed with this idea. Thanks Sassan On 26 July 2011 11:23, Hannes Reinecke wrote: > On 07/26/2011 08:04 AM, Stefan Hajnoczi wrote: > >> On Mon, Jul 25, 2011 at 4:53 PM, Sassan >> Panahinejad> >> wrote: >> >

[Qemu-devel] idea: non-ethernet paravirtual network device

2011-07-25 Thread Sassan Panahinejad
Hi all, Here's a thought, could we improve network performance by creating a paravirtual network device which doesn't emulate ethernet? It shouldn't be too hard to just whack IP packets pretty much directly over a virtio link. This should improve performance when using a "user" host connection and

Re: [Qemu-devel] [PATCH] Clean up virtio-9p error handling code

2011-06-28 Thread Sassan Panahinejad
On 28 June 2011 15:22, Venkateswararao Jujjuri wrote: > ** > On 06/28/2011 05:25 AM, Sassan Panahinejad wrote: > > Hi JV, > > Any progress regarding merging this patch (and the fsync patch I > submitted)? > Is there anything I can do to assist/speed the process? > &g

Re: [Qemu-devel] [PATCH] Clean up virtio-9p error handling code

2011-06-28 Thread Sassan Panahinejad
Hi JV, Any progress regarding merging this patch (and the fsync patch I submitted)? Is there anything I can do to assist/speed the process? Thanks Sassan On 8 June 2011 17:21, Sassan Panahinejad wrote: > In a lot of cases, the handling of errors was quite ugly. > This patch moves read

[Qemu-devel] [PATCH] Clean up virtio-9p error handling code

2011-06-08 Thread Sassan Panahinejad
. This patch is created against your 9p-coroutine-bh branch, as requested. Sorry for the delay, I was unexpectedly required to work abroad for 2 weeks. Signed-off-by: Sassan Panahinejad --- fsdev/file-op-9p.h|4 +- hw/9pfs/codir.c | 14 + hw/9pfs/virtio-9p-local.c | 123

[Qemu-devel] [PATCH] Clean up virtio-9p error handling code

2011-05-15 Thread Sassan Panahinejad
. Signed-off-by: Sassan Panahinejad --- fsdev/file-op-9p.h|4 +- hw/9pfs/virtio-9p-local.c | 123 + hw/9pfs/virtio-9p-xattr.c | 21 ++- hw/9pfs/virtio-9p.c | 150 - 4 files changed, 128 insertions

[Qemu-devel] [PATCH] Clean up virtio-9p error handling code

2011-05-08 Thread Sassan Panahinejad
In a lot of cases, the handling of errors was quite ugly. This patch moves reading of errno to immediately after the system calls and passes it up through the system more cleanly. Also, in the case of the xattr functions (and possibly others), completely the wrong error was being returned. --- f

Re: [Qemu-devel] Bug in virtio-9p when fstatting an fd referring to a file that no longer exists

2011-05-03 Thread Sassan Panahinejad
On 2 May 2011 16:47, Venkateswararao Jujjuri wrote: > On 04/28/2011 09:51 AM, Sassan Panahinejad wrote: > > This thread seems relevant: > http://www.mail-archive.com/linux-fsdevel@vger.kernel.org/msg09159.html > Unless things have changed, it looks like the problem is in the

Re: [Qemu-devel] Bug in virtio-9p when fstatting an fd referring to a file that no longer exists

2011-04-28 Thread Sassan Panahinejad
. Any thoughts on a workaround for this? Thanks Sassan On 28 April 2011 17:13, Sassan Panahinejad wrote: > It should be possible for guest applications to fstat a file for which they > have a valid file descriptor, even if the file has been removed. > Demonstrated by the code sampl

[Qemu-devel] Bug in virtio-9p when fstatting an fd referring to a file that no longer exists

2011-04-28 Thread Sassan Panahinejad
It should be possible for guest applications to fstat a file for which they have a valid file descriptor, even if the file has been removed. Demonstrated by the code sample below (fstat reports no such file or directory). Strangely it seems that reading from a file in this state works fine (and whe

[Qemu-devel] [PATCH] Fix bug with virtio-9p xattr functions return values

2011-04-28 Thread Sassan Panahinejad
plications to fail in cases where the operation is not supported by the host. This causes a number of problems with dpkg and with install. This patch fixes the bug and returns the correct value, which means that guest applications are able to handle the error correctly. Signed-off-by: Sassan P

Re: [Qemu-devel] [PATCH] Fix bug with virtio-9p rename

2011-04-28 Thread Sassan Panahinejad
Malahal Naineni's patch "Stop renaming files with similar name!" (posted since this one) also fixes this bug. I don't mind which one gets merged, as long as the bug gets fixed ;) Sassan On 27 April 2011 19:30, Sassan Panahinejad wrote: > After renaming a file, any exi

[Qemu-devel] [PATCH] Fix bug with virtio-9p rename

2011-04-27 Thread Sassan Panahinejad
-new. This breaks debconf and probably many other applications. This patch fixes the problem. Now only files exactly matching, or files which are a subdirectory of a directory being moved are affected. Signed-off-by: Sassan Panahinejad --- hw/virtio-9p.c |9 - 1 files changed, 8

[Qemu-devel] [PATCH] Fix bug with virtio-9p fsync

2011-04-27 Thread Sassan Panahinejad
. This error can result in guest applications failing (in my case it was dpkg). This patch fixes the issue and implements correct behaviour for fsync, wstat, lock and getlock. Signed-off-by: Sassan Panahinejad --- hw/virtio-9p.c | 36 1 files changed, 32

[Qemu-devel] [PATCH] Fix bug with virtio-9p fsync

2011-04-26 Thread Sassan Panahinejad
the issue, although there may be other, similar bugs in virtio-9p. Signed-off-by: Sassan Panahinejad --- Here I've implemented it as a function. If you'd prefer a macro or inline function then let me know. Thanks Sassan hw/virtio-9p.c | 43

Re: [Qemu-devel] [PATCH] Fix bug with virtio-9p fsync

2011-04-26 Thread Sassan Panahinejad
On 26 April 2011 13:58, Stefan Hajnoczi wrote: > What about P9_FID_XATTR, seems like we have the same issue there too? > > wstat, lock, and getlock need closer auditing and perhaps fixing. > > Stefan > Sorry, forgot to hit reply-to-all. Yes, it is probable that those functions will suffer from

[Qemu-devel] [PATCH] Fix bug with virtio-9p fsync

2011-04-26 Thread Sassan Panahinejad
the issue, although there may be other, similar bugs in virtio-9p. Signed-off-by: Sassan Panahinejad --- hw/virtio-9p.c |6 +- 1 files changed, 5 insertions(+), 1 deletions(-) diff --git a/hw/virtio-9p.c b/hw/virtio-9p.c index 7e29535..cc4fdc8 100644 --- a/hw/virtio-9p.c +++ b/hw/virtio

[Qemu-devel] [PATCH] Fix bug with virtio-9p fsync

2011-04-25 Thread Sassan Panahinejad
v9fs_fsync and possibly others break when asked to operate on a directory. It does not check fid_type to see if it is operating on a directory and therefore accesses the wrong element of the fs union. This error can result in guest applications failing (in my case it was dpkg). This patch fixes th