Re: [Qemu-devel] [PATCH v3 00/27] Support disabling TCG on ARM

2019-07-01 Thread Samuel Ortiz
On Mon, Jul 01, 2019 at 05:44:58PM +0200, Philippe Mathieu-Daudé wrote: > On 7/1/19 5:41 PM, Peter Maydell wrote: > > On Mon, 1 Jul 2019 at 14:25, Philippe Mathieu-Daudé > > wrote: > >> > >> Paolo motived me to salvage this (other!) previous series from

Re: [Qemu-devel] About making QEMU to LIBs!

2019-03-27 Thread Samuel Ortiz
On Tue, Mar 26, 2019 at 02:31:00PM +0100, Paolo Bonzini wrote: > On 26/03/19 12:38, Yang Zhong wrote: > > On Tue, Mar 26, 2019 at 10:07:35AM +0100, Paolo Bonzini wrote: > >> Would separate QEMU binaries be a solution? I think I am not as opposed > >> to a "q35-lite" machine type these days, I find

Re: [Qemu-devel] About making QEMU to LIBs!

2019-03-27 Thread Samuel Ortiz
Hi Paolo, On Tue, Mar 26, 2019 at 10:07:35AM +0100, Paolo Bonzini wrote: > Would separate QEMU binaries be a solution? I think I am not as opposed > to a "q35-lite" machine type these days, I find it preferrable to share > the northbridge and southbridge with Q35 and just get rid of IDE, VGA, > I

Re: [Qemu-devel] [PATCH v4 7/8] hw: acpi: Export and share the ARM RSDP build

2018-12-17 Thread Samuel Ortiz
On Mon, Dec 17, 2018 at 04:35:36PM +0100, Igor Mammedov wrote: > On Mon, 17 Dec 2018 14:49:59 +0100 > Samuel Ortiz wrote: > > > On Mon, Dec 17, 2018 at 01:20:28PM +0100, Igor Mammedov wrote: > > > On Mon, 17 Dec 2018 11:48:37 +0100 > > > Samuel Ortiz wrote: &

[Qemu-devel] [PATCH v5 7/8] hw: acpi: Export and share the ARM RSDP build

2018-12-17 Thread Samuel Ortiz
From: Samuel Ortiz Now that build_rsdp() supports building both legacy and current RSDP tables, we can move it to a generic folder (hw/acpi) and have the i386 ACPI code reuse it in order to reduce code duplication. Signed-off-by: Samuel Ortiz Reviewed-by: Igor Mammedov --- include/hw/acpi

Re: [Qemu-devel] [PATCH v4 7/8] hw: acpi: Export and share the ARM RSDP build

2018-12-17 Thread Samuel Ortiz
On Mon, Dec 17, 2018 at 04:25:47PM +0100, Igor Mammedov wrote: > On Mon, 17 Dec 2018 15:06:11 +0100 > Samuel Ortiz wrote: > > > > > From: Samuel Ortiz > > Subject should be > [Qemu-devel] [PATCH v5 7/8] hw: acpi: Export and share the ARM RSDP build >

Re: [Qemu-devel] [PATCH v4 7/8] hw: acpi: Export and share the ARM RSDP build

2018-12-17 Thread Samuel Ortiz
From: Samuel Ortiz Now that build_rsdp() supports building both legacy and current RSDP tables, we can move it to a generic folder (hw/acpi) and have the i386 ACPI code reuse it in order to reduce code duplication. Signed-off-by: Samuel Ortiz Reviewed-by: Igor Mammedov --- V4 ->

Re: [Qemu-devel] [PATCH v4 7/8] hw: acpi: Export and share the ARM RSDP build

2018-12-17 Thread Samuel Ortiz
On Mon, Dec 17, 2018 at 01:20:28PM +0100, Igor Mammedov wrote: > On Mon, 17 Dec 2018 11:48:37 +0100 > Samuel Ortiz wrote: > > > Now that build_rsdp() supports building both legacy and current RSDP > > tables, we can move it to a generic folder (hw/acpi) and have the i386 &

[Qemu-devel] [PATCH v4 3/8] hw: i386: Use correct RSDT length for checksum

2018-12-17 Thread Samuel Ortiz
ry regions (a1666142d) for ACPI blobs. So keep wasting memory to avoid breaking old machines. Fixes: 72c194f7e (i386: ACPI table generation code from seabios) Signed-off-by: Igor Mammedov Reviewed-by: Samuel Ortiz Signed-off-by: Samuel Ortiz --- hw/i386/acpi-build.c | 7 ++- 1 file changed, 6

[Qemu-devel] [PATCH v4 8/8] hw: acpi: Remove AcpiRsdpDescriptor and fix tests

2018-12-17 Thread Samuel Ortiz
The only remaining AcpiRsdpDescriptor users are the ACPI utils for the BIOS table tests. We remove that dependency and can thus remove the structure itself. Signed-off-by: Samuel Ortiz Reviewed-by: Igor Mammedov Reviewed-by: Andrew Jones --- include/hw/acpi/acpi-defs.h | 13 --- tests

[Qemu-devel] [PATCH v4 5/8] hw: arm: Convert the RSDP build to the buid_append_foo() API

2018-12-17 Thread Samuel Ortiz
. Signed-off-by: Samuel Ortiz Reviewed-by: Igor Mammedov Reviewed-by: Andrew Jones --- hw/arm/virt-acpi-build.c | 42 ++-- 1 file changed, 23 insertions(+), 19 deletions(-) diff --git a/hw/arm/virt-acpi-build.c b/hw/arm/virt-acpi-build.c index ce8bfa5a37

[Qemu-devel] [PATCH v4 1/8] hw: acpi: The RSDP build API can return void

2018-12-17 Thread Samuel Ortiz
For both x86 and ARM architectures, the internal RSDP build API can return void as the current return value is unused. Signed-off-by: Samuel Ortiz Reviewed-by: Igor Mammedov Reviewed-by: Philippe Mathieu-Daudé Tested-by: Philippe Mathieu-Daudé Reviewed-by: Thomas Huth Reviewed-by: Andrew

[Qemu-devel] [PATCH v4 2/8] hw: arm: acpi: Fix incorrect checksums in RSDP

2018-12-17 Thread Samuel Ortiz
remove unused AcpiRsdpDescriptor structure. Based on "[PATCH v5 05/24] hw: acpi: Implement XSDT support for RSDP" by Samuel Ortiz, who did it right in his impl. Fixes: d4bec5d87 (hw/arm/virt-acpi-build: Generate RSDP table) Signed-off-by: Igor Mammedov CC: Ard Biesheuvel CC: Sh

[Qemu-devel] [PATCH v4 7/8] hw: acpi: Export and share the ARM RSDP build

2018-12-17 Thread Samuel Ortiz
Now that build_rsdp() supports building both legacy and current RSDP tables, we can move it to a generic folder (hw/acpi) and have the i386 ACPI code reuse it in order to reduce code duplication. Signed-off-by: Samuel Ortiz Reviewed-by: Philippe Mathieu-Daudé Tested-by: Philippe Mathieu-Daudé

[Qemu-devel] [PATCH v4 0/8] hw: acpi: RSDP fixes and refactoring

2018-12-17 Thread Samuel Ortiz
lace init_rsdp_data() helper with open coded rsdp variable init. * Rename acpi_find_[rx]sdt_address to acpi_get_[rx]sdt_address. Igor Mammedov (2): hw: arm: acpi: Fix incorrect checksums in RSDP hw: i386: Use correct RSDT length for checksum Samuel Ortiz (6): hw: acpi: The RSDP build API can re

[Qemu-devel] [PATCH v4 6/8] hw: arm: Support both legacy and current RSDP build

2018-12-17 Thread Samuel Ortiz
We add the ability to build legacy or current RSDP tables, based on the AcpiRsdpData revision field passed to build_rsdp(). Although arm/virt only uses RSDP v2, adding that capability to build_rsdp will allow us to share the RSDP build code between ARM and x86. Signed-off-by: Samuel Ortiz

[Qemu-devel] [PATCH v4 4/8] hw: arm: Carry RSDP specific data through AcpiRsdpData

2018-12-17 Thread Samuel Ortiz
That will allow us to generalize the ARM build_rsdp() routine to support both legacy RSDP (The current i386 implementation) and extended RSDP (The ARM implementation). Signed-off-by: Samuel Ortiz Reviewed-by: Igor Mammedov Reviewed-by: Andrew Jones --- include/hw/acpi/acpi-defs.h | 8

[Qemu-devel] [PATCH v3 8/8] hw: acpi: Remove AcpiRsdpDescriptor and fix tests

2018-11-30 Thread Samuel Ortiz
The only remaining AcpiRsdpDescriptor users are the ACPI utils for the BIOS table tests. We remove that dependency and can thus remove the structure itself. Signed-off-by: Samuel Ortiz --- include/hw/acpi/acpi-defs.h | 13 --- tests/acpi-utils.h | 4 +++- tests/acpi-utils.c

[Qemu-devel] [PATCH v3 7/8] hw: acpi: Export and share the ARM RSDP build

2018-11-30 Thread Samuel Ortiz
Now that build_rsdp() supports building both legacy and current RSDP tables, we can move it to a generic folder (hw/acpi) and have the i386 ACPI code reuse it in order to reduce code duplication. Signed-off-by: Samuel Ortiz Reviewed-by: Philippe Mathieu-Daudé Tested-by: Philippe Mathieu-Daudé

[Qemu-devel] [PATCH v3 5/8] hw: arm: Convert the RSDP build to the buid_append_foo() API

2018-11-30 Thread Samuel Ortiz
. Reviewed-by: Andrew Jones Signed-off-by: Samuel Ortiz --- hw/arm/virt-acpi-build.c | 42 ++-- 1 file changed, 23 insertions(+), 19 deletions(-) diff --git a/hw/arm/virt-acpi-build.c b/hw/arm/virt-acpi-build.c index ce8bfa5a37..4a6b53fbfc 100644 --- a/hw/arm/virt

[Qemu-devel] [PATCH v3 0/8] hw: acpi: RSDP fixes and refactoring

2018-11-30 Thread Samuel Ortiz
with hard coded constants. * Replace init_rsdp_data() helper with open coded rsdp variable init. * Rename acpi_find_[rx]sdt_address to acpi_get_[rx]sdt_address. Igor Mammedov (2): hw: arm: acpi: Fix incorrect checksums in RSDP hw: i386: Use correct RSDT length for checksum Samuel Ortiz (6): hw

[Qemu-devel] [PATCH v3 4/8] hw: arm: Carry RSDP specific data through AcpiRsdpData

2018-11-30 Thread Samuel Ortiz
That will allow us to generalize the ARM build_rsdp() routine to support both legacy RSDP (The current i386 implementation) and extended RSDP (The ARM implementation). Signed-off-by: Samuel Ortiz Reviewed-by: Igor Mammedov --- include/hw/acpi/acpi-defs.h | 8 hw/arm/virt-acpi-build.c

[Qemu-devel] [PATCH v3 1/8] hw: acpi: The RSDP build API can return void

2018-11-30 Thread Samuel Ortiz
For both x86 and ARM architectures, the internal RSDP build API can return void as the current return value is unused. Signed-off-by: Samuel Ortiz Reviewed-by: Igor Mammedov Reviewed-by: Philippe Mathieu-Daudé Tested-by: Philippe Mathieu-Daudé Reviewed-by: Thomas Huth Reviewed-by: Andrew

[Qemu-devel] [PATCH v3 3/8] hw: i386: Use correct RSDT length for checksum

2018-11-30 Thread Samuel Ortiz
ry regions (a1666142d) for ACPI blobs. So keep wasting memory to avoid breaking old machines. Fixes: 72c194f7e (i386: ACPI table generation code from seabios) Signed-off-by: Igor Mammedov Reviewed-by: Samuel Ortiz Signed-off-by: Samuel Ortiz --- hw/i386/acpi-build.c | 7 ++- 1 file changed, 6

[Qemu-devel] [PATCH v3 6/8] hw: arm: Support both legacy and current RSDP build

2018-11-30 Thread Samuel Ortiz
We add the ability to build legacy or current RSDP tables, based on the AcpiRsdpData revision field passed to build_rsdp(). Although arm/virt only uses RSDP v2, adding that capability to build_rsdp will allow us to share the RSDP build code between ARM and x86. Signed-off-by: Samuel Ortiz

[Qemu-devel] [PATCH v3 2/8] hw: arm: acpi: Fix incorrect checksums in RSDP

2018-11-30 Thread Samuel Ortiz
remove unused AcpiRsdpDescriptor structure. Based on "[PATCH v5 05/24] hw: acpi: Implement XSDT support for RSDP" by Samuel Ortiz, who did it right in his impl. Fixes: d4bec5d87 (hw/arm/virt-acpi-build: Generate RSDP table) Signed-off-by: Igor Mammedov CC: Ard Biesheuvel CC: Sh

Re: [Qemu-devel] [PATCH v2 8/8] hw: acpi: Remove AcpiRsdpDescriptor and fix tests

2018-11-30 Thread Samuel Ortiz
On Thu, Nov 29, 2018 at 04:07:43PM +0100, Andrew Jones wrote: > On Thu, Nov 29, 2018 at 02:24:28PM +0100, Samuel Ortiz wrote: > > The only remaining AcpiRsdpDescriptor users are the ACPI utils for the > > BIOS table tests. > > We remove that dependency and can thus remove

Re: [Qemu-devel] [PATCH v2 6/8] hw: arm: Support both legacy and current RSDP build

2018-11-29 Thread Samuel Ortiz
On Thu, Nov 29, 2018 at 04:09:47PM +0100, Andrew Jones wrote: > On Thu, Nov 29, 2018 at 03:59:42PM +0100, Samuel Ortiz wrote: > > On Thu, Nov 29, 2018 at 03:42:43PM +0100, Andrew Jones wrote: > > > On Thu, Nov 29, 2018 at 02:24:26PM +0100, Samuel Ortiz wrote: > > > &g

Re: [Qemu-devel] [PATCH v2 6/8] hw: arm: Support both legacy and current RSDP build

2018-11-29 Thread Samuel Ortiz
On Thu, Nov 29, 2018 at 03:42:43PM +0100, Andrew Jones wrote: > On Thu, Nov 29, 2018 at 02:24:26PM +0100, Samuel Ortiz wrote: > > We add the ability to build legacy or current RSDP tables, based on the > > AcpiRsdpData revision field passed to build_rsdp(). > > Although arm/v

Re: [Qemu-devel] [PATCH v2 4/8] hw: arm: Carry RSDP specific data through AcpiRsdpData

2018-11-29 Thread Samuel Ortiz
On Thu, Nov 29, 2018 at 03:09:32PM +0100, Andrew Jones wrote: > On Thu, Nov 29, 2018 at 02:24:24PM +0100, Samuel Ortiz wrote: > > That will allow us to generalize the ARM build_rsdp() routine to support > > both legacy RSDP (The current i386 implementation) and extended RS

[Qemu-devel] [PATCH v2 6/8] hw: arm: Support both legacy and current RSDP build

2018-11-29 Thread Samuel Ortiz
We add the ability to build legacy or current RSDP tables, based on the AcpiRsdpData revision field passed to build_rsdp(). Although arm/virt only uses RSDP v2, adding that capability to build_rsdp will allow us to share the RSDP build code between ARM and x86. Signed-off-by: Samuel Ortiz

[Qemu-devel] [PATCH v2 8/8] hw: acpi: Remove AcpiRsdpDescriptor and fix tests

2018-11-29 Thread Samuel Ortiz
The only remaining AcpiRsdpDescriptor users are the ACPI utils for the BIOS table tests. We remove that dependency and can thus remove the structure itself. Signed-off-by: Samuel Ortiz --- include/hw/acpi/acpi-defs.h | 13 --- tests/acpi-utils.h | 5 +++- tests/acpi-utils.c

[Qemu-devel] [PATCH v2 5/8] hw: arm: Convert the RSDP build to the buid_append_foo() API

2018-11-29 Thread Samuel Ortiz
. Signed-off-by: Samuel Ortiz --- hw/arm/virt-acpi-build.c | 42 +--- 1 file changed, 22 insertions(+), 20 deletions(-) diff --git a/hw/arm/virt-acpi-build.c b/hw/arm/virt-acpi-build.c index ce8bfa5a37..4782aea4fe 100644 --- a/hw/arm/virt-acpi-build.c +++ b/hw/arm

[Qemu-devel] [PATCH v2 7/8] hw: acpi: Export and share the ARM RSDP build

2018-11-29 Thread Samuel Ortiz
Now that build_rsdp() supports building both legacy and current RSDP tables, we can move it to a generic folder (hw/acpi) and have the i386 ACPI code reuse it in order to reduce code duplication. Signed-off-by: Samuel Ortiz Reviewed-by: Philippe Mathieu-Daudé Tested-by: Philippe Mathieu-Daudé

[Qemu-devel] [PATCH v2 4/8] hw: arm: Carry RSDP specific data through AcpiRsdpData

2018-11-29 Thread Samuel Ortiz
That will allow us to generalize the ARM build_rsdp() routine to support both legacy RSDP (The current i386 implementation) and extended RSDP (The ARM implementation). Signed-off-by: Samuel Ortiz --- include/hw/acpi/acpi-defs.h | 8 hw/arm/virt-acpi-build.c| 18

[Qemu-devel] [PATCH v2 0/8] hw: acpi: RSDP fixes and refactoring

2018-11-29 Thread Samuel Ortiz
ons with hard coded constants. * Replace init_rsdp_data() helper with open coded rsdp variable init. * Rename acpi_find_[rx]sdt_address to acpi_get_[rx]sdt_address. Igor Mammedov (2): hw: arm: acpi: Fix incorrect checksums in RSDP hw: i386: Use correct RSDT length for checksum Samuel Ortiz (6

[Qemu-devel] [PATCH v2 3/8] hw: i386: Use correct RSDT length for checksum

2018-11-29 Thread Samuel Ortiz
ry regions (a1666142d) for ACPI blobs. So keep wasting memory to avoid breaking old machines. Fixes: 72c194f7e (i386: ACPI table generation code from seabios) Signed-off-by: Igor Mammedov Reviewed-by: Samuel Ortiz Signed-off-by: Samuel Ortiz --- hw/i386/acpi-build.c | 7 ++- 1 file changed, 6

[Qemu-devel] [PATCH v2 1/8] hw: acpi: The RSDP build API can return void

2018-11-29 Thread Samuel Ortiz
For both x86 and ARM architectures, the internal RSDP build API can return void as the current return value is unused. Signed-off-by: Samuel Ortiz Reviewed-by: Igor Mammedov Reviewed-by: Philippe Mathieu-Daudé Tested-by: Philippe Mathieu-Daudé Reviewed-by: Thomas Huth --- hw/arm/virt-acpi

[Qemu-devel] [PATCH v2 2/8] hw: arm: acpi: Fix incorrect checksums in RSDP

2018-11-29 Thread Samuel Ortiz
remove unused AcpiRsdpDescriptor structure. Based on "[PATCH v5 05/24] hw: acpi: Implement XSDT support for RSDP" by Samuel Ortiz, who did it right in his impl. Fixes: d4bec5d87 (hw/arm/virt-acpi-build: Generate RSDP table) Signed-off-by: Igor Mammedov CC: Ard Biesheuvel CC: Sh

Re: [Qemu-devel] [PATCH 04/13] target: arm: Move all interrupt and exception handlers into their own file

2018-11-28 Thread Samuel Ortiz
On Wed, Nov 28, 2018 at 02:57:19PM +0100, Samuel Ortiz wrote: > On Wed, Nov 28, 2018 at 11:39:57AM +, Peter Maydell wrote: > > On Wed, 28 Nov 2018 at 10:40, Samuel Ortiz wrote: > > > Given that this piece of code effectively builds a dependency to TCG > > > fro

Re: [Qemu-devel] [PATCH 04/13] target: arm: Move all interrupt and exception handlers into their own file

2018-11-28 Thread Samuel Ortiz
On Wed, Nov 28, 2018 at 11:39:57AM +, Peter Maydell wrote: > On Wed, 28 Nov 2018 at 10:40, Samuel Ortiz wrote: > > Given that this piece of code effectively builds a dependency to TCG > > from the KVM code, I see a few solutions but I need your input here. We > > could

Re: [Qemu-devel] [PATCH 04/13] target: arm: Move all interrupt and exception handlers into their own file

2018-11-28 Thread Samuel Ortiz
On Tue, Nov 27, 2018 at 03:46:30PM +, Peter Maydell wrote: > On Tue, 27 Nov 2018 at 15:36, Samuel Ortiz wrote: > > > > On Tue, Nov 20, 2018 at 01:45:03PM +, Peter Maydell wrote: > > > What is your plan for dealing with the way that the KVM code > > > for

Re: [Qemu-devel] [PATCH 4/8] hw: arm: Carry RSDP specific data through AcpiRsdpData

2018-11-28 Thread Samuel Ortiz
On Wed, Nov 28, 2018 at 10:46:41AM +0100, Samuel Ortiz wrote: > On Tue, Nov 27, 2018 at 05:27:49PM +0100, Igor Mammedov wrote: > > On Tue, 27 Nov 2018 16:42:18 +0100 > > Samuel Ortiz wrote: > > > > > Hi Igor, > > > > > > On Tue, Nov 27, 2018 at 0

Re: [Qemu-devel] [PATCH 4/8] hw: arm: Carry RSDP specific data through AcpiRsdpData

2018-11-28 Thread Samuel Ortiz
Hi Michael, On Tue, Nov 27, 2018 at 10:26:30PM -0500, Michael S. Tsirkin wrote: > On Tue, Nov 27, 2018 at 05:27:49PM +0100, Igor Mammedov wrote: > > On Tue, 27 Nov 2018 16:42:18 +0100 > > Samuel Ortiz wrote: > > > > > Hi Igor, > > > > > > On Tue,

Re: [Qemu-devel] [PATCH 4/8] hw: arm: Carry RSDP specific data through AcpiRsdpData

2018-11-28 Thread Samuel Ortiz
On Tue, Nov 27, 2018 at 05:27:49PM +0100, Igor Mammedov wrote: > On Tue, 27 Nov 2018 16:42:18 +0100 > Samuel Ortiz wrote: > > > Hi Igor, > > > > On Tue, Nov 27, 2018 at 04:25:51PM +0100, Igor Mammedov wrote: > > > On Mon, 26 Nov 2018 17:2

Re: [Qemu-devel] [PATCH 4/8] hw: arm: Carry RSDP specific data through AcpiRsdpData

2018-11-27 Thread Samuel Ortiz
Hi Igor, On Tue, Nov 27, 2018 at 04:25:51PM +0100, Igor Mammedov wrote: > On Mon, 26 Nov 2018 17:29:37 +0100 > Samuel Ortiz wrote: > > > That will allow us to generalize the ARM build_rsdp() routine to support > > both legacy RSDP (The current i386 implementation) and exten

Re: [Qemu-devel] [PATCH 04/13] target: arm: Move all interrupt and exception handlers into their own file

2018-11-27 Thread Samuel Ortiz
On Tue, Nov 20, 2018 at 01:45:03PM +, Peter Maydell wrote: > On 13 November 2018 at 16:52, Samuel Ortiz wrote: > > Most of them are TCG dependent so we want to be able to not build them > > in order to support TCG disablement with ARM. > > > > Signed-off-by:

Re: [Qemu-devel] [PATCH 03/13] target: arm: Move all v7m helpers into their own file

2018-11-27 Thread Samuel Ortiz
Hi Peter, On Tue, Nov 20, 2018 at 01:54:08PM +, Peter Maydell wrote: > On 13 November 2018 at 16:52, Samuel Ortiz wrote: > > In preparation for supporting TCG disablement on ARM, we move all TCG > > related v7m helpers and APIs into their own file (m_helper.c for all &

[Qemu-devel] [PATCH 6/8] hw: arm: Support both legacy and current RSDP build

2018-11-26 Thread Samuel Ortiz
We add the ability to build legacy or current RSDP tables, based on the AcpiRsdpData revision field passed to build_rsdp(). Although arm/virt only uses RSDP v2, adding that capability to build_rsdp will allow us to share the RSDP build code between ARM and x86. Signed-off-by: Samuel Ortiz

[Qemu-devel] [PATCH 5/8] hw: arm: Convert the RSDP build to the buid_append_foo() API

2018-11-26 Thread Samuel Ortiz
y any more. Signed-off-by: Samuel Ortiz --- include/hw/acpi/acpi-defs.h | 22 ++ hw/arm/virt-acpi-build.c| 60 - 2 files changed, 61 insertions(+), 21 deletions(-) diff --git a/include/hw/acpi/acpi-defs.h b/include/hw/acpi/acpi-defs.h index e7fd2

[Qemu-devel] [PATCH 8/8] hw: acpi: Remove AcpiRsdpDescriptor and fix tests

2018-11-26 Thread Samuel Ortiz
We switched to the build_append_*() API for all RSDP callers, and this patch converts all existing tests depending on this structure. It is no longer needed and we can thus remove it. Signed-off-by: Samuel Ortiz --- include/hw/acpi/acpi-defs.h | 13 -- tests/acpi-utils.h | 5

[Qemu-devel] [PATCH 7/8] hw: acpi: Export and share the ARM RSDP build

2018-11-26 Thread Samuel Ortiz
Now that build_rsdp() supports building both legacy and current RSDP tables, we can move it to a generic folder (hw/acpi) and have the i386 ACPI code reuse it in order to reduce code duplication. Signed-off-by: Samuel Ortiz --- include/hw/acpi/aml-build.h | 5 +++ hw/acpi/aml-build.c

[Qemu-devel] [PATCH 3/8] hw: i386: Use correct RSDT length for checksum

2018-11-26 Thread Samuel Ortiz
ry regions (a1666142d) for ACPI blobs. So keep wasting memory to avoid breaking old machines. Fixes: 72c194f7e (i386: ACPI table generation code from seabios) Signed-off-by: Igor Mammedov Reviewed-by: Samuel Ortiz --- hw/i386/acpi-build.c | 7 ++- 1 file changed, 6 insertions(+), 1 deletion(-) di

[Qemu-devel] [PATCH 0/8] hw: acpi: RSDP fixes and refactoring

2018-11-26 Thread Samuel Ortiz
. The new implementation is a closer reflection of the ACPI spec itself, is endian agnostic and allows for getting rid of the AcpiRsdpDescriptor structure. Igor Mammedov (2): hw: arm: acpi: Fix incorrect checksums in RSDP hw: i386: Use correct RSDT length for checksum Samuel Ortiz (6): hw:

[Qemu-devel] [PATCH 1/8] hw: acpi: The RSDP build API can return void

2018-11-26 Thread Samuel Ortiz
For both x86 and ARM architectures, the internal RSDP build API can return void as the current return value is unused. Signed-off-by: Samuel Ortiz Reviewed-by: Igor Mammedov --- hw/arm/virt-acpi-build.c | 4 +--- hw/i386/acpi-build.c | 4 +--- 2 files changed, 2 insertions(+), 6 deletions

[Qemu-devel] [PATCH 4/8] hw: arm: Carry RSDP specific data through AcpiRsdpData

2018-11-26 Thread Samuel Ortiz
That will allow us to generalize the ARM build_rsdp() routine to support both legacy RSDP (The current i386 implementation) and extended RSDP (The ARM implementation). Signed-off-by: Samuel Ortiz --- include/hw/acpi/acpi-defs.h | 11 +++ hw/arm/virt-acpi-build.c| 27

[Qemu-devel] [PATCH 2/8] hw: arm: acpi: Fix incorrect checksums in RSDP

2018-11-26 Thread Samuel Ortiz
remove unused AcpiRsdpDescriptor structure. Based on "[PATCH v5 05/24] hw: acpi: Implement XSDT support for RSDP" by Samuel Ortiz, who did it right in his impl. Fixes: d4bec5d87 (hw/arm/virt-acpi-build: Generate RSDP table) Signed-off-by: Igor Mammedov CC: Ard Biesheuvel CC: Sh

Re: [Qemu-devel] [PATCH 0/2] acpi: RSDP: fix checksum calculations

2018-11-26 Thread Samuel Ortiz
On Mon, Nov 26, 2018 at 11:31:25AM +0100, Igor Mammedov wrote: > On Fri, 23 Nov 2018 11:11:50 -0500 > "Michael S. Tsirkin" wrote: > > > On Thu, Nov 22, 2018 at 11:29:32AM +0100, Igor Mammedov wrote: > > > * arm/virt is broken but it looks like linux doesn't care, lets fix it > > > anyways > > >

Re: [Qemu-devel] [PATCH v5 05/24] hw: acpi: Implement XSDT support for RSDP

2018-11-23 Thread Samuel Ortiz
On Thu, Nov 22, 2018 at 05:26:52PM +0100, Igor Mammedov wrote: > On Wed, 21 Nov 2018 15:42:11 +0100 > Samuel Ortiz wrote: > > > Hi Igor, > > > > On Thu, Nov 08, 2018 at 03:16:23PM +0100, Igor Mammedov wrote: > > > On Mon, 5 Nov 2018 02:4

Re: [Qemu-devel] [PATCH v5 00/24] ACPI reorganization for hardware-reduced API addition

2018-11-21 Thread Samuel Ortiz
On Wed, Nov 21, 2018 at 03:15:26PM +0100, Igor Mammedov wrote: > On Wed, 21 Nov 2018 07:35:47 -0500 > "Michael S. Tsirkin" wrote: > > > On Mon, Nov 19, 2018 at 04:31:10PM +0100, Igor Mammedov wrote: > > > On Fri, 16 Nov 2018 17:37:54 +0100 > > > Paolo Bonzini wrote: > > > > > > > On 16/11/18

Re: [Qemu-devel] [PATCH v5 20/24] hw: acpi: Define ACPI tables builder interface

2018-11-21 Thread Samuel Ortiz
On Fri, Nov 16, 2018 at 05:02:26PM +0100, Igor Mammedov wrote: > On Mon, 5 Nov 2018 02:40:43 +0100 > Samuel Ortiz wrote: > > > In order to decouple ACPI APIs from specific machine types, we are > > creating an ACPI builder interface that each ACPI platform can choose to &g

Re: [Qemu-devel] [PATCH v5 15/24] hw: i386: Export the i386 ACPI SRAT build method

2018-11-21 Thread Samuel Ortiz
On Thu, Nov 15, 2018 at 02:28:54PM +0100, Igor Mammedov wrote: > On Mon, 5 Nov 2018 02:40:38 +0100 > Samuel Ortiz wrote: > > > This is the standard way of building SRAT on x86 platfoms. But future > > machine types could decide to define their own custom SRAT build method

Re: [Qemu-devel] [PATCH v5 12/24] hw: acpi: Export the MCFG getter

2018-11-21 Thread Samuel Ortiz
Hi Igor, On Thu, Nov 15, 2018 at 01:36:58PM +0100, Igor Mammedov wrote: > On Mon, 5 Nov 2018 02:40:35 +0100 > Samuel Ortiz wrote: > > > From: Yang Zhong > > > > The ACPI MCFG getter is not x86 specific and could be called from > > anywhere within generic A

Re: [Qemu-devel] [PATCH v5 11/24] hw: acpi: Export and generalize the PCI host AML API

2018-11-21 Thread Samuel Ortiz
Hi Igor, On Wed, Nov 14, 2018 at 11:55:37AM +0100, Igor Mammedov wrote: > On Mon, 5 Nov 2018 02:40:34 +0100 > Samuel Ortiz wrote: > > > From: Yang Zhong > > > > The AML build routines for the PCI host bridge and the corresponding > > DSDT addition are neither

Re: [Qemu-devel] [PATCH v5 10/24] hw: acpi: Export the PCI host and holes getters

2018-11-21 Thread Samuel Ortiz
On Tue, Nov 13, 2018 at 04:59:18PM +0100, Igor Mammedov wrote: > On Mon, 5 Nov 2018 02:40:33 +0100 > Samuel Ortiz wrote: > > > This is going to be needed by the hardware reduced implementation, so > > let's export it. > > Once the ACPI builder methods and

Re: [Qemu-devel] [PATCH v5 07/24] hw: acpi: Generalize AML build routines

2018-11-21 Thread Samuel Ortiz
Hi Igor, On Fri, Nov 09, 2018 at 02:37:33PM +0100, Igor Mammedov wrote: > On Mon, 5 Nov 2018 02:40:30 +0100 > Samuel Ortiz wrote: > > > From: Yang Zhong > > > > Most of the AML build routines under acpi-build are not even > > architecture specific. They ca

Re: [Qemu-devel] [PATCH v5 02/24] hw: acpi: Export ACPI build alignment API

2018-11-21 Thread Samuel Ortiz
On Fri, Nov 09, 2018 at 03:27:16PM +0100, Igor Mammedov wrote: > On Mon, 5 Nov 2018 02:40:25 +0100 > Samuel Ortiz wrote: > > > This is going to be needed by the Hardware-reduced ACPI routines. > > > > Reviewed-by: Philippe Mathieu-Daudé > > Tested-by: Philippe

Re: [Qemu-devel] [PATCH v5 01/24] hw: i386: Decouple the ACPI build from the PC machine type

2018-11-21 Thread Samuel Ortiz
Hi Igor, On Fri, Nov 09, 2018 at 03:23:16PM +0100, Igor Mammedov wrote: > On Mon, 5 Nov 2018 02:40:24 +0100 > Samuel Ortiz wrote: > > > ACPI tables are platform and machine type and even architecture > > agnostic, and as such we want to provide an internal ACPI API tha

Re: [Qemu-devel] [PATCH v5 05/24] hw: acpi: Implement XSDT support for RSDP

2018-11-21 Thread Samuel Ortiz
Hi Igor, On Thu, Nov 08, 2018 at 03:16:23PM +0100, Igor Mammedov wrote: > On Mon, 5 Nov 2018 02:40:28 +0100 > Samuel Ortiz wrote: > > > XSDT is the 64-bit version of the legacy ACPI RSDT (Root System > > Description Table). RSDT only allow for 32-bit addressses a

Re: [Qemu-devel] [PATCH v5 00/24] ACPI reorganization for hardware-reduced API addition

2018-11-21 Thread Samuel Ortiz
Igor, On Wed, Nov 21, 2018 at 03:15:26PM +0100, Igor Mammedov wrote: > On Wed, 21 Nov 2018 07:35:47 -0500 > "Michael S. Tsirkin" wrote: > > > On Mon, Nov 19, 2018 at 04:31:10PM +0100, Igor Mammedov wrote: > > > On Fri, 16 Nov 2018 17:37:54 +0100 > > > Paolo Bonzini wrote: > > > > > > > On 16

Re: [Qemu-devel] [PATCH v5 00/24] ACPI reorganization for hardware-reduced API addition

2018-11-21 Thread Samuel Ortiz
Hi Michael, On Wed, Nov 21, 2018 at 07:35:47AM -0500, Michael S. Tsirkin wrote: > On Mon, Nov 19, 2018 at 04:31:10PM +0100, Igor Mammedov wrote: > > On Fri, 16 Nov 2018 17:37:54 +0100 > > Paolo Bonzini wrote: > > > > > On 16/11/18 17:29, Igor Mammedov wrote: > > > > General suggestions for this

Re: [Qemu-devel] SeaBIOS booting time optimization

2018-11-18 Thread Samuel Ortiz
Hi Stefano, On Fri, Nov 16, 2018 at 05:13:59PM +0100, Stefano Garzarella wrote: > Hi, > I'm investigating the SeaBIOS booting time, to understand if we can reduce > the boot time in some cases (e.g. legacy hardware is not needed). I think > this > can be interesting also for NEMU developers. Defin

Re: [Qemu-devel] SeaBIOS booting time optimization

2018-11-18 Thread Samuel Ortiz
Hi Stefan, On Fri, Nov 16, 2018 at 04:39:20PM +, Stefan Hajnoczi wrote: > On Fri, Nov 16, 2018 at 4:21 PM Stefano Garzarella > wrote: > > I'm investigating the SeaBIOS booting time, to understand if we can reduce > > the boot time in some cases (e.g. legacy hardware is not needed). I think >

Re: [Qemu-devel] [PATCH 01/13] target: arm: Add copyright boilerplate

2018-11-13 Thread Samuel Ortiz
On Tue, Nov 13, 2018 at 04:58:40PM +, Peter Maydell wrote: > On 13 November 2018 at 16:52, Samuel Ortiz wrote: > > From: Philippe Mathieu-Daudé > > > > Signed-off-by: Philippe Mathieu-Daudé > > Reviewed-by: Robert Bradford > > Reviewed-by: Samuel Ortiz >

Re: [Qemu-devel] [PATCH 02/13] target: arm: Remove unused headers

2018-11-13 Thread Samuel Ortiz
Hi Philippe, On Tue, Nov 13, 2018 at 07:02:57PM +0100, Philippe Mathieu-Daudé wrote: > On 13/11/18 18:01, Peter Maydell wrote: > > On 13 November 2018 at 16:52, Samuel Ortiz wrote: > > > From: Philippe Mathieu-Daudé > > > > > > Signed-off-by: Philippe Math

[Qemu-devel] [PATCH 00/13] Support disabling TCG on ARM

2018-11-13 Thread Samuel Ortiz
thieu-Daudé (2): target: arm: Add copyright boilerplate target: arm: Remove unused headers Samuel Ortiz (11): target: arm: Move all v7m helpers into their own file target: arm: Move all interrupt and exception handlers into their own file target: arm: Move the DC ZVA helper into op_h

[Qemu-devel] [PATCH 07/13] target: arm: Remove the LDST headers

2018-11-13 Thread Samuel Ortiz
They are no longer needed. Signed-off-by: Samuel Ortiz Reviewed-by: Philippe Mathieu-Daudé Tested-by: Philippe Mathieu-Daudé Reviewed-by: Robert Bradford --- target/arm/helper.c | 1 - 1 file changed, 1 deletion(-) diff --git a/target/arm/helper.c b/target/arm/helper.c index 689879c23a

[Qemu-devel] [PATCH 12/13] target: arm: Makefile cleanup

2018-11-13 Thread Samuel Ortiz
Group objects with the same build dependencies together. Signed-off-by: Samuel Ortiz Reviewed-by: Philippe Mathieu-Daudé Tested-by: Philippe Mathieu-Daudé Reviewed-by: Robert Bradford --- target/arm/Makefile.objs | 15 +++ 1 file changed, 7 insertions(+), 8 deletions(-) diff

[Qemu-devel] [PATCH 05/13] target: arm: Move the DC ZVA helper into op_helper

2018-11-13 Thread Samuel Ortiz
Signed-off-by: Samuel Ortiz Reviewed-by: Philippe Mathieu-Daudé Tested-by: Philippe Mathieu-Daudé Reviewed-by: Robert Bradford --- target/arm/helper.c| 84 -- target/arm/op_helper.c | 84 ++ 2 files changed

[Qemu-devel] [PATCH 06/13] target: arm: Make ARM TLB filling routine static

2018-11-13 Thread Samuel Ortiz
It's only used in op_helper.c, it does not need to be exported and moreover it should only be build when TCG is enabled. Signed-off-by: Samuel Ortiz Reviewed-by: Philippe Mathieu-Daudé Tested-by: Philippe Mathieu-Daudé Reviewed-by: Robert Bradford --- target/arm/internals.h

[Qemu-devel] [PATCH 11/13] target: arm: Define TCG dependent functions when TCG is enabled

2018-11-13 Thread Samuel Ortiz
do_interrupt, do_unaligned_access, do_transaction_failed and debug_excp are only relevant in the TCG context, so we should not define them when TCG is disabled. Signed-off-by: Samuel Ortiz Reviewed-by: Philippe Mathieu-Daudé Tested-by: Philippe Mathieu-Daudé Reviewed-by: Robert Bradford

[Qemu-devel] [PATCH 02/13] target: arm: Remove unused headers

2018-11-13 Thread Samuel Ortiz
From: Philippe Mathieu-Daudé Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Robert Bradford Reviewed-by: Samuel Ortiz --- target/arm/helper.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/target/arm/helper.c b/target/arm/helper.c index 3d4e9c5c8a..27d9285e1e 100644 --- a/target

[Qemu-devel] [PATCH 01/13] target: arm: Add copyright boilerplate

2018-11-13 Thread Samuel Ortiz
From: Philippe Mathieu-Daudé Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Robert Bradford Reviewed-by: Samuel Ortiz --- target/arm/helper.c | 7 +++ 1 file changed, 7 insertions(+) diff --git a/target/arm/helper.c b/target/arm/helper.c index 0da1424f72..3d4e9c5c8a 100644 --- a

[Qemu-devel] [PATCH 08/13] target: arm: Move all VFP helpers into their own file

2018-11-13 Thread Samuel Ortiz
Since softfloat is only relevant with TCG, we move all ARM VFP helpers into their own file (vfp_helper.c), in order to support TCG disablement on ARM. Signed-off-by: Samuel Ortiz Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Philippe Mathieu-Daudé Tested-by: Philippe Mathieu-Daudé

[Qemu-devel] [PATCH 10/13] target: arm: Move watchpoints APIs to helper.c

2018-11-13 Thread Samuel Ortiz
Here again, those APIs are not TCG dependent and can move to the always built helper.c. Signed-off-by: Samuel Ortiz Reviewed-by: Philippe Mathieu-Daudé Tested-by: Philippe Mathieu-Daudé Reviewed-by: Robert Bradford --- target/arm/internals.h | 6 ++ target/arm/helper.c| 204

[Qemu-devel] [PATCH 13/13] target: arm: Do not build TCG objects when TCG is off

2018-11-13 Thread Samuel Ortiz
We can now safely turn all TCG dependent build off when CONFIG_TCG is off. This allows building ARM binaries with --disable-tcg. Signed-off-by: Samuel Ortiz Reviewed-by: Philippe Mathieu-Daudé Tested-by: Philippe Mathieu-Daudé Reviewed-by: Robert Bradford --- target/arm/Makefile.objs | 14

[Qemu-devel] [PATCH 09/13] target: arm: Move CPU state dumping routines to helper.c

2018-11-13 Thread Samuel Ortiz
They're not TCG specific and should be living the generic helper file instead. Signed-off-by: Samuel Ortiz Reviewed-by: Robert Bradford --- target/arm/internals.h | 12 +++ target/arm/translate.h | 7 -- target/arm/helper.c| 214 + t

[Qemu-devel] [PATCH 04/13] target: arm: Move all interrupt and exception handlers into their own file

2018-11-13 Thread Samuel Ortiz
Most of them are TCG dependent so we want to be able to not build them in order to support TCG disablement with ARM. Signed-off-by: Samuel Ortiz Tested-by: Philippe Mathieu-Daudé Reviewed-by: Robert Bradford --- target/arm/excp_helper.c | 550 +++ target

Re: [Qemu-devel] [PATCH v5 05/24] hw: acpi: Implement XSDT support for RSDP

2018-11-08 Thread Samuel Ortiz
Hi Igor, On Thu, Nov 08, 2018 at 03:16:23PM +0100, Igor Mammedov wrote: > On Mon, 5 Nov 2018 02:40:28 +0100 > Samuel Ortiz wrote: > > > XSDT is the 64-bit version of the legacy ACPI RSDT (Root System > > Description Table). RSDT only allow for 32-bit addressses a

Re: [Qemu-devel] QEMU and Kconfig

2018-11-08 Thread Samuel Ortiz
On Wed, Nov 07, 2018 at 05:24:14PM -0200, Eduardo Habkost wrote: > On Wed, Nov 07, 2018 at 06:39:54PM +0100, Paolo Bonzini wrote: > > On 07/11/2018 16:41, Samuel Ortiz wrote: > > > - The Kconfig parser would be used to generate the equivalent of what we > > > currently

Re: [Qemu-devel] QEMU and Kconfig

2018-11-07 Thread Samuel Ortiz
Hi Paolo, On Thu, Sep 27, 2018 at 10:55:59AM +0200, Paolo Bonzini wrote: > > What is the syntactic thing in this example which distinguishes > > "user can toggle this" (ESP_PCI, ARM_VIRT, SUN4M) from "user > > can't toggle this, it's just an internal thing selected by > > other nodes" (the rest) ?

Re: [Qemu-devel] [PATCH v5 03/24] hw: acpi: The RSDP build API can return void

2018-11-06 Thread Samuel Ortiz
On Tue, Nov 06, 2018 at 11:23:39AM +0100, Paolo Bonzini wrote: > On 05/11/2018 02:40, Samuel Ortiz wrote: > > /* RSDP */ > > -static GArray * > > +static void > > build_rsdp(GArray *rsdp_table, BIOSLinker *linker, unsigned > > xsdt_tbl_offset) > &g

Re: [Qemu-devel] [PATCH v4 00/23] ACPI reorganization for hardware-reduced support

2018-11-05 Thread Samuel Ortiz
Hi Andrew, On Mon, Nov 05, 2018 at 05:07:53PM +0100, Andrew Jones wrote: > > > QEMU already has hw reduced implementation, specifically in arm/virt board > > Back in May, I tried booting a virt machine type with "acpi=force" with > > no success, and today's HEAD still fails. With "acpi=on": > > >

Re: [Qemu-devel] [PATCH v4 00/23] ACPI reorganization for hardware-reduced support

2018-11-05 Thread Samuel Ortiz
Igor, On Mon, Nov 05, 2018 at 03:10:28AM +0100, Samuel Ortiz wrote: > > QEMU already has hw reduced implementation, specifically in arm/virt board > Back in May, I tried booting a virt machine type with "acpi=force" with > no success, and today's HEAD

Re: [Qemu-devel] [PATCH v4 00/23] ACPI reorganization for hardware-reduced support

2018-11-04 Thread Samuel Ortiz
Hi Igor, On Fri, Nov 02, 2018 at 01:29:25PM +0100, Igor Mammedov wrote: > On Thu, 1 Nov 2018 11:22:40 +0100 > Samuel Ortiz wrote: > > Thanks for looking at ACPI mess we have in QEMU and trying to make it better, Thanks for the initial review and feedback. > this series loo

[Qemu-devel] [PATCH v5 19/24] hw: acpi: Retrieve the PCI bus from AcpiPciHpState

2018-11-04 Thread Samuel Ortiz
From: Sebastien Boeuf Instead of using the machine type specific method find_i440fx() to retrieve the PCI bus, this commit aims to rely on the fact that the PCI bus is known by the structure AcpiPciHpState. When the structure is initialized through acpi_pcihp_init() call, it saves the PCI bus, w

[Qemu-devel] [PATCH v5 17/24] hw: acpi: Export the PCI hotplug API

2018-11-04 Thread Samuel Ortiz
From: Sebastien Boeuf The ACPI hotplug support for PCI devices APIs are not x86 or even machine type specific. In order for future machine types to be able to re-use that code, we export it through the architecture agnostic hw/acpi folder. Reviewed-by: Philippe Mathieu-Daudé Tested-by: Philippe

[Qemu-devel] [PATCH v5 18/24] hw: i386: Export the MADT build method

2018-11-04 Thread Samuel Ortiz
-Daudé Tested-by: Philippe Mathieu-Daudé Signed-off-by: Samuel Ortiz --- include/hw/i386/acpi.h | 28 hw/arm/virt-acpi-build.c | 4 ++-- hw/i386/acpi-build.c | 4 ++-- 3 files changed, 32 insertions(+), 4 deletions(-) create mode 100644 include/hw/i386

[Qemu-devel] [PATCH v5 24/24] hw: i386: Refactor PCI host getter

2018-11-04 Thread Samuel Ortiz
From: Yang Zhong Now that the ACPI builder methods are added, we can reach the ACPI configuration pointer from the MachineState pointer. From there we can get to the PCI host pointer and return it. This makes the PCI host getter an ACPI, architecture agnostic function. Signed-off-by: Yang Zhong

[Qemu-devel] [PATCH v5 07/24] hw: acpi: Generalize AML build routines

2018-11-04 Thread Samuel Ortiz
From: Yang Zhong Most of the AML build routines under acpi-build are not even architecture specific. They can be moved to the more generic hw/acpi folder where they could be shared across machine types and architectures. Reviewed-by: Philippe Mathieu-Daudé Tested-by: Philippe Mathieu-Daudé Sig

  1   2   3   >