el version 6.8.5 for testing,
the crashes are far more frequent. In kernel version 6.15.0-rc3+, it's much
harder to reproduce.
On 5/15/25 11:49 AM, Eugenio Perez Martin wrote:
On Wed, May 14, 2025 at 8:22 AM Sahil Siddiq wrote:
On 4/16/25 12:50 PM, Eugenio Perez Martin wrote:
On Mon, Apr
Hi,
Apologies, I haven't been in touch for a while. I have an update that
I would like to give.
On 4/16/25 12:50 PM, Eugenio Perez Martin wrote:
On Mon, Apr 14, 2025 at 11:20 AM Sahil Siddiq wrote:
Hi,
On 3/26/25 1:05 PM, Eugenio Perez Martin wrote:
On Mon, Mar 24, 2025 at 2:59 PM
Hi,
On 4/14/25 2:50 PM, Sahil Siddiq wrote:
On 3/26/25 1:05 PM, Eugenio Perez Martin wrote:
On Mon, Mar 24, 2025 at 2:59 PM Sahil Siddiq wrote:
I managed to fix a few issues while testing this patch series.
There is still one issue that I am unable to resolve. I thought
I would send this
Hi,
On 4/14/25 8:37 PM, Eugenio Perez Martin wrote:
On Mon, Apr 14, 2025 at 11:38 AM Sahil Siddiq wrote:
On 3/28/25 1:21 PM, Eugenio Perez Martin wrote:
On Thu, Mar 27, 2025 at 7:42 PM Sahil Siddiq wrote:
On 3/26/25 1:33 PM, Eugenio Perez Martin wrote:
[...]
I think both approaches should
Hi,
On 3/28/25 1:21 PM, Eugenio Perez Martin wrote:
On Thu, Mar 27, 2025 at 7:42 PM Sahil Siddiq wrote:
On 3/26/25 1:33 PM, Eugenio Perez Martin wrote:
On Mon, Mar 24, 2025 at 3:14 PM Sahil Siddiq wrote:
On 3/24/25 7:29 PM, Sahil Siddiq wrote:
Implement the insertion of available buffers
Hi,
On 3/26/25 1:05 PM, Eugenio Perez Martin wrote:
On Mon, Mar 24, 2025 at 2:59 PM Sahil Siddiq wrote:
I managed to fix a few issues while testing this patch series.
There is still one issue that I am unable to resolve. I thought
I would send this patch series for review in case I have
Hi,
On 3/26/25 5:38 PM, Eugenio Perez Martin wrote:
On Mon, Mar 24, 2025 at 3:00 PM Sahil Siddiq wrote:
[...]
Link: https://lists.nongnu.org/archive/html/qemu-devel/2024-10/msg05106.html
Link: https://lore.kernel.org/r/20210602021536.39525-4-jasow...@redhat.com
Link: 1225c216d954 ("vp
Hi,
On 3/26/25 5:32 PM, Eugenio Perez Martin wrote:
On Mon, Mar 24, 2025 at 3:00 PM Sahil Siddiq wrote:
Implement the insertion of available buffers in the descriptor area of
packed shadow virtqueues. It takes into account descriptor chains, but
does not consider indirect descriptors
Hi,
On 3/26/25 5:36 PM, Eugenio Perez Martin wrote:
On Mon, Mar 24, 2025 at 3:00 PM Sahil Siddiq wrote:
Validate transport device features required for utilizing packed SVQ
that both guests can use with the SVQ and SVQs can use with vdpa.
Signed-off-by: Sahil Siddiq
---
Changes from v4
Hi,
On 3/26/25 4:56 PM, Eugenio Perez Martin wrote:
On Mon, Mar 24, 2025 at 3:00 PM Sahil Siddiq wrote:
Introduce "struct vring_packed".
Modify VhostShadowVirtqueue so it can support split and packed virtqueue
formats.
Signed-off-by: Sahil Siddiq
---
Changes from v4 -> v
Hi,
On 3/26/25 2:04 PM, Eugenio Perez Martin wrote:
On Mon, Mar 24, 2025 at 3:34 PM Sahil Siddiq wrote:
Hi,
I had a few more queries here as well.
On 3/24/25 7:29 PM, Sahil Siddiq wrote:
Detect when used descriptors are ready for consumption by the guest via
packed virtqueues and forward
Hi,
On 3/26/25 4:55 PM, Eugenio Perez Martin wrote:
On Mon, Mar 24, 2025 at 2:59 PM Sahil Siddiq wrote:
This commit refactors vhost_svq_add_split and vhost_svq_add to simplify
their implementation and prepare for the addition of packed vqs in the
following commits.
Signed-off-by: Sahil
Hi,
On 3/26/25 1:33 PM, Eugenio Perez Martin wrote:
On Mon, Mar 24, 2025 at 3:14 PM Sahil Siddiq wrote:
On 3/24/25 7:29 PM, Sahil Siddiq wrote:
Implement the insertion of available buffers in the descriptor area of
packed shadow virtqueues. It takes into account descriptor chains, but
does
Hi,
I had a few more queries here as well.
On 3/24/25 7:29 PM, Sahil Siddiq wrote:
Detect when used descriptors are ready for consumption by the guest via
packed virtqueues and forward them from the device to the guest.
Signed-off-by: Sahil Siddiq
---
Changes from v4 -> v5:
- New com
Hi,
I had a few queries here.
On 3/24/25 7:29 PM, Sahil Siddiq wrote:
Implement the insertion of available buffers in the descriptor area of
packed shadow virtqueues. It takes into account descriptor chains, but
does not consider indirect descriptors.
Enable the packed SVQ to forward the
This commit refactors vhost_svq_add_split and vhost_svq_add to simplify
their implementation and prepare for the addition of packed vqs in the
following commits.
Signed-off-by: Sahil Siddiq
---
No changes from v4 -> v5.
hw/virtio/vhost-shadow-virtqueue.c | 107 +++--
05106.html
Link: https://lore.kernel.org/r/20210602021536.39525-4-jasow...@redhat.com
Link: 1225c216d954 ("vp_vdpa: allow set vq state to initial state after reset")
Signed-off-by: Sahil Siddiq
Acked-by: Eugenio Pérez
---
Changes from v4 -> v5:
- Initially commit #5 in v4.
- Fix coding sty
ze flags, counters and indices for packed vqs before they
are utilized.
Signed-off-by: Sahil Siddiq
---
Changes from v4 -> v5:
- vhost-shadow-virtqueue.c:
(vhost_svq_start): Initialize variables used by packed vring.
hw/virtio/vhost-shadow-virtqueue.c | 52 +-
h
Validate transport device features required for utilizing packed SVQ
that both guests can use with the SVQ and SVQs can use with vdpa.
Signed-off-by: Sahil Siddiq
---
Changes from v4 -> v5:
- Split from commit #2 in v4.
hw/virtio/vhost-shadow-virtqueue.c | 3 +++
1 file changed, 3 inserti
Implement the insertion of available buffers in the descriptor area of
packed shadow virtqueues. It takes into account descriptor chains, but
does not consider indirect descriptors.
Enable the packed SVQ to forward the descriptors to the device.
Signed-off-by: Sahil Siddiq
---
Changes from v4
Detect when used descriptors are ready for consumption by the guest via
packed virtqueues and forward them from the device to the guest.
Signed-off-by: Sahil Siddiq
---
Changes from v4 -> v5:
- New commit.
- vhost-shadow-virtqueue.c:
(vhost_svq_more_used): Split into vhost_svq_more_used_sp
Introduce "struct vring_packed".
Modify VhostShadowVirtqueue so it can support split and packed virtqueue
formats.
Signed-off-by: Sahil Siddiq
---
Changes from v4 -> v5:
- This was commit #3 in v4. This has been reordered to commit #2
based on review comments.
- Place sha
implementation of "vhost_svq_(en|dis)able_notification" in commit #5.
4. something else?
Thanks,
Sahil
[1] https://github.com/torvalds/linux/blob/master/drivers/net/virtio_net.c#L3245
[2]
https://www.redhat.com/en/blog/hands-vdpa-what-do-you-do-when-you-aint-got-hardware-part-2
Sahil Sidd
Hi,
On 3/6/25 12:53 PM, Eugenio Perez Martin wrote:
On Thu, Mar 6, 2025 at 6:26 AM Sahil Siddiq wrote:
[...]
On 2/11/25 1:27 PM, Eugenio Perez Martin wrote:
[...]
[ 49.173243] watchdog: BUG: soft lockup - CPU#1 stuck for 25s!
[NetworkManager:782]
[ 49.174167] Modules linked in: rfkill
Hi,
Sorry for the delay in my response. There was a lot to absorb in the
previous mail and I thought I would spend some more time exploring
this.
On 2/11/25 1:27 PM, Eugenio Perez Martin wrote:
On Mon, Feb 10, 2025 at 5:25 PM Sahil Siddiq wrote:
On 2/10/25 7:53 PM, Eugenio Perez Martin wrote
Hi,
On 2/10/25 7:53 PM, Eugenio Perez Martin wrote:
On Mon, Feb 10, 2025 at 11:58 AM Sahil Siddiq wrote:
On 2/6/25 8:47 PM, Sahil Siddiq wrote:
On 2/6/25 12:42 PM, Eugenio Perez Martin wrote:
On Thu, Feb 6, 2025 at 6:26 AM Sahil Siddiq wrote:
On 2/4/25 11:45 PM, Eugenio Perez Martin wrote
Hi,
On 2/6/25 8:47 PM, Sahil Siddiq wrote:
On 2/6/25 12:42 PM, Eugenio Perez Martin wrote:
On Thu, Feb 6, 2025 at 6:26 AM Sahil Siddiq wrote:
On 2/4/25 11:45 PM, Eugenio Perez Martin wrote:
PS: Please note that you can check packed_vq SVQ implementation
already without CVQ, as these
Hi,
On 2/6/25 12:42 PM, Eugenio Perez Martin wrote:
On Thu, Feb 6, 2025 at 6:26 AM Sahil Siddiq wrote:
Hi,
On 2/4/25 11:40 PM, Eugenio Perez Martin wrote:
On Tue, Feb 4, 2025 at 1:49 PM Sahil Siddiq wrote:
On 1/31/25 12:27 PM, Eugenio Perez Martin wrote:
On Fri, Jan 31, 2025 at 6:04 AM
Hi,
On 2/4/25 11:40 PM, Eugenio Perez Martin wrote:
On Tue, Feb 4, 2025 at 1:49 PM Sahil Siddiq wrote:
On 1/31/25 12:27 PM, Eugenio Perez Martin wrote:
On Fri, Jan 31, 2025 at 6:04 AM Sahil Siddiq wrote:
On 1/24/25 1:04 PM, Eugenio Perez Martin wrote:
On Fri, Jan 24, 2025 at 6:47 AM Sahil
Hi,
On 1/31/25 12:27 PM, Eugenio Perez Martin wrote:
On Fri, Jan 31, 2025 at 6:04 AM Sahil Siddiq wrote:
On 1/24/25 1:04 PM, Eugenio Perez Martin wrote:
On Fri, Jan 24, 2025 at 6:47 AM Sahil Siddiq wrote:
On 1/21/25 10:07 PM, Eugenio Perez Martin wrote:
On Sun, Jan 19, 2025 at 7:37 AM
Hi,
On 1/24/25 1:04 PM, Eugenio Perez Martin wrote:
On Fri, Jan 24, 2025 at 6:47 AM Sahil Siddiq wrote:
On 1/21/25 10:07 PM, Eugenio Perez Martin wrote:
On Sun, Jan 19, 2025 at 7:37 AM Sahil Siddiq wrote:
On 1/7/25 1:35 PM, Eugenio Perez Martin wrote:
[...]
Apologies for the delay in
Hi,
On 1/21/25 10:07 PM, Eugenio Perez Martin wrote:
On Sun, Jan 19, 2025 at 7:37 AM Sahil Siddiq wrote:
Hi,
On 1/7/25 1:35 PM, Eugenio Perez Martin wrote:
On Fri, Jan 3, 2025 at 2:06 PM Sahil Siddiq wrote:
Hi,
On 12/20/24 12:28 PM, Eugenio Perez Martin wrote:
On Thu, Dec 19, 2024 at
Hi,
On 1/7/25 1:35 PM, Eugenio Perez Martin wrote:
On Fri, Jan 3, 2025 at 2:06 PM Sahil Siddiq wrote:
Hi,
On 12/20/24 12:28 PM, Eugenio Perez Martin wrote:
On Thu, Dec 19, 2024 at 8:37 PM Sahil Siddiq wrote:
Hi,
On 12/17/24 1:20 PM, Eugenio Perez Martin wrote:
On Tue, Dec 17, 2024 at
Hi,
On 12/20/24 12:28 PM, Eugenio Perez Martin wrote:
On Thu, Dec 19, 2024 at 8:37 PM Sahil Siddiq wrote:
Hi,
On 12/17/24 1:20 PM, Eugenio Perez Martin wrote:
On Tue, Dec 17, 2024 at 6:45 AM Sahil Siddiq wrote:
On 12/16/24 2:09 PM, Eugenio Perez Martin wrote:
On Sun, Dec 15, 2024 at 6
Hi,
On 12/17/24 1:20 PM, Eugenio Perez Martin wrote:
On Tue, Dec 17, 2024 at 6:45 AM Sahil Siddiq wrote:
On 12/16/24 2:09 PM, Eugenio Perez Martin wrote:
On Sun, Dec 15, 2024 at 6:27 PM Sahil Siddiq wrote:
On 12/10/24 2:57 PM, Eugenio Perez Martin wrote:
On Thu, Dec 5, 2024 at 9:34 PM
Hi,
Thank you for your reply.
On 12/16/24 2:09 PM, Eugenio Perez Martin wrote:
On Sun, Dec 15, 2024 at 6:27 PM Sahil Siddiq wrote:
On 12/10/24 2:57 PM, Eugenio Perez Martin wrote:
On Thu, Dec 5, 2024 at 9:34 PM Sahil Siddiq wrote:
[...]
I have been following the "Hands on vDPA: wh
Hi,
On 12/10/24 2:57 PM, Eugenio Perez Martin wrote:
On Thu, Dec 5, 2024 at 9:34 PM Sahil Siddiq wrote:
Hi,
There are two issues that I found while trying to test
my changes. I thought I would send the patch series
as well in case that helps in troubleshooting. I haven't
been able to
Hi,
On 12/10/24 2:25 PM, Eugenio Perez Martin wrote:
On Thu, Dec 5, 2024 at 9:35 PM Sahil Siddiq wrote:
Introduce "struct vring_packed".
Modify VhostShadowVirtqueue so it can support split
and packed virtqueue formats.
This patch should be before the previous one or it does n
Hi,
On 12/10/24 2:24 PM, Eugenio Perez Martin wrote:
On Thu, Dec 5, 2024 at 9:35 PM Sahil Siddiq wrote:
This commit is the first in a series to add support for packed
virtqueues in vhost_shadow_virtqueue.
This patch implements the insertion of available buffers in the
descriptor area. It
Hi,
Thank you for your reply.
On 12/10/24 2:57 PM, Eugenio Perez Martin wrote:
On Thu, Dec 5, 2024 at 9:34 PM Sahil Siddiq wrote:
Hi,
There are two issues that I found while trying to test
my changes. I thought I would send the patch series
as well in case that helps in troubleshooting. I
Hi,
On 11/13/24 5:00 PM, Eugenio Perez Martin wrote:
On Wed, Nov 13, 2024 at 6:11 AM Sahil Siddiq wrote:
Hi,
On 10/28/24 11:07 AM, Sahil Siddiq wrote:
[...]
The payload that VHOST_SET_VRING_BASE accepts depends on whether
split virtqueues or packed virtqueues are used [6]. In hw/virtio
Allocate memory for the packed vq format and map them to the vdpa
device.
Since "struct vring" and "struct vring_packed's vring" both have
the same layout memory, the implementation in svq start and svq
stop should not differ based on the vq's format.
Signed-off-by
This commit refactors vhost_svq_add_split and
vhost_svq_add to simplify their implementation
and prepare for the addition of packed vqs in
following commits.
Signed-off-by: Sahil Siddiq
---
Changes v3 -> v4:
- Split commit #1 in v3 into 2 commits.
- Changes related to "vhost_svq_add_pac
"vp_vdpa: allow set vq state to initial state after reset")
Signed-off-by: Sahil Siddiq
Acked-by: Eugenio Pérez
---
Changes v3 -> v4:
- New commit.
- vhost-vdpa.c
(vhost_vdpa_svq_setup): Add comment.
hw/virtio/vhost-vdpa.c | 13 +
1 file changed, 13 insertions(+)
Introduce "struct vring_packed".
Modify VhostShadowVirtqueue so it can support split
and packed virtqueue formats.
Signed-off-by: Sahil Siddiq
---
Changes v3 -> v4:
- Commit #2 of v3 is now commit #3 in this series.
- vhost-shadow-virtqueue.h
(struct VhostShadowVirtqueue): Add b
features that vdpa supports.
Signed-off-by: Sahil Siddiq
---
Changes v3 -> v4:
- Split commit #1 in v3 into 2 commits.
- vhost-shadow-virtqueue.c
(vhost_svq_valid_features): Add enums.
hw/virtio/vhost-shadow-virtqueue.c | 83 +-
1 file changed, 81 insertions(+)
5.html
[6] https://github.com/torvalds/linux/blob/master/drivers/net/virtio_net.c#L3104
[7] https://lists.nongnu.org/archive/html/qemu-devel/2024-08/msg01148.html
[8] https://lists.nongnu.org/archive/html/qemu-devel/2024-11/msg00598.html
Sahil Siddiq (5):
vhost: Refactor vhost_svq_add_split
vhost
Hi,
On 11/14/24 12:28 PM, Michael S. Tsirkin wrote:
On Mon, Nov 04, 2024 at 09:51:24PM +0530, Sahil Siddiq wrote:
Linux commit v5.14-rc1~30^2~8 enabled the vp_vdpa driver to set the
vq state to the device's initial state. This works differently for
split and packed vqs.
With shadow virtq
Hi,
On 10/28/24 11:07 AM, Sahil Siddiq wrote:
[...]
The payload that VHOST_SET_VRING_BASE accepts depends on whether
split virtqueues or packed virtqueues are used [6]. In hw/virtio/vhost-
vdpa.c:vhost_vdpa_svq_setup() [7], the following payload is used which is
not suitable for packed
Hi,
On 11/6/24 8:30 PM, Eugenio Perez Martin wrote:
On Wed, Nov 6, 2024 at 3:33 PM Stefano Garzarella wrote:
On Tue, Nov 05, 2024 at 08:24:17PM +0530, Sahil Siddiq wrote:
Hi,
Thank you for the review.
On 11/5/24 3:06 PM, Stefano Garzarella wrote:
On Mon, Nov 04, 2024 at 09:51:24PM +0530
Hi,
Thank you for the review.
On 11/5/24 3:06 PM, Stefano Garzarella wrote:
On Mon, Nov 04, 2024 at 09:51:24PM +0530, Sahil Siddiq wrote:
Linux commit v5.14-rc1~30^2~8 enabled the vp_vdpa driver to set the
To refer to a commit, please use the SHA-1 id or even better the form
suggested in
vhost-vdpa
(with the vp_vdpa driver) can use packed svqs.
Link: https://lists.nongnu.org/archive/html/qemu-devel/2024-10/msg05106.html
Link: https://lore.kernel.org/r/20210602021536.39525-4-jasow...@redhat.com
Signed-off-by: Sahil Siddiq
---
QEMU currently does not support packed vhost s
Hi,
Thank you for your reply.
On 10/28/24 1:40 PM, Eugenio Perez Martin wrote:
On Mon, Oct 28, 2024 at 6:38 AM Sahil Siddiq wrote:
[...]
I spent some time tinkering with the L0-L1-L2 test environment setup,
and understanding QEMU's hw/virtio/vhost-vdpa.c [1] as well as Linux's
dri
Hi,
It's been a while since I gave my last update. I have one more update
that I would like to give.
> On Tue, Sep 24, 2024 at 7:31 AM Sahil wrote:
> > And I booted L2 by running:
> >
> > # ./qemu/build/qemu-system-x86_64 \
> > -nographic \
> > -m 4G \
> > -enable-kvm \
> > -M q35 \
> > -drive f
Allocate memory for the packed vq format and support
packed vq in the SVQ "start" and "stop" operations.
Signed-off-by: Sahil Siddiq
---
Changes v2 -> v3:
* vhost-shadow-virtqueue.c
(vhost_svq_memory_packed): New function
(vhost_svq_start):
- Remove common variable
Introduce "struct vring_packed".
Modify VhostShadowVirtqueue so it can support split
and packed virtqueue formats.
Signed-off-by: Sahil Siddiq
---
No changes from v1/v2 -> v3
hw/virtio/vhost-shadow-virtqueue.h | 66 --
1 file changed, 44 insertions(+),
q_start):
- Remove common variables out of if-else branch.
(vhost_svq_stop):
- Add support for packed vq.
(vhost_svq_get_vring_addr): Revert changes
(vhost_svq_get_vring_addr_packed): Likwise.
* vhost-shadow-virtqueue.h
- Revert changes made to "vhost_svq_get_vring_addr*"
functio
This is the first patch in a series to add support for packed
virtqueues in vhost_shadow_virtqueue. This patch implements the
insertion of available buffers in the descriptor area. It takes
into account descriptor chains, but does not consider indirect
descriptors.
Signed-off-by: Sahil Siddiq
): New function but is yet to be implemented.
(vhost_svq_memory_packed): New function.
(vhost_svq_start): Support packed vq format.
* vhost-shadow-virtqueue.h
(struct VhostShadowVirtqueue): New member "is_packed"
(vhost_svq_get_vring_addr): Renamed function.
(vhost_svq_get_vring_ad
This is the first patch in a series to add support for packed
virtqueues in vhost_shadow_virtqueue. This patch implements the
insertion of available buffers in the descriptor area. It takes
into account descriptor chains, but does not consider indirect
descriptors.
Signed-off-by: Sahil Siddiq
Allocate memory for the packed vq format and support
packed vq in the SVQ "start" operation.
Signed-off-by: Sahil Siddiq
---
Changes v1 -> v2:
* vhost-shadow-virtqueue.h
(struct VhostShadowVirtqueue): New member "is_packed"
(vhost_svq_get_vring_
Introduce "struct vring_packed".
Modify VhostShadowVirtqueue so it can support split
and packed virtqueue formats.
Signed-off-by: Sahil Siddiq
---
No changes since v1.
hw/virtio/vhost-shadow-virtqueue.h | 66 --
1 file changed, 44 insertions(+), 22
been modified so it acts as a layer
of abstraction for split and packed virtqueues.
Signed-off-by: Sahil Siddiq
---
Hi,
I am currently working on adding support for packed virtqueues in
vhost_shadow_virtqueue [1]. This patch only implements the insertion of
available buffers in the descriptor area
63 matches
Mail list logo
