Re: [Qemu-devel] [PATCH] hw/ppc/prep: Remove superfluous call to soundhw_init()

2017-06-09 Thread Sahid Orentino Ferdjaoui
On Fri, Jun 09, 2017 at 08:53:17AM +0200, Thomas Huth wrote: > When using the 40p machine, soundhw_init() is currently called twice, > one time from vl.c and one time from ibm_40p_init(). The call in > ibm_40p_init() was likely just a copy-and-paste from a old version > of the prep machine - but th

Re: [Qemu-devel] [PATCH]Enable kvmvapic only when host doesn't support VAPIC capability in KVM mode

2017-04-10 Thread Sahid Orentino Ferdjaoui
On Thu, Apr 06, 2017 at 06:18:33PM +, Xu, Anthony wrote: > > > --- a/kvm-all.c > > > +++ b/kvm-all.c > > > @@ -2232,6 +2232,10 @@ int kvm_has_sync_mmu(void) > > > return kvm_check_extension(kvm_state, KVM_CAP_SYNC_MMU); > > > } > > > > > > +int kvm_has_vapic(void){ > > > +return !kvm_

Re: [Qemu-devel] [PATCH 3/3] esp-pci: simple clean up

2017-04-07 Thread Sahid Orentino Ferdjaoui
On Fri, Apr 07, 2017 at 02:59:08PM +0800, weiqi wrote: > From: Wei Qi > > It is unnecessary to assign variable 'size' here, because 'size' unused after > assignment. > > Signed-off-by: Wei Qi > --- > hw/scsi/esp-pci.c | 1 - > 1 file chan

Re: [Qemu-devel] [PATCH 2/3] vnc: simple clean up

2017-04-07 Thread Sahid Orentino Ferdjaoui
rle.c | 1 - > 1 file changed, 1 deletion(-) Reviewed-By: Sahid Orentino Ferdjaoui > > diff --git a/ui/vnc-enc-zrle.c b/ui/vnc-enc-zrle.c > index 5489870..fd63d4f 100644 > --- a/ui/vnc-enc-zrle.c > +++ b/ui/vnc-enc-zrle.c > @@ -163,7 +163,6 @@ static void zrle_choose

Re: [Qemu-devel] [PATCH 1/3] vhost: simple clean up

2017-04-07 Thread Sahid Orentino Ferdjaoui
]. [0] http://wiki.qemu-project.org/Contribute/SubmitAPatch#Write_a_meaningful_commit_message > > Signed-off-by: Wei Qi > --- > hw/virtio/vhost.c | 1 - > 1 file changed, 1 deletion(-) Reviewed-By: Sahid Orentino Ferdjaoui > > diff --git a/hw/virtio/vhost.c b/hw/virtio/vhos

Re: [Qemu-devel] [PATCH 2/3] move xen-hvm.c to hw/i386/xen/

2017-04-06 Thread Sahid Orentino Ferdjaoui
rename xen-hvm.c => hw/i386/xen/xen-hvm.c (99%) > rename xen-hvm-stub.c => stubs/xen-hvm.c (100%) Reviewed-By: Sahid Orentino Ferdjaoui > > diff --git a/Makefile.target b/Makefile.target > index 48c027f..d5ff0c7 100644 > --- a/Makefile.target > +++ b/Makefile

Re: [Qemu-devel] [PATCH 1/3] move xen-common.c to hw/xen/

2017-04-06 Thread Sahid Orentino Ferdjaoui
On Wed, Apr 05, 2017 at 04:21:29PM -0700, Anthony Xu wrote: > move xen-common.c to hw/xen/ > > Signed-off -by: Anthony Xu nit: s/Signed-off -by/Signed-off-by, not sure if it's really important or not. Reviewed-By: Sahid Orentino Ferdjaoui > > --

Re: [Qemu-devel] [PATCH]Enable kvmvapic only when host doesn't support VAPIC capability in KVM mode

2017-04-06 Thread Sahid Orentino Ferdjaoui
On Wed, Apr 05, 2017 at 12:52:25AM +, Xu, Anthony wrote: > In KVM mode, enable kvmvapic only when host doesn't support > VAPIC capability. > > Save the time to set up kvmvapic in some hosts. > > > Signed-off -by: Anthony Xu > s/Signed-off -by/Signed-off-by nit: I think we do prefer a sin

Re: [Qemu-devel] [Qemu-trivial] [PATCH] virtio-gpu: replace PIXMAN_* by PIXMAN_BE_*

2017-04-06 Thread Sahid Orentino Ferdjaoui
r > > Reviewed-by: Philippe Mathieu-Daudé > Reviewed-by: Sahid Orentino Ferdjaoui > > > --- > > hw/display/virtio-gpu.c | 35 --- > > 1 file changed, 8 insertions(+), 27 deletions(-) > > > > diff --git a/hw/display/virtio