Hi,
On Tue, Jul 09, 2024 at 06:58:41PM GMT, Marc-André Lureau wrote:
> Hi
>
> On Tue, Jul 9, 2024 at 6:41 PM Ruihan Li wrote:
>
> > Hi,
> >
> > On Mon, Jul 08, 2024 at 03:21:58PM GMT, Marc-André Lureau wrote:
> > > Hi
> > >
> &
Hi,
On Mon, Jul 08, 2024 at 03:21:58PM GMT, Marc-André Lureau wrote:
> Hi
>
> On Mon, Jul 8, 2024 at 12:12 AM Ruihan Li wrote:
>
> > Hi,
> >
> > Thanks for your quick review!
> >
> > On Sun, Jul 07, 2024 at 08:28:50PM GMT, Marc-André Lureau wrote:
>
Hi,
Thanks for your quick review!
On Sun, Jul 07, 2024 at 08:28:50PM GMT, Marc-André Lureau wrote:
> Hi
>
> On Sun, Jul 7, 2024 at 3:26 PM Ruihan Li wrote:
>
> > This commit fixes a bug that causes incorrect results when pasting more
> > than 32 bytes, the size of the
also passes the data to the backend one byte at a time.
Signed-off-by: Ruihan Li
---
chardev/char-mux.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/chardev/char-mux.c b/chardev/char-mux.c
index ee2d47b..5c6eea2 100644
--- a/chardev/char-mux.c
+++ b/chardev/char-mux.c
@@
inhibit_reset = true;
> } else if (inhibit) {
> gen_set_hflag(s, HF_INHIBIT_IRQ_MASK);
> }
Yes, I agree with you that your changes look a bit clearer. I have
tested your changes and verified that they fix the reported bug.
> No need to submit v3, I can do the change myself when applying.
Thank you for your review. Feel free to do that.
Thanks,
Ruihan Li
: Ruihan Li
---
The same problem was discovered two years ago, see [StackOverflow][so].
[so]:
https://stackoverflow.com/questions/68135305/executing-ret-after-sti-doesnt-start-interrupts
Changes since v1:
- Fix a typo: "RET is followed by STI" -> "STI is followed by RET"
Hi all,
On Mon, Dec 11, 2023 at 03:01:48AM +0800, Ruihan Li wrote:
> When emulated with QEMU, interrupts will never come in the following
> loop. However, if the NOP instruction is uncommented, interrupts will
> fire as normal.
>
> loop:
> cli
>
On Mon, Dec 11, 2023 at 03:01:48AM +0800, Ruihan Li wrote:
> [ .. ]
>
> This problem is caused because the previous code may choose not to end
> the TB even if the HF_INHIBIT_IRQ_MASK has just been reset (e.g., in the
> case where the RET instruction is immediately foll
RET instruction is immediately followed by the STI
instruction), so that IRQs may not have a change to trigger. This commit
fixes the problem by always terminating the current TB to give IRQs a
chance to trigger when HF_INHIBIT_IRQ_MASK is reset.
Signed-off-by: Ruihan Li
---
The same problem was
