Re: [PATCH 0/5] Make WDOGCONTROL.INTEN the counter enable of the CMSDK APB Watchdog

2024-11-15 Thread Roque Arcudia Hernandez
Hello, I forgot to add the -v 2 to this patch series. This is the second version after Peter's feedback. Shall I resend it again or is it fine like this? Thanks Roque On Fri, Nov 15, 2024 at 8:03 AM Roque Arcudia Hernandez wrote: > > The following patchset tries to address an issu

[PATCH 1/5] hw/watchdog/cmsdk_apb_watchdog: Fix broken link

2024-11-15 Thread Roque Arcudia Hernandez
The patch changes the comments to point to the latest Design Kit Technical Reference Manual. Signed-off-by: Roque Arcudia Hernandez --- hw/watchdog/cmsdk-apb-watchdog.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/hw/watchdog/cmsdk-apb-watchdog.c b/hw/watchdog/cmsdk

[PATCH 5/5] tests/qtest/cmsdk-apb-watchdog-test: Test INTEN as counter enable

2024-11-15 Thread Roque Arcudia Hernandez
: Roque Arcudia Hernandez Reviewed-by: Stephen Longfield --- tests/qtest/cmsdk-apb-watchdog-test.c | 215 ++ 1 file changed, 215 insertions(+) diff --git a/tests/qtest/cmsdk-apb-watchdog-test.c b/tests/qtest/cmsdk-apb-watchdog-test.c index fe535a553c..53538f98c9 100644 --- a

[PATCH 2/5] hw/watchdog/cmsdk_apb_watchdog: Fix INTEN issues

2024-11-15 Thread Roque Arcudia Hernandez
abled, after previously being disabled. Source of the time of writing: https://developer.arm.com/documentation/ddi0479/d/apb-components/apb-watchdog/programmers-model Signed-off-by: Roque Arcudia Hernandez Reviewed-by: Stephen Longfield Reviewed-by: Joe Komlodi --- hw/watchdog/cm

[PATCH 0/5] Make WDOGCONTROL.INTEN the counter enable of the CMSDK APB Watchdog

2024-11-15 Thread Roque Arcudia Hernandez
which has a special behavior where it cannot be stopped. The MPS2 machine on the other hand uses the standard CMSDK watchdog and could expose the problems we were dealing with. Roque Arcudia Hernandez (5): hw/watchdog/cmsdk_apb_watchdog: Fix broken link hw/watchdog/cmsdk_apb_watchdog: Fix

[PATCH 4/5] tests/qtest/cmsdk-apb-watchdog-test: Don't abort on assertion failure

2024-11-15 Thread Roque Arcudia Hernandez
behavior in order to let the test finish other tests and report the ones that pass and fail: # ERROR:../tests/qtest/cmsdk-apb-watchdog-test.c:101:test_watchdog: assertion failed ... not ok 1 /arm/cmsdk-apb-watchdog/watchdog Signed-off-by: Roque Arcudia Hernandez --- tests/qtest/cmsdk-apb-watchdog

[PATCH 3/5] tests/qtest/cmsdk-apb-watchdog-test: Parameterize tests

2024-11-15 Thread Roque Arcudia Hernandez
) while still having CONFIG_CMSDK_APB_WATCHDOG and the test will fail. Due to the addition of the MPS2 machine CONFIG_MPS2 becomes also a dependency for the test compilation. Signed-off-by: Roque Arcudia Hernandez Reviewed-by: Stephen Longfield --- tests/qtest/cmsdk-apb-watchdog-test.c | 112

Re: [PATCH 3/3] tests/qtest/cmsdk-apb-watchdog-test: Test INTEN as counter enable

2024-11-15 Thread Roque Arcudia Hernandez
Thanks for pointing this out. For now I'll be adding the extra line in the version 2 of this patch. On Thu, Nov 14, 2024 at 5:01 AM Peter Maydell wrote: > > On Fri, 8 Nov 2024 at 19:10, Roque Arcudia Hernandez > wrote: > > > > The following tests focus on making sure

Re: [PATCH 2/3] tests/qtest/cmsdk-apb-watchdog-test: Parameterize tests

2024-11-15 Thread Roque Arcudia Hernandez
I'll edit the g_test_set_nonfatal_assertions in a separate patch explaining the reasoning behind it in version 2. On Thu, Nov 14, 2024 at 4:55 AM Peter Maydell wrote: > > On Fri, 8 Nov 2024 at 19:10, Roque Arcudia Hernandez > wrote: > > > > Currently the CMSDK AP

Re: [PATCH 1/3] hw/watchdog/cmsdk_apb_watchdog: Fix INTEN issues

2024-11-15 Thread Roque Arcudia Hernandez
I'll be removing the extra line in the comment and adding a new patch modifying the link in version 2. On Thu, Nov 14, 2024 at 4:53 AM Peter Maydell wrote: > > On Fri, 8 Nov 2024 at 19:10, Roque Arcudia Hernandez > wrote: > > > > Current watchdog is free running o

[PATCH 2/3] tests/qtest/cmsdk-apb-watchdog-test: Parameterize tests

2024-11-08 Thread Roque Arcudia Hernandez
) while still having CONFIG_CMSDK_APB_WATCHDOG and the test will fail. Due to the addition of the MPS2 machine CONFIG_MPS2 becomes also a dependency for the test compilation. Signed-off-by: Roque Arcudia Hernandez Reviewed-by: Stephen Longfield --- tests/qtest/cmsdk-apb-watchdog-test.c | 115

[PATCH 0/3] Make WDOGCONTROL.INTEN the counter enable of the CMSDK APB Watchdog

2024-11-08 Thread Roque Arcudia Hernandez
which has a special behavior where it cannot be stopped. The MPS2 machine on the other hand uses the standard CMSDK watchdog and could expose the problems we were dealing with. Roque Arcudia Hernandez (3): hw/watchdog/cmsdk_apb_watchdog: Fix INTEN issues tests/qtest/cmsdk-apb-watchdog

[PATCH 3/3] tests/qtest/cmsdk-apb-watchdog-test: Test INTEN as counter enable

2024-11-08 Thread Roque Arcudia Hernandez
: Roque Arcudia Hernandez Reviewed-by: Stephen Longfield --- tests/qtest/cmsdk-apb-watchdog-test.c | 214 ++ 1 file changed, 214 insertions(+) diff --git a/tests/qtest/cmsdk-apb-watchdog-test.c b/tests/qtest/cmsdk-apb-watchdog-test.c index fe535a553c..3777b7bd59 100644 --- a

[PATCH 1/3] hw/watchdog/cmsdk_apb_watchdog: Fix INTEN issues

2024-11-08 Thread Roque Arcudia Hernandez
abled, after previously being disabled. Source of the time of writing: https://developer.arm.com/documentation/ddi0479/d/apb-components/apb-watchdog/programmers-model Signed-off-by: Roque Arcudia Hernandez Reviewed-by: Stephen Longfield Reviewed-by: Joe Komlodi --- hw/watchdog/cm

[PATCH] hw/pci: Add parenthesis to PCI_BUILD_BDF macro

2024-11-01 Thread Roque Arcudia Hernandez
DF(bus, devfn) ((bus << 8) | (devfn)) | ^~~ cc1: all warnings being treated as errors Signed-off-by: Roque Arcudia Hernandez Reviewed-by: Nabih Estefan --- include/hw/pci/pci.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/include/hw/pci/

[PATCH] sysemu/os-win32.h: Windows clang-cl compiler fixes

2024-11-01 Thread Roque Arcudia Hernandez
This contains a series of small compiler fixes to enable the compilation of qemu using clang-cl. It mainly involves adding some missing header files and updating #ifdefs to handle clang-cl specific things. Signed-off-by: Erwin Jansen Signed-off-by: Roque Arcudia Hernandez --- include/qemu

[PATCH] hw/usb: Use __attribute__((packed)) vs __packed

2024-11-01 Thread Roque Arcudia Hernandez
__packed is non standard and is not present in clang-cl. __attribute__((packed)) has the same semantics. Signed-off-by: Erwin Jansen Signed-off-by: Roque Arcudia Hernandez --- include/hw/usb/dwc2-regs.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/include/hw/usb/dwc2

[PATCH] scripts/tracetool:Use posix paths in trace event generation

2024-11-01 Thread Roque Arcudia Hernandez
l use a '/' (forward) slash. Signed-off-by: Erwin Jansen Signed-off-by: Roque Arcudia Hernandez --- scripts/tracetool/__init__.py | 3 ++- scripts/tracetool/backend/ftrace.py | 5 +++-- scripts/tracetool/backend/log.py| 5 +++-- scripts/tracetool/backend/syslog.py |

Re: [PATCH v2 0/2] Fix for multi-process gdbstub breakpoints

2024-10-30 Thread Roque Arcudia Hernandez
Hello, This is the second version of the patch. I have taken into consideration the feedback from the first discussion thread. Is there anything else to do? Thanks Roque On Thu, Oct 17, 2024 at 8:37 AM Roque Arcudia Hernandez wrote: > > This patch series modifies the gdbstub to address

Re: [PATCH] hw/net: Changing log error to trace message

2024-10-30 Thread Roque Arcudia Hernandez
Hello, Is there any feedback for this patch? Thanks Roque On Mon, Oct 14, 2024 at 11:49 AM Roque Arcudia Hernandez wrote: > > From: Nabih Estefan > > Converting error to trace message to avoid spamming of message when > there is nothing to transmit. > > Signed-off-by: Na

[PATCH 1/2] ui: Allow injection of vnc display name

2024-10-17 Thread Roque Arcudia Hernandez
ned-off-by: Andrew Keesler Signed-off-by: Roque Arcudia Hernandez --- include/ui/console.h | 1 + ui/console-priv.h| 1 + ui/console.c | 8 ui/vnc.c | 8 +++- 4 files changed, 17 insertions(+), 1 deletion(-) diff --git a/include/ui/console.h b/include/ui/conso

[PATCH 0/2] Allow injection of virtio-gpu EDID name

2024-10-17 Thread Roque Arcudia Hernandez
Thanks to 72d277a7, 1ed2cb32, and others, EDID (Extended Display Identification Data) is propagated by QEMU such that a virtual display presents legitimate metadata (e.g., name, serial number, preferred resolutions, etc.) to its connected guest. This change adds the ability to specify the EDID nam

[PATCH 2/2] hw/display: Allow injection of virtio-gpu EDID name

2024-10-17 Thread Roque Arcudia Hernandez
vga,head=0,name=AAA \ -display vnc=localhost:1,id=bbb,display=vga,head=1,name=BBB \ -device virtio-vga,max_outputs=2,id=vga,edid_name=true Signed-off-by: Andrew Keesler Signed-off-by: Roque Arcudia Hernandez --- hw/display/virtio-gpu-base.c | 4 include/hw/virtio/virtio-gpu.h | 5

[PATCH v2 2/2] gdbstub: Apply breakpoints only to the relevant CPUs

2024-10-17 Thread Roque Arcudia Hernandez
entify the CPUs that should be affected by the breakpoint insertion/deletion operations based on the thread-id sent in the last 'Hg' packet. When multiprocess gdb is not used it falls back to applying the breakpoints to all cpus. Signed-off-by: Roque Arcudia Hernandez --- accel/tcg/tcg-accel-o

[PATCH v2 0/2] Fix for multi-process gdbstub breakpoints

2024-10-17 Thread Roque Arcudia Hernandez
c https:sourceware.org/git/?p=binutils-gdb.git;a=blob;f=gdb/breakpoint.c;h=17bd627f867cf3d4dc81322ed1919ba40cbb237d;hb=HEAD#l5550 The proposed fix inserts or removes a breakpoint to all the cpus sharing the same process ID as the one selected with the latest received 'Hg' packet. Roq

[PATCH v2 1/2] gdbstub: Fix wrong CPUState pointer in breakpoint functions

2024-10-17 Thread Roque Arcudia Hernandez
he GDB source code file gdb/remote.c. Functions remote_target::insert_breakpoint and remote_target::remove_breakpoint will eventually call remote_target::set_general_thread if it needs to change the process focus and not remote_target::set_continue_thread. This can be seen around a comment that says:

Re: [PATCH 2/2] gdbstub: Apply breakpoints only to the selected PID

2024-10-17 Thread Roque Arcudia Hernandez
I'm reimplementing this in a new patchset with a new function gdb_cpu_in_source_group instead of making public the PID and multiptocess functions. On Mon, Oct 7, 2024 at 3:15 AM Alex Bennée wrote: > > Roque Arcudia Hernandez writes: > > > In the context of using the remo

Re: [PATCH 1/2] gdbstub: Fix wrong CPUState pointer in breakpoint functions

2024-10-17 Thread Roque Arcudia Hernandez
I'm adding extra documentation to those fields in a new patchset. On Fri, Oct 4, 2024 at 1:46 PM Alex Bennée wrote: > > Roque Arcudia Hernandez writes: > > > In the context of using the remote gdb with multiple > > processes/inferiors (multiple cluster machine) a

Re: [PATCH 1/2] gdbstub: Fix wrong CPUState pointer in breakpoint functions

2024-10-16 Thread Roque Arcudia Hernandez
ure the remote is pointing at the right process, if > > necessary. */ > > > > Google-Bug-Id: 355027002 > > Where can we find more information on this bug ID? > I tried various query in the Google public tracker but > couldn't find anything. > (i.e. https://issuetracker.google.com/issues?q=canonicalid:355027002) > > > Signed-off-by: Roque Arcudia Hernandez > > --- > > gdbstub/gdbstub.c | 4 ++-- > > 1 file changed, 2 insertions(+), 2 deletions(-) >

[PATCH] hw/net: Changing log error to trace message

2024-10-14 Thread Roque Arcudia Hernandez
From: Nabih Estefan Converting error to trace message to avoid spamming of message when there is nothing to transmit. Signed-off-by: Nabih Estefan Signed-off-by: Roque Arcudia Hernandez --- hw/net/npcm_gmac.c | 5 ++--- hw/net/trace-events | 1 + 2 files changed, 3 insertions(+), 3

[PATCH 1/2] gdbstub: Fix wrong CPUState pointer in breakpoint functions

2024-09-06 Thread Roque Arcudia Hernandez
he GDB source code file gdb/remote.c. Functions remote_target::insert_breakpoint and remote_target::remove_breakpoint will eventually call remote_target::set_general_thread if it needs to change the process focus and not remote_target::set_continue_thread. This can be seen around a comment that says: /

[PATCH 2/2] gdbstub: Apply breakpoints only to the selected PID

2024-09-06 Thread Roque Arcudia Hernandez
rivate function gdb_get_cpu_pid to the TCG and also expose the value of gdbserver_state.multiprocess. The PID filtering will only be applicable to multiprocess gdb because the PIDs are only defined in that context. Google-Bug-Id: 355027002 Signed-off-by: Roque Arcudia Hernandez --- accel/tcg

[PATCH 0/2] Fix for multi-process gdbstub breakpoints

2024-09-06 Thread Roque Arcudia Hernandez
c https:sourceware.org/git/?p=binutils-gdb.git;a=blob;f=gdb/breakpoint.c;h=17bd627f867cf3d4dc81322ed1919ba40cbb237d;hb=HEAD#l5550 The proposed fix inserts or removes a breakpoint to all the cpus sharing the same process ID as the one selected with the latest received 'Hg' packet. Roque

Adding Implementation Defined ARM cpu registers

2023-03-06 Thread Roque Arcudia Hernandez
Hello, I'm dealing with a problem in which I need to add support for some neoverse-v2 registers defined as implementation defined in the TRM of the core. In file helper.c I can see the decision of whether or not a register is implemented is based mainly in function calls arm_feature(env, ARM_FEAT

Hard limit on 256 IRQs in qtest

2022-07-21 Thread Roque Arcudia Hernandez
Hello, To write a qtest for an SoC using ARM GICv3 as interrupt controller the qtest infrastructure is short on IRQs. File tests/qtest/libqtest.c defines: #define MAX_IRQ 256 Which is the number of elements in the array that is used to keep track of the value of the irq gpio: bool irq_leve