Re: [Qemu-devel] [PATCH 1/2 V4] e1000: add the ability to select among several specific types of e1000[e]; 82566DM emulation ; some pointers to documentations and details.

can use > bitwise-AND/OR. Copy/paste from the e1000e driver... works for it :-) Anyway, I probably won't be able to update the patch, I've already spent a lot more time on it than I should have :-/ Cordially, -- Romain Dolbeau

[Qemu-devel] [PATCH 1/2 V4] e1000: add the ability to select among several specific types of e1000[e]; 82566DM emulation ; some pointers to documentations and details.

Try to implement proper QOM some cleaning up, and (hopefully proper) E1000State versioning support Signed-off-by: Romain Dolbeau --- hw/net/e1000.c | 398 +++ hw/net/e1000_regs.h | 149 --- 2 files changed, 496 insertions

[Qemu-devel] [PATCH 0/2 V4] E1000 device selection & 82566DM support

econd patch adds the spaces around '<<' everywhere in the file, not just in the bits I added. So either with or without, the style is consistent :-) Cordially, Romain Dolbeau (2): e1000: add the ability to select among several specific types of e1000[e]; 82566DM emulati

[Qemu-devel] [PATCH 2/2 V4] spaces around '<<' everywhere

Signed-off-by: Romain Dolbeau --- hw/net/e1000.c | 18 +- 1 file changed, 9 insertions(+), 9 deletions(-) diff --git a/hw/net/e1000.c b/hw/net/e1000.c index 4d7204c..8987edd 100644 --- a/hw/net/e1000.c +++ b/hw/net/e1000.c @@ -49,7 +49,7 @@ enum { DEBUG_UNKNOWN

Re: [Qemu-devel] [PATCH v3] e1000: add the ability to select among several specific types of e1000[e]; 82566DM emulation ; some pointers to documentations and details.

e; the e1000e driver requires the second mapping to be the flash registers, if I understand the code correctly. > Spaces around << at least please, not sure about file's surrounding > style - Stefan's call. As before - copy/pasting from a few lines above, so the style matches the file. Cordially, -- Romain Dolbeau

[Qemu-devel] [PATCH v3] e1000: add the ability to select among several specific types of e1000[e]; 82566DM emulation ; some pointers to documentations and details.

Try to implement proper QOM Signed-off-by: Romain Dolbeau --- hw/net/e1000.c | 394 +++ hw/net/e1000_regs.h | 149 --- 2 files changed, 492 insertions(+), 51 deletions(-) diff --git a/hw/net/e1000.c b/hw/net/e1000.c index

[Qemu-devel] [PATCH v2 1/1] e1000: add the ability to select among several specific types of e1000[e]; 82566DM emulation ; some pointers to documentations and details.

Signed-off-by: Romain Dolbeau --- hw/net/e1000.c | 395 ++- hw/net/e1000_regs.h | 149 --- 2 files changed, 489 insertions(+), 55 deletions(-) diff --git a/hw/net/e1000.c b/hw/net/e1000.c index 8387443..c77786d 100644 --- a

[Qemu-devel] [PATCH v2 0/1] e1000: add the ability to select among several specific

checkpatch.pl). --- Cordially, Romain Dolbeau [1] See <http://www.contrib.andrew.cmu.edu/~somlo/OSXKVM/> for details -- Romain Dolbeau

Re: [Qemu-devel] [PATCH] e1000: add the ability to select among several specific types of e1000, plus some pointers to documentations and details.

2014-02-25 9:58 GMT+01:00 Romain Dolbeau : > 2014-02-25 9:01 GMT+01:00 Andreas Färber : > > > @@ -1572,6 +1572,9 @@ static const char * const pci_nic_models[] = { >> > @@ -1584,6 +1587,9 @@ static const char * const pci_nic_names[] = { >> >> I would hope that ad

Re: [Qemu-devel] [PATCH] e1000: add the ability to select among several specific types of e1000, plus some pointers to documentations and details.

ok inspiration from eepro100.c, and it has 3 devices in there (i82551, i82557b, i82559er). And the model is handled by -device, as my example shows: # "-netdev user,id=mynet0 -device 82545EM,netdev=mynet0" # Cordially, -- Romain Dolbeau

[Qemu-devel] [PATCH] e1000: add the ability to select among several specific types of e1000, plus some pointers to documentations and details.

nding lines (minus the tabs, another source of error in checkpatch.pl). No maintainer CC:, because I couldn't find a maintainer for hw/net/e1000 or hw/net/*. Cordially, Romain Dolbeau [1] See <http://www.contrib.andrew.cmu.edu/~somlo/OSXKVM/> for detai