A few of the vDSO VM_ALWAYSDUMP cases have a comment about the core dump.
(It looks like they were all copied from my original comment in
arch/x86/vdso/vdso32-setup.c.) So those should be removed where they are.
(You removed some of them, but not all.) You should put that comment into
always_dump
> well, sure, we can provide an arch interface, for this check. I'm more
> concerned with the general idea. If it seems ok, I can re-do this bit
> with an arch interface.
Anything based on strcmp is dismal. VM_ALWAYSDUMP was nice and clean.
A hook along the lines of arch_vma_name would be clean e
On Wed, Mar 7, 2012 at 9:00 AM, Jason Baron wrote:
> + if (vma_name) {
> + if ((strcmp(vma_name, "[vdso]") == 0) ||
> + (strcmp(vma_name, "[vectors]") == 0) ||
> + (strcmp(vma_name, "[vsyscall]") == 0))
That's just disgusting.
