Hi Michael
On Mon, 4 Nov 2024 at 14:46, Michael S. Tsirkin wrote:
>
> On Tue, Sep 24, 2024 at 01:24:12PM +, Ricardo Ribalda wrote:
> > Signed-off-by: Ricardo Ribalda
>
>
> two things wrong here:
> 1. you do not describe what changed in the ASL in the commit
Signed-off-by: Ricardo Ribalda
---
tests/qtest/bios-tables-test-allowed-diff.h | 15 +++
1 file changed, 15 insertions(+)
diff --git a/tests/qtest/bios-tables-test-allowed-diff.h
b/tests/qtest/bios-tables-test-allowed-diff.h
index dfb8523c8b..f81f4e2469 100644
--- a/tests/qtest
Signed-off-by: Ricardo Ribalda
---
tests/data/acpi/x86/pc/DSDT | Bin 8527 -> 8526 bytes
tests/data/acpi/x86/pc/DSDT.acpierst| Bin 8438 -> 8437 bytes
tests/data/acpi/x86/pc/DSDT.acpihmat| Bin 9852 -> 9851 bytes
tests/data/acpi/x86/pc/DSDT.bridge
etter):
12c12
< * Length 0x3917 (14615)
---
> * Length 0x3914 (14612)
14c14
< * Checksum 0xD9
---
> * Checksum 0x09
Diff v1:
- Add assert(), Thanks Igor
Ricardo Ribalda (3):
tests/acpi: pc: allow DSDT acpi table changes
h
Mammedov
Reported-by: Mark Cave-Ayland
Fixes: 99cb2c6c7b ("hw/i386/acpi-build: Return a pre-computed _PRT table")
Closes:
https://lore.kernel.org/all/eb11c984-ebe4-4a09-9d71-1e9db7fe7...@ilande.co.uk/
Signed-off-by: Ricardo Ribalda
---
hw/i386/acpi-build.c | 3 ++-
1 file changed, 2 insert
Signed-off-by: Ricardo Ribalda
---
tests/data/acpi/x86/pc/DSDT | Bin 8527 -> 8526 bytes
tests/data/acpi/x86/pc/DSDT.acpierst| Bin 8438 -> 8437 bytes
tests/data/acpi/x86/pc/DSDT.acpihmat| Bin 9852 -> 9851 bytes
tests/data/acpi/x86/pc/DSDT.bridge
-Ayland
Fixes: 99cb2c6c7b ("hw/i386/acpi-build: Return a pre-computed _PRT table")
Closes:
https://lore.kernel.org/all/eb11c984-ebe4-4a09-9d71-1e9db7fe7...@ilande.co.uk/
Signed-off-by: Ricardo Ribalda
---
hw/i386/acpi-build.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff
Signed-off-by: Ricardo Ribalda
---
tests/qtest/bios-tables-test-allowed-diff.h | 15 +++
1 file changed, 15 insertions(+)
diff --git a/tests/qtest/bios-tables-test-allowed-diff.h
b/tests/qtest/bios-tables-test-allowed-diff.h
index dfb8523c8b..f81f4e2469 100644
--- a/tests/qtest
etter):
12c12
< * Length 0x3917 (14615)
---
> * Length 0x3914 (14612)
14c14
< * Checksum 0xD9
---
> * Checksum 0x09
Ricardo Ribalda (3):
tests/acpi: pc: allow DSDT acpi table changes
hw/i386/acpi-build: return a non-var
Hi Mark
On Sun, 22 Sept 2024 at 13:57, Mark Cave-Ayland
wrote:
>
> On 21/08/2024 15:45, Igor Mammedov wrote:
>
> > On Wed, 14 Aug 2024 11:56:08 +0000
> > Ricardo Ribalda wrote:
> >
> >> Today for x86 the _PRT() table is computed in runtime.
> >>
tic
Changelog v3->v4 Thanks Igor:
- Add missing files to tests/qtest/bios-tables-test-allowed-diff.h
Changelog v2->v3 Thanks Michael:
- Code style
- Add cover letter
Ricardo Ribalda (3):
tests/acpi: pc: allow DSDT acpi table changes
hw/i386/acpi-build: Return a pre-computed _PRT tabl
LNKS,
Zero
},
Context:
https://lore.kernel.org/virtualization/20240417145544.38d7b...@imammedo.users.ipa.redhat.com/T/#t
Signed-off-by: Ricardo Ribalda
Reviewed-by: Igor Mammedov
Reviewed-by: Richard Henderson
---
hw/i38
Signed-off-by: Ricardo Ribalda
---
tests/data/acpi/x86/pc/DSDT | Bin 6830 -> 8527 bytes
tests/data/acpi/x86/pc/DSDT.acpierst| Bin 6741 -> 8438 bytes
tests/data/acpi/x86/pc/DSDT.acpihmat| Bin 8155 -> 9852 bytes
tests/data/acpi/x86/pc/DSDT.bridge
Signed-off-by: Ricardo Ribalda
---
tests/qtest/bios-tables-test-allowed-diff.h | 15 +++
1 file changed, 15 insertions(+)
diff --git a/tests/qtest/bios-tables-test-allowed-diff.h
b/tests/qtest/bios-tables-test-allowed-diff.h
index dfb8523c8b..f81f4e2469 100644
--- a/tests/qtest
Signed-off-by: Ricardo Ribalda
---
tests/data/acpi/x86/pc/DSDT | Bin 6830 -> 8527 bytes
tests/data/acpi/x86/pc/DSDT.acpierst| Bin 6741 -> 8438 bytes
tests/data/acpi/x86/pc/DSDT.acpihmat| Bin 8155 -> 9852 bytes
tests/data/acpi/x86/pc/DSDT.bridge
Signed-off-by: Ricardo Ribalda
---
tests/qtest/bios-tables-test-allowed-diff.h | 15 +++
1 file changed, 15 insertions(+)
diff --git a/tests/qtest/bios-tables-test-allowed-diff.h
b/tests/qtest/bios-tables-test-allowed-diff.h
index dfb8523c8b..f81f4e2469 100644
--- a/tests/qtest
LNKS,
Zero
},
Context:
https://lore.kernel.org/virtualization/20240417145544.38d7b...@imammedo.users.ipa.redhat.com/T/#t
Reviewed-by: Igor Mammedov
Signed-off-by: Ricardo Ribalda
---
hw/i386/acpi-build.c | 120 --
sts/qtest/bios-tables-test-allowed-diff.h
Changelog v2->v3 Thanks Michael:
- Code style
- Add cover letter
Ricardo Ribalda (3):
tests/acpi: pc: allow DSDT acpi table changes
hw/i386/acpi-build: Return a pre-computed _PRT table
tests/acpi: pc: update golden masters for DSDT
hw/i386/acpi-b
Hi Igor
On Fri, 28 Jun 2024 at 13:25, Igor Mammedov wrote:
>
> On Fri, 7 Jun 2024 14:17:24 +0000
> Ricardo Ribalda wrote:
>
> > Signed-off-by: Ricardo Ribalda
> > ---
> > tests/qtest/bios-tables-test-allowed-diff.h | 1 +
> > 1 file changed, 1 insertion
Ricardo Ribalda (3):
tests/acpi: pc: allow DSDT acpi table changes
hw/i386/acpi-build: Return a pre-computed _PRT table
tests/acpi: pc: update golden masters for DSDT
hw/i386/acpi-build.c | 120 ++-
tests/data/acpi/pc/DSDT | Bin 6830 -> 8
Signed-off-by: Ricardo Ribalda
---
tests/qtest/bios-tables-test-allowed-diff.h | 1 +
1 file changed, 1 insertion(+)
diff --git a/tests/qtest/bios-tables-test-allowed-diff.h
b/tests/qtest/bios-tables-test-allowed-diff.h
index dfb8523c8b..b2c2c10cbc 100644
--- a/tests/qtest/bios-tables-test
Return (0x09)
}
Return (0x0B)
}
Method (IQCR, 1, Serialized)
{
Name (PRR0, ResourceTemplate ()
**
Signed-off-by: Ricardo Ribalda
---
tests/data/acpi/pc/DSDT | Bin 6830 -> 8527 bytes
tests/data/a
LNKS,
Zero
},
Context:
https://lore.kernel.org/virtualization/20240417145544.38d7b...@imammedo.users.ipa.redhat.com/T/#t
Signed-off-by: Ricardo Ribalda
---
hw/i386/acpi-build.c | 120 ---
1 file ch
LNKS,
Zero
},
Context:
https://lore.kernel.org/virtualization/20240417145544.38d7b...@imammedo.users.ipa.redhat.com/T/#t
Signed-off-by: Ricardo Ribalda
---
hw/i386/acpi-build.c | 118 ---
1 file ch
Signed-off-by: Ricardo Ribalda
---
tests/qtest/bios-tables-test-allowed-diff.h | 1 +
1 file changed, 1 insertion(+)
diff --git a/tests/qtest/bios-tables-test-allowed-diff.h
b/tests/qtest/bios-tables-test-allowed-diff.h
index dfb8523c8b..b2c2c10cbc 100644
--- a/tests/qtest/bios-tables-test
Method (IQST, 1, NotSerialized)
{
If ((0x80 & Arg0))
{
Return (0x09)
}
Return (0x0B)
}
Method (IQCR, 1, Serialized)
{
Name (PRR0, ResourceTemplate ()
**
Signed-off-by: Ricardo
Friendly ping
On Wed, 17 Apr 2024 at 15:56, Ricardo Ribalda wrote:
>
> When qemu runs without kvm acceleration the ACPI executions take a great
> amount of time. If they take more than the default time (30sec), the
> ACPI calls fail and the system might not behave correctly.
>
LNKS,
Zero
},
Context:
https://lore.kernel.org/virtualization/20240417145544.38d7b...@imammedo.users.ipa.redhat.com/T/#t
Signed-off-by: Ricardo Ribalda
---
hw/i386/acpi-build.c | 118 ---
1 file ch
nsn group.
>
> Reported-by: Ricardo Ribalda Delgado
> Signed-off-by: Richard Henderson
> ---
> target/i386/translate.c | 25 -
> 1 file changed, 8 insertions(+), 17 deletions(-)
>
> diff --git a/target/i386/translate.c b/target/i386/translate.c
> i
. (Google
is not my friend today)
I might work on implementing some of those and I do not want to step
into anyones foot, or redo work.
Thanks!
--
Ricardo Ribalda
out, "blsfill %ld (0x%lx)\n",ret, ret);
ret = test_blsic(op1);
fprintf(stdout, "blsic %ld (0x%lx)\n",ret, ret);
ret = test_t1mskc(op1);
fprintf(stdout, "t1mskc %ld (0x%lx)\n",ret, ret);
ret = test_tzmsk(op1);
fprintf(stdout, "tzmsk %ld (0x%lx)\n",ret, ret);
uot;blmsk %ld (0x%lx)\n",ret, ret);
ret = test_andn(op1,op2);
fprintf(stdout, "andn %ld (0x%lx)\n",ret, ret);
ret = test_tzcnt(op1);
fprintf(stdout, "tzcnt %ld (0x%lx)\n",ret, ret);
ret = test_bextr(op1, op2, op3);
fprintf(stdout, "bextr %ld (0x%lx)\n",ret, ret);
retq
93a: 66 0f 1f 44 00 00 nopw 0x0(%rax,%rax,1)
The test showed than -mbmi version behaved differently than the
-march native version.
Signed-off-by: Ricardo Ribalda Delgado
---
target/i386/translate.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/target/
time, unify the setup of eflags for the insn group.
>
> Reported-by: Ricardo Ribalda Delgado
> Signed-off-by: Richard Henderson
> ---
> target/i386/translate.c | 26 +-
> 1 file changed, 9 insertions(+), 17 deletions(-)
>
> diff --git a/ta
nown_op;
}
+gen_op_update2_cc();
+set_cc_op(s, CC_OP_BMILGB + ot);
break;
default:
On Wed, Jul 12, 2017 at 9:12 PM, Richard Henderson wrote:
> On 07/12/2017 08:58 AM, Ricardo Ribalda Delgado wrote:
>>
>> Hi Rich
eflags for the insn group.
>
> Reported-by: Ricardo Ribalda Delgado
> Signed-off-by: Richard Henderson
> ---
> target/i386/translate.c | 25 -
> 1 file changed, 8 insertions(+), 17 deletions(-)
>
> diff --git a/target/i386/translate.c b/target/i3
n a host that does not support TBM, so the extension is
> being used. A browse through exactly one of these used only bextr. Running
> the same tests with dejagnu using qemu-x86_64 -cpu qemu64,+tbm shows zero
> failures.
>
>
> r~
--
Ricardo Ribalda
A)
+ goto unknown_op;
+b = 0x138;
+s->vex_v = (~vex3 >> 3) & 0xf;
+s->vex_l = (vex3 >> 2) & 1;
+prefixes |= pp_prefix[vex3 & 3] | PREFIX_XOP;
+}
+fprintf(stderr, "XOP end!\n");
+break;
}
/* Post-pr
hat should support bmi1
(https://en.wikipedia.org/wiki/Bit_Manipulation_Instruction_Sets#BMI1)
What am I doing wrong?
Thanks!
cc: Richard Henderson and Blue Swril, that Implemented BEXTR
--
Ricardo Ribalda
in
> independent of the rest of the patch (no knowledge about the 16550A to
> know if it should be 16 or 32).
Fixed using qemu_chr_can_read(). Thanks for your help!
>
> Later, Juan.
>
Hope this time the patch is better.
Regards
--
Ricardo Ribalda
http://www.eps.uam.es/~rribalda/
From: Ricardo Ribalda Delgado
New char device emulating an Elo serial touchpad.
v2: -Emulate id packages (linux recognizes the hw)
-Limit output to 96-4000 (thanks to Dmitry Zhurikhin)
v3: -Output buffer (thanks to Juan Quintela)
-Code Style
---
Makefile.objs |2 +-
hw/elo.c
ok
> Why does the lenght of the FIFO changes here? I think this change in
> independent of the rest of the patch (no knowledge about the 16550A to
> know if it should be 16 or 32).
I have to send a 2x10 bytes package, and it does not fit the the 16
bytes buffer Any other suggestion about how to do it?
>
> Later, Juan.
>
Thanks again for your comments
--
Ricardo Ribalda
http://www.eps.uam.es/~rribalda/
tion. But I don't know a clean way to get the screen resolution.
>> Any help will be very wellcomed
>
> Are you sure? I don't see how real hardware would be able to do that.
>
> Paul
>
--
Ricardo Ribalda
http://www.eps.uam.es/~rribalda/
+= qdev.o qdev-properties.o
common-obj-y += qemu-config.o block-migration.o
diff --git a/hw/elo.c b/hw/elo.c
new file mode 100644
index 000..359333d
--- /dev/null
+++ b/hw/elo.c
@@ -0,0 +1,153 @@
+/*
+ * QEMU ELO Touchpad via serial port
+ *
+ * Copyright (c) 2010 Ricardo Ribalda: QTechnology
From: Ricardo Ribalda Delgado
New char device emulating an Elo serial touchpad.
TODO: The output of the touchpad should be in the range of the
resolution. But I don't know a clean way to get the screen resolution.
Any help will be very wellcomed
---
Please, be nice it is my first patch t
-0,0 +1,95 @@
+/*
+ * QEMU ELO Touchpad via serial port
+ *
+ * Copyright (c) 2010 Ricardo Ribalda: QTechnology http://qtec.com
+ *
+ * Permission is hereby granted, free of charge, to any person obtaining a copy
+ * of this software and associated documentation files (the "Software"), to
46 matches
Mail list logo