Re: [PATCH v2 2/2] bcm2835_dma: Re-initialize xlen in TD mode

2020-02-03 Thread Rene Stange
: > On 2/3/20 4:40 PM, Rene Stange wrote: > > TD (two dimensions) DMA mode did not work, because the xlen variable > > has not been re-initialized before each additional ylen run through > > in bcm2835_dma_update(), which has been fixed. > > "which has been fixed&q

[PATCH v2 2/2] bcm2835_dma: Re-initialize xlen in TD mode

2020-02-03 Thread Rene Stange
TD (two dimensions) DMA mode did not work, because the xlen variable has not been re-initialized before each additional ylen run through in bcm2835_dma_update(), which has been fixed. Signed-off-by: Rene Stange --- hw/dma/bcm2835_dma.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion

[PATCH v2 0/2] bcm2835_dma: Fix TD mode

2020-02-03 Thread Rene Stange
Hi Philippe, this v2 patch splits the initial fix into two commits as suggested. Regards, Rene Rene Stange (2): bcm2835_dma: Fix the ylen loop in TD mode bcm2835_dma: Re-initialize xlen in TD mode hw/dma/bcm2835_dma.c | 8 +--- 1 file changed, 5 insertions(+), 3 deletions

[PATCH v2 1/2] bcm2835_dma: Fix the ylen loop in TD mode

2020-02-03 Thread Rene Stange
passed at all for a value of zero. Signed-off-by: Rene Stange --- hw/dma/bcm2835_dma.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/hw/dma/bcm2835_dma.c b/hw/dma/bcm2835_dma.c index 1e458d7fba..667d951a6f 100644 --- a/hw/dma/bcm2835_dma.c +++ b/hw/dma/bcm2835_dma.c @@ -70,14

Re: [PATCH] bcm2835_dma: Fix TD mode

2020-01-27 Thread Rene Stange
quot;s/bOK = m_USBHCI/\/\/bOK = m_USBHCI/" kernel.cpp make qemu-system-aarch64 -M raspi3 -kernel kernel8.img On Monday, 27 January 2020, 09:29:59 CET, Philippe Mathieu-Daudé wrote: > Hi Rene, > > On 1/24/20 6:55 PM, Rene Stange wrote: > > TD (two dimensions) DMA mode did not work,

[PATCH] bcm2835_dma: Fix TD mode

2020-01-24 Thread Rene Stange
run through of the ylen loop. Both issues have been fixed. Signed-off-by: Rene Stange --- hw/dma/bcm2835_dma.c | 9 + 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/hw/dma/bcm2835_dma.c b/hw/dma/bcm2835_dma.c index 1e458d7fba..0881c9506e 100644 --- a/hw/dma/bcm2835_dma.c