[Qemu-devel] About TCG_AREG0

2016-08-25 Thread Ren Kimura
Hi. I have a question about TCG_AREG0 register. TCG_AREG0 register is used to point CPUArchState *env. Is is correct? When host architecture is x64, all memory operations to 0x**(r14) that actually qemu execute equivalent to access to env->register? Thanks Ren

[Qemu-devel] What should qemu do when ACPI's OST event happen.

2016-06-04 Thread Ren Kimura
When user add new DIMM to memory slot by using qemu hotplug function, under ACPI mode, SCI interrupt will happen and then guest OS may issue _OST event 0x01. Is it correct? And in such moment, what should QEMU do? (i.e. What does the comment "/* TODO: handle device insert OST event */" in acpi_memo

[Qemu-devel] [PATCH v5] qemu-img: check block status of backing file when converting.

2016-04-27 Thread Ren Kimura
When converting images, check the block status of its backing file chain to avoid needlessly reading zeros. Signed-off-by: Ren Kimura --- qemu-img.c | 15 +-- 1 file changed, 13 insertions(+), 2 deletions(-) diff --git a/qemu-img.c b/qemu-img.c index 1697762..cb72f14 100644 --- a

Re: [Qemu-devel] [PATCH v4 1/1] qemu-img: check block status of backing file when converting.

2016-04-27 Thread Ren Kimura
Aha. I realized what bdrv_get_block_status_above(bs, NULL...) meant. Sorry for many times resendings. I'll fix it next time then. Ren

[Qemu-devel] [PATCH v4 0/1] qemu-img: check block status of backing file when converting.

2016-04-22 Thread Ren Kimura
I've just changed last patch to new one that uses loop iteration instead of recursion. https://lists.gnu.org/archive/html/qemu-block/2016-04/msg00584.html At first, a head of chain has checked it's status by bdrv_get_block_status in "convert_iteration_sectors". If this status is not BDRV_BLOCK_D

[Qemu-devel] [PATCH v4 1/1] qemu-img: check block status of backing file when converting.

2016-04-22 Thread Ren Kimura
When converting images, check the block status of its backing file chain to avoid needlessly reading zeros. Signed-off-by: Ren Kimura --- qemu-img.c | 31 +-- 1 file changed, 29 insertions(+), 2 deletions(-) diff --git a/qemu-img.c b/qemu-img.c index 06264d9

Re: [Qemu-devel] [PATCH v3] qemu-img: check block status of backing file when converting.

2016-04-20 Thread Ren Kimura
ping

[Qemu-devel] [PATCH v3] qemu-img: check block status of backing file when converting.

2016-04-16 Thread Ren Kimura
When converting images, check the block status of its backing file chain to avoid needlessly reading zeros. Signed-off-by: Ren Kimura --- qemu-img.c | 27 +-- 1 file changed, 25 insertions(+), 2 deletions(-) diff --git a/qemu-img.c b/qemu-img.c index 06264d9..ad1df5f

Re: [Qemu-devel] [PATCH v2] qemu-img: check block status of backing file when converting.

2016-04-16 Thread Ren Kimura
> So the correct way to test this would be: > if (!(ret & BDRV_BLOCK_DATA) && !(ret & BDRV_BLOCK_ZERO)) > Or, shorter: > if (!(ret & (BDRV_BLOCK_DATA | BDRV_BLOCK_ZERO))) Oops! It's very trivial mistake. I'll fix it. > I originally said (in my reply to v1) that we may not fall through to > the ba

[Qemu-devel] [PATCH v2] qemu-img: check block status of backing file when converting.

2016-04-14 Thread Ren Kimura
When converting images, check the block status of its backing file chain to avoid needlessly reading zeros. Signed-off-by: Ren Kimura --- qemu-img.c | 27 +-- 1 file changed, 25 insertions(+), 2 deletions(-) diff --git a/qemu-img.c b/qemu-img.c index 06264d9..6330f2a

Re: [Qemu-devel] [Qemu-block] [PATCH 1/1] qemu-img: check block status of backing file when converting.

2016-04-14 Thread Ren Kimura
Max Thank you for reviewing. OK. I'll fix these and send version 2 later. Thanks

[Qemu-devel] [PATCH 1/1] qemu-img: check block status of backing file when converting.

2016-04-13 Thread Ren Kimura
Signed-off-by: Ren Kimura --- qemu-img.c | 27 --- 1 file changed, 24 insertions(+), 3 deletions(-) diff --git a/qemu-img.c b/qemu-img.c index 06264d9..53471a1 100644 --- a/qemu-img.c +++ b/qemu-img.c @@ -1451,6 +1451,21 @@ static void convert_select_part(ImgConvertState

[Qemu-devel] [PATCH 0/1] qemu-img: check block status of backing file when converting.

2016-04-13 Thread Ren Kimura
When converting images, check the block status of it's backing file chain to avoid needlessly reading zeros.

[Qemu-devel] [PATCH v3 1/1] ui/console: add escape sequence \e[5, 6n

2016-03-08 Thread Ren Kimura
Add support of escape sequence "\e[5n" and "\e[6n" to console. "\e[5n" reports status of console and it always succeed in virtual console. "\e[6n" reports now cursor position in console. Signed-off-by: Ren Kimura --- ui/console.c | 56 +++

[Qemu-devel] [PATCH v3 0/1] ui/console: add escape sequence \e[5, 6n

2016-03-08 Thread Ren Kimura
I've moved code block to a new function console_put_one. If console_putchar will be called directly from console_respond_str, it cause some problems. For example "\e[0n" should be printed entirely, but on the other hand, almost same escape sequence(i.e. in same switch statement) "\e[5n" should

Re: [Qemu-devel] [PATCH v2] ui/console: add escape sequence \e[5, 6n

2016-03-08 Thread Ren Kimura
Thank you for review. OK I'll change these and send version3 later. Ren 2016-03-08 18:40 GMT+09:00 Gerd Hoffmann : > > +static void console_respond_str(QemuConsole *s, const char *buf) > > +{ > > +TextCell *c; > > +int y1; > > +while (*buf) { > > > +if (s->x >= s->width) { >

[Qemu-devel] [PATCH v2] ui/console: add escape sequence \e[5,6n

2016-03-06 Thread Ren Kimura
Add support of escape sequence "\e[5n" and "\e[6n" to console. "\e[5n" reports status of console and it always succeed in virtual console. "\e[6n" reports now cursor position in console. Signed-off-by: Ren Kimura --- ui/console.c | 35 +++

Re: [Qemu-devel] [PATCH] ui/console: add escape sequence \e[5,6n

2016-03-06 Thread Ren Kimura
Oh OK. I'll send version2 of this patch that contains comment about these. 2016-03-06 18:49 GMT+09:00 Peter Maydell : > On 5 March 2016 at 23:50, Ren Kimura wrote: > > This patch add support of escape sequence "\e[5,6n". > > This implementation similar to that of l

[Qemu-devel] [PATCH] ui/console: add escape sequence \e[5,6n

2016-03-05 Thread Ren Kimura
This patch add support of escape sequence "\e[5,6n". This implementation similar to that of linux tty driver. Signed-off-by: Ren Kimura --- ui/console.c | 32 +++- 1 file changed, 31 insertions(+), 1 deletion(-) diff --git a/ui/console.c b/ui/console.c ind

[Qemu-devel] [PATCH] ui/console: add escape sequence \e[5,6n

2016-03-05 Thread Ren Kimura
Signed-off-by: Ren Kimura --- ui/console.c | 32 +++- 1 file changed, 31 insertions(+), 1 deletion(-) diff --git a/ui/console.c b/ui/console.c index ae61382..854ec98 100644 --- a/ui/console.c +++ b/ui/console.c @@ -757,6 +757,25 @@ static void console_clear_xy