Re: [Qemu-devel] Patch to improve handling of server sockets

2010-05-05 Thread Reinhard Max
Hi, I've attached a revised version of the patch against git as of this morning. It has even more FIXMEs in it than the previous version, because of the changes that went into QEMU since 0.11.0 and I think I'll have to leave those to you guys who are more familiar with QEMUs internals than

Re: [Qemu-devel] Patch to improve handling of server sockets

2010-05-05 Thread Reinhard Max
Hi, On Wed, 5 May 2010 at 10:53, Gerd Hoffmann wrote: Noticed that it probably should get a few helper functions to handle FdLists to avoid the quite simliar open-coded loop-over-all-fds loops all over the place. indeed, thanks for the hint. I now have functions to create a new list element

Re: [Qemu-devel] Patch to improve handling of server sockets

2010-05-05 Thread Reinhard Max
On Tue, 4 May 2010 at 23:47, Gerd Hoffmann wrote: My tigervnc (tightvnc successor) has IPv6 support and handles this just fine. Well, as I wrote, the code is not just used for vnc, but also for server sockets that (if I got that right) could be connected from telnet or netcat implementations

Re: [Qemu-devel] Patch to improve handling of server sockets

2010-05-05 Thread Reinhard Max
On Tue, 4 May 2010 at 16:50, Anthony Liguori wrote: Personally, I'm inclined to agree that this is a client problem. That would be a violation of the "be liberal in what you accept and conservative in what you produce" principle and there are plenty of scenarios where even a client that Does

Re: [Qemu-devel] Patch to improve handling of server sockets

2010-05-05 Thread Reinhard Max
Hi, On Tue, 4 May 2010 at 11:23, Anthony Liguori wrote: 0.11.0 is pretty old. Please update your patch against the latest git. Ok, will do. I'm not sure we're doing the wrong thing right now. Well, I think it just can't be correct, that an IPv6-enabled process running on a dual-stack ma

[Qemu-devel] Patch to improve handling of server sockets

2010-05-04 Thread Reinhard Max
Hi, I am maintaining the tightvnc package for openSUSE and was recently confronted with an alleged vnc problem with QWMU that turned out to be a shortcoming in QEMU's code for handling TCP server sockets, which is used by the vnc and char modules. The problem occurs when the address to liste