Re: [PATCH v5 1/2] hw/pci-host/gt64120: Fix endianness handling

On Tue, Apr 29, 2025 at 10:34 PM Rakesh Jeyasingh wrote: > The GT-64120 PCI controller requires special handling where: > 1. Host bridge(bus 0 ,device 0) must never be byte-swapped > 2. Other devices follow MByteSwap bit in GT_PCI0_CMD > > The previous implementation incorrect

[PATCH v5 0/2] GT64120 PCI endianness fixes and cleanup

Changes since v4: 1.Introduced needs_bswap() helper for clean endianness logic 2.use the existing pci_host_data_le_ops.read/write from hw/pci/pci_host.c v4:https://patchew.org/QEMU/20250331184820.34673-1-rakeshjb...@gmail.com/ Rakesh Jeyasingh (2): hw/pci-host/gt64120: Fix endianness handling

[PATCH v5 2/2] hw/pci-host: Remove unused pci_host_data_be_ops

pci_host_data_be_ops became unused after endianness fixes Suggested-by: Paolo Bonzini Signed-off-by: Rakesh Jeyasingh Reviewed-by: Philippe Mathieu-Daudé --- hw/pci/pci_host.c | 6 -- include/hw/pci-host/dino.h | 4 include/hw/pci/pci_host.h | 1 - 3 files changed, 11

[PATCH v5 1/2] hw/pci-host/gt64120: Fix endianness handling

big-endian mode Fixes: 145e2198 ("hw/mips/gt64xxx_pci: Endian-swap using PCI_HOST_BRIDGE MemoryRegionOps") Resolves: https://gitlab.com/qemu-project/qemu/-/issues/2826 Signed-off-by: Rakesh Jeyasingh --- hw/pci-host/gt64120.c | 82 +-- 1 file c

[PATCH 2/2] rust/hw/char/pl011: Extract DR write logic into separate function

- Split `write()` DR case into `write_data_register()` Signed-off-by: Rakesh Jeyasingh --- rust/hw/char/pl011/src/device.rs | 14 -- 1 file changed, 8 insertions(+), 6 deletions(-) diff --git a/rust/hw/char/pl011/src/device.rs b/rust/hw/char/pl011/src/device.rs index 87153cdae1

[PATCH 0/2] pl011: Refactor DR register handling in Rust implementation

This patch series refactors the rust PL011Registers read/write for DR: Patch 1/2 extracts DR read logic Patch 2/2 extracts DR write logic Rakesh Jeyasingh (2): rust/hw/char/pl011: Extract extract DR read logic into separate function rust/hw/char/pl011: Extract DR write logic into separate

[PATCH 1/2] rust/hw/char/pl011: Extract extract DR read logic into separate function

- Split `read()` DR case into `read_data_register()` Signed-off-by: Rakesh Jeyasingh --- rust/hw/char/pl011/src/device.rs | 39 1 file changed, 20 insertions(+), 19 deletions(-) diff --git a/rust/hw/char/pl011/src/device.rs b/rust/hw/char/pl011/src/device.rs

[PATCH v4 2/2] hw/pci-host: Remove unused pci_host_data_be_ops

pci_host_data_be_ops became unused after endianness fixes Suggested-by: Paolo Bonzini Signed-off-by: Rakesh Jeyasingh Reviewed-by: Philippe Mathieu-Daudé --- hw/pci/pci_host.c | 6 -- include/hw/pci-host/dino.h | 4 include/hw/pci/pci_host.h | 1 - 3 files changed, 11

[PATCH v4 0/2] GT64120 PCI endianness fixes and cleanup

*** BLURB HERE *** Changes since v3: In [PATCH v3 1/2] hw/pci-host/gt64120: Fix endianness handling 1.Set .min_access_size = 4 in MemoryRegionOps 2.Remove the now-unnecessary bswap16 handling v3: https://mail.gnu.org/archive/html/qemu-devel/2025-03/msg06942.html Rakesh Jeyasingh (2): hw/pci

[PATCH v4 1/2] hw/pci-host/gt64120: Fix endianness handling

, bswap32 for 4-byte) per MemoryRegionOps requirements. Fixes: 145e2198 ("hw/mips/gt64xxx_pci: Endian-swap using PCI_HOST_BRIDGE MemoryRegionOps") Resolves: https://gitlab.com/qemu-project/qemu/-/issues/2826 Signed-off-by: Rakesh Jeyasingh --- hw/pci-host/gt64

[PATCH v3 2/2] hw/pci-host: Remove unused pci_host_data_be_ops

pci_host_data_be_ops became unused after endianness fixes Signed-off-by: Rakesh Jeyasingh --- hw/pci/pci_host.c | 6 -- include/hw/pci-host/dino.h | 4 include/hw/pci/pci_host.h | 1 - 3 files changed, 11 deletions(-) diff --git a/hw/pci/pci_host.c b/hw/pci/pci_host.c index

[PATCH v3 1/2] hw/pci-host/gt64120: Fix endianness handling

, bswap32 for 4-byte) per MemoryRegionOps requirements. Fixes: 145e2198 ("hw/mips/gt64xxx_pci: Endian-swap using PCI_HOST_BRIDGE MemoryRegionOps") Resolves: https://gitlab.com/qemu-project/qemu/-/issues/2826 Signed-off-by: Rakesh Jeyasingh --- hw/pci-host/gt64

[PATCH v3 0/2] GT64120 PCI endianness fixes and cleanup

v2: https://mail.gnu.org/archive/html/qemu-devel/2025-03/msg06884.html Rakesh Jeyasingh (2): hw/pci-host/gt64120: Fix endianness handling hw/pci-host: Remove unused pci_host_data_be_ops hw/pci-host/gt64120.c | 99 +- hw/pci/pci_host.c | 6