Re: [Qemu-devel] [RFC PATCH 03/20] intel_iommu: add "svm" option

2017-05-04 Thread Raj, Ashok
On Thu, May 04, 2017 at 02:28:53PM -0600, Alex Williamson wrote: > On Thu, 27 Apr 2017 18:53:17 +0800 > Peter Xu wrote: > > > On Wed, Apr 26, 2017 at 06:06:33PM +0800, Liu, Yi L wrote: > > > Expose "Shared Virtual Memory" to guest by using "svm" option. > > > Also use "svm" to expose SVM related

Re: [Qemu-devel] [RFC Design Doc v3] Enable Shared Virtual Memory feature in pass-through scenarios

2017-03-01 Thread Raj, Ashok
On Wed, Mar 01, 2017 at 04:09:38PM -0500, Konrad Rzeszutek Wilk wrote: > .snip.. > > > > No. SVM is purely about sharing CPU address space with device. Command > > submission is still through kernel driver which controls rings (with SVM > > then > > you can put VA into those commands). There are

Re: [Qemu-devel] [PATCH v4 3/3] i386: publish advised value of MSR_IA32_FEATURE_CONTROL via fw_cfg

2016-06-17 Thread Raj, Ashok
On Fri, Jun 17, 2016 at 10:48:17PM +0200, Laszlo Ersek wrote: > On 06/17/16 22:21, Raj, Ashok wrote: > > On Fri, Jun 17, 2016 at 07:31:08PM +0200, Laszlo Ersek wrote: > >>>> > >>>> On 16/06/2016 08:06, Haozhong Zhang wrote: > >>>>> It'

Re: [Qemu-devel] [PATCH v4 3/3] i386: publish advised value of MSR_IA32_FEATURE_CONTROL via fw_cfg

2016-06-17 Thread Raj, Ashok
On Fri, Jun 17, 2016 at 07:31:08PM +0200, Laszlo Ersek wrote: > >> > >> On 16/06/2016 08:06, Haozhong Zhang wrote: > >>> It's a prerequisite that certain bits of MSR_IA32_FEATURE_CONTROL should > >>> be set before some features (e.g. VMX and LMCE) can be used, which is > >>> usually done by the fir

Re: [Qemu-devel] [Patch V2 1/2] x86, mce: Basic support to add LMCE support to QEMU

2015-12-14 Thread Raj, Ashok
On Mon, Dec 14, 2015 at 11:37:16PM +0100, Borislav Petkov wrote: > On Mon, Dec 14, 2015 at 02:11:46PM -0500, Raj, Ashok wrote: > > This is mostly harmless.. since the MCG_CAP space is shared and has no > > conflict between vendors. Also just the CAP being set has no effect. > &

Re: [Qemu-devel] [Patch V2 1/2] x86, mce: Basic support to add LMCE support to QEMU

2015-12-14 Thread Raj, Ashok
On Mon, Dec 14, 2015 at 05:37:38PM +0100, Borislav Petkov wrote: > > ... and obviously LMCE is vendor-specific so it cannot be enabled on > !Intel guests with a define like that. mce_init() in qemu should check > vendor too. > > The same mistake was done with SER_P but that's much harder to chang

Re: [Qemu-devel] [Patch V2 1/2] x86, mce: Basic support to add LMCE support to QEMU

2015-12-14 Thread Raj, Ashok
Hi Eduardo, Thanks for the feedback. All the suggestions make sense.. On Mon, Dec 14, 2015 at 02:23:56PM -0200, Eduardo Habkost wrote: > > +static void feature_control_init(X86CPU *cpu) > > +{ > > + CPUX86State *cenv = &cpu->env; > > + > > + cenv->msr_ia32_feature_control = ((1<<20) | (1<<0))

Re: [Qemu-devel] [Patch V0] x86, mce: Basic support to add LMCE support to QEMU

2015-12-09 Thread Raj, Ashok
On Wed, Dec 09, 2015 at 10:07:48PM +0100, Paolo Bonzini wrote: > > > On 09/12/2015 20:57, Ashok Raj wrote: > > +/* > > + * We need to read back the value of MSREXT_MCG_CTL that was set by the > > + * guest kernel back into Qemu > > + */ > > +cs->kvm_vcpu_dirty = false; > > +