Re: [PATCH v6] block/file-posix.c: Use pwritev2() with RWF_DSYNC for FUA

Yay! 😊 On Tue, Apr 8, 2025, 8:43 a.m. Stefan Hajnoczi wrote: > On Mon, Apr 07, 2025 at 08:47:30AM -0700, Pinku Deb Nath wrote: > > Full Unit Access (FUA) is an optimization where a disk write with the > > flag set will be persisted to disk immediately instead of potentially &

[PATCH v6] block/file-posix.c: Use pwritev2() with RWF_DSYNC for FUA

cb_flush(). Signed-off-by: Pinku Deb Nath --- v5: - Use pwritev for unsupported OSes v4: - Add fallback when qemu_pwritev_fua() returns ENOSYS - Similar fallback was not added for handle_aiocb_rw_vector() since there is a preadv_present check in handle_aiocb_rw() v3: - Changed signature to add

[PATCH v5] block/file-posix.c: Use pwritev2() with RWF_DSYNC for FUA

cb_flush(). Signed-off-by: Pinku Deb Nath --- v4: - Add fallback when qemu_pwritev_fua() returns ENOSYS - Similar fallback was not added for handle_aiocb_rw_vector() since there is a preadv_present check in handle_aiocb_rw() v3: - Changed signature to add fd, iov, nr_iov - Return -ENOSYS for n

[PATCH] block/file-posix.c: Use pwritev2() with RWF_DSYNC for FUA

that the BDRV_REQ_FUA is always turned on when blk->enable_write_cache is not set in block/block-backend.c, so I commented this section off during testing: https://gitlab.com/qemu-project/qemu/-/blob/master/block/block-backend.c?ref_type=heads#L1432-1434 Signed-off-by: Pinku Deb Nath --- block/file-p

[PATCH v4] block/file-posix.c: Use pwritev2() with RWF_DSYNC for FUA

that the BDRV_REQ_FUA is always turned on when blk->enable_write_cache is not set in block/block-backend.c, so I commented this section off during testing: https://gitlab.com/qemu-project/qemu/-/blob/master/block/block-backend.c?ref_type=heads#L1432-1434 Signed-off-by: Pinku Deb Nath Update 1: The t

[PATCH v2 1/2] block/file-posix.c: Use pwritev2() with RWF_DSYNC for FUA

that the BDRV_REQ_FUA is always turned on when blk->enable_write_cache is not set in block/block-backend.c, so I commented this section off during testing: https://gitlab.com/qemu-project/qemu/-/blob/master/block/block-backend.c?ref_type=heads#L1432-1434 Signed-off-by: Pinku Deb Nath --- block/file-p

[PATCH v2 0/2] [PATCH] block/file-posix.c: Use pwritev2() with RWF_DSYNC for FUA - update

Signed-off-by: Pinku Deb Nath Pinku Deb Nath (2): block/file-posix.c: Use pwritev2() with RWF_DSYNC for FUA block/file-posix.c: Use pwritev2() with RWF_DSYNC for FUA - update block/file-posix.c | 54 +++--- 1 file changed, 42 insertions(+), 12

[PATCH v2 2/2] [PATCH] block/file-posix.c: Use pwritev2() with RWF_DSYNC for FUA - update

Signed-off-by: Pinku Deb Nath --- block/file-posix.c | 38 +- 1 file changed, 21 insertions(+), 17 deletions(-) diff --git a/block/file-posix.c b/block/file-posix.c index 34de816eab..4fffd49318 100644 --- a/block/file-posix.c +++ b/block/file-posix.c @@ -1676,1