Re: [PATCH] ui/vnc.c: Allow websocket connections over AF_UNIX sockets

2023-01-17 Thread Pierre-Yves Ritschard
Allowing websockets is fine, but just removing this check is not > sufficient > > The 'websocket=' parameter for -vnc takes two formats > >websocket=on|off > > or > >websocket=portnum > > In the case of on|off, the code takes the original VNC display > num and listens on 5700 + displa

Re: [PATCH] ui/vnc.c: Allow websocket connections over AF_UNIX sockets

2023-01-17 Thread Pierre-Yves Ritschard
> Please don't queue, this patch is not correct becasue it is failing > to validate the 'websocket' parameter at all. > > Hi, Thanks for the review! I'm happy to adapt the patch to add validation, though I am not quite sure what additional validation you would like to see occur here. Cheers, Pier

[PATCH] ui/vnc.c: Allow websocket connections over AF_UNIX sockets

2022-12-02 Thread Pierre-Yves Ritschard
Hi, The provided patch allows the VNC websocket server of a qemu process to be provided over AF_UNIX as it is already possible for standard TCP VNC servers. Now that many clients support websocket connections, some exclusively, it can be useful to expose the VNC server. One such case is when a pr