Re: [PATCH v3] util: use RETRY_ON_EINTR() on open() more consistently

2024-08-02 Thread Philipp Reisner
qemu is okay but not necessary. I will no further pursuit the inclusion of this patch. Sorry for the noise. Best regards, Philipp On Thu, Aug 1, 2024 at 2:48 PM Philippe Mathieu-Daudé wrote: > > Hi Philipp, > > On 31/7/24 17:17, Philipp Reisner wrote: > > As with many sysc

Re: [PATCH] util: retry open() when it gets interrupted by a signal

2024-07-31 Thread Philipp Reisner
Hi Daniel, > > > > The experienced logfile entry is: > > > > > > > > qemu-system-x86_64: -device > > > > virtio-blk-pci,bus=pci.0,addr=0x7,drive=libvirt-2-format,id=virtio-disk0,bootindex=2,write-cache=on,serial=1b990c4d13b74a4e90ea: > > > > Could not open '/dev/drbd1003': Interrupted system cal

[PATCH] util: use RETRY_ON_EINTR() on open() more consistently

2024-07-31 Thread Philipp Reisner
exec() and remove it on call-sites using qemu_open_old(). Signed-off-by: Philipp Reisner --- chardev/char-fd.c | 2 +- chardev/char-pipe.c | 4 ++-- os-posix.c | 2 +- util/osdep.c| 4 ++-- 4 files changed, 6 insertions(+), 6 deletions(-) diff --git a/chardev/char-fd.c b/ch

[PATCH] util: retry open() when it gets interrupted by a signal

2024-07-31 Thread Philipp Reisner
d1003': Interrupted system call Retry it until it is not interrupted by a signal. FYI, dd has the same kind of loop aroud open(). https://github.com/coreutils/coreutils/blob/1ae98dbda7322427e8226356fd110d2553f5fac9/src/dd.c#L1294-L1299 Signed-off-by: Philipp Reisner --- util/osdep.c | 4 ++-- 1 file

[PATCH] util: retry open() when it gets interrupted by a signal

2024-07-31 Thread Philipp Reisner
d1003': Interrupted system call Retry it until it is not interrupted by a signal. FYI, dd has the same kind of loop aroud open(). https://github.com/coreutils/coreutils/blob/1ae98dbda7322427e8226356fd110d2553f5fac9/src/dd.c#L1294-L1299 Signed-off-by: Philipp Reisner --- util/osdep.c | 13 ---