Re: [PATCH v2] s390x/css: revert SCSW ctrl/flag bits on error

2022-10-31 Thread Peter Jin
On 10/28/22 4:22 PM, Eric Farman wrote: On Thu, 2022-10-27 at 23:23 +0200, Peter Jin wrote: Revert the control and flag bits in the subchannel status word in case the SSCH operation fails with non-zero CC (ditto for CSCH and HSCH). According to POPS, the control and flag bits are only changed if

Re: [PATCH v2] s390x/css: revert SCSW ctrl/flag bits on error

2022-10-28 Thread Peter Jin
On 10/28/22 16:22, Eric Farman wrote: On Thu, 2022-10-27 at 23:23 +0200, Peter Jin wrote: Revert the control and flag bits in the subchannel status word in case the SSCH operation fails with non-zero CC (ditto for CSCH and HSCH). According to POPS, the control and flag bits are only changed

[PATCH v2] s390x/css: revert SCSW ctrl/flag bits on error

2022-10-27 Thread Peter Jin
place. Signed-off-by: Peter Jin --- hw/s390x/css.c | 51 +++--- 1 file changed, 48 insertions(+), 3 deletions(-) diff --git a/hw/s390x/css.c b/hw/s390x/css.c index 7d9523f811..95d1b3a3ce 100644 --- a/hw/s390x/css.c +++ b/hw/s390x/css.c @@ -1522,21

[PATCH] s390x/css: revert SCSW ctrl/flag bits on error

2022-10-27 Thread Peter Jin
simulate that after the fact, the bits need to be reverted on non-zero CC. Signed-off-by: Peter Jin --- hw/s390x/css.c | 51 +++--- 1 file changed, 48 insertions(+), 3 deletions(-) diff --git a/hw/s390x/css.c b/hw/s390x/css.c index 7d9523f811