Re: [PATCH] accel/tcg: fix msan findings in translate-all

2025-03-03 Thread Peter Foley
:23, Patrick Venture wrote: >> > From: Peter Foley >> > >> > e.g. >> >Uninitialized value was created by an allocation of 'host_pc' in the >> stack frame >> >#0 0xc07df87c in tb_gen_code >> third_party/qemu/a

Re: [PATCH] accel/tcg: fix msan findings in translate-all

2025-03-03 Thread Peter Foley
://gitlab.com/qemu-project/qemu/-/blob/master/accel/tcg/translate-all.c?ref_type=heads#L362 On Mon, Mar 3, 2025 at 11:34 AM Peter Foley wrote: > For reference, the full output from msan looks like: > > ==4872==WARNING: MemorySanitizer: use-of-uninitialized-value > #0 0xc681ef98 in

Re: [PATCH] util/keyval: fix msan findings

2025-03-03 Thread Peter Foley
On Sat, Mar 1, 2025 at 2:14 AM Markus Armbruster wrote: > Paolo Bonzini writes: > > > On 2/28/25 22:20, Patrick Venture wrote: > >> From: Peter Foley > >> e.g. > >> qemu: Uninitialized value was created by an allocation of > 'key_in_cur.i'

[PATCH v3] Don't require libcap-ng for virtfs support

2023-05-03 Thread Peter Foley
It's only required for the proxy helper. Add a new option for the proxy helper rather than enabling it implicitly. Change-Id: I95b73fca625529e99d16b0a64e01c65c0c1d43f2 Signed-off-by: Peter Foley --- meson.build | 12 +--- meson_options.txt | 2 ++ sc

[PATCH v2] Don't require libcap-ng for virtfs support

2023-04-28 Thread Peter Foley
It's only required for the proxy helper. Add a new option for the proxy helper rather than enabling it implicitly. Change-Id: I95b73fca625529e99d16b0a64e01c65c0c1d43f2 Signed-off-by: Peter Foley --- meson.build | 11 --- meson_options.txt | 2 ++ sc

[PATCH] Don't require libcap-ng for virtfs support

2023-04-21 Thread Peter Foley
It's only required for the proxy helper. Signed-off-by: Peter Foley --- meson.build | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/meson.build b/meson.build index c44d05a13f..1d4888b1c0 100644 --- a/meson.build +++ b/meson.build @@ -1759,12 +1759,12 @@ have_v

Re: misaligned-pointer-use libslirp/src/tcp_input.c

2022-06-21 Thread Peter Foley
The upstream fixes in https://gitlab.freedesktop.org/slirp/libslirp/-/commit/6489ebbc691f5d97221ad154d570a231e30fb369 and https://gitlab.freedesktop.org/slirp/libslirp/-/commit/cc20d9ac578aec5502dcb26557765d3e9433cb26 resolved the failure we were seeing in our internal test-case. Thanks! On Tue, J

Re: [PATCH] net: Fix uninitialized data usage

2022-01-06 Thread Peter Foley
Yeah, but this same pattern is used elsewhere in the file, so I went with being consistent. On Thu, Jan 6, 2022, 2:44 PM Philippe Mathieu-Daudé wrote: > On 6/1/22 19:28, Patrick Venture wrote: > > From: Peter Foley > > > > e.g. > > 1109 15:16:20.151506 Uninitialize