Re: [q&a] Status of IOMMU virtualization for nested virtualization (userspace PCI drivers in VMs)

2024-02-29 Thread Peter Delevoryas
> On Feb 28, 2024, at 11:38 AM, Alex Williamson > wrote: > > On Wed, 28 Feb 2024 10:29:32 -0800 > Peter Delevoryas wrote: > >> Hey guys, >> >> I’m having a little trouble reading between the lines on various >> docs, mailing list threads, KVM

[q&a] Status of IOMMU virtualization for nested virtualization (userspace PCI drivers in VMs)

2024-02-28 Thread Peter Delevoryas
Hey guys, I’m having a little trouble reading between the lines on various docs, mailing list threads, KVM presentations, github forks, etc, so I figured I’d just ask: What is the status of IOMMU virtualization, like in the case where I want a VM guest to have a virtual IOMMU? I found this gre

Re: [PULL 4/5] contrib/gitdm: Add Facebook the domain map

2023-03-10 Thread Peter Delevoryas
ok I’ll send an update Thanks! Peter > > Signed-off-by: Alex Bennée > Cc: Iris Chen > Cc: Daniel Müller > Reviewed-by: Peter Delevoryas > Message-Id: <20221219121914.851488-9-alex.ben...@linaro.org> > > diff --git a/contrib/gitdm/domain-map b/contrib/gitdm/dom

Re: [PATCH qemu v3 2/2] aspeed/fuji : correct the eeprom size

2023-02-27 Thread Peter Delevoryas
B); > +/* > +* EEPROM 24c64 size is 64Kbits or 8 Kbytes > +*24c02 size is 2Kbits or 256 bytes > +*/ > +at24c_eeprom_init(i2c[19], 0x52, 8 * KiB); > +at24c_eeprom_init(i2c[20], 0x50, 256); > + at24c_eeprom_init(i2c[22], 0x52, 256); Perfect! L

Re: [PATCH qemu v3 1/2] hw/at24c : modify at24c to support 1 byte address mode

2023-02-27 Thread Peter Delevoryas
; > static > @@ -213,6 +234,7 @@ void at24c_eeprom_reset(DeviceState *state) > > static Property at24c_eeprom_props[] = { > DEFINE_PROP_UINT32("rom-size", EEPROMState, rsize, 0), > +DEFINE_PROP_UINT8("address-size", EEPROMState, asize, 0), > DEFINE_PROP_BOOL("writable", EEPROMState, writable, true), > DEFINE_PROP_DRIVE("drive", EEPROMState, blk), > DEFINE_PROP_END_OF_LIST() Reviewed-by: Peter Delevoryas > -- > 2.34.6 > >

Re: [PATCH qemu 1/2] hw/at24c : modify at24c to support 1 byte address mode

2023-02-15 Thread Peter Delevoryas
nge to fix behavior, we can do a refactoring like that later (If Cedric is ok with it). Reviewed-by: Peter Delevoryas > > > --- > > hw/nvram/eeprom_at24c.c | 8 +--- > > 1 file changed, 5 insertions(+), 3 deletions(-) > > > > diff --git a/hw/nvram/eep

Re: [PATCH qemu 2/2] aspeed/fuji : correct the eeprom size

2023-02-15 Thread Peter Delevoryas
dded systems) I agree with Cedric though, instead of adding "/ 8", could we just replace 64 * KiB / 8 with 8 * KiB, and 2 * KiB / 8 with 256? - Peter Reviewed-by: Peter Delevoryas > > > --- > > hw/arm/aspeed.c | 32 > > 1

Re: [PATCH 1/8] m25p80: Improve error when the backend file size does not match the device

2023-02-15 Thread Peter Delevoryas
> This is confusing for the user. > > Use blk_check_size_and_read_all() instead of blk_pread() to improve > the reported error. > > Reviewed-by: Peter Maydell > Reviewed-by: Philippe Mathieu-Daudé > Reviewed-by: Peter Delevoryas > Reviewed-by: Alistair Francis > M

[PATCH v5 0/5] hw/nvram/eeprom_at24c: Cleanup + FRUID EEPROM init example

2023-01-27 Thread Peter Delevoryas
e_new in eeprom_at24c.c - Switched back to "extern const size_t fby35_*_len" in aspeed_eeprom.h NOTE: I rebased on the latest master and tlb exec segfaults in "Starting kernel" for fby35-bmc: I'll make a bug report separately. I've kept the base on 7c9236d6d

[PATCH v5 3/5] hw/nvram/eeprom_at24c: Add init_rom field and at24c_eeprom_init_rom helper

2023-01-27 Thread Peter Delevoryas
overrides init_rom data Signed-off-by: Peter Delevoryas Reviewed-by: Joel Stanley Reviewed-by: Corey Minyard Reviewed-by: Cédric Le Goater Tested-by: Ninad Palsule --- hw/nvram/eeprom_at24c.c | 36 - include/hw/nvram/eeprom_at24c.h | 16

[PATCH v5 5/5] hw/nvram/eeprom_at24c: Make reset behavior more like hardware

2023-01-27 Thread Peter Delevoryas
EMU as well, to verify software instrumentation like determining the cause of a reboot. Fixes: 5d8424dbd3e8 ("nvram: add AT24Cx i2c eeprom") Signed-off-by: Peter Delevoryas Reviewed-by: Joel Stanley Reviewed-by: Cédric Le Goater Reviewed-by: Corey Minyard --- hw/

[PATCH v5 2/5] hw/arm/aspeed: Replace aspeed_eeprom_init with at24c_eeprom_init

2023-01-27 Thread Peter Delevoryas
aspeed_eeprom_init is an exact copy of at24c_eeprom_init, not needed. Signed-off-by: Peter Delevoryas Reviewed-by: Cédric Le Goater Reviewed-by: Philippe Mathieu-Daudé Reviewed-by: Joel Stanley Reviewed-by: Corey Minyard --- hw/arm/aspeed.c | 95

[PATCH v5 4/5] hw/arm/aspeed: Add aspeed_eeprom.c

2023-01-27 Thread Peter Delevoryas
: X Product Version : A9 Product Serial: Product Custom Data 3 : ConnectX-6 DX Signed-off-by: Peter Delevoryas Reviewed-by: Cédric Le Goater Reviewed-by: Joel Stanley Reviewed-by: Corey Minyard --- hw/arm/aspeed.c| 10

[PATCH v5 1/5] hw/arm: Extract at24c_eeprom_init helper from Aspeed and Nuvoton boards

2023-01-27 Thread Peter Delevoryas
This helper is useful in board initialization because lets users initialize and realize an EEPROM on an I2C bus with a single function call. Signed-off-by: Peter Delevoryas Reviewed-by: Cédric Le Goater Reviewed-by: Joel Stanley Reviewed-by: Corey Minyard --- hw/arm/aspeed.c

Re: [PATCH v4 3/5] hw/nvram/eeprom_at24c: Add init_rom field and at24c_eeprom_init_rom helper

2023-01-27 Thread Peter Delevoryas
On Fri, Jan 27, 2023 at 08:42:40AM +0100, Cédric Le Goater wrote: > > > > I2CSlave *at24c_eeprom_init(I2CBus *bus, uint8_t address, uint32_t > > > > rom_size) > > > > { > > > > -I2CSlave *i2c_dev = i2c_slave_new(TYPE_AT24C_EE, address); > > > > -DeviceState *dev = DEVICE(i2c_dev); > >

Re: [PATCH v4 5/5] hw/nvram/eeprom_at24c: Make reset behavior more like hardware

2023-01-25 Thread Peter Delevoryas
On Wed, Jan 25, 2023 at 03:41:30PM -0600, Corey Minyard wrote: > On Tue, Jan 17, 2023 at 06:42:14PM -0800, Peter Delevoryas wrote: > > EEPROM's are a form of non-volatile memory. After power-cycling an EEPROM, > > I would expect the I2C state machine to be reset to d

Re: [PATCH v4 3/5] hw/nvram/eeprom_at24c: Add init_rom field and at24c_eeprom_init_rom helper

2023-01-25 Thread Peter Delevoryas
On Wed, Jan 25, 2023 at 03:36:23PM -0600, Corey Minyard wrote: > On Tue, Jan 17, 2023 at 06:42:12PM -0800, Peter Delevoryas wrote: > > Allows users to specify binary data to initialize an EEPROM, allowing users > > to > > emulate data programmed at manufacturing time. >

Re: [PATCH v4 3/5] hw/nvram/eeprom_at24c: Add init_rom field and at24c_eeprom_init_rom helper

2023-01-25 Thread Peter Delevoryas
On Wed, Jan 25, 2023 at 04:53:20PM +, Ninad S Palsule wrote: > Signed-off-by: Peter Delevoryas pe...@pjd.dev<mailto:pe...@pjd.dev> > Reviewed-by: Joel Stanley j...@jms.id.au<mailto:j...@jms.id.au> > > Tested-by: Ninad Palsule > ninadpals...@us.ibm.com<mailto:ni

Re: [PATCH v4 4/5] hw/arm/aspeed: Add aspeed_eeprom.c

2023-01-18 Thread Peter Delevoryas
On Wed, Jan 18, 2023 at 11:31:57AM +0100, Cédric Le Goater wrote: > On 1/18/23 03:42, Peter Delevoryas wrote: > > - Create aspeed_eeprom.c and aspeed_eeprom.h > > - Include aspeed_eeprom.c in CONFIG_ASPEED meson source files > > - Include aspeed_eeprom.h in aspeed.c > >

[PATCH v4 2/5] hw/arm/aspeed: Replace aspeed_eeprom_init with at24c_eeprom_init

2023-01-17 Thread Peter Delevoryas
aspeed_eeprom_init is an exact copy of at24c_eeprom_init, not needed. Signed-off-by: Peter Delevoryas Reviewed-by: Cédric Le Goater Reviewed-by: Philippe Mathieu-Daudé Reviewed-by: Joel Stanley --- hw/arm/aspeed.c | 95 ++--- 1 file changed, 43

[PATCH v4 1/5] hw/arm: Extract at24c_eeprom_init helper from Aspeed and Nuvoton boards

2023-01-17 Thread Peter Delevoryas
This helper is useful in board initialization because lets users initialize and realize an EEPROM on an I2C bus with a single function call. Signed-off-by: Peter Delevoryas Reviewed-by: Cédric Le Goater Reviewed-by: Joel Stanley --- hw/arm/aspeed.c | 10 +- hw/arm

[PATCH v4 3/5] hw/nvram/eeprom_at24c: Add init_rom field and at24c_eeprom_init_rom helper

2023-01-17 Thread Peter Delevoryas
overrides init_rom data Signed-off-by: Peter Delevoryas Reviewed-by: Joel Stanley --- hw/nvram/eeprom_at24c.c | 37 - include/hw/nvram/eeprom_at24c.h | 16 ++ 2 files changed, 48 insertions(+), 5 deletions(-) diff --git a/hw/nvram

[PATCH v4 5/5] hw/nvram/eeprom_at24c: Make reset behavior more like hardware

2023-01-17 Thread Peter Delevoryas
EMU as well, to verify software instrumentation like determining the cause of a reboot. Fixes: 5d8424dbd3e8 ("nvram: add AT24Cx i2c eeprom") Signed-off-by: Peter Delevoryas Reviewed-by: Joel Stanley --- hw/nvram/eeprom_at24c.c | 22 ++ 1 file changed, 10 insertions(

[PATCH v4 4/5] hw/arm/aspeed: Add aspeed_eeprom.c

2023-01-17 Thread Peter Delevoryas
: X Product Version : A9 Product Serial: Product Custom Data 3 : ConnectX-6 DX Signed-off-by: Peter Delevoryas Reviewed-by: Cédric Le Goater Reviewed-by: Joel Stanley --- hw/arm/aspeed.c| 10 -- hw/arm/aspeed_eeprom.c

[PATCH v4 0/5] hw/nvram/eeprom_at24c: Cleanup + FRUID EEPROM init example

2023-01-17 Thread Peter Delevoryas
oard for default behavior. v4: - Moved at24c_eeprom_init_rom doc comment to the patch introducing the function (moved from patch 4/5 to patch 3/5). - Added review tags from Joel Thanks, Peter Peter Delevoryas (5): hw/arm: Extract at24c_eeprom_init helper from Aspeed a

Re: [PATCH v3 3/5] hw/nvram/eeprom_at24c: Add init_rom field and at24c_eeprom_init_rom helper

2023-01-17 Thread Peter Delevoryas
On Wed, Jan 18, 2023 at 02:22:01AM +, Joel Stanley wrote: > On Tue, 17 Jan 2023 at 23:24, Peter Delevoryas wrote: > > > > Allows users to specify binary data to initialize an EEPROM, allowing users > > to > > emulate data programmed at manufacturing time. > &

[PATCH v3 2/5] hw/arm/aspeed: Replace aspeed_eeprom_init with at24c_eeprom_init

2023-01-17 Thread Peter Delevoryas
aspeed_eeprom_init is an exact copy of at24c_eeprom_init, not needed. Signed-off-by: Peter Delevoryas Reviewed-by: Cédric Le Goater Reviewed-by: Philippe Mathieu-Daudé --- hw/arm/aspeed.c | 95 ++--- 1 file changed, 43 insertions(+), 52 deletions

[PATCH v3 4/5] hw/arm/aspeed: Add aspeed_eeprom.c

2023-01-17 Thread Peter Delevoryas
: X Product Version : A9 Product Serial: Product Custom Data 3 : ConnectX-6 DX Signed-off-by: Peter Delevoryas Reviewed-by: Cédric Le Goater --- hw/arm/aspeed.c | 10 +++-- hw/arm/aspeed_eeprom.c | 78

[PATCH v3 5/5] hw/nvram/eeprom_at24c: Make reset behavior more like hardware

2023-01-17 Thread Peter Delevoryas
EMU as well, to verify software instrumentation like determining the cause of a reboot. Fixes: 5d8424dbd3e8 ("nvram: add AT24Cx i2c eeprom") Signed-off-by: Peter Delevoryas --- hw/nvram/eeprom_at24c.c | 22 ++ 1 file changed, 10 insertions(+), 12 deletions(

[PATCH v3 3/5] hw/nvram/eeprom_at24c: Add init_rom field and at24c_eeprom_init_rom helper

2023-01-17 Thread Peter Delevoryas
overrides init_rom data Signed-off-by: Peter Delevoryas --- hw/nvram/eeprom_at24c.c | 37 - include/hw/nvram/eeprom_at24c.h | 2 ++ 2 files changed, 34 insertions(+), 5 deletions(-) diff --git a/hw/nvram/eeprom_at24c.c b/hw/nvram/eeprom_at24c.c index

[PATCH v3 0/5] hw/nvram/eeprom_at24c: Cleanup + FRUID EEPROM init example

2023-01-17 Thread Peter Delevoryas
ization code before ee->blk, so that -drive property overrides init_rom initialization. This gives more flexibility (people can override contents of an AT24C EEPROM using a file for debugging/prototyping) while still allowing the init_rom data to be specified for a boa

[PATCH v3 1/5] hw/arm: Extract at24c_eeprom_init helper from Aspeed and Nuvoton boards

2023-01-17 Thread Peter Delevoryas
This helper is useful in board initialization because lets users initialize and realize an EEPROM on an I2C bus with a single function call. Signed-off-by: Peter Delevoryas Reviewed-by: Cédric Le Goater --- hw/arm/aspeed.c | 10 +- hw/arm/npcm7xx_boards.c | 20

Re: [PATCH v2 1/5] hw/arm: Extract at24c_eeprom_init helper from Aspeed and Nuvoton boards

2023-01-17 Thread Peter Delevoryas
On Tue, Jan 17, 2023 at 10:32:15AM -0800, Peter Delevoryas wrote: > On Tue, Jan 17, 2023 at 09:00:34AM +0100, Philippe Mathieu-Daudé wrote: > > On 17/1/23 00:56, Peter Delevoryas wrote: > > > This helper is useful in board initialization because lets users > > > init

Re: [PATCH v2 4/5] hw/arm/aspeed: Add aspeed_eeprom.c

2023-01-17 Thread Peter Delevoryas
On Tue, Jan 17, 2023 at 09:08:57AM +0100, Philippe Mathieu-Daudé wrote: > On 17/1/23 08:39, Cédric Le Goater wrote: > > On 1/17/23 00:56, Peter Delevoryas wrote: > > > - Create aspeed_eeprom.c and aspeed_eeprom.h > > > - Include aspeed_eeprom.c in CONFIG_ASPEED meson s

Re: [PATCH v2 1/5] hw/arm: Extract at24c_eeprom_init helper from Aspeed and Nuvoton boards

2023-01-17 Thread Peter Delevoryas
On Tue, Jan 17, 2023 at 09:00:34AM +0100, Philippe Mathieu-Daudé wrote: > On 17/1/23 00:56, Peter Delevoryas wrote: > > This helper is useful in board initialization because lets users initialize > > and > > realize an EEPROM on an I2C bus with a single function call. &

Re: [PATCH v2 5/5] hw/nvram/eeprom_at24c: Make reset behavior more like hardware

2023-01-17 Thread Peter Delevoryas
On Tue, Jan 17, 2023 at 08:42:46AM +0100, Cédric Le Goater wrote: > On 1/17/23 00:56, Peter Delevoryas wrote: > > EEPROM's are a form of non-volatile memory. After power-cycling an EEPROM, > > I would expect the I2C state machine to be reset to default values, but I > >

Re: [PATCH v2 4/5] hw/arm/aspeed: Add aspeed_eeprom.c

2023-01-17 Thread Peter Delevoryas
On Tue, Jan 17, 2023 at 08:39:06AM +0100, Cédric Le Goater wrote: > On 1/17/23 00:56, Peter Delevoryas wrote: > > - Create aspeed_eeprom.c and aspeed_eeprom.h > > - Include aspeed_eeprom.c in CONFIG_ASPEED meson source files > > - Include aspeed_eeprom.h in aspeed.c > >

Re: [PATCH v2 3/5] hw/nvram/eeprom_at24c: Add init_rom field and at24c_eeprom_init_rom helper

2023-01-17 Thread Peter Delevoryas
On Tue, Jan 17, 2023 at 08:35:44AM +0100, Cédric Le Goater wrote: > On 1/17/23 00:56, Peter Delevoryas wrote: > > Allows users to specify binary data to initialize an EEPROM, allowing users > > to > > emulate data programmed at manufacturing time. > > > > -

Re: [PATCH 6/6] hw/arm/aspeed: Init fby35 BMC FRUID EEPROM

2023-01-17 Thread Peter Delevoryas
On Tue, Jan 17, 2023 at 07:47:06AM +0100, Philippe Mathieu-Daudé wrote: > On 16/1/23 18:23, Peter Delevoryas wrote: > > On Mon, Jan 16, 2023 at 01:30:19PM +0100, Philippe Mathieu-Daudé wrote: > > > On 14/1/23 18:01, Peter Delevoryas wrote: > > > > S

[PATCH v2 2/5] hw/arm/aspeed: Replace aspeed_eeprom_init with at24c_eeprom_init

2023-01-16 Thread Peter Delevoryas
aspeed_eeprom_init is an exact copy of at24c_eeprom_init, not needed. Signed-off-by: Peter Delevoryas Reviewed-by: Cédric Le Goater Reviewed-by: Philippe Mathieu-Daudé --- hw/arm/aspeed.c | 95 ++--- 1 file changed, 43 insertions(+), 52 deletions

[PATCH v2 4/5] hw/arm/aspeed: Add aspeed_eeprom.c

2023-01-16 Thread Peter Delevoryas
Custom Data 1 : X Product Custom Data 2 : Config A Signed-off-by: Peter Delevoryas --- hw/arm/aspeed.c| 4 +++- hw/arm/aspeed_eeprom.c | 51 ++ hw/arm/aspeed_eeprom.h | 11 + hw/arm/meson.build | 1 + 4 files changed, 66

[PATCH v2 1/5] hw/arm: Extract at24c_eeprom_init helper from Aspeed and Nuvoton boards

2023-01-16 Thread Peter Delevoryas
This helper is useful in board initialization because lets users initialize and realize an EEPROM on an I2C bus with a single function call. Signed-off-by: Peter Delevoryas --- hw/arm/aspeed.c | 10 +- hw/arm/npcm7xx_boards.c | 20 +--- hw/nvram

[PATCH v2 5/5] hw/nvram/eeprom_at24c: Make reset behavior more like hardware

2023-01-16 Thread Peter Delevoryas
EMU as well, to verify software instrumentation like determining the cause of a reboot. Fixes: 5d8424dbd3e8 ("nvram: add AT24Cx i2c eeprom") Signed-off-by: Peter Delevoryas --- hw/nvram/eeprom_at24c.c | 22 ++ 1 file changed, 10 insertions(+), 12 deletions(

[PATCH v2 3/5] hw/nvram/eeprom_at24c: Add init_rom field and at24c_eeprom_init_rom helper

2023-01-16 Thread Peter Delevoryas
Allows users to specify binary data to initialize an EEPROM, allowing users to emulate data programmed at manufacturing time. - Added init_rom and init_rom_size attributes to TYPE_AT24C_EE - Added at24c_eeprom_init_rom helper function to initialize attributes Signed-off-by: Peter Delevoryas

[PATCH v2 0/5] hw/nvram/eeprom_at24c: Cleanup + FRUID EEPROM init example

2023-01-16 Thread Peter Delevoryas
at24c-eeprom "init_rom" attribute - Added aspeed_eeprom.c and fby35-bmc BMC FRUID EEPROM initialization - Added commit to change reset behavior for at24c-eeprom (optional) The reset behavior one might be controversial, I put it last, you can drop it if you like. Thanks, Pe

Re: [PATCH 6/6] hw/arm/aspeed: Init fby35 BMC FRUID EEPROM

2023-01-16 Thread Peter Delevoryas
On Mon, Jan 16, 2023 at 01:30:19PM +0100, Philippe Mathieu-Daudé wrote: > On 14/1/23 18:01, Peter Delevoryas wrote: > > Signed-off-by: Peter Delevoryas > > --- > > hw/arm/aspeed.c | 49 + > > 1 file changed, 49 insertio

Re: [PATCH 2/6] hw/arm/aspeed: Remove local copy of at24c_eeprom_init

2023-01-16 Thread Peter Delevoryas
On Mon, Jan 16, 2023 at 01:24:36PM +0100, Philippe Mathieu-Daudé wrote: > On 14/1/23 18:01, Peter Delevoryas wrote: > > Signed-off-by: Peter Delevoryas > > --- > > hw/arm/aspeed.c | 10 +- > > 1 file changed, 1 insertion(+), 9 deletions(-) > > > -

Re: [PATCH 1/6] hw/nvram/eeprom_at24c: Add header w/ init helper

2023-01-16 Thread Peter Delevoryas
On Mon, Jan 16, 2023 at 01:23:01PM +0100, Philippe Mathieu-Daudé wrote: > On 14/1/23 18:01, Peter Delevoryas wrote: > > Signed-off-by: Peter Delevoryas > > --- > > hw/nvram/eeprom_at24c.c | 10 ++ > > include/hw/nvram/eeprom_at24c.h | 10 +

Re: [PATCH 6/6] hw/arm/aspeed: Init fby35 BMC FRUID EEPROM

2023-01-16 Thread Peter Delevoryas
On Mon, Jan 16, 2023 at 01:42:48PM +0100, Cédric Le Goater wrote: > On 1/14/23 18:01, Peter Delevoryas wrote: > > Signed-off-by: Peter Delevoryas > > --- > > hw/arm/aspeed.c | 49 + > > 1 file changed, 49 insertions(

Re: [PATCH 0/6] hw/nvram/eeprom_at24c: Cleanup + FRUID EEPROM init example

2023-01-14 Thread Peter Delevoryas
On Sat, Jan 14, 2023 at 09:01:45AM -0800, Peter Delevoryas wrote: > This cleans up some of the code we have creating at24c-eeprom objects in the > Aspeed and Nuvoton files, and adds an example of how to initialize a FRUID > EEPROM with static data using I2C transfers. > > Initially

[PATCH 3/6] hw/arm/aspeed: Replace aspeed_eeprom_init with at24c_eeprom_init

2023-01-14 Thread Peter Delevoryas
Signed-off-by: Peter Delevoryas --- hw/arm/aspeed.c | 95 ++--- 1 file changed, 43 insertions(+), 52 deletions(-) diff --git a/hw/arm/aspeed.c b/hw/arm/aspeed.c index 1f9799d4321e..c929c61d582a 100644 --- a/hw/arm/aspeed.c +++ b/hw/arm/aspeed.c

[PATCH 5/6] hw/nvram/eeprom_at24c: Add I2C write helper

2023-01-14 Thread Peter Delevoryas
Signed-off-by: Peter Delevoryas --- hw/nvram/eeprom_at24c.c | 15 +++ include/hw/nvram/eeprom_at24c.h | 2 ++ 2 files changed, 17 insertions(+) diff --git a/hw/nvram/eeprom_at24c.c b/hw/nvram/eeprom_at24c.c index 0c27eae2b354..69565a420c28 100644 --- a/hw/nvram

[PATCH 0/6] hw/nvram/eeprom_at24c: Cleanup + FRUID EEPROM init example

2023-01-14 Thread Peter Delevoryas
static data, but then I realized I could just accomplish the same thing using i2c_send in board reset. The patch at the end demonstrates this. Thanks, Peter Peter Delevoryas (6): hw/nvram/eeprom_at24c: Add header w/ init helper hw/arm/aspeed: Remove local copy of at24c_eeprom_init hw/arm

[PATCH 4/6] hw/arm/npcm7xx: Remove local copy of at24c_eeprom_init

2023-01-14 Thread Peter Delevoryas
Signed-off-by: Peter Delevoryas --- hw/arm/npcm7xx_boards.c | 20 +--- 1 file changed, 5 insertions(+), 15 deletions(-) diff --git a/hw/arm/npcm7xx_boards.c b/hw/arm/npcm7xx_boards.c index 6bc6f5d2fe29..9b31207a06e9 100644 --- a/hw/arm/npcm7xx_boards.c +++ b/hw/arm

[PATCH 2/6] hw/arm/aspeed: Remove local copy of at24c_eeprom_init

2023-01-14 Thread Peter Delevoryas
Signed-off-by: Peter Delevoryas --- hw/arm/aspeed.c | 10 +- 1 file changed, 1 insertion(+), 9 deletions(-) diff --git a/hw/arm/aspeed.c b/hw/arm/aspeed.c index 55f114ef729f..1f9799d4321e 100644 --- a/hw/arm/aspeed.c +++ b/hw/arm/aspeed.c @@ -17,6 +17,7 @@ #include "h

[PATCH 6/6] hw/arm/aspeed: Init fby35 BMC FRUID EEPROM

2023-01-14 Thread Peter Delevoryas
Signed-off-by: Peter Delevoryas --- hw/arm/aspeed.c | 49 + 1 file changed, 49 insertions(+) diff --git a/hw/arm/aspeed.c b/hw/arm/aspeed.c index c929c61d582a..4ac8ff11a835 100644 --- a/hw/arm/aspeed.c +++ b/hw/arm/aspeed.c @@ -922,6 +922,52

[PATCH 1/6] hw/nvram/eeprom_at24c: Add header w/ init helper

2023-01-14 Thread Peter Delevoryas
Signed-off-by: Peter Delevoryas --- hw/nvram/eeprom_at24c.c | 10 ++ include/hw/nvram/eeprom_at24c.h | 10 ++ 2 files changed, 20 insertions(+) create mode 100644 include/hw/nvram/eeprom_at24c.h diff --git a/hw/nvram/eeprom_at24c.c b/hw/nvram/eeprom_at24c.c index

Re: [PATCH v4 1/1] python/machine: Fix AF_UNIX path too long on macOS

2023-01-10 Thread Peter Delevoryas
On Tue, Jan 10, 2023 at 06:18:29PM -0500, John Snow wrote: > On Tue, Jan 10, 2023 at 3:34 AM Peter Delevoryas wrote: > > > > On macOS, private $TMPDIR's are the default. These $TMPDIR's are > > generated from a user's unix UID and UUID [1], which c

Re: [PATCH v5 0/1] python/machine: Fix AF_UNIX path too long

2023-01-10 Thread Peter Delevoryas
On Tue, Jan 10, 2023 at 09:38:38AM +0100, Philippe Mathieu-Daudé wrote: > On 10/1/23 09:29, Peter Delevoryas wrote: > > > $ make check-avocado > > > Avocado crashed: TypeError: cannot pickle '_thread.RLock' object > > Yeah... you have to pick Clebe

[PATCH v5 1/1] python/machine: Fix AF_UNIX path too long on macOS

2023-01-10 Thread Peter Delevoryas
xchange.com/questions/353832/why-is-mac-osx-temp-directory-in-weird-path [2] /Library/Developer/CommandLineTools/SDKs/MacOSX12.3.sdk/usr/include/sys/un.h Signed-off-by: Peter Delevoryas Reviewed-by: Daniel P. Berrangé Reviewed-by: Philippe Mathieu-Daudé --- python/qemu/machine/machine.p

[PATCH v5 0/1] python/machine: Fix AF_UNIX path too long

2023-01-10 Thread Peter Delevoryas
: 18a949ed9150e22d6ecea69b99ede1ded17233f4 JOB LOG: /Users/pdel/qemu/build/tests/results/job-2023-01-10T00.03-18a949e/job.log Avocado crashed: TypeError: cannot pickle '_thread.RLock' object Peter Delevoryas (1): python/machine: Fix AF_UNIX path too long on macOS python/qemu/mach

[PATCH v4 0/1] python/machine: Fix AF_UNIX path too long

2023-01-10 Thread Peter Delevoryas
233f4 JOB LOG: /Users/pdel/qemu/build/tests/results/job-2023-01-10T00.03-18a949e/job.log Avocado crashed: TypeError: cannot pickle '_thread.RLock' object Peter Delevoryas (1): python/machine: Fix AF_UNIX path too long on macOS python/qemu/machine/machine.py | 6 +++--

[PATCH v4 1/1] python/machine: Fix AF_UNIX path too long on macOS

2023-01-10 Thread Peter Delevoryas
xchange.com/questions/353832/why-is-mac-osx-temp-directory-in-weird-path [2] /Library/Developer/CommandLineTools/SDKs/MacOSX12.3.sdk/usr/include/sys/un.h Signed-off-by: Peter Delevoryas --- python/qemu/machine/machine.py | 6 +++--- tests/avocado/avocado_qemu/__init__.py | 2 +- 2 files ch

Re: [PATCH v3 1/1] python/machine: Fix AF_UNIX path too long on macOS

2023-01-10 Thread Peter Delevoryas
On Mon, Jan 09, 2023 at 04:09:32PM -0500, John Snow wrote: > On Mon, Jul 25, 2022 at 5:06 AM Daniel P. Berrangé > wrote: > > > > On Fri, Jul 22, 2022 at 11:25:08AM -0700, Peter Delevoryas wrote: > > > On macOS, private $TMPDIR's are the default. These $TMPDIR

[PATCH 1/1] net/slirp: Add mfr-id and oob-eth-addr parameters

2023-01-05 Thread Peter Delevoryas
This adds mfr-id and oob-eth-addr parameters to the userspace netdev backend. -netdev user,id=[str],mfr-id=[uint32],oob-eth-addr=[MAC address] Signed-off-by: Peter Delevoryas --- net/slirp.c | 19 --- qapi/net.json | 9 - 2 files changed, 24 insertions(+), 4

[PATCH 0/1] net/slirp: Add mfr-id and oob-eth-addr parameters

2023-01-05 Thread Peter Delevoryas
o create a new slirp release, 4.8.0. But, I don't see the point of that, because we already have a version number exposed for the SlirpConfig. Thanks, Peter Peter Delevoryas (1): net/slirp: Add mfr-id and oob-eth-addr parameters net/slirp.c | 19 --- qapi/net.json | 9 +

Re: [PATCH v2 02/11] hw/watchdog/wdt_aspeed: Extend MMIO range to cover more registers

2023-01-03 Thread Peter Delevoryas
On Tue, Jan 03, 2023 at 04:48:14PM +0100, Cédric Le Goater wrote: > On 1/3/23 16:31, Peter Delevoryas wrote: > > On Mon, Jan 02, 2023 at 02:31:31PM +0100, Cédric Le Goater wrote: > > > On 12/31/22 23:52, Dong, Eddie wrote: > > > > > When boot

Re: [PATCH v2 02/11] hw/watchdog/wdt_aspeed: Extend MMIO range to cover more registers

2023-01-03 Thread Peter Delevoryas
0. And, that the #regs would still just be 0x30/4. Afaik the AST2600 and AST1030 should have the exact same peripheral. Peter > > > AFAICT, the WDT logic was changed in a compatible way with the previous > generation. > > Thanks > > C. > > > while iosize is for

Re: [PATCH v2 01/11] hw/watchdog/wdt_aspeed: Rename MMIO region size as 'iosize'

2023-01-03 Thread Peter Delevoryas
gt; at larger offsets. > > Here we are interested in the I/O region size, so rename as > 'iosize'. > > Reviewed-by: Peter Delevoryas > Signed-off-by: Philippe Mathieu-Daudé > --- > hw/arm/aspeed_ast10x0.c | 2 +- > hw/arm/aspeed_ast2600.c

Re: [PATCH 6/9] hw/arm/aspeed_ast10x0: Map HACE peripheral

2022-12-30 Thread Peter Delevoryas
On Fri, Dec 30, 2022 at 09:13:29AM +0100, Philippe Mathieu-Daudé wrote: > On 29/12/22 21:52, Peter Delevoryas wrote: > > On Thu, Dec 29, 2022 at 04:23:22PM +0100, Philippe Mathieu-Daudé wrote: > > > Since I don't have access to the datasheet, the relevant > > > v

Re: [PATCH v2 02/11] hw/watchdog/wdt_aspeed: Extend MMIO range to cover more registers

2022-12-30 Thread Peter Delevoryas
t; (qemu) info mtree -f > ... > 7e785000-7e78507f (prio 0, i/o): aspeed.wdt > 7e785080-7e7850ff (prio 0, i/o): aspeed.wdt > 7e785100-7e78517f (prio 0, i/o): aspeed.wdt > 00007e785180-7e7851ff (prio 0, i

Re: [PATCH v2 03/11] hw/watchdog/wdt_aspeed: Log unimplemented registers as UNIMP level

2022-12-30 Thread Peter Delevoryas
s://github.com/AspeedTech-BMC/zephyr/blob/v00.01.08/drivers/watchdog/wdt_aspeed.c#L31 > > Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Peter Delevoryas > --- > hw/watchdog/wdt_aspeed.c | 13 + > include/hw/watchdog/wdt_aspeed.h | 2 +- > 2 files ch

Re: [PATCH 7/9] hw/misc/aspeed_hace: Do not crash if address_space_map() failed

2022-12-29 Thread Peter Delevoryas
tv[0]:hash_final error > sha384_test > tv[0]:hash_final error > sha512_test > tv[0]:hash_final error > [00:00:06.278,000] hace_global: HACE poll timeout > [00:00:09.324,000] hace_global: HACE poll timeout > [00:00:12.261,000] hace_global: HACE poll

Re: [PATCH 8/9] hw/arm/aspeed_ast10x0: Add TODO comment to use Cortex-M4F

2022-12-29 Thread Peter Delevoryas
this somewhere. Reviewed-by: Peter Delevoryas > --- > hw/arm/aspeed_ast10x0.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/hw/arm/aspeed_ast10x0.c b/hw/arm/aspeed_ast10x0.c > index 02636705b6..788827ca9d 100644 > --- a/hw/arm/aspeed_ast10x0.c > ++

Re: [PATCH 9/9] tests/avocado: Test Aspeed Zephyr SDK v00.01.08 on AST1030 board

2022-12-29 Thread Peter Delevoryas
-- -- -- -- -- > console: 40: -- -- -- -- -- -- -- -- -- -- -- -- -- -- -- -- > console: 50: 50 -- -- -- -- -- -- -- -- -- -- -- -- -- -- -- > console: 60: -- -- -- -- -- -- -- -- -- -- -- -- -- -- -- -- > console: 70: -- -- -- -- -- -- -- -- > console: 1 devices fo

Re: [PATCH 6/9] hw/arm/aspeed_ast10x0: Map HACE peripheral

2022-12-29 Thread Peter Delevoryas
hace_global: crypto_cmd_reg: 11c2018 > [00:00:05.772,000] hace_global: HACE_STS: 1000 > [00:00:05.772,000] crypto: Output length (decryption): 64 > [00:00:05.772,000] crypto: CBC mode DECRYPT - Mismatch between > plaintext and decrypted cipher text > [00:00:05.774,0

Re: [PATCH 5/9] hw/arm/aspeed_ast10x0: Map the secure SRAM

2022-12-29 Thread Peter Delevoryas
t; ^~ > ../hw/arm/aspeed_ast10x0.c:24:30: note: previous initialization is here > [ASPEED_DEV_SBC] = 0x7900, > ^~ O! Oh no, yeah I think Zephyr has this warning enabled by default, right? I gues

Re: [PATCH 4/9] hw/arm/aspeed_ast10x0: Map I3C peripheral

2022-12-29 Thread Peter Delevoryas
gt; +if (!sysbus_realize(SYS_BUS_DEVICE(&s->i3c), errp)) { > +return; > +} > +aspeed_mmio_map(s, SYS_BUS_DEVICE(&s->i3c), 0, > sc->memmap[ASPEED_DEV_I3C]); > +for (i = 0; i < ASPEED_I3C_NR_DEVICES; i++) { > +qemu_irq irq = qdev_

Re: [PATCH 3/9] hw/arm/aspeed_ast10x0: Add various unimplemented peripherals

2022-12-29 Thread Peter Delevoryas
://github.com/AspeedTech-BMC/zephyr/blob/v00.01.08/dts/arm/aspeed/ast10x0.dtsi > > Signed-off-by: Philippe Mathieu-Daudé Oh cool, yeah looks good. Reviewed-by: Peter Delevoryas > --- > hw/arm/aspeed_ast10x0.c | 35 +++ > include/hw/arm/aspeed_so

Re: [PATCH 2/9] hw/arm/aspeed: Use the IEC binary prefix definitions

2022-12-29 Thread Peter Delevoryas
On Thu, Dec 29, 2022 at 04:23:18PM +0100, Philippe Mathieu-Daudé wrote: > IEC binary prefixes ease code review: the unit is explicit. Oh, yeah, another good idea. Reviewed-by: Peter Delevoryas > > Signed-off-by: Philippe Mathieu-Daudé > --- > hw/arm/aspeed_ast10x0.c |

Re: [PATCH 1/9] hw/watchdog/wdt_aspeed: Map the whole MMIO range

2022-12-29 Thread Peter Delevoryas
Watchdog Controller"; > -awc->offset = 0x80; > +awc->iosize = 0x80; > awc->ext_pulse_width_mask = 0xf; /* TODO */ > awc->reset_ctrl_reg = AST2600_SCU_RESET_CONTROL1; > awc->reset_pulse = aspeed_2500_wdt_reset_pulse; > diff --git

Re: [PATCH 0/9] hw/arm/aspeed_ast10x0: Map more peripherals & few more fixes

2022-12-29 Thread Peter Delevoryas
On Thu, Dec 29, 2022 at 04:23:16PM +0100, Philippe Mathieu-Daudé wrote: > Trying to fix some bugs triggered running Zephyr. Yay! > > Still 2 bugs: > > 1/ > uart:~$ sensor get SYSCLK > [00:00:23.592,000] os: * USAGE FAULT * > [00:00:23.593,000] os: Illegal use of the EPSR > [00:00:23

Re: [PATCH 08/11] contrib/gitdm: Add Facebook the domain map

2022-12-19 Thread Peter Delevoryas
> On Dec 19, 2022, at 7:49 AM, Philippe Mathieu-Daudé wrote: > > !---| > This Message Is From an External Sender > > |---! > > On 19/12/22

Re: [PATCH 08/11] contrib/gitdm: Add Facebook the domain map

2022-12-19 Thread Peter Delevoryas
> On Dec 19, 2022, at 7:56 AM, Peter Delevoryas wrote: > > > >> On Dec 19, 2022, at 7:49 AM, Philippe Mathieu-Daudé >> wrote: >> >> !---| >&g

Re: [PATCH 08/11] contrib/gitdm: Add Facebook the domain map

2022-12-19 Thread Peter Delevoryas
igrated to “usern...@meta.com”. So now all my fb.com email goes to my meta.com inbox. We may or may not want to include both emails. I think the fb.com emails will stay around for quite a while, but yeah. > > Signed-off-by: Alex Bennée > Cc: Iris Chen > Cc: Peter Delevoryas &

Re: [PATCH v2] m25p80: Improve error when the backend file size does not match the device

2022-11-15 Thread Peter Delevoryas
> > hw/block/m25p80.c | 4 ++-- > > 1 file changed, 2 insertions(+), 2 deletions(-) > > Reviewed-by: Philippe Mathieu-Daudé > Thanks Cedric! Reviewed-by: Peter Delevoryas

Re: [PATCH 0/1] hw/arm/aspeed: Automatically zero-extend flash images

2022-11-15 Thread Peter Delevoryas
On Tue, Nov 15, 2022 at 02:06:57PM +0100, Cédric Le Goater wrote: > Hello Peter, > > On 11/14/22 20:08, Peter Delevoryas wrote: > > I've been using this patch for a long time so that I don't have to use > > dd to zero-extend stuff all the time. It's just doi

Re: [PATCH 0/1] hw/arm/aspeed: Automatically zero-extend flash images

2022-11-15 Thread Peter Delevoryas
On Tue, Nov 15, 2022 at 10:48:40AM +, Peter Maydell wrote: > On Mon, 14 Nov 2022 at 19:08, Peter Delevoryas wrote: > > > > I've been using this patch for a long time so that I don't have to use > > dd to zero-extend stuff all the time. It's just doing what

[PATCH 0/1] hw/arm/aspeed: Automatically zero-extend flash images

2022-11-14 Thread Peter Delevoryas
permissions on the block device to allow truncation. If somebody knows how to avoid the `blk_get_perm`, `blk_set_perm` calls here, let me know! Thanks, Peter Peter Delevoryas (1): hw/arm/aspeed: Automatically zero-extend flash images hw/arm/aspeed.c | 40 +++

[PATCH 1/1] hw/arm/aspeed: Automatically zero-extend flash images

2022-11-14 Thread Peter Delevoryas
ipt does this already, it will be a no-op. And, if your firmware image is larger than the SPI-NOR device, then it will not truncate it. Signed-off-by: Peter Delevoryas --- hw/arm/aspeed.c | 40 +++- 1 file changed, 39 insertions(+), 1 deletion(-) diff --git a

Re: [RFC PATCH v2 3/3] hw/peci: add support for EndPointConfig reads

2022-09-13 Thread Peter Delevoryas
On Tue, Sep 13, 2022 at 06:21:49PM +, Titus Rwantare wrote: > Signed-off-by: Titus Rwantare > Reviewed-by: Hao Wu Reviewed-by: Peter Delevoryas > --- > hw/peci/peci-client.c | 63 ++ > hw/peci/peci

Re: [RFC PATCH 1/3] hw/peci: add initial support for PECI

2022-09-13 Thread Peter Delevoryas
On Tue, Sep 13, 2022 at 11:21:16AM -0700, Titus Rwantare wrote: > On Fri, 9 Sept 2022 at 12:58, Peter Delevoryas wrote: > > > > +/* > > > + * PECI Client device > > > + * Copyright 2021 Google LLC > > > + * > > > + * SPDX-License-Identifier:

Re: [RFC PATCH 0/3] Initial PECI bus support

2022-09-13 Thread Peter Delevoryas
On Tue, Sep 13, 2022 at 11:20:57AM -0700, Titus Rwantare wrote: > On Fri, 9 Sept 2022 at 12:54, Peter Delevoryas wrote: > > > > On Tue, Sep 06, 2022 at 10:05:49PM +, Titus Rwantare wrote: > ... > > > > > > This is something that can also be extended as oth

Re: [RFC PATCH v2 1/3] hw/peci: add initial support for PECI

2022-09-13 Thread Peter Delevoryas
> > Commands not implemented: > - RdIAMSR > - RdPCIConfig > - RdPCIConfigLocal > > Signed-off-by: Titus Rwantare > Reviewed-by: Hao Wu > Reviewed-by: Patrick Venture Reviewed-by: Peter Delevoryas > --- > MAINTAINERS| 7 ++ > hw/Kc

Re: [RFC PATCH 2/3] hw/peci: add PECI support for NPCM7xx BMCs

2022-09-09 Thread Peter Delevoryas
On Tue, Sep 06, 2022 at 10:05:51PM +, Titus Rwantare wrote: > This allows BMC firmware for npcm7xx BMCs to talk to a PECI client > in qemu. > > Signed-off-by: Titus Rwantare > Reviewed-by: Patrick Venture Looks good to me! Reviewed-by: Peter Delevoryas >

Re: [RFC PATCH 1/3] hw/peci: add initial support for PECI

2022-09-09 Thread Peter Delevoryas
On Tue, Sep 06, 2022 at 10:05:50PM +, Titus Rwantare wrote: > PECI - Platform Environment Control Interface > > This commit adds support for reading basic sensor values from a client > on the PECI bus. > BMCs can use the PECI wire to get thermal information out of an Intel > cpu. Additionally,

Re: [RFC PATCH 0/3] Initial PECI bus support

2022-09-09 Thread Peter Delevoryas
On Tue, Sep 06, 2022 at 10:05:49PM +, Titus Rwantare wrote: > The Platform Environment Control Interface (PECI), is a way for Intel > processors to communicate with management controllers. > > This series of patches simulate some PECI subsystem functionality. This > work is currently used agai

Re: [RFC PATCH 3/3] hw/peci: add support for EndPointConfig reads

2022-09-09 Thread Peter Delevoryas
On Tue, Sep 06, 2022 at 10:05:52PM +, Titus Rwantare wrote: > Signed-off-by: Titus Rwantare > Reviewed-by: Hao Wu > --- > hw/peci/peci-client.c | 63 ++ > hw/peci/peci-core.c| 44 +++-- > include/hw/peci/peci.h | 23 +++

Re: slirp: Can I get IPv6-only DHCP working?

2022-08-25 Thread Peter Delevoryas
On Fri, Aug 26, 2022 at 12:56:10AM +0200, Samuel Thibault wrote: > Hello, > > Peter Delevoryas, le jeu. 25 août 2022 15:38:53 -0700, a ecrit: > > It seems like there's support for an IPv6 dns proxy, and there's literally a > > file called "dhcpv6.c" in s

slirp: Can I get IPv6-only DHCP working?

2022-08-25 Thread Peter Delevoryas
I'm having a hard time figuring this out from looking at the code and the user-level help options. It seems like there's support for an IPv6 dns proxy, and there's literally a file called "dhcpv6.c" in slirp, but it has a comment saying it only supports whatever is necessary for TFTP network boot

  1   2   3   4   >