Re: [PATCH v7 2/3] linux-headers: Update to Linux 6.13-rc7

2025-01-16 Thread Paul Durrant
On 16/01/2025 14:59, David Woodhouse wrote: From: David Woodhouse Signed-off-by: David Woodhouse --- include/standard-headers/linux/vmclock-abi.h | 182 +++ linux-headers/linux/iommufd.h| 31 ++-- linux-headers/linux/stddef.h | 13 +- 3 fi

Re: [PATCH v2] hw/i386/pc: Fix level interrupt sharing for Xen event channel GSI

2025-01-07 Thread Paul Durrant
On 07/01/2025 16:32, David Woodhouse wrote: From: David Woodhouse The system GSIs are not designed for sharing. One device might assert a shared interrupt with qemu_set_irq() and another might deassert it, and the level from the first device is lost. This could be solved by using a multiplexer

Re: [PATCH v5] hw/acpi: Add vmclock device

2024-12-10 Thread Paul Durrant
nclude/hw/acpi/vmclock.h create mode 100644 include/standard-headers/linux/vmclock-abi.h Reviewed-by: Paul Durrant

Re: Rust in QEMU roadmap

2024-12-05 Thread Paul Durrant
On 05/12/2024 12:00, Daniel P. Berrangé wrote: On Wed, Nov 27, 2024 at 01:22:00PM +0100, Paolo Bonzini wrote: On Wed, Nov 27, 2024 at 1:18 PM Daniel P. Berrangé wrote: I question the usefulness of the 'syslog' trace target. I can't see it being desirable as a option for 'production' builds, an

Re: [PATCH v2 0/2] qdev-monitor: avoid QemuOpts in QMP device_add

2024-08-13 Thread Paul Durrant
On 12/08/2024 19:15, Stefan Hajnoczi wrote: On Fri, Aug 02, 2024 at 10:10:43AM +0200, Markus Armbruster wrote: Can we additionally cut out the QemuOpts middleman in usbback_portid_add()? qdict = qdict_new(); qdict_put_str(qdict, "driver", "usb-host"); tmp = g_strdup_printf("%s.0"

Re: [PATCH] MAINTAINERS: add Edgar as Xen maintainer

2024-07-11 Thread Paul Durrant
subsystem in QEMU and we are very happy to welcome him to the team. His knowledge and expertise with QEMU internals will be of great help. Signed-off-by: Stefano Stabellini Reviewed-by: Paul Durrant diff --git a/MAINTAINERS b/MAINTAINERS index 6725913c8b..63e11095a2 100644 --- a/MAINTAINERS +++ b

Re: [PATCH v3 3/3] ui+display: rename is_buffer_shared() -> surface_is_allocated()

2024-06-06 Thread Paul Durrant
: Gerd Hoffmann --- include/ui/surface.h| 4 ++-- hw/display/qxl-render.c | 2 +- hw/display/vga.c| 20 ++-- hw/display/xenfb.c | 5 +++-- ui/console.c| 3 ++- 5 files changed, 18 insertions(+), 16 deletions(-) Reviewed-by: Paul Durrant

Re: [PATCH v2 7/7] hw/xen: Register framebuffer backend via xen_backend_init()

2024-05-31 Thread Paul Durrant
alized the vga_interface_type variable. Signed-off-by: Philippe Mathieu-Daudé --- include/hw/xen/xen-legacy-backend.h | 3 --- hw/display/xenfb.c | 9 +++-- hw/xenpv/xen_machine_pv.c | 2 -- 3 files changed, 7 insertions(+), 7 deletions(-) Reviewed-by: Paul Durrant

Re: [PATCH v2 6/7] hw/xen: register legacy backends via xen_backend_init

2024-05-31 Thread Paul Durrant
kend.c | 16 6 files changed, 20 insertions(+), 38 deletions(-) Reviewed-by: Paul Durrant

Re: [PATCH v2 5/7] hw/xen: initialize legacy backends from xen_bus_init()

2024-05-31 Thread Paul Durrant
(+), 7 deletions(-) Reviewed-by: Paul Durrant

Re: [PATCH v2 4/7] hw/xen: Make XenDevOps structures const

2024-05-31 Thread Paul Durrant
| 4 ++-- 4 files changed, 9 insertions(+), 9 deletions(-) Reviewed-by: Paul Durrant

Re: [PATCH v2 3/7] hw/xen: Constify xenstore_be::XenDevOps

2024-05-31 Thread Paul Durrant
(-) Reviewed-by: Paul Durrant

Re: [PATCH v2 2/7] hw/xen: Constify XenLegacyDevice::XenDevOps

2024-05-31 Thread Paul Durrant
On 10/05/2024 11:49, Philippe Mathieu-Daudé wrote: XenDevOps @ops is not updated, mark it const. Signed-off-by: Philippe Mathieu-Daudé --- include/hw/xen/xen_pvdev.h | 2 +- hw/xen/xen-legacy-backend.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) Reviewed-by: Paul Durrant

Re: [PATCH v2 1/7] hw/xen: Remove declarations left over in 'xen-legacy-backend.h'

2024-05-31 Thread Paul Durrant
;xen_console_ops' in commit 9b77374690 ("hw/xen: update Xen console to XenDevice model"). Remove them. Signed-off-by: Philippe Mathieu-Daudé --- include/hw/xen/xen-legacy-backend.h | 3 --- 1 file changed, 3 deletions(-) Reviewed-by: Paul Durrant

Re: [PATCH] xen-hvm: Avoid livelock while handling buffered ioreqs

2024-04-08 Thread Paul Durrant
continue processing them. This lets QEMU go back to the main loop and catch up. Signed-off-by: Ross Lagerwall --- hw/xen/xen-hvm-common.c | 26 +- 1 file changed, 17 insertions(+), 9 deletions(-) Reviewed-by: Paul Durrant

Re: [PATCH] xen-hvm: Avoid livelock while handling buffered ioreqs

2024-04-08 Thread Paul Durrant
On 08/04/2024 14:00, Ross Lagerwall wrote: On Sat, Apr 6, 2024 at 11:58 AM Durrant, Paul wrote: On 04/04/2024 15:08, Ross Lagerwall wrote: A malicious or buggy guest may generated buffered ioreqs faster than QEMU can process them in handle_buffered_iopage(). The result is a livelock - QEMU co

Re: [PATCH v4 3/6] xen: decouple generic xen code from legacy backends codebase

2023-12-04 Thread Paul Durrant
: add option to disable legacy backends" - Do not move xenstore global variable from xen-legacy-backend.c, instead use a local variable. --- accel/xen/xen-all.c | 16 1 file changed, 12 insertions(+), 4 deletions(-) Reviewed-by: Paul Durrant

Re: [PATCH 05/12] block: remove AioContext locking

2023-11-30 Thread Paul Durrant
/test-replication.c | 11 -- util/async.c | 4 - util/vhost-user-server.c | 3 - scripts/block-coroutine-wrapper.py | 3 - tests/tsan/suppressions.tsan | 1 - 41 files changed, 102 insertions(+), 1202 deletions(-) Reviewed-by: Paul Durrant

Re: [PATCH 2/6] qemu/main-loop: rename QEMU_IOTHREAD_LOCK_GUARD to QEMU_BQL_LOCK_GUARD

2023-11-30 Thread Paul Durrant
ons(+), 25 deletions(-) Reviewed-by: Paul Durrant

Re: [PATCH 1/6] system/cpus: rename qemu_mutex_lock_iothread() to qemu_bql_lock()

2023-11-30 Thread Paul Durrant
les changed, 502 insertions(+), 502 deletions(-) Reviewed-by: Paul Durrant

Re: [PATCH v2 4/6] xen_pvdev: Do not assume Dom0 when creating a directory

2023-11-23 Thread Paul Durrant
On 23/11/2023 12:27, David Woodhouse wrote: On 23 November 2023 12:17:57 GMT, Volodymyr Babchuk wrote: Hi David, David Woodhouse writes: Which PV backends do you care about? We already have net, block and console converted. Well, this is all what we need, actually. Even console only wil

Re: [PATCH v2 1/6] hw/xen: Set XenBackendInstance in the XenDevice before realizing it

2023-11-23 Thread Paul Durrant
On 22/11/2023 23:04, David Woodhouse wrote: On Wed, 2023-11-22 at 22:56 +, Volodymyr Babchuk wrote: Paul Durrant writes: On 21/11/2023 22:10, Volodymyr Babchuk wrote: From: David Woodhouse This allows a XenDevice implementation to know whether it was created by QEMU, or merely

Re: [PATCH v2 4/6] xen_pvdev: Do not assume Dom0 when creating a directory

2023-11-23 Thread Paul Durrant
at 14:29 -0800, Stefano Stabellini wrote: On Wed, 22 Nov 2023, Paul Durrant wrote: On 21/11/2023 22:10, Volodymyr Babchuk wrote: From: Oleksandr Tyshchenko Instead of forcing the owner to domid 0, use XS_PRESERVE_OWNER to inherit the owner of the directory. Ah... so that's why the pre

Re: [PATCH v2 4/6] xen_pvdev: Do not assume Dom0 when creating a directory

2023-11-22 Thread Paul Durrant
On 21/11/2023 22:10, Volodymyr Babchuk wrote: From: Oleksandr Tyshchenko Instead of forcing the owner to domid 0, use XS_PRESERVE_OWNER to inherit the owner of the directory. Ah... so that's why the previous patch is there. This is not the right way to fix it. The QEMU Xen support is *assumi

Re: [PATCH v2 3/6] xen: xenstore: add possibility to preserve owner

2023-11-22 Thread Paul Durrant
On 21/11/2023 22:10, Volodymyr Babchuk wrote: Add option to preserve owner when creating an entry in Xen Store. This may be needed in cases when Qemu is working as device model in a *may* be needed? I don't undertstand why this patch is necessary and the commit comment isn't really helping me

Re: [PATCH v2 1/6] hw/xen: Set XenBackendInstance in the XenDevice before realizing it

2023-11-22 Thread Paul Durrant
On 21/11/2023 22:10, Volodymyr Babchuk wrote: From: David Woodhouse This allows a XenDevice implementation to know whether it was created by QEMU, or merely discovered in XenStore after the toolstack created it. This will allow us to create frontend/backend nodes only when we should, rather tha

Re: [PATCH v2 2/6] xen: backends: touch some XenStore nodes only if device...

2023-11-22 Thread Paul Durrant
On 21/11/2023 22:10, Volodymyr Babchuk wrote: was created by QEMU Xen PV devices in QEMU can be created in two ways: either by QEMU itself, if they were passed via command line, or by Xen toolstack. In the latter case, QEMU scans XenStore entries and configures devices accordingly. In the secon

Re: [PATCH v2 1/6] hw/xen: Set XenBackendInstance in the XenDevice before realizing it

2023-11-22 Thread Paul Durrant
/xen_nic.c | 2 +- hw/xen/xen-bus.c | 4 include/hw/xen/xen-backend.h | 2 -- include/hw/xen/xen-bus.h | 2 ++ 6 files changed, 9 insertions(+), 6 deletions(-) Reviewed-by: Paul Durrant

Re: [PATCH 2/3] vl: disable default serial when xen-console is enabled

2023-11-21 Thread Paul Durrant
On 15/11/2023 17:24, David Woodhouse wrote: From: David Woodhouse If a Xen console is configured on the command line, do not add a default serial port. Signed-off-by: David Woodhouse --- system/vl.c | 1 + 1 file changed, 1 insertion(+) Reviewed-by: Paul Durrant

Re: [PATCH 3/3] hw/xen: clean up xen_block_find_free_vdev() to avoid Coverity false positive

2023-11-15 Thread Paul Durrant
de to hopefully make it clearer to Coverity and human reviewers alike. Signed-off-by: David Woodhouse --- hw/block/xen-block.c | 24 +--- 1 file changed, 21 insertions(+), 3 deletions(-) Reviewed-by: Paul Durrant

Re: [PATCH v1 3/7] xen: xenstore: add possibility to preserve owner

2023-11-12 Thread Paul Durrant
On 10/11/2023 15:42, Volodymyr Babchuk wrote: Add option to preserve owner when creating an entry in Xen Store. This may be needed in cases when Qemu is working as device model in a domain that is Domain-0, e.g. in driver domain. "owner" parameter for qemu_xen_xs_create() function can have speci

Re: [PATCH v1 5/7] xen-bus: Set offline if backend's state is XenbusStateClosed

2023-11-12 Thread Paul Durrant
On 10/11/2023 15:42, Volodymyr Babchuk wrote: From: Oleksandr Tyshchenko Both state (XenbusStateClosed) and online (0) are expected by toolstack/xl devd to completely destroy the device. But "offline" is never being set by the backend resulting in timeout during domain destruction, garbage in X

Re: [PATCH v1 1/7] xen-block: Do not write frontend nodes

2023-11-12 Thread Paul Durrant
On 10/11/2023 15:42, Volodymyr Babchuk wrote: From: Oleksandr Tyshchenko The PV backend running in other than Dom0 domain (non toolstack domain) is not allowed to write frontend nodes. The more, the backend does not need to do that at all, this is purely toolstack/xl devd business. I do not kn

Re: [PATCH] hw/xen: clean up xen_block_find_free_vdev() to avoid Coverity false positive

2023-11-09 Thread Paul Durrant
de to hopefully make it clearer to Coverity and human reviewers alike. Signed-off-by: David Woodhouse ---  hw/block/xen-block.c | 24 +---  1 file changed, 21 insertions(+), 3 deletions(-) Reviewed-by: Paul Durrant

Re: [PATCH v4 17/17] docs: update Xen-on-KVM documentation

2023-11-06 Thread Paul Durrant
.rst | 107 +-- qemu-options.hx | 14 +++-- 3 files changed, 91 insertions(+), 32 deletions(-) Reviewed-by: Paul Durrant

Re: [PATCH v4 16/17] doc/sphinx/hxtool.py: add optional label argument to SRST directive

2023-11-06 Thread Paul Durrant
fs option is set. Signed-off-by: David Woodhouse --- docs/sphinx/hxtool.py | 18 +- docs/system/invocation.rst | 1 + 2 files changed, 18 insertions(+), 1 deletion(-) Reviewed-by: Paul Durrant

Re: [PATCH v4 13/17] hw/i386/pc: support '-nic' for xen-net-device

2023-11-06 Thread Paul Durrant
2 +- hw/i386/pc_q35.c | 2 +- hw/xen/xen-bus.c | 4 +++- include/hw/i386/pc.h | 4 +++- include/hw/xen/xen-bus.h | 2 +- 6 files changed, 17 insertions(+), 8 deletions(-) Reviewed-by: Paul Durrant

Re: [PATCH v4 06/17] hw/xen: automatically assign device index to block devices

2023-11-06 Thread Paul Durrant
ed, 125 insertions(+), 46 deletions(-) Reviewed-by: Paul Durrant

Re: [PATCH] xen/pt: Emulate multifunction bit in header type

2023-11-06 Thread Paul Durrant
using QAPI). This allows making passthrough devices appear as functions in a Xen guest. Signed-off-by: Ross Lagerwall Reviewed-by: Paul Durrant

Re: [PATCH 12/12] hw/xen: add support for Xen primary console in emulated mode

2023-10-25 Thread Paul Durrant
On 25/10/2023 10:00, David Woodhouse wrote: On Wed, 2023-10-25 at 09:31 +0100, Paul Durrant wrote: On 24/10/2023 17:34, David Woodhouse wrote: On Tue, 2023-10-24 at 17:25 +0100, Paul Durrant wrote: On 24/10/2023 16:49, David Woodhouse wrote: On Tue, 2023-10-24 at 16:39 +0100, Paul Durrant

Re: [PATCH 12/12] hw/xen: add support for Xen primary console in emulated mode

2023-10-25 Thread Paul Durrant
On 24/10/2023 17:34, David Woodhouse wrote: On Tue, 2023-10-24 at 17:25 +0100, Paul Durrant wrote: On 24/10/2023 16:49, David Woodhouse wrote: On Tue, 2023-10-24 at 16:39 +0100, Paul Durrant wrote: On 24/10/2023 16:37, David Woodhouse wrote: On Tue, 2023-10-24 at 15:20 +0100, Paul Durrant

Re: [PATCH 12/12] hw/xen: add support for Xen primary console in emulated mode

2023-10-24 Thread Paul Durrant
On 24/10/2023 16:49, David Woodhouse wrote: On Tue, 2023-10-24 at 16:39 +0100, Paul Durrant wrote: On 24/10/2023 16:37, David Woodhouse wrote: On Tue, 2023-10-24 at 15:20 +0100, Paul Durrant wrote: On 16/10/2023 16:19, David Woodhouse wrote: From: David Woodhouse The primary console is

Re: [PATCH v2 16/24] hw/xen: handle soft reset for primary console

2023-10-24 Thread Paul Durrant
On 24/10/2023 16:48, David Woodhouse wrote: On Tue, 2023-10-24 at 16:44 +0100, Paul Durrant wrote: On 19/10/2023 16:40, David Woodhouse wrote: From: David Woodhouse On soft reset, the prinary console event channel needs to be rebound to the backend port (in the xen-console driver). We could

Re: [PATCH 2/4] hw/xen: update Xen PV NIC to XenDevice model

2023-10-24 Thread Paul Durrant
On 24/10/2023 16:17, David Woodhouse wrote: [snip] I don't think that's really a valid state for a network frontend. Linux netback just ignores it. Must we? I was thinking of making the ->frontend_changed() methods optional and allowing backends to just provide ->connect() and ->disconnect() m

Re: [PATCH v2 16/24] hw/xen: handle soft reset for primary console

2023-10-24 Thread Paul Durrant
On 19/10/2023 16:40, David Woodhouse wrote: From: David Woodhouse On soft reset, the prinary console event channel needs to be rebound to the backend port (in the xen-console driver). We could put that into the xen-console driver itself, but it's slightly less ugly to keep it within the KVM/Xen

Re: [PATCH 12/12] hw/xen: add support for Xen primary console in emulated mode

2023-10-24 Thread Paul Durrant
On 24/10/2023 16:37, David Woodhouse wrote: On Tue, 2023-10-24 at 15:20 +0100, Paul Durrant wrote: On 16/10/2023 16:19, David Woodhouse wrote: From: David Woodhouse The primary console is special because the toolstack maps a page at a fixed GFN and also allocates the guest-side event channel

Re: [PATCH v2 10/24] hw/xen: populate store frontend nodes with XenStore PFN/port

2023-10-24 Thread Paul Durrant
ts to *rebind* to the event channel port after a reset. Signed-off-by: David Woodhouse --- hw/i386/kvm/xen_xenstore.c | 11 +++ 1 file changed, 11 insertions(+) Reviewed-by: Paul Durrant

Re: [PATCH v2 05/24] hw/xen: fix XenStore watch delivery to guest

2023-10-24 Thread Paul Durrant
On 19/10/2023 16:40, David Woodhouse wrote: From: David Woodhouse When fire_watch_cb() found the response buffer empty, it would call deliver_watch() to generate the XS_WATCH_EVENT message in the response buffer and send an event channel notification to the guest… without actually *copying* the

Re: [PATCH v2 04/24] hw/xen: don't clear map_track[] in xen_gnttab_reset()

2023-10-24 Thread Paul Durrant
: de26b2619789 ("hw/xen: Implement soft reset for emulated gnttab") Signed-off-by: David Woodhouse --- hw/i386/kvm/xen_gnttab.c | 2 -- 1 file changed, 2 deletions(-) Reviewed-by: Paul Durrant

Re: [PATCH v2 03/24] hw/xen: select kernel mode for per-vCPU event channel upcall vector

2023-10-24 Thread Paul Durrant
+++ 3 files changed, 14 insertions(+) Reviewed-by: Paul Durrant

Re: [PATCH 2/4] hw/xen: update Xen PV NIC to XenDevice model

2023-10-24 Thread Paul Durrant
On 17/10/2023 19:25, David Woodhouse wrote: From: David Woodhouse Signed-off-by: David Woodhouse --- hw/net/meson.build| 2 +- hw/net/trace-events | 9 + hw/net/xen_nic.c | 426 +- hw/xenpv/xen_machine_pv.c | 1 - 4 files c

Re: [PATCH 1/4] hw/xen: only remove peers of PCI NICs on unplug

2023-10-24 Thread Paul Durrant
On 17/10/2023 19:25, David Woodhouse wrote: From: David Woodhouse When the Xen guest asks to unplug *emulated* NICs, it's kind of unhelpful also to unplug the peer of the *Xen* PV NIC. Signed-off-by: David Woodhouse --- hw/i386/xen/xen_platform.c | 9 +++-- 1 file changed, 7 insertions

Re: [PATCH 12/12] hw/xen: add support for Xen primary console in emulated mode

2023-10-24 Thread Paul Durrant
On 16/10/2023 16:19, David Woodhouse wrote: From: David Woodhouse The primary console is special because the toolstack maps a page at a fixed GFN and also allocates the guest-side event channel. Add support for that in emulated mode, so that we can have a primary console. Add a *very* rudiment

Re: [PATCH 09/12] hw/xen: prevent duplicate device registrations

2023-10-24 Thread Paul Durrant
On 16/10/2023 16:19, David Woodhouse wrote: From: David Woodhouse Ensure that we have a XenBackendInstance for every device regardless of whether it was "discovered" in XenStore or created directly in QEMU. This allows the backend_list to be a source of truth about whether a given backend exis

Re: [PATCH 06/12] hw/xen: add get_frontend_path() method to XenDeviceClass

2023-10-24 Thread Paul Durrant
On 24/10/2023 14:29, David Woodhouse wrote: On Tue, 2023-10-24 at 13:59 +0100, Paul Durrant wrote: On 24/10/2023 13:56, David Woodhouse wrote: On Tue, 2023-10-24 at 13:42 +0100, Paul Durrant wrote: --- a/hw/xen/xen-bus.c +++ b/hw/xen/xen-bus.c @@ -711,8 +711,16 @@ static void

Re: [PATCH 08/12] hw/xen: do not repeatedly try to create a failing backend device

2023-10-24 Thread Paul Durrant
/xen-backend.h | 1 + 3 files changed, 24 insertions(+), 7 deletions(-) Reviewed-by: Paul Durrant

Re: [PATCH 07/12] hw/xen: update Xen console to XenDevice model

2023-10-24 Thread Paul Durrant
|= xencons_send(con); } +return done_something; +} -path = g_string_new(dom_path); -free(dom_path); +/* */ -if (con->xendev.dev) { -g_string_append_printf(path, "/device/console/%d", con->xendev.dev); -} else { -g_string_append(path, "/console"); +static void xen_console_disconnect(XenDevice *xendev, Error **errp) +{ +XenConsole *con = XEN_CONSOLE_DEVICE(xendev); + +qemu_chr_fe_set_handlers(&con->chr, NULL, NULL, NULL, NULL, + con, NULL, true); + nit: extraneous blank line by the looks of it. With that fixed... Reviewed-by: Paul Durrant

Re: [PATCH 06/12] hw/xen: add get_frontend_path() method to XenDeviceClass

2023-10-24 Thread Paul Durrant
On 24/10/2023 13:56, David Woodhouse wrote: On Tue, 2023-10-24 at 13:42 +0100, Paul Durrant wrote: --- a/hw/xen/xen-bus.c +++ b/hw/xen/xen-bus.c @@ -711,8 +711,16 @@ static void xen_device_frontend_create(XenDevice *xendev, Error **errp)    {    ERRP_GUARD();    XenBus *xenbus

Re: [PATCH 06/12] hw/xen: add get_frontend_path() method to XenDeviceClass

2023-10-24 Thread Paul Durrant
On 16/10/2023 16:19, David Woodhouse wrote: From: David Woodhouse The primary Xen console is special. The guest's side is set up for it by the toolstack automatically and not by the standard PV init sequence. Accordingly, its *frontend* doesn't appear in …/device/console/0 either; instead it a

Re: [PATCH 05/12] hw/xen: populate store frontend nodes with XenStore PFN/port

2023-10-24 Thread Paul Durrant
allow guests to *rebind* to the event channel port after a reset. ... although this can also be done by querying the remote end of the port before reset. Signed-off-by: David Woodhouse --- hw/i386/kvm/xen_xenstore.c | 10 ++ 1 file changed, 10 insertions(+) Reviewed-by: Paul Durrant

Re: [PATCH 04/12] i386/xen: advertise XEN_HVM_CPUID_UPCALL_VECTOR in CPUID

2023-10-24 Thread Paul Durrant
(+) Reviewed-by: Paul Durrant

Re: [PATCH 03/12] include: update Xen public headers to Xen 4.17.2 release

2023-10-24 Thread Paul Durrant
/interface/vcpu.h | 19 +-- include/hw/xen/interface/version.h| 19 +-- include/hw/xen/interface/xen-compat.h | 19 +-- include/hw/xen/interface/xen.h| 19 +-- 29 files changed, 124 insertions(+), 523 deletions(-) Acked-by: Paul

Re: [PATCH 02/12] hw/xen: select kernel mode for per-vCPU event channel upcall vector

2023-10-24 Thread Paul Durrant
On 16/10/2023 16:18, David Woodhouse wrote: From: David Woodhouse A guest which has configured the per-vCPU upcall vector may set the HVM_PARAM_CALLBACK_IRQ param to fairly much anything other than zero. For example, Linux v6.0+ after commit b1c3497e604 ("x86/xen: Add support for HVMOP_set_evt

Re: [PATCH 01/12] i386/xen: fix per-vCPU upcall vector for Xen emulation

2023-10-24 Thread Paul Durrant
d, 2 insertions(+), 3 deletions(-) Reviewed-by: Paul Durrant

Re: [RFC PATCH v3 42/78] hw/i386: add fallthrough pseudo-keyword

2023-10-17 Thread Paul Durrant
| 2 +- Reviewed-by: Paul Durrant hw/i386/x86.c| 2 +- 3 files changed, 4 insertions(+), 4 deletions(-)

Re: [PATCH] i386/xen: Ignore VCPU_SSHOTTMR_future flag in set_singleshot_timer()

2023-08-25 Thread Paul Durrant
d to ignore the flag). target/i386/kvm/xen-emu.c | 20 ++-- 1 file changed, 10 insertions(+), 10 deletions(-) Reviewed-by: Paul Durrant

Re: [PATCH v2 1/4] block: rename blk_io_plug_call() API to defer_call()

2023-08-18 Thread Paul Durrant
/plug.c | 109 +++--- hw/block/dataplane/xen-block.c| 10 +-- hw/block/virtio-blk.c | 4 +- hw/scsi/virtio-scsi.c | 6 +- 9 files changed, 76 insertions(+), 79 deletions(-) Reviewed-by: Paul Durrant

Re: [PATCH] i386/xen: Don't advertise XENFEAT_supervisor_mode_kernel

2023-08-14 Thread Paul Durrant
nly really cosmetic. Don't feel strongly about whether it makes 8.1. target/i386/kvm/xen-emu.c | 1 - 1 file changed, 1 deletion(-) Reviewed-by: Paul Durrant

Re: [RFC PATCH post-8.1] hw/xen: Clean up event channel 'type_val' handling to use union

2023-08-14 Thread Paul Durrant
enEvtchnState *s = xen_evtchn_singleton; -uint16_t type_val; int ret; if (!s) { @@ -1451,18 +1454,19 @@ int xen_evtchn_alloc_unbound_op(struct evtchn_alloc_unbound *alloc) return -ESRCH; } -if (alloc->remote_dom == DOMID_QEMU) { -type_val = PORT_INFO_TYPEVAL_REMOTE_QEMU; -} else if (alloc->remote_dom == DOMID_SELF || - alloc->remote_dom == xen_domid) { -type_val = 0; -} else { +if (alloc->remote_dom != DOMID_QEMU && alloc->remote_dom != DOMID_SELF && +alloc->remote_dom != xen_domid) { Maybe vertically align the clauses here as in the 'if' a couple of hunks back? return -EPERM; } Since all the above are nits... Reviewed-by: Paul Durrant

Re: [PATCH v1] xen-platform: do full PCI reset during unplug of IDE devices

2023-07-27 Thread Paul Durrant
/xen/xen_platform.c | 7 --- 1 file changed, 4 insertions(+), 3 deletions(-) Reviewed-by: Paul Durrant

Re: i386/xen: prevent guest from binding loopback event channel to itself

2023-07-26 Thread Paul Durrant
On 26/07/2023 10:07, David Woodhouse wrote: On Wed, 2023-07-26 at 09:44 +0100, Paul Durrant wrote: On 25/07/2023 11:05, David Woodhouse wrote: From: David Woodhouse Fuzzing showed that a guest could bind an interdomain port to itself, by guessing the next port to be allocated and putting

Re: [PATCH] hw/xen: Clarify (lack of) error handling in transaction_commit()

2023-07-26 Thread Paul Durrant
1 deletion(-) Reviewed-by: Paul Durrant

Re: i386/xen: prevent guest from binding loopback event channel to itself

2023-07-26 Thread Paul Durrant
t has type EVTCHNSTAT_unbound. It shouldn't. Signed-off-by: David Woodhouse --- hw/i386/kvm/xen_evtchn.c | 11 +-- 1 file changed, 9 insertions(+), 2 deletions(-) Reviewed-by: Paul Durrant

Re: [PATCH] xen-block: Avoid leaks on new error path

2023-07-06 Thread Paul Durrant
f-by: Anthony PERARD --- hw/block/xen-block.c | 11 ++- 1 file changed, 6 insertions(+), 5 deletions(-) Reviewed-by: Paul Durrant

Re: [PATCH v2] i386/xen: consistent locking around Xen singleshot timers

2023-07-06 Thread Paul Durrant
- 1 file changed, 26 insertions(+), 10 deletions(-) Reviewed-by: Paul Durrant

Re: [PATCH] i386/xen: consistent locking around Xen singleshot timers

2023-05-23 Thread Paul Durrant
ads/xenfv on top of the other fixes that didn't make 8.0. target/i386/kvm/xen-emu.c | 15 +-- 1 file changed, 9 insertions(+), 6 deletions(-) Reviewed-by: Paul Durrant

Re: [PATCH v2 RESEND] xen: Fix SEGV on domain disconnect

2023-04-24 Thread Paul Durrant
On 24/04/2023 14:17, Tim Smith wrote: On Mon, Apr 24, 2023 at 1:08 PM Mark Syms wrote: Copying in Tim who did the final phase of the changes. On Mon, 24 Apr 2023 at 11:32, Paul Durrant wrote: On 20/04/2023 12:02, mark.s...@citrix.com wrote: From: Mark Syms Ensure the PV ring is drained

Re: [PATCH v2 RESEND] xen: Fix SEGV on domain disconnect

2023-04-24 Thread Paul Durrant
: Anthony Perard CC: Paul Durrant CC: xen-de...@lists.xenproject.org v2: * Ensure all inflight requests are completed before teardown * RESEND to fix formatting --- hw/block/dataplane/xen-block.c | 31 +-- 1 file changed, 25 insertions(+), 6 deletions(-) diff

Re: [PATCH v2 08/16] hw/xen: do not use aio_set_fd_handler(is_external=true) in xen_xenstore

2023-04-20 Thread Paul Durrant
David Woodhouse Signed-off-by: Stefan Hajnoczi --- hw/i386/kvm/xen_xenstore.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) Reviewed-by: Paul Durrant

Re: [PATCH 5/5] hw/xen: Fix broken check for invalid state in xs_be_open()

2023-04-17 Thread Paul Durrant
David Woodhouse --- hw/i386/kvm/xen_xenstore.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) Reviewed-by: Paul Durrant

Re: [PATCH 4/5] hw/xen: Fix double-free in xen_console store_con_info()

2023-04-17 Thread Paul Durrant
("hw/xen: Move xenstore_store_pv_console_info to xen_console.c") Signed-off-by: David Woodhouse --- hw/char/xen_console.c | 13 +++-- 1 file changed, 3 insertions(+), 10 deletions(-) Reviewed-by: Paul Durrant

Re: [PATCH 3/5] xen: Drop support for Xen versions below 4.7.1

2023-04-17 Thread Paul Durrant
ve.h | 107 +--- meson.build | 5 +- scripts/xen-detect.c| 60 4 files changed, 3 insertions(+), 226 deletions(-) Reviewed-by: Paul Durrant

Re: [PATCH 2/5] hw/xen: Fix memory leak in libxenstore_open() for Xen

2023-04-17 Thread Paul Durrant
: Add xenstore operations to allow redirection to internal emulation") Suggested-by: Peter Maydell Signed-off-by: David Woodhouse Reviewed-by: Peter Maydell Reviewed-by: Paul Durrant

Re: [PATCH] hw/xen: Simplify emulated Xen platform init

2023-03-24 Thread Paul Durrant
386/pc.c | 13 - 3 files changed, 25 insertions(+), 31 deletions(-) Reviewed-by: Paul Durrant

Re: [PATCH] hw/xenpv: Initialize Xen backend operations

2023-03-23 Thread Paul Durrant
. Add the missing call to setup_xen_backend_ops(). Fixes: b6cacfea0b38 ("hw/xen: Add evtchn operations to allow redirection to internal emulation") Reported-by: Anthony PERARD Signed-off-by: David Woodhouse --- hw/xenpv/xen_machine_pv.c | 2 ++ 1 file changed, 2 insertions(+) Reviewe

Re: [PATCH] accel/xen: Fix DM state change notification in dm_restrict mode

2023-03-14 Thread Paul Durrant
Andryuk --- accel/xen/xen-all.c | 27 ++- 1 file changed, 10 insertions(+), 17 deletions(-) Reviewed-by: Paul Durrant

Re: [PATCH v2 00/27] Enable PV backends with Xen/KVM emulation

2023-03-07 Thread Paul Durrant
tion of XenStore operations hw/xen: Map guest XENSTORE_PFN grant in emulated Xenstore hw/xen: Implement soft reset for emulated gnttab i386/xen: Initialize Xen backends from pc_basic_device_init() for emulation MAINTAINERS: Add entry for Xen on KVM emulation docs:

Re: [PATCH v2 25/27] i386/xen: Initialize Xen backends from pc_basic_device_init() for emulation

2023-03-07 Thread Paul Durrant
device xen-disk,drive=disk,vdev=xvda If we use -M pc instead of q35, we can even add an IDE disk and boot a guest image normally through grub. But q35 gives us AHCI and that isn't unplugged by the Xen magic, so the guests ends up seeing "both" disks. Signed-off-by: David Woodhouse

Re: [RFC PATCH v1 07/25] hw/xen: Implement core serialize/deserialize methods for xenstore_impl

2023-03-07 Thread Paul Durrant
On 07/03/2023 16:59, Paul Durrant wrote: On 07/03/2023 16:52, David Woodhouse wrote: On Tue, 2023-03-07 at 16:39 +, Paul Durrant wrote: On 07/03/2023 16:33, David Woodhouse wrote: On Thu, 2023-03-02 at 15:34 +, David Woodhouse wrote: From: David Woodhouse In fact I think we want to

Re: [RFC PATCH v1 07/25] hw/xen: Implement core serialize/deserialize methods for xenstore_impl

2023-03-07 Thread Paul Durrant
On 07/03/2023 16:52, David Woodhouse wrote: On Tue, 2023-03-07 at 16:39 +, Paul Durrant wrote: On 07/03/2023 16:33, David Woodhouse wrote: On Thu, 2023-03-02 at 15:34 +, David Woodhouse wrote: From: David Woodhouse In fact I think we want to only serialize the contents of the

Re: [RFC PATCH v1 07/25] hw/xen: Implement core serialize/deserialize methods for xenstore_impl

2023-03-07 Thread Paul Durrant
On 07/03/2023 16:39, Paul Durrant wrote: On 07/03/2023 16:33, David Woodhouse wrote: On Thu, 2023-03-02 at 15:34 +, David Woodhouse wrote: From: David Woodhouse In fact I think we want to only serialize the contents of the domain's path in /local/domain/${domid} and leave the rest

Re: [RFC PATCH v1 07/25] hw/xen: Implement core serialize/deserialize methods for xenstore_impl

2023-03-07 Thread Paul Durrant
On 07/03/2023 16:33, David Woodhouse wrote: On Thu, 2023-03-02 at 15:34 +, David Woodhouse wrote: From: David Woodhouse In fact I think we want to only serialize the contents of the domain's path in /local/domain/${domid} and leave the rest to be recreated? Will defer to Paul for that. Si

Re: [RFC PATCH v1 27/25] docs: Update Xen-on-KVM documentation for PV disk support

2023-03-07 Thread Paul Durrant
On 07/03/2023 16:22, David Woodhouse wrote: From: David Woodhouse Signed-off-by: David Woodhouse --- docs/system/i386/xen.rst | 30 +++--- 1 file changed, 23 insertions(+), 7 deletions(-) Reviewed-by: Paul Durrant

Re: [RFC PATCH v1 26/25] MAINTAINERS: Add entry for Xen on KVM emulation

2023-03-07 Thread Paul Durrant
On 07/03/2023 16:21, David Woodhouse wrote: From: David Woodhouse Signed-off-by: David Woodhouse --- MAINTAINERS | 9 + 1 file changed, 9 insertions(+) Reviewed-by: Paul Durrant

Re: [RFC PATCH v1 25/25] i386/xen: Initialize Xen backends from pc_basic_device_init() for emulation

2023-03-07 Thread Paul Durrant
e --- hw/i386/pc.c | 7 +++ 1 file changed, 7 insertions(+) Reviewed-by: Paul Durrant

Re: [RFC PATCH v1 24/25] hw/xen: Implement soft reset for emulated gnttab

2023-03-07 Thread Paul Durrant
+ 3 files changed, 30 insertions(+), 2 deletions(-) Reviewed-by: Paul Durrant

Re: [RFC PATCH v1 23/25] hw/xen: Map guest XENSTORE_PFN grant in emulated Xenstore

2023-03-07 Thread Paul Durrant
*looks* like it's in use in the guest-visible grant table. Might be useful to stick this text in the commit comment too. Reviewed-by: Paul Durrant + */ +s->gt = qemu_xen_gnttab_open(); +uint32_t xs_gntref = GNTTAB_RESERVED_XENSTORE; +s->granted_xs = qemu_xen_gnttab_map_refs(s->gt, 1, xen_domid, &xs_gntref, + PROT_READ | PROT_WRITE); + return 0; }

Re: [RFC PATCH v1 22/25] hw/xen: Add emulated implementation of XenStore operations

2023-03-07 Thread Paul Durrant
nsertions(+), 4 deletions(-) Reviewed-by: Paul Durrant

Re: [RFC PATCH v1 21/25] hw/xen: Add emulated implementation of grant table operations

2023-03-07 Thread Paul Durrant
s and the domid. We probably ought to fail to set the flags if the guest is playing with the domid but since we're single-tenant it doesn't *really* matter... just a nice-to-have. So... Reviewed-by: Paul Durrant

Re: [RFC PATCH v1 20/25] hw/xen: Hook up emulated implementation for event channel operations

2023-03-07 Thread Paul Durrant
insertions(+) Reviewed-by: Paul Durrant

  1   2   3   4   5   6   7   8   9   10   >