Re: Fwd: [PATCH 0/2] block/raw: implemented persistent dirty bitmap and ability to dump bitmap content via qapi

2021-03-22 Thread Patrik Janoušek
On 3/22/21 1:06 PM, Max Reitz wrote: > On 22.03.21 12:27, Patrik Janoušek wrote: >> On 3/22/21 11:48 AM, Max Reitz wrote: >>> Hi, >>> >>> On 20.03.21 11:01, Patrik Janoušek wrote: >>>> I'm sorry, but I forgot to add you to the cc, so I'm f

Re: [PATCH 1/2] block/raw: added support of persistent dirty bitmaps

2021-03-22 Thread Patrik Janoušek
On 3/22/21 12:18 PM, Vladimir Sementsov-Ogievskiy wrote: > 22.03.2021 13:46, Vladimir Sementsov-Ogievskiy wrote: >> 22.03.2021 13:18, Patrik Janoušek wrote: >>> On 3/22/21 9:41 AM, Vladimir Sementsov-Ogievskiy wrote: >>>> 20.03.2021 12:32, Patrik Janoušek wrote: &

Re: Fwd: [PATCH 0/2] block/raw: implemented persistent dirty bitmap and ability to dump bitmap content via qapi

2021-03-22 Thread Patrik Janoušek
On 3/22/21 11:48 AM, Max Reitz wrote: > Hi, > > On 20.03.21 11:01, Patrik Janoušek wrote: >> I'm sorry, but I forgot to add you to the cc, so I'm forwarding the >> patch to you additionally. I don't want to spam the mailing list >> unnecessarily. > >

Re: [PATCH 1/2] block/raw: added support of persistent dirty bitmaps

2021-03-22 Thread Patrik Janoušek
On 3/22/21 9:41 AM, Vladimir Sementsov-Ogievskiy wrote: > 20.03.2021 12:32, Patrik Janoušek wrote: >> Current implementation of dirty bitmaps for raw format is very >> limited, because those bitmaps cannot be persistent. Basically it >> makes sense, because the raw format doe

Re: [PATCH 0/2] block/raw: implemented persistent dirty bitmap and ability to dump bitmap content via qapi

2021-03-22 Thread Patrik Janoušek
Hello, thank you for the quick reply. On 3/22/21 9:29 AM, Vladimir Sementsov-Ogievskiy wrote: > Hi Patrik! > > 20.03.2021 12:32, Patrik Janoušek wrote: >> Currently, QEMU doesn't support persistent dirty bitmaps for raw format > > That's right, we don't have s

[PATCH 2/2] qapi: implementation of the block-dirty-bitmap-dump command

2021-03-20 Thread Patrik Janoušek
drive that uses raw format because third-party apps can easily use it to create incremental or differential backup. Signed-off-by: Patrik Janoušek --- block/monitor/bitmap-qmp-cmds.c | 61 +++ qapi/block-core.json| 64 - 2

[PATCH 1/2] block/raw: added support of persistent dirty bitmaps

2021-03-20 Thread Patrik Janoušek
itmap stored on the host filesystem, granularity, persistence, etc.). Signed-off-by: Patrik Janoušek --- block/meson.build | 1 + block/raw-format-bitmap.c | 163 block/raw-format.c| 256 -- block/raw-format.h

[PATCH 0/2] block/raw: implemented persistent dirty bitmap and ability to dump bitmap content via qapi

2021-03-20 Thread Patrik Janoušek
able to create incremental backups of drives in raw format that are LVM volumes (ability to create snapshot is required). Please keep in mind that this is my first submission to such a large project and also the first time when I send patch over the email. So I hope I did it correctly. Patrik Janoušek (