Re: [Qemu-devel] [PATCH] usb: Remove magic constants from device bmAttributes

2013-12-16 Thread Pantelis Koukousoulas
Either version is fine with me :) On Mon, Dec 16, 2013 at 4:27 PM, Gerd Hoffmann wrote: > Hi, > > > I thought that for lines that are just a logical or of constants > > it would be ok to go over 80 columns, since the alternatives > > > > (shortening the names of constants or breaking the line

Re: [Qemu-devel] [PATCH] usb: Remove magic constants from device bmAttributes

2013-12-16 Thread Pantelis Koukousoulas
CONFIG and broke the two lines that were still longer than 80 columns, now checkpatch.pl seems happy :) Cheers, Pantelis On Mon, Dec 16, 2013 at 1:43 PM, Gerd Hoffmann wrote: > On Mo, 2013-12-16 at 11:36 +0200, Pantelis Koukousoulas wrote: > > Replace magic constants in device bmAttrib

[Qemu-devel] [PATCH] usb: Remove magic constants from device bmAttributes

2013-12-16 Thread Pantelis Koukousoulas
Replace magic constants in device bmAttributes with symbolic ones from Linux kernel ch9.h Signed-off-by: Pantelis Koukousoulas --- hw/usb/desc.c | 2 +- hw/usb/dev-audio.c| 2 +- hw/usb/dev-bluetooth.c| 2 +- hw/usb/dev-hid.c | 8 hw/usb

Re: [Qemu-devel] a QOM Coding Conventions question

2013-12-15 Thread Pantelis Koukousoulas
Why not add "protected" then for the fields that are only meant to be accessible by the implementation but not public ? On Sun, Dec 15, 2013 at 1:51 AM, Peter Crosthwaite < peter.crosthwa...@xilinx.com> wrote: > On Sun, Dec 15, 2013 at 9:42 AM, Peter Maydell > wrote: > > On 14 December 2013 23:

Re: [Qemu-devel] I want to emulate Android's goldfish on QEMU, but first: How to familiarize with QEMU's source code and design?

2011-04-03 Thread Pantelis Koukousoulas
On Sat, Apr 2, 2011 at 10:56 PM, AKA wrote: > Hi guys. [...] > What I have tried so far to understand the source code > > Diffs: I made a Diff of the Android emulator code base and the corresponding > QEMU 0.10.x (lots of changes) and to a newer QEMU (it's easier to enumerate > what has not change