Re: [RFC PATCH: v4 1/2] add mi device in qemu

2021-10-26 Thread Padmakar Kalghatgi
-0,0 +1,93 @@ +/* + * QEMU NVMe-MI Controller + * + * Copyright (c) 2021, Samsung Electronics co Ltd. + * + * Written by Padmakar Kalghatgi + * + * This code is licensed under the GNU GPL v2 or later. + * + * This module acts as a host slave, to which the QEMU-MI module + * will post the response

Re: [RFC PATCH: v3 1/2] add mi device in qemu

2021-10-02 Thread Padmakar Kalghatgi
On Wed, Sep 29, 2021 at 06:37:54AM +0200, Klaus Jensen wrote: On Aug 3 12:54, Padmakar Kalghatgi wrote: From: padmakar This patch contains the implementation of certain commands of nvme-mi specification.The MI commands are useful to manage/configure/monitor the device.Eventhough the MI

Re: [RFC PATCH: v3 1/2] add mi device in qemu

2021-08-19 Thread Padmakar Kalghatgi
On Wed, Aug 18, 2021 at 08:01:03AM +0200, Klaus Jensen wrote: On Aug 3 12:54, Padmakar Kalghatgi wrote: From: padmakar This patch contains the implementation of certain commands of nvme-mi specification.The MI commands are useful to manage/configure/monitor the device.Eventhough the MI

[RFC PATCH: v3 1/2] add mi device in qemu

2021-08-03 Thread Padmakar Kalghatgi
From: padmakar This patch contains the implementation of certain commands of nvme-mi specification.The MI commands are useful to manage/configure/monitor the device.Eventhough the MI commands can be sent via the inband NVMe-MI send/recieve commands, the idea here is to emulate the sideband

[RFC PATCH v2 1/2] Adding i2c interface for qemu

2021-08-02 Thread Padmakar
From: padmakar The changes here includes the interface for i2c/smbus for nvme-mi protocol. We have used an address of 0x15 using which the guest VM can send and recieve the nvme-mi commands. Since the nvme-mi device uses the I2C_SLAVE as parent, we have used the send and recieve callbacks by

Re: [RFC PATCH 1/2] hw/nvme: add mi device

2021-07-15 Thread Padmakar Kalghatgi
On Tue, Jul 13, 2021 at 10:37:23AM +0100, Stefan Hajnoczi wrote: On Tue, Jul 13, 2021 at 06:30:28AM +0100, Christoph Hellwig wrote: On Tue, Jul 13, 2021 at 06:30:28AM +0100, Christoph Hellwig wrote: On Mon, Jul 12, 2021 at 12:03:27PM +0100, Stefan Hajnoczi wrote: > Why did you decide to implemen

Re: [RFC PATCH 1/2] hw/nvme: add mi device

2021-07-15 Thread Padmakar Kalghatgi
On Mon, Jul 12, 2021 at 12:03:27PM +0100, Stefan Hajnoczi wrote: On Fri, Jul 09, 2021 at 07:25:45PM +0530, Padmakar Kalghatgi wrote: The enclosed patch contains the implementation of certain commands of nvme-mi specification.The MI commands are useful to manage/configure/monitor the

Re: [RFC PATCH 1/2] hw/nvme: add mi device

2021-07-15 Thread Padmakar Kalghatgi
On Fri, Jul 09, 2021 at 08:58:42AM -0700, Keith Busch wrote: On Fri, Jul 09, 2021 at 07:25:45PM +0530, Padmakar Kalghatgi wrote: The following commands are tested with nvme-cli by hooking to the cid of the vsock as shown above and use the socket send/recieve commands to issue the commands and

[RFC PATCH 1/2] hw/nvme: add mi device

2021-07-09 Thread Padmakar Kalghatgi
subsystem health status poll nvme-mi identify nvme-admin get log page nvme-admin get features nvme-admin Signed-off-by: Padmakar Kalghatgi --- hw/nvme/meson.build | 2 +- hw/nvme/nvme-mi.c | 676

[PATCH]: /hw/nvme/ctrl error handling if descriptors are greater than 1024

2021-07-06 Thread Padmakar Kalghatgi
From: padmakar if the number of descriptors or pages is more than 1024, dma writes or reads will result in failure. Hence, we check if the number of descriptors or pages is more than 1024 in the nvme module and return Internal Device error. Signed-off-by: Padmakar Kalghatgi --- hw

[PATCH v2] hw/block/nvme: map prp fix if prp2 contains non-zero offset

2021-04-09 Thread Padmakar Kalghatgi
From: padmakar nvme_map_prp needs to calculate the number of list entries based on the offset value. For the subsequent PRP2 list, need to ensure the number of entries is within the MAX number of PRP entries for a page. Signed-off-by: Padmakar Kalghatgi --- -v2: removed extraneous

[PATCH] hw/block/nvme: map prp fix if prp2 contains non-zero offset

2021-04-08 Thread Padmakar Kalghatgi
From: padmakar nvme_map_prp needs to calculate the number of list entries based on the offset value. For the subsequent PRP2 list, need to ensure the number of entries is within the MAX number of PRP entries for a page. Signed-off-by: Padmakar Kalghatgi --- hw/block/nvme.c | 12