Re: [PATCH RESEND v3] meson: fix Windows build

2025-06-12 Thread Oleg Tolmatcev
Am Do., 12. Juni 2025 um 21:35 Uhr schrieb Stefan Hajnoczi : > > On Sat, Jun 7, 2025 at 5:47 AM oltolm wrote: > > > > Sorry, I forgot to cc the maintainers. > > > > The build failed when run on Windows. I replaced calls to Unix programs > > like ´cat´, ´sed´ and ´true´ with calls to ´python´. I wr

Re: [PATCH RESEND v3] meson: fix Windows build

2025-06-08 Thread Oleg Tolmatcev
Am So., 8. Juni 2025 um 02:43 Uhr schrieb Pierrick Bouvier : > > On 6/7/25 2:45 AM, oltolm wrote: > > Sorry, I forgot to cc the maintainers. > > > > The build failed when run on Windows. I replaced calls to Unix programs > > like ´cat´, ´sed´ and ´true´ with calls to ´python´. I wrapped calls to >

Re: [PATCH RESEND v3] meson: fix Windows build

2025-06-08 Thread Oleg Tolmatcev
Am Sa., 7. Juni 2025 um 21:12 Uhr schrieb Stefan Hajnoczi : > > On Sat, Jun 07, 2025 at 11:45:04AM +0200, oltolm wrote: > > Sorry, I forgot to cc the maintainers. > > > > The build failed when run on Windows. I replaced calls to Unix programs > > like ´cat´, ´sed´ and ´true´ with calls to ´python´.

Re: [PATCH v2] meson: fix Windows build

2025-06-03 Thread Oleg Tolmatcev
Am Di., 3. Juni 2025 um 19:56 Uhr schrieb Stefan Hajnoczi : > > On Tue, Jun 3, 2025 at 1:00 PM Oleg Tolmatcev > wrote: > > > > Am Mo., 2. Juni 2025 um 20:45 Uhr schrieb Stefan Hajnoczi > > : > > > > > > > +try: > > > &

Re: [PATCH v2] meson: fix Windows build

2025-06-03 Thread Oleg Tolmatcev
Am Mo., 2. Juni 2025 um 20:45 Uhr schrieb Stefan Hajnoczi : > > > +try: > > +event_filename = os.path.relpath(event.filename) > > +except ValueError: > > +event_filename = event.filename > > +event_filename = PurePath(event_filename).as_posix() > > Please do this in one

Re: [PATCH] meson: fix Windows build

2025-05-24 Thread Oleg Tolmatcev
gt; +++ b/tests/functional/meson.build > > @@ -413,4 +413,4 @@ endforeach > > > > run_target('precache-functional', > > depends: precache_all, > > - command: ['true']) > > + command: [python, '-c', '']) > > I wonder if this can be replaced with alias_target() too; and also the > pre-existing code suggests that alias_target needs at least one target, > but is that really true? > > So, maybe all or most uses of 'true' can just go away. I could replace this one with `alias_target()`, but it does need at least one dependency so I could not replace the others. Best regards Oleg Tolmatcev